adva_blog 0.0.1

data/lib/adva_blog.rb

@@ -0,0 +1,10 @@
+# require "adva_blog/version"
+require "rails"
+
+module AdvaBlog
+  class Engine < Rails::Engine
+    initializer "adva_blog.init" do
+      Section.register_type 'Blog'
+    end
+  end
+end

data/lib/adva_blog/version.rb

@@ -0,0 +1,3 @@
+module AdvaBlog
+  VERSION = "0.0.1"
+end

data/test/contexts.rb

@@ -0,0 +1,9 @@
+class Test::Unit::TestCase
+  share :a_blog do
+    before do
+      @section = Blog.find_by_permalink 'a-blog'
+      @site = @section.site
+      set_request_host!
+    end
+  end
+end

data/test/fixtures.rb

@@ -0,0 +1,50 @@
+user = User.find_by_first_name('a user')
+admin = User.find_by_first_name('an admin')
+moderator = User.find_by_first_name('a moderator')
+
+site         = Site.create! :name => 'site with blog',
+                            :title => 'site with blog title',
+                            :host => 'site-with-blog.com'
+
+blog         = Blog.create! :site => site,
+                            :title => 'a blog',
+                            :permalink => 'a-blog',
+                            :comment_age => 0,
+                            :published_at => Time.parse('2008-01-01 12:00:00')
+
+category = Category.create! :section => blog,
+                            :title => 'a category'
+
+           Category.create! :section => blog,
+                            :title => 'another category'
+                            
+           Category.create! :section => blog,
+                            :title => 'öäü'
+
+           Category.create! :section => blog,
+                            :title => '$%&'
+
+article   = Article.create! :site => site,
+                            :section => blog,
+                            :title => 'a blog article',
+                            :body => 'a blog article body',
+                            :categories => [category],
+                            :tag_list => 'foo bar',
+                            :author => user,
+                            :published_at => Time.parse('2008-01-01 12:00:00')
+
+           Article.create!  :site => site,
+                            :section => blog,
+                            :title => 'an unpublished blog article',
+                            :body => 'an unpublished blog article body',
+                            :categories => [category],
+                            :tag_list => 'foo bar',
+                            :author => user
+
+attributes = { :site => site, :section => blog, :commentable => article, :author => user }
+Comment.create! attributes.merge(:body => 'the approved comment body', :approved => 1)
+Comment.create! attributes.merge(:body => 'the unapproved comment body', :approved => 0)
+
+admin.roles.create!(:name => 'admin', :context => site)
+moderator.roles.create!(:name => 'moderator', :context => blog)
+

data/test/functional/blog_articles_controller_test.rb

@@ -0,0 +1,139 @@
+require File.expand_path(File.dirname(__FILE__) + "/../test_helper")
+
+class BlogArticlesControllerTest < ActionController::TestCase
+  tests BlogArticlesController
+  with_common :a_blog, :a_category, :an_article
+
+  test "is an BaseController" do
+    @controller.should be_kind_of(BaseController)
+  end
+
+  { :blog_paths              => %w( /a-blog
+                                    /a-blog/2008
+                                    /a-blog/2008/1 ),
+    :blog_category_paths     => %w( /a-blog/categories/a-category
+                                    /a-blog/categories/a-category/2008
+                                    /a-blog/categories/a-category/2008/1 ),
+    :blog_tag_paths          => %w( /a-blog/tags/foo+bar ),
+    :blog_feed_paths         => %w( /a-blog.atom
+                                    /a-blog/categories/a-category.atom
+                                    /a-blog/tags/foo+bar.atom ),
+    :blog_comment_feed_paths => %w( /a-blog/comments.atom
+                                    /a-blog/2008/1/1/a-blog-article.atom ) }.each do |type, paths|
+
+    paths.each { |path| With.share(type) { before { @params = params_from path } } }
+  end
+
+  describe "GET to :index" do
+    action { get :index, @params }
+
+    with [:blog_paths, :blog_category_paths, :blog_tag_paths] do
+      it_assigns :section, :articles
+      it_caches_the_page :track => ['@article', '@articles', '@category', {'@site' => :tag_counts, '@section' => :tag_counts}]
+
+      it_assigns :category,         :in => :blog_category_paths
+      it_assigns :tags, %(foo bar), :in => :blog_tag_paths
+
+      it_renders :template, :index
+    end
+
+    with "a blog path" do
+      # splitting this off so we do not test all these combinations on any of the paths above
+      before { @params = params_from('/a-blog') }
+
+      it "displays the article" do
+        has_tag('div[class~=entry]') { has_permalink @article }
+      end
+
+      it "shows the excerpt", :with => :article_has_an_excerpt do
+        does_not_have_text 'article body'
+        has_text 'article excerpt'
+        has_tag 'a', /read the rest of this entry/i
+      end
+
+      it "shows the body", :with => :article_has_no_excerpt do
+        has_text 'article body'
+        does_not_have_text 'article excerpt'
+        has_tag 'a', :text => /read the rest of this entry/i, :count => 0
+      end
+
+      it "displays the number of comments and links to them", :with => :comments_or_commenting_allowed do
+        has_tag 'div.meta a', /\d comment[s]?/i
+      end
+
+      it "does not display the number of comments", :with => :no_comments_and_commenting_not_allowed do
+        has_tag 'div.meta a', :text => /\d comment[s]?/, :count => 0
+      end
+
+      has_tag 'div[id=footer]', :if => :default_theme do
+        has_tag 'ul[id=categories_list]'
+        has_tag 'ul[id=archives]'
+        # has_tag 'ul[id=tags-list]' # FIXME currently tags are not displayed
+      end
+    end
+
+    with :blog_feed_paths do
+      it_assigns :section, :articles
+      it_renders :template, :index, :format => :atom
+    end
+  end
+
+  describe "GET to :show" do
+    action { get :show, {:section_id => @section.id}.merge(@article.full_permalink) }
+
+    with :the_article_is_published do
+      it_assigns :section, :article
+      it_caches_the_page :track => ['@article', '@articles', '@category', {'@site' => :tag_counts, '@section' => :tag_counts}]
+
+      it_renders :template, :show do
+        has_tag 'div[class~=entry]' do
+          # displays the title and links it to the article
+          has_permalink @article
+
+          # displays excerpt and body
+          has_text @article.excerpt
+          has_text @article.body
+
+          # displays an edit link for authorized users
+          has_authorized_tag 'a[href=?]', edit_admin_article_path(@site, @section, @article), /edit/i
+
+          # does not display a 'read more' link
+          assert @response.body !~ /read the rest of this entry/i
+
+          # FIXME
+          # lists the article's categories
+          # lists the article's tags
+        end
+      end
+
+      # FIXME
+      # when article has an approved comment: shows the comment
+      # when article has an unapproved comment: does not show any comments
+      # when article does not have any comments: does not show any comments
+      #
+      # when article allows commenting: shows comment form
+      # when article does not allow commenting: does not show comment form
+    end
+
+    # FIXME
+    # with "the article is not published" do
+    #   when the user does not have edit permissions: 404, raises ActiveRecord::RecordNotFound
+    #   when the user has edit permissions: renders show template, does not cache the page
+    # end
+
+    # FIXME
+    # with a permalink that does not point to an article: raises ActiveRecord::RecordNotFound
+  end
+
+  describe "GET to :comments" do
+    action { get :comments, @params }
+
+    with :the_article_is_published do
+      with :blog_comment_feed_paths do
+        # FIXME it_caches_the_page ...
+        it_assigns :section, :comments
+        it_renders :template, 'comments/comments', :format => :atom
+      end
+    end
+  end
+end

data/test/functional/blog_articles_routes_test.rb

@@ -0,0 +1,159 @@
+require File.expand_path(File.dirname(__FILE__) + "/../test_helper")
+
+class BlogArticlesRoutesTest < ActionController::TestCase
+  tests BlogArticlesController
+  with_common :default_routing_filters, :a_blog, :a_category, :an_article
+
+  # FIXME /blogs/1 is regenerated as /sections/1
+  paths = %W( /blogs/1/2007
+              /blogs/1/2007/1
+              /blogs/1/categories/a-category
+              /blogs/1/categories/a-category/2007
+              /blogs/1/categories/a-category/2007/1
+              /blogs/1/categories/a-category.atom
+              /blogs/1/tags/foo+bar
+              /blogs/1/tags/foo+bar/2007
+              /blogs/1/tags/foo+bar/2007/1
+              /blogs/1/tags/foo+bar.atom )
+
+  paths.each do |path|
+    test "regenerates the original path from the recognized params for #{path}" do
+      without_routing_filters do
+        params = ActionController::Routing::Routes.recognize_path(path, :method => :get)
+        assert_equal path, @controller.url_for(params.merge(:only_path => true))
+      end
+    end
+  end
+
+  describe "routing" do
+    ['', '/a-blog', '/de', '/de/a-blog'].each do |path_prefix|
+      ['', '/pages/2'].each do |path_suffix|
+
+        common = { :section_id => Blog.first.id.to_s, :path_prefix => path_prefix, :path_suffix => path_suffix }
+        common.merge! :locale => 'de' if path_prefix =~ /de/
+        common.merge! :page => 2      if path_suffix =~ /pages/
+
+        with_options common do |r|
+          r.it_maps :get, '/',                           :action => 'index'
+          r.it_maps :get, '/2000',                       :action => 'index', :year => '2000'
+          r.it_maps :get, '/2000/1',                     :action => 'index', :year => '2000', :month => '1'
+
+          r.it_maps :get, '/categories/foo',             :action => 'index', :category_id => 'foo'
+          r.it_maps :get, '/categories/foo/2000',        :action => 'index', :category_id => 'foo', :year => '2000'
+          r.it_maps :get, '/categories/foo/2000/1',      :action => 'index', :category_id => 'foo', :year => '2000', :month => '1'
+
+          r.it_maps :get, '/tags/foo+bar',               :action => 'index', :tags => 'foo+bar'
+          r.it_maps :get, '/tags/foo+bar/2000',          :action => 'index', :tags => 'foo+bar', :year => '2000'
+          r.it_maps :get, '/tags/foo+bar/2000/1',        :action => 'index', :tags => 'foo+bar', :year => '2000', :month => '1'
+
+          unless path_suffix =~ /pages/
+            r.it_maps :get, '/2000/1/1/an-article',      :action => 'show', :year => '2000', :month => '1', :day => '1',
+                                                         :permalink => 'an-article'
+
+            # article feeds
+            r.it_maps :get, '.atom',                     :action => 'index', :format => 'atom'
+            r.it_maps :get, '/categories/foo.atom',      :action => 'index', :category_id => 'foo', :format => 'atom'
+            r.it_maps :get, '/tags/foo+bar.atom',        :action => 'index', :tags => 'foo+bar', :format => 'atom'
+
+            # comment feeds
+            r.it_maps :get, '/2000/1/1/an-article.atom', :action => 'comments', :year => '2000', :month => '1', :day => '1',
+                                                         :permalink => 'an-article', :format => 'atom'
+          end
+        end
+      end
+    end
+
+    # these do not work with a root section path because there's a reguar Comments resource
+    with_options :action => 'comments', :format => 'atom', :section_id => Blog.first.id.to_s do |r|
+      r.it_maps :get, '/a-blog/comments.atom'
+      r.it_maps :get, '/de/a-blog/comments.atom', :locale => 'de'
+    end
+  end
+
+  describe "the url_helper blog_path" do
+    before do
+      other = @section.site.sections.create! :title => 'another section' # FIXME move to db/populate
+      other.move_to_left_of @section
+
+      url_rewriter = ActionController::UrlRewriter.new @request, :controller => 'blog', :section => @section.id
+      @controller.instance_variable_set :@url, url_rewriter
+      @controller.instance_variable_set :@site, @site
+
+      I18n.default_locale = :en
+      I18n.locale = :de
+    end
+
+    blog_path                  = lambda { blog_path(@section) }
+    archive_path               = lambda { blog_path(@section, :year => '2008', :month => '1') }
+    tag_path                   = lambda { blog_tag_path(@section, 'foo+bar') }
+    category_path              = lambda { blog_category_path(@section, @category) }
+
+    paged_blog_path            = lambda { blog_path(@section, :page => 2) }
+    paged_archive_path         = lambda { blog_path(@section, :year => '2008', :month => '1', :page => 2) }
+    paged_tag_path             = lambda { blog_tag_path(@section, 'foo+bar', :page => 2) }
+    paged_category_path        = lambda { blog_category_path(@section, @category, :page => 2) }
+
+    blog_feed_path             = lambda { blog_feed_path(@section.id, :format => :rss) }
+    tag_feed_path              = lambda { tag_feed_path(@section, 'foo+bar', :rss) }
+    category_feed_path         = lambda { category_feed_path(@section, @category, :rss) }
+
+    article_path               = lambda { blog_article_path(@section, @article.full_permalink) }
+    comments_feed_path         = lambda { blog_comments_path(@section, :format => :rss) }
+    article_comments_feed_path = lambda { blog_article_comments_path(@section, @article.full_permalink.merge(:format => :rss)) }
+
+    it_rewrites blog_path,           :to => '/',                                      :with => [:is_default_locale, :is_root_section]
+    it_rewrites blog_path,           :to => '/de',                                    :with => [:is_root_section]
+    it_rewrites blog_path,           :to => '/a-blog',                                :with => [:is_default_locale]
+    it_rewrites blog_path,           :to => '/de/a-blog'
+
+    it_rewrites archive_path,        :to => '/2008/1',                                :with => [:is_default_locale, :is_root_section]
+    it_rewrites archive_path,        :to => '/de/2008/1',                             :with => [:is_root_section]
+    it_rewrites archive_path,        :to => '/a-blog/2008/1',                         :with => [:is_default_locale]
+    it_rewrites archive_path,        :to => '/de/a-blog/2008/1'
+
+    it_rewrites tag_path,            :to => '/tags/foo+bar',                          :with => [:is_default_locale, :is_root_section]
+    it_rewrites tag_path,            :to => '/de/tags/foo+bar',                       :with => [:is_root_section]
+    it_rewrites tag_path,            :to => '/a-blog/tags/foo+bar',                   :with => [:is_default_locale]
+    it_rewrites tag_path,            :to => '/de/a-blog/tags/foo+bar'
+
+    it_rewrites category_path,       :to => '/categories/a-category',                 :with => [:is_default_locale, :is_root_section]
+    it_rewrites category_path,       :to => '/de/categories/a-category',              :with => [:is_root_section]
+    it_rewrites category_path,       :to => '/a-blog/categories/a-category',          :with => [:is_default_locale]
+    it_rewrites category_path,       :to => '/de/a-blog/categories/a-category'
+
+    it_rewrites paged_blog_path,     :to => '/de/a-blog/pages/2'
+    it_rewrites paged_archive_path,  :to => '/de/a-blog/2008/1/pages/2'
+    it_rewrites paged_tag_path,      :to => '/de/a-blog/tags/foo+bar/pages/2'
+    it_rewrites paged_category_path, :to => '/de/a-blog/categories/a-category/pages/2'
+
+    it_rewrites blog_feed_path,      :to => '/a-blog.rss',                            :with => [:is_default_locale, :is_root_section]
+    it_rewrites blog_feed_path,      :to => '/de/a-blog.rss',                         :with => [:is_root_section]
+    it_rewrites blog_feed_path,      :to => '/a-blog.rss',                            :with => [:is_default_locale]
+    it_rewrites blog_feed_path,      :to => '/de/a-blog.rss'
+
+    it_rewrites tag_feed_path,       :to => '/tags/foo+bar.rss',                      :with => [:is_default_locale, :is_root_section]
+    it_rewrites tag_feed_path,       :to => '/de/tags/foo+bar.rss',                   :with => [:is_root_section]
+    it_rewrites tag_feed_path,       :to => '/a-blog/tags/foo+bar.rss',               :with => [:is_default_locale]
+    it_rewrites tag_feed_path,       :to => '/de/a-blog/tags/foo+bar.rss'
+
+    it_rewrites category_feed_path,  :to => '/categories/a-category.rss',             :with => [:is_default_locale, :is_root_section]
+    it_rewrites category_feed_path,  :to => '/de/categories/a-category.rss',          :with => [:is_root_section]
+    it_rewrites category_feed_path,  :to => '/a-blog/categories/a-category.rss',      :with => [:is_default_locale]
+    it_rewrites category_feed_path,  :to => '/de/a-blog/categories/a-category.rss'
+
+    it_rewrites article_path,        :to => '/2008/1/1/a-blog-article',               :with => [:is_default_locale, :is_root_section]
+    it_rewrites article_path,        :to => '/de/2008/1/1/a-blog-article',            :with => [:is_root_section]
+    it_rewrites article_path,        :to => '/a-blog/2008/1/1/a-blog-article',        :with => [:is_default_locale]
+    it_rewrites article_path,        :to => '/de/a-blog/2008/1/1/a-blog-article'
+
+    it_rewrites comments_feed_path,  :to => '/comments.rss',                          :with => [:is_default_locale, :is_root_section]
+    it_rewrites comments_feed_path,  :to => '/de/comments.rss',                       :with => [:is_root_section]
+    it_rewrites comments_feed_path,  :to => '/a-blog/comments.rss',                   :with => [:is_default_locale]
+    it_rewrites comments_feed_path,  :to => '/de/a-blog/comments.rss'
+
+    it_rewrites article_comments_feed_path, :to => '/2008/1/1/a-blog-article.rss',        :with => [:is_default_locale, :is_root_section]
+    it_rewrites article_comments_feed_path, :to => '/de/2008/1/1/a-blog-article.rss',     :with => [:is_root_section]
+    it_rewrites article_comments_feed_path, :to => '/a-blog/2008/1/1/a-blog-article.rss', :with => [:is_default_locale]
+    it_rewrites article_comments_feed_path, :to => '/de/a-blog/2008/1/1/a-blog-article.rss'
+  end
+end

data/test/integration/admin/blog_article_test.rb

@@ -0,0 +1,54 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../test_helper' )
+
+module IntegrationTests
+  class AdminBlogArticleTest < ActionController::IntegrationTest
+    def setup
+      super
+      @section = Blog.first
+      @site = @section.site
+      use_site! @site
+      stub(Time).now.returns Time.utc(2008, 1, 1)
+    end
+  
+    test "Admin creates an article, previews, edits and deletes it" do
+      login_as_admin
+      visit_admin_articles_index_page
+      create_a_new_article
+      revise_the_article
+      preview_article
+      delete_article
+    end
+
+    def visit_admin_articles_index_page
+      visit "/admin/sites/#{@site.id}/sections/#{@section.id}/articles"
+    end
+
+    def create_a_new_article
+      click_link "New"
+      fill_in 'article[title]', :with => 'the article title'
+      fill_in 'article[body]',  :with => 'the article body'
+      click_button 'Save'
+      request.url.should =~ %r(/admin/sites/\d+/sections/\d+/articles/\d+/edit)
+    end
+
+    def revise_the_article
+      fill_in 'article[title]', :with => 'the revised article title'
+      fill_in 'article[body]',  :with => 'the revised article body'
+      click_button 'Save'
+      request.url.should =~ %r(/admin/sites/\d+/sections/\d+/articles/\d+/edit)
+      @back_url = request.url
+    end
+
+    def preview_article
+      click_link 'Show'
+      request.url.should == controller.show_url(Article.find_by_permalink('the-article-title'))
+    end
+
+    def delete_article
+      visit @back_url
+      click_link 'Delete'
+      request.url.should =~ %r(/admin/sites/\d+/sections/\d+/articles)
+      response.body.should_not =~ %r(the revised article title)
+    end
+  end
+end

data/test/integration/admin/blog_ping_test.rb

@@ -0,0 +1,68 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../test_helper' )
+
+if Rails.plugin?(:adva_post_ping)
+  module IntegrationTests
+    class AdminBlogPingTest < ActionController::IntegrationTest
+      def setup
+        super
+        @section = Blog.first
+        @site = @section.site
+        use_site! @site
+        stub(Time).now.returns Time.utc(2008, 1, 2)
+      
+        Article.old_add_observer(@observer = ArticlePingObserver.instance)
+
+        @ping_service = { :url => "http://rpc.pingomatic.com/", :type => :xmlrpc }
+        ArticlePingObserver::SERVICES.replace [@ping_service]
+      end
+    
+      def teardown
+        super
+        Article.delete_observer(@observer)
+      end
+  
+      test "The system pings FOO when a blog article is published" do
+        login_as_admin
+      
+        visit "/admin/sites/#{@site.id}/sections/#{@section.id}/articles"
+        click_link "New"
+
+        expect_no_pings do
+          create_a_new_article
+        end
+      
+        expect_ping_to(@ping_service) do
+          publish_article
+        end
+      end
+
+      def create_a_new_article
+        fill_in 'article[title]', :with => 'the article title'
+        fill_in 'article[body]',  :with => 'the article body'
+        click_button 'Save'
+        request.url.should =~ %r(/admin/sites/\d+/sections/\d+/articles/\d+/edit)
+      end
+
+      def publish_article
+        uncheck 'article[draft]'
+        select_date "2008-1-1", :from => 'Publish on this date'
+        click_button 'Save'
+        request.url.should =~ %r(/admin/sites/\d+/sections/\d+/articles/\d+/edit)
+      end
+    
+      def expect_no_pings
+        RR.dont_allow(ArticlePingObserver.instance).ping_service(anything, anything)
+        yield
+        RR.verify
+        RR.reset
+      end
+    
+      def expect_ping_to(service)
+        RR.mock(ArticlePingObserver.instance).ping_service(service, anything)
+        yield
+        RR.verify
+        RR.reset
+      end
+    end
+  end
+end