adva-core 0.0.4 → 0.0.5

data/lib/adva_core/version.rb

@@ -1,3 +1,3 @@
 module AdvaCore
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/core_ext/rails/action_view/has_many_through_collection_helpers.rb

@@ -2,9 +2,12 @@ require 'action_view/helpers/form_helper'
 
 ActionView::Helpers::FormBuilder.send :include do
   def has_many_through_collection_check_boxes(attribute, collection, label_attribute)
+    return if collection.empty?
     through_class = object.class.reflect_on_association(attribute).class_name.constantize
     foreign_key = through_class.reflect_on_all_associations(:belongs_to).detect { |r| r.class_name != object.class.name }.primary_key_name
 
+    item_class = collection.first.class.name.underscore.gsub('/', '_')
+    # TODO: wouldn't it be better to render the checkboxes as a list(iw)
     html = ''
     collection.each_with_index do |item, ix|
       param   = "#{object_name}[#{attribute}_attributes][#{ix}]"
@@ -13,11 +16,11 @@ ActionView::Helpers::FormBuilder.send :include do
       if through
         html << @template.hidden_field_tag("#{param}[id]", through.id, :id => '')
         html << @template.hidden_field_tag("#{param}[_destroy]", '1', :id => '')
-        html << @template.label_tag("#{param}[_destroy]", :class => 'checkbox') do
+        html << @template.label_tag("#{param}[_destroy]", :class => "checkbox #{item_class}") do
           @template.check_box_tag("#{param}[_destroy]", '0', true) + item.send(label_attribute)
         end
       else
-        html << @template.label_tag("#{param}[#{foreign_key}]", :class => 'checkbox') do
+        html << @template.label_tag("#{param}[#{foreign_key}]", :class => "checkbox #{item_class}") do
           @template.check_box_tag("#{param}[#{foreign_key}]", item.id) + item.send(label_attribute)
         end
       end

data/lib/patches/arel_in_subquery.rb

@@ -0,0 +1,44 @@
+# https://gist.github.com/730257
+# bars.where(bars[:id].in(foos.project(:bar_id).where(...)))
+
+Gem.patching('arel', '2.0.6') do
+  Arel::Predications.module_eval do
+    def in_with_select_fix(other)
+      case other
+      when Arel::SelectManager
+        Arel::Nodes::In.new(self, other)
+      else
+        in_without_select_fix(other)
+      end
+    end
+    alias_method_chain :in, :select_fix
+
+    def not_in_with_select_fix(other)
+      case other
+      when Arel::SelectManager
+        Arel::Nodes::NotIn.new(self, other)
+      else
+        in_without_select_fix(other)
+      end
+    end
+    alias_method_chain :not_in, :select_fix
+  end
+
+  Arel::Visitors::ToSql.class_eval do
+    def visit_Arel_SelectManager o
+      o.to_sql
+    end
+
+    def visit_Arel_Nodes_In o
+      "#{visit o.left} IN (#{visit o.right})"
+    end
+
+    def visit_Arel_Nodes_NotIn o
+      "#{visit o.left} NOT IN (#{visit o.right})"
+    end
+
+    def visit_Array o
+      o.empty? ? 'NULL' : o.map { |x| visit x }.join(', ')
+    end
+  end
+end

data/lib/patches/webrat/within_xpath.rb

@@ -0,0 +1,13 @@
+# see https://webrat.lighthouseapp.com/projects/10503/tickets/153-within-should-support-xpath
+
+Gem.patching('webrat', '0.7.2') do
+  Webrat::Scope.class_eval do
+    def scoped_dom
+      if @selector =~ /^\.?\/\/?/
+        @scope.dom.xpath(@selector).first
+      else
+        @scope.dom.css(@selector).first
+      end
+    end
+  end
+end if defined?(Webrat)

data/lib/testing/step_definitions/common_steps.rb

@@ -285,3 +285,14 @@ Then /^I should see "([^"]*)" formatted as a "([^"]*)" tag$/ do |value, tag|
   assert_select(tag, value)
 end
 
+Then /^I should see (\d+|no|one|two|three) ([a-z ]+)$/ do |amount, item_class|
+  amount = case amount
+    when 'no' then 0
+    when 'one' then 1
+    when 'two' then 2
+    when 'three' then 3
+    else amount.to_i
+  end
+  assert_select ".#{item_class.gsub(' ', '_').singularize}", :count => amount
+end
+

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: adva-core
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Ingo Weiss
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-03 00:00:00 +01:00
+date: 2010-12-18 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -203,12 +203,12 @@ dependencies:
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 41
+        hash: 39
         segments: 
         - 0
         - 0
-        - 27
-        version: 0.0.27
+        - 28
+        version: 0.0.28
   type: :runtime
   version_requirements: *id012
 - !ruby/object:Gem::Dependency 
@@ -323,6 +323,7 @@ files:
 - lib/core_ext/ruby/array/flatten_once.rb
 - lib/patches/webrat/logger.rb
 - lib/patches/webrat/upload_file.rb
+- lib/patches/webrat/within_xpath.rb
 - lib/patches/webrat/links-data-method.rb
 - lib/patches/rails/asset_expansion_multiple_registrations.rb
 - lib/patches/rails/recognize_path_env.rb
@@ -336,6 +337,7 @@ files:
 - lib/patches/inherited_resources.rb
 - lib/patches/responders/flash_responder.rb
 - lib/patches/simple_form.rb
+- lib/patches/arel_in_subquery.rb
 - lib/patches/thor/group/symbolized_options.rb
 - lib/patches/thor/core_ext/hash.rb
 - lib/adva-core.rb