administrate-field-carrierwave 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 505ff07bb8b8dc13a7926c9a327bf73068de8564d6fe89b7cc84f5236e7c1bde
-  data.tar.gz: 19bc883f883ecdb2f70156c58083f0067fed395259e148b1e000a42a41321223
+  metadata.gz: 3e06215467cf2202c2c081140fb7676b891de7e3a7e5f4d971ef78144f8b5bcd
+  data.tar.gz: f9ef96c25f4705381150fc96f7098bd617e8faef81c717f39abd606c57e060f0
 SHA512:
-  metadata.gz: 7ffbfa4ac815083b73c806a26089d8f43499a8022a52c2cf3650b844c5f566d7a33514cf4c4b8ba3ec8f4fd3c32cd078d5546076caefcdac6e3cc03d66801180
-  data.tar.gz: e11d1584a89a28f1dbffe2030696c9061e426b5c8538e5d18fe377f979c381fc7f80ed2693cf9d32d6b660442aa72fe89545a12d9ba9495a95bee7269191e115
+  metadata.gz: ddcbfba35becd5eedb7c3a07427df242a1351c7a070438f378c7dfbf47d18a5ee8eea39747503dfbeb234d102072a764719a6f268a84472bd10801817daf9335
+  data.tar.gz: 719e67c4a90194e28156f7dea326a8d8c587af9649c59c67378ed5b1468e9b68981d53c9c7380c18357eecb63232d062a6a539c3027675af0d40ca072de27631

data/.gitignore

@@ -1,2 +1,3 @@
 *.gem
 Gemfile.lock
+.ruby-gemset

data/.rubocop.yml

@@ -0,0 +1,10 @@
+AllCops:
+  Exclude:
+    - 'bin/*'
+
+Documentation:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*.rb'

data/.ruby-version

@@ -0,0 +1 @@
+2.5.1

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [v0.3.3](https://github.com/zooppa/administrate-field-carrierwave/tree/v0.3.3) (2018-10-11)
+
+[Full Changelog](https://github.com/zooppa/administrate-field-carrierwave/compare/v0.3.2...v0.3.3)
+
+* Fix form with nested attributes (thanks @JapArt)
+* Add RuboCop and Guard
+* Add contribution guidelines
+
 ## [v0.3.2](https://github.com/zooppa/administrate-field-carrierwave/tree/v0.3.2) (2018-03-06)
 
 [Full Changelog](https://github.com/zooppa/administrate-field-carrierwave/compare/v0.3.1...v0.3.2)

data/CONTRIBUTING.md

@@ -0,0 +1,9 @@
+# Contributing
+
+1. [Fork this repository](https://help.github.com/articles/fork-a-repo/)
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Run `guard`
+4. Make changes and keep an eye on RuboCop violations and green tests
+5. Commit your changes (`git commit -am 'Add a feature'`)
+6. Push to the branch (`git push origin my-new-feature`)
+7. [Create a new pull request](https://help.github.com/articles/creating-a-pull-request/)

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Guardfile

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+directories(%w[app lib spec]).select do |d|
+  Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist")
+end
+
+guard :rspec, cmd: 'rspec' do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { 'spec' }
+end
+
+guard :rubocop do
+  watch(%r{/.+\.rb$/})
+  watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
+end

data/README.md

@@ -1,7 +1,7 @@
 # Administrate::Field::Carrierwave
 
-[![Code Climate](https://codeclimate.com/github/zooppa/administrate-field-carrierwave/badges/gpa.svg)](https://codeclimate.com/github/zooppa/administrate-field-carrierwave)
 [![Build Status](https://semaphoreci.com/api/v1/zooppa/administrate-field-carrierwave/branches/master/badge.svg)](https://semaphoreci.com/zooppa/administrate-field-carrierwave)
+[![Code Climate](https://codeclimate.com/github/zooppa/administrate-field-carrierwave/badges/gpa.svg)](https://codeclimate.com/github/zooppa/administrate-field-carrierwave)
 
 A plugin to upload and preview Carrierwave attachments in [Administrate].
 
@@ -10,7 +10,7 @@ A plugin to upload and preview Carrierwave attachments in [Administrate].
 Add it to your `Gemfile`:
 
 ```ruby
-gem 'administrate-field-carrierwave', '~> 0.3.2'
+gem 'administrate-field-carrierwave', '~> 0.3.3'
 ```
 
 Run:

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/administrate-field-carrierwave.gemspec

@@ -1,8 +1,10 @@
-$:.push File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 
 Gem::Specification.new do |gem|
   gem.name = 'administrate-field-carrierwave'
-  gem.version = '0.3.2'
+  gem.version = '0.3.3'
   gem.authors = ['Michele Gerarduzzi']
   gem.email = ['michele.gerarduzzi@gmail.com']
   gem.homepage = 'https://github.com/zooppa/administrate-field-carrierwave'
@@ -17,6 +19,10 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'administrate', '< 1.0.0'
   gem.add_runtime_dependency 'rails', '>= 4.2', '< 6'
 
+  gem.add_development_dependency 'guard', '~> 2.14'
+  gem.add_development_dependency 'guard-rspec', '~> 4.7'
+  gem.add_development_dependency 'guard-rubocop', '~> 1.3'
   gem.add_development_dependency 'rake', '~> 12.3'
   gem.add_development_dependency 'rspec', '~> 3.7'
+  gem.add_development_dependency 'rubocop', '~> 0.59'
 end

data/bin/_guard-core

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application '_guard-core' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("guard", "_guard-core")

data/bin/guard

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'guard' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("guard", "guard")

data/lib/administrate/field/carrierwave.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'administrate/field/base'
 require 'rails'
 
@@ -35,7 +37,9 @@ module Administrate
       end
 
       def show_preview?
-        data.model.persisted? && file.version_exists?(image) && data.file.present?
+        data&.model&.persisted? &&
+          data&.file.present? &&
+          file.version_exists?(image)
       end
 
       def show_file?

data/spec/lib/administrate/field/carrierwave_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Administrate::Field::Carrierwave do
@@ -5,8 +7,12 @@ describe Administrate::Field::Carrierwave do
   let(:model) { double 'Model', persisted?: true }
   let(:file) { double 'File' }
 
-  let(:cw_file) { double 'CW with file', model: model, file: file, version_exists?: true }
-  let(:cw_no_file) { double 'CW without file', model: model, file: nil, version_exists?: true }
+  let(:cw_file) do
+    double 'CW with file', model: model, file: file, version_exists?: true
+  end
+  let(:cw_no_file) do
+    double 'CW without file', model: model, file: nil, version_exists?: true
+  end
 
   let(:data) { cw_file }
   let(:options) { {} }

data/spec/spec_helper.rb

@@ -1,2 +1,4 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'administrate/field/carrierwave'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: administrate-field-carrierwave
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Michele Gerarduzzi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-06 00:00:00.000000000 Z
+date: 2018-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: administrate
@@ -44,6 +44,48 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '6'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,6 +114,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.59'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.59'
 description: A plugin to manage Carrierwave attachments in Administrate
 email:
 - michele.gerarduzzi@gmail.com
@@ -81,8 +137,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
+- Guardfile
 - LICENSE.md
 - README.md
 - Rakefile
@@ -92,6 +152,8 @@ files:
 - app/views/fields/carrierwave/_index.html.erb
 - app/views/fields/carrierwave/_preview.html.erb
 - app/views/fields/carrierwave/_show.html.erb
+- bin/_guard-core
+- bin/guard
 - lib/administrate/field/carrierwave.rb
 - spec/lib/administrate/field/carrierwave_spec.rb
 - spec/spec_helper.rb
@@ -115,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Carrierwave field plugin for Administrate