admin_suite 0.3.1 → 0.5.0

data/test/lib/resource_exportable_deprecation_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module AdminSuite
+  class ResourceExportableDeprecationTest < ActiveSupport::TestCase
+    # Regression fixture for Finding 1 of the whole-branch review: Task 8
+    # removed `exportable` after grepping the *gem* for readers, but host
+    # apps are *callers* of this DSL (gleania: 30 resource files;
+    # trust_growth: 1). A real removal raises `NoMethodError` at
+    # definition-load time -- and in production `DefinitionLoader` logs and
+    # swallows that, so the resource silently vanishes from the admin.
+    class LegacyExportableResource < Admin::Base::Resource
+      exportable :json, :csv
+    end
+
+    setup { LegacyExportableResource.reset_deprecation_notices! }
+
+    test "calling exportable in a resource body is harmless" do
+      assert_nothing_raised { LegacyExportableResource.exportable(:json, :csv) }
+    end
+
+    test "exportable does not restore any export-format reader" do
+      refute LegacyExportableResource.respond_to?(:export_formats)
+      refute LegacyExportableResource.instance_variable_defined?(:@export_formats)
+    end
+
+    test "exportable warns once per resource class, naming the class and the 0.6.0 removal" do
+      logged = []
+      LegacyExportableResource.stub(:warn_once_sink, ->(msg) { logged << msg }) do
+        2.times { LegacyExportableResource.exportable(:json, :csv) }
+      end
+
+      assert_equal 1, logged.size
+      assert_includes logged.first, "LegacyExportableResource"
+      # Deliberately a hardcoded literal, not read off
+      # EXPORTABLE_DEPRECATION_MESSAGE_FORMAT: reading the version out of
+      # the constant under test and asserting the message contains it is
+      # true by construction (format() only substitutes %<resource>s, never
+      # the version digits), so it can never fail on a wrong retarget --
+      # exactly the property this test exists to catch. If the removal
+      # target changes again, this literal must be updated by hand; that's
+      # the point.
+      assert_includes logged.first, "0.6.0"
+    end
+  end
+end

data/test/lib/show_value_formatter_test.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module AdminSuite
+  class ShowValueFormatterTest < ActionView::TestCase
+    # ActionView::Base includes ::ERB::Util (giving views access to `h`), but
+    # ActionView::TestCase::Behavior only includes ActionView::Helpers, not
+    # ERB::Util. Include it here so this test's context matches what
+    # BaseHelper actually runs inside at runtime (`h` is used by
+    # render_text_block / highlight_json).
+    include ::ERB::Util
+    include AdminSuite::BaseHelper
+
+    # A record stand-in exposing the value under the field name the formatter
+    # reads via `record.public_send(field_name)`.
+    Record = Struct.new(:some_field)
+
+    def fmt(value)
+      format_show_value(Record.new(value), :some_field)
+    end
+
+    test "nil renders the em dash placeholder" do
+      assert_includes fmt(nil), "—"
+    end
+
+    test "booleans render Yes/No with an icon" do
+      assert_includes fmt(true), "Yes"
+      assert_includes fmt(false), "No"
+    end
+
+    test "dates and times render humanized with relative age" do
+      assert_includes fmt(Date.new(2026, 1, 2)), "January"
+      assert_includes fmt(Time.utc(2026, 1, 2, 3, 4)), "January"
+      assert_includes fmt(DateTime.new(2026, 1, 2, 3, 4)), "January"
+    end
+
+    test "integers and floats render delimited" do
+      assert_includes fmt(1_234_567), "1,234,567"
+      assert_includes fmt(1234.5), "1,234"
+    end
+
+    test "BigDecimal renders delimited rather than as an object string" do
+      result = fmt(BigDecimal("9876.5"))
+      assert_includes result, "9,876"
+      refute_includes result, "0.98765e4"
+    end
+
+    test "hashes render as a JSON block" do
+      assert_includes fmt({ "a" => 1 }), "JSON"
+    end
+
+    test "arrays of hashes render as a JSON block" do
+      assert_includes fmt([ { "a" => 1 } ]), "JSON"
+    end
+
+    test "empty arrays render a placeholder, populated arrays render chips" do
+      assert_includes fmt([]), "Empty array"
+      assert_includes fmt(%w[alpha beta]), "alpha"
+    end
+
+    test "long strings render as a text block, short strings render inline" do
+      long = "x" * 250
+      assert_includes fmt(long), "x"
+      assert_includes fmt("short"), "short"
+    end
+
+    test "strings containing JSON render as a JSON block" do
+      assert_includes fmt('{"mode":"fast"}'), "mode"
+    end
+
+    test "malformed JSON-looking strings fall back to plain rendering" do
+      assert_includes fmt("{not actually json"), "not actually json"
+    end
+
+    test "short strings containing a newline render as a text block" do
+      result = fmt("first line\nsecond line")
+      assert_includes result, "bg-slate-900"
+      assert_includes result, "second line"
+    end
+
+    # ActiveRecord::Base branch (show_formatter_registry.rb:72-77) is
+    # untestable in this harness: the dummy app is database-free and
+    # ActiveRecord::Base is never loaded/defined here, so the registry's
+    # `if defined?(ActiveRecord::Base)` guard never registers that handler.
+    # See task-1-report.md's fix report for the verification.
+  end
+end

data/test/lib/zeitwerk_integration_test.rb

@@ -30,43 +30,13 @@ module AdminSuite
       [ loader, ignored_dirs, pushed_dirs ]
     end
 
-    # Helper method that simulates the Zeitwerk integration logic from engine.rb
-    def simulate_zeitwerk_integration(app_root, loader)
-      admin_suite_app_dir = app_root.join("app/admin_suite")
-      admin_dir = app_root.join("app/admin")
-      admin_portals_dir = app_root.join("app/admin/portals")
-
-      # Map app/admin -> Admin namespace if files define Admin::* constants.
-      if admin_dir.exist?
-        rb_files = Dir[admin_dir.join("**/*.rb").to_s]
-        rb_files.reject! { |f| f.include?("/portals/") }
-
-        host_uses_admin_namespace =
-          rb_files.any? do |file|
-            content = File.binread(file).encode("UTF-8", invalid: :replace, undef: :replace, replace: "")
-            content.match?(/\b(module|class)\s+Admin\b/) || content.match?(/\b(module|class)\s+Admin::/)
-          rescue StandardError
-            false
-          end
-
-        loader.push_dir(admin_dir, namespace: Admin) if host_uses_admin_namespace
-      end
-
-      loader.ignore(admin_suite_app_dir) if admin_suite_app_dir.exist?
-
-      # Ignore portal DSL files (side-effect DSL, not constants).
-      if admin_portals_dir.exist?
-        portal_files = Dir[admin_portals_dir.join("**/*.rb").to_s]
-        contains_admin_suite_portals =
-          portal_files.any? do |file|
-            content = File.binread(file).encode("UTF-8", invalid: :replace, undef: :replace, replace: "")
-            content.match?(/(::)?AdminSuite\s*\.\s*portal\b/)
-          rescue StandardError
-            false
-          end
-
-        loader.ignore(admin_portals_dir) if contains_admin_suite_portals
-      end
+    # A minimal stand-in for the Rails::Application instance HostAutoloadPolicy
+    # is invoked with in production: it only needs `#root` and a
+    # `#config.autoload_paths` / `#config.eager_load_paths` that respond to
+    # `#delete` (exercised only by the "maps app/admin..." test below).
+    def create_fake_app(root)
+      config = Struct.new(:autoload_paths, :eager_load_paths).new([], [])
+      Struct.new(:root, :config).new(Pathname.new(root), config)
     end
 
     test "ignores app/admin/portals when it contains AdminSuite portal DSL" do
@@ -78,13 +48,12 @@ module AdminSuite
         "AdminSuite.portal :ops do\n  # portal config\nend"
       )
 
-      # Create loader and simulate initializer logic
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, ignored_dirs, _pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
       # Verify that app/admin/portals was ignored
-      expected_path = app_root.join("app/admin/portals").to_s
+      expected_path = app.root.join("app/admin/portals").to_s
       assert_includes ignored_dirs, expected_path,
                       "Expected app/admin/portals to be ignored when it contains AdminSuite portal DSL"
     end
@@ -98,13 +67,12 @@ module AdminSuite
         "module Admin\n  module Portals\n    class AdminUser\n    end\n  end\nend"
       )
 
-      # Create loader and simulate initializer logic
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, ignored_dirs, _pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
       # Verify that app/admin/portals was NOT ignored
-      unexpected_path = app_root.join("app/admin/portals").to_s
+      unexpected_path = app.root.join("app/admin/portals").to_s
       assert_not_includes ignored_dirs, unexpected_path,
                           "Expected app/admin/portals to NOT be ignored when it contains only real constants"
     end
@@ -118,13 +86,12 @@ module AdminSuite
         "# Some DSL configuration"
       )
 
-      # Create loader and simulate initializer logic
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, ignored_dirs, _pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
       # Verify that app/admin_suite was ignored
-      expected_path = app_root.join("app/admin_suite").to_s
+      expected_path = app.root.join("app/admin_suite").to_s
       assert_includes ignored_dirs, expected_path,
                       "Expected app/admin_suite to always be ignored"
     end
@@ -146,13 +113,12 @@ module AdminSuite
         "AdminSuite.portal :ops do\n  # portal config\nend"
       )
 
-      # Create loader and simulate initializer logic
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, ignored_dirs, _pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
       # Verify that app/admin/portals was ignored due to presence of portal DSL
-      expected_path = app_root.join("app/admin/portals").to_s
+      expected_path = app.root.join("app/admin/portals").to_s
       assert_includes ignored_dirs, expected_path,
                       "Expected app/admin/portals to be ignored when any file contains portal DSL"
     end
@@ -164,8 +130,7 @@ module AdminSuite
       test_file = File.join(portals_dir, "test.rb")
       File.write(test_file, "AdminSuite.portal :ops do; end")
 
-      # Create loader
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, ignored_dirs, _pushed_dirs = create_tracked_loader
 
       # Temporarily override File.binread to simulate read errors
@@ -180,11 +145,10 @@ module AdminSuite
       end
 
       begin
-        # Simulate the initializer logic
-        simulate_zeitwerk_integration(app_root, loader)
+        AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
         # Verify that app/admin/portals was NOT ignored due to read error
-        unexpected_path = app_root.join("app/admin/portals").to_s
+        unexpected_path = app.root.join("app/admin/portals").to_s
         assert_not_includes ignored_dirs, unexpected_path,
                             "Expected app/admin/portals to NOT be ignored when file read fails"
       ensure
@@ -201,11 +165,11 @@ module AdminSuite
         "module Admin\n  module Resources\n    class UserResource; end\n  end\nend\n"
       )
 
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, _ignored_dirs, pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
-      assert pushed_dirs.any? { |h| h[:path] == app_root.join("app/admin").to_s && h[:namespace] == Admin },
+      assert pushed_dirs.any? { |h| h[:path] == app.root.join("app/admin").to_s && h[:namespace] == Admin },
              "Expected app/admin to be pushed with namespace Admin when files define Admin::* constants"
     end
 
@@ -217,11 +181,11 @@ module AdminSuite
         "module Resources\n  class UserResource; end\nend\n"
       )
 
-      app_root = Pathname.new(@temp_dir)
+      app = create_fake_app(@temp_dir)
       loader, _ignored_dirs, pushed_dirs = create_tracked_loader
-      simulate_zeitwerk_integration(app_root, loader)
+      AdminSuite::HostAutoloadPolicy.apply!(app, loaders: [ loader ])
 
-      assert pushed_dirs.none? { |h| h[:path] == app_root.join("app/admin").to_s },
+      assert pushed_dirs.none? { |h| h[:path] == app.root.join("app/admin").to_s },
              "Expected app/admin to NOT be pushed when files contain only top-level constants"
     end
   end

data/test/test_helper.rb

@@ -32,14 +32,17 @@ unless defined?(ActiveRecord::RecordNotFound)
   end
 end
 
-module TurboFrameTestHelper
-  def turbo_frame_tag(name, **options, &block)
-    content_tag(:turbo_frame, capture(&block), id: name, **options)
+# Same rationale as above: base_helper.rb's show-page/association rendering
+# checks `record.is_a?(ActiveRecord::Base)` to distinguish a real AR
+# association from a plain in-memory relation stand-in. Supply just the bare
+# constant so that check can run (and return false for our PORO fixtures)
+# without requiring the full active_record/railtie in this DB-free dummy app.
+unless defined?(ActiveRecord::Base)
+  module ActiveRecord
+    class Base; end
   end
 end
 
-ActionView::Base.include(TurboFrameTestHelper)
-
 module ReadOnlyResourceFixtures
   class Relation
     include Enumerable
@@ -65,3 +68,116 @@ module ReadOnlyResourceFixtures
     end
   end
 end
+
+module RedirectFixtures
+  class Widget
+    extend ActiveModel::Naming
+
+    def persisted? = true
+    def to_param = "42"
+  end
+end
+
+module Admin
+  module Resources
+    class RedirectWidgetResource < Admin::Base::Resource
+      model RedirectFixtures::Widget
+      portal :ops
+      section :observability
+    end
+  end
+end
+RedirectFixtures::WidgetResource = Admin::Resources::RedirectWidgetResource
+
+# Fixtures for exercising execute_model_method's exception-handling chain
+# end-to-end, in the dummy app's DB-free configuration (no ActiveRecord
+# loaded), which is where a bare `rescue ActiveRecord::RecordInvalid` or
+# `rescue AASM::InvalidTransition` would raise NameError while handling the
+# original exception instead of reporting it.
+module ExceptionHandlingFixtures
+  class Boomer
+    extend ActiveModel::Naming
+
+    def kaboom
+      raise "actual failure message"
+    end
+  end
+
+  # Named to mirror AASM::InvalidTransition (and similar state-machine gem
+  # exceptions) without depending on AASM: only the class name matters to
+  # the rescue chain's class-name match.
+  class InvalidTransitionError < StandardError; end
+
+  class StateMachineWidget
+    extend ActiveModel::Naming
+
+    def transition
+      raise InvalidTransitionError, "cannot transition from draft to published"
+    end
+  end
+end
+
+module Admin
+  module Resources
+    class ExceptionHandlingBoomerResource < Admin::Base::Resource
+      model ExceptionHandlingFixtures::Boomer
+      portal :ops
+      section :observability
+      actions { action :kaboom }
+    end
+
+    class ExceptionHandlingStateMachineResource < Admin::Base::Resource
+      model ExceptionHandlingFixtures::StateMachineWidget
+      portal :ops
+      section :observability
+      actions { action :transition }
+    end
+  end
+end
+
+# The dummy app is database-free and `ActiveRecord::Base` above is a bare
+# stub class, so every other fixture in this suite is a PORO and
+# `active_record_base?` is false for all of them -- every AR-dependent path
+# (`auto_admin_suite_path_for`, `format_table_cell`'s AR branch) is
+# otherwise unreachable by tests. Subclassing the stub gives a fixture that
+# genuinely satisfies `active_record_base?`, with no database and no
+# railtie required. Established here (Task 3, phase 2b) because it's
+# reused by later tasks (4, 7); those tasks' own test files each `require
+# "test_helper"`, so this is visible to them even when a single test file
+# is run in isolation via `rake test TEST=...` -- unlike a fixture defined
+# only in association_linking_test.rb, which would not be.
+module LinkingFixtures
+  class Company < ActiveRecord::Base
+    extend ActiveModel::Naming
+
+    attr_reader :id, :name
+
+    def initialize(id: 7, name: "Acme Corp")
+      @id = id
+      @name = name
+    end
+
+    def self.all = ReadOnlyResourceFixtures::Relation.new([ new ])
+    def self.column_names = %w[id name]
+    def self.primary_key = "id"
+    def self.columns_hash = { "id" => Struct.new(:type).new(:integer) }
+    def self.find(_id) = new
+    def to_param = id.to_s
+    def attributes = { "id" => id, "name" => name }
+  end
+end
+
+module Admin
+  module Resources
+    # Registered so `auto_admin_suite_path_for` can resolve a real path for
+    # `LinkingFixtures::Company` instances (it looks up `registered_resources`
+    # by `model_class`). Never call `Admin::Base::Resource.reset_registry!` in
+    # a test: `inherited` fires only on class creation, so a reset-then-reload
+    # would permanently empty the registry for the rest of the run.
+    class LinkingCompanyResource < Admin::Base::Resource
+      model LinkingFixtures::Company
+      portal :ops
+      section :observability
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: admin_suite
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.0
 platform: ruby
 authors:
 - TechWright Labs
@@ -36,20 +36,40 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '9.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '10'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '9.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '10'
+- !ruby/object:Gem::Dependency
+  name: turbo-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: lucide-rails
   requirement: !ruby/object:Gem::Requirement
@@ -126,6 +146,9 @@ files:
 - app/assets/builds/admin_suite_tailwind.css
 - app/assets/rouge.css
 - app/assets/tailwind/admin_suite.css
+- app/assets/vendor/chart.umd.min.js
+- app/assets/vendor/easymde.min.css
+- app/assets/vendor/easymde.min.js
 - app/controllers/admin_suite/application_controller.rb
 - app/controllers/admin_suite/dashboard_controller.rb
 - app/controllers/admin_suite/docs_controller.rb
@@ -137,6 +160,7 @@ files:
 - app/helpers/admin_suite/resources_helper.rb
 - app/helpers/admin_suite/theme_helper.rb
 - app/javascript/admin_suite_application.js
+- app/javascript/controllers/admin_suite/chart_controller.js
 - app/javascript/controllers/admin_suite/click_actions_controller.js
 - app/javascript/controllers/admin_suite/clipboard_controller.js
 - app/javascript/controllers/admin_suite/code_editor_controller.js
@@ -167,6 +191,7 @@ files:
 - app/views/admin_suite/shared/_flash.html.erb
 - app/views/admin_suite/shared/_form.html.erb
 - app/views/admin_suite/shared/_json_editor_field.html.erb
+- app/views/admin_suite/shared/_pagination.html.erb
 - app/views/admin_suite/shared/_sidebar.html.erb
 - app/views/admin_suite/shared/_toggle_cell.html.erb
 - app/views/admin_suite/shared/_topbar.html.erb
@@ -183,10 +208,22 @@ files:
 - lib/admin_suite/auth/http_basic.rb
 - lib/admin_suite/auth/strategy.rb
 - lib/admin_suite/configuration.rb
+- lib/admin_suite/definition_loader.rb
+- lib/admin_suite/deprecation.rb
 - lib/admin_suite/engine.rb
+- lib/admin_suite/host_autoload_policy.rb
+- lib/admin_suite/legacy_custom_renderer_procs.rb
 - lib/admin_suite/markdown_renderer.rb
 - lib/admin_suite/portal_definition.rb
 - lib/admin_suite/portal_registry.rb
+- lib/admin_suite/renderer.rb
+- lib/admin_suite/renderer_registry.rb
+- lib/admin_suite/renderers/code_renderer.rb
+- lib/admin_suite/renderers/json_renderer.rb
+- lib/admin_suite/renderers/key_value_renderer.rb
+- lib/admin_suite/renderers/legacy_gleania.rb
+- lib/admin_suite/renderers/table_from_renderer.rb
+- lib/admin_suite/section_definition.rb
 - lib/admin_suite/theme_palette.rb
 - lib/admin_suite/ui/dashboard_definition.rb
 - lib/admin_suite/ui/field_renderer_registry.rb
@@ -245,18 +282,38 @@ files:
 - test/dummy/public/robots.txt
 - test/dummy/test/test_helper.rb
 - test/fixtures/docs/progress/PROGRESS_REPORT.md
+- test/integration/association_linking_test.rb
 - test/integration/authentication_test.rb
 - test/integration/authorization_test.rb
+- test/integration/chart_panel_test.rb
 - test/integration/dashboard_test.rb
 - test/integration/docs_test.rb
+- test/integration/index_table_test.rb
+- test/integration/layout_assets_test.rb
+- test/integration/navigation_sections_test.rb
+- test/integration/pagination_and_stats_test.rb
 - test/integration/read_only_resource_test.rb
+- test/integration/searchable_select_search_test.rb
+- test/integration/show_hide_blank_test.rb
 - test/integration/theme_test.rb
+- test/integration/toggle_test.rb
+- test/lib/action_executor_redirect_test.rb
 - test/lib/action_executor_test.rb
 - test/lib/auth_http_basic_test.rb
 - test/lib/auth_resolution_test.rb
 - test/lib/auth_test.rb
+- test/lib/builtin_renderers_test.rb
+- test/lib/definition_loader_test.rb
+- test/lib/engine_defaults_test.rb
+- test/lib/form_field_renderer_test.rb
+- test/lib/format_table_cell_test.rb
+- test/lib/index_includes_test.rb
+- test/lib/legacy_renderer_deprecation_test.rb
 - test/lib/markdown_renderer_test.rb
+- test/lib/renderer_test.rb
+- test/lib/resource_exportable_deprecation_test.rb
 - test/lib/resource_observability_extensions_test.rb
+- test/lib/show_value_formatter_test.rb
 - test/lib/theme_palette_test.rb
 - test/lib/zeitwerk_integration_test.rb
 - test/test_helper.rb