adlint 2.4.10 → 2.6.0

data/ChangeLog

@@ -1,3 +1,212 @@
+Mon Oct 22 15:02:29 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.ga : 2.6.0
+	  - Fix W0609 and w0610 detections not to over-warn about explicit
+	    controlling expressions of for-statements by adding workarounds for
+	    the interpreter.
+	  - Fix W0088 detection not to warn about controlling expression of
+	    for-statement.
+	  - Fix W0723 detection in order to correctly warn about signed `-'
+	    expression.
+	  - Fix bad parameter type convertibility check and bad type
+	    convertibility check of pointer to arbitrary types to void-pointer.
+	  - Revise string representation of typedefed type so that message and
+	    metric show typedefed type name itself.
+	  - Clarify W9003 message text by adding destination type name of the
+	    implicit conversion.
+
+Mon Oct 22 11:07:37 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.5.3
+	  - Clarify W9003 message text by adding destination type name of the
+	    implicit conversion.
+
+Mon Oct 22 10:59:09 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Clarify W9003 message text by
+	  adding destination type name of the implicit conversion.
+	* etc/mesg.d/c_builtin/ja_JP/messages.yml : Ditto.
+	* etc/mesg.d/c_builtin/en_US/messages.yml : Ditto.
+	* share/doc/users_guide_ja.texi : Ditto.
+	* share/doc/users_guide_en.texi : Ditto.
+
+Fri Oct 19 19:33:19 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.5.2
+	  - Fix W0582, W0583, W0584 and W9003 detections to warn about constant
+	    pointers except for NULL.
+
+Fri Oct 19 19:26:31 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/conv.rb : Fix #untyped_pointer_conversion? predicate
+	  method to support consideration about converting value.
+
+	* features/code_check/W0582.feature : Add W0582 specification to
+	  reproduce a known bug.
+	* features/code_check/W0583.feature : Add W0583 specification to
+	  reproduce a known bug.
+	* features/code_check/W0584.feature : Add W0584 specification to
+	  reproduce a known bug.
+	* features/code_check/W9003.feature : Add W9003 specification to
+	  reproduce a known bug.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0582, W0583, W0584 and
+	  W9003 detections to warn about constant pointers except for NULL.
+
+Fri Oct 19 16:19:35 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.5.1
+	  - Fix W0584 detection not to warn when the constant argument is
+	    convertible to the corresponding parameter.
+
+Fri Oct 19 14:59:29 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0584.feature: Add W0584 specification to
+	  reproduce a known bug.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0584 detection not to
+	  warn when the constant argument is convertible to the corresponding
+	  parameter.
+
+Fri Oct 19 13:43:34 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.5.0
+	  - Fix W0582, W0583 and W0584 detections not to warn about unmatched
+	    argument which is considerd as untyped constant pointer such as
+	    NULL or 0.
+
+Fri Oct 19 13:33:28 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0582.feature : Add W0582 specification to
+	  reproduce a known bug.
+	* MANIFEST : Ditto.
+
+	* features/code_check/W0583.feature : Add W0583 specification to
+	  reproduce a known bug.
+
+	* features/code_check/W0584.feature : Add W0584 specification to
+	  reproduce a known bug.
+	* MANIFEST : Ditto.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0582, W0583 and W0584
+	  detections not to warn about unmatched argument which is considerd as
+	  untyped constant pointer such as NULL or 0.
+
+Fri Oct 19 11:25:11 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/conv.rb : Move #untyped_pointer_conversion? predicate
+	  method to C::Conversion module from CBuiltin::W9003 class.
+	* lib/adlint/exam/c_builtin/c_check.rb : Ditto.
+
+Thu Oct 18 16:45:28 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.17
+	  - Fix W0088 detection not to warn about argument expressions in a
+	    function-call-expression.
+
+Thu Oct 18 16:35:48 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0088.feature : Add W0088 specification to
+	  reproduce a known bug.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0088 detection not to
+	  warn about argument expressions in a function-call-expression.
+
+Thu Oct 18 15:17:34 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.15
+	  - Fix expression-statement evaluation in order to notify end of the
+	    evaluation at all times.
+
+Thu Oct 18 15:09:13 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/interp.rb : Fix expression-statement evaluation in order
+	  to notify end of the evaluation at all times.
+
+Thu Oct 18 14:07:33 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.13
+	  - Revise W9003 detection not to warn about implicit conversion of
+	    untyped constant pointers such as NULL or 0.
+	  - Fix W0088 detection not to skip checking when an outmost expression
+	    has side-effect but it contains problematic logical-and-expression
+	    or logical-or-expression.
+
+Thu Oct 18 14:03:00 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0088.feature : Add W0088 specification to
+	  reproduce a known bug.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0088 detection not to
+	  skip checking when an outmost expression has side-effect but it
+	  contains problematic logical-and-expression or logical-or-expression.
+
+Thu Oct 18 13:19:22 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W9003.feature : Add W9003 specification of
+	  implicit convertion of constant pointers.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Revise W9003 detection not to
+	  warn about implicit conversion of untyped constant pointers such as
+	  NULL or 0.
+
+Wed Oct 17 18:28:03 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.11
+	  - Fix W0609 and w0610 detections not to over-warn about explicit
+	    controlling expressions of for-statements by adding workarounds for
+	    the interpreter.
+	  - Fix W0088 detection not to warn about controlling expression of
+	    for-statement.
+	  - Fix W0723 detection in order to correctly warn about signed `-'
+	    expression.
+	  - Fix bad parameter type convertibility check and bad type
+	    convertibility check of pointer to arbitrary types to void-pointer.
+	  - Revise string representation of typedefed type so that message and
+	    metric show typedefed type name itself.
+
+Wed Oct 17 18:08:20 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/type.rb : Revise string representation of typedefed type
+	  so that message and metric show typedefed type name itself.
+
+Wed Oct 17 14:48:23 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W9003.feature : Add W9003 specification to
+	  reproduce a known bug.
+
+	* lib/adlint/c/type.rb : Fix bad parameter type convertibility check
+	  and bad type convertibility check of pointer to arbitrary types to
+	  void-pointer.
+
+Wed Oct 17 13:30:01 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0722.feature : Add W0722 specification.
+	* MANIFEST : Ditto.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0723 detection in order
+	  to correctly warn about signed `-' expression.
+
+Tue Oct 16 18:44:33 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0088.feature : Add W0088 specification.
+	* MANIFEST : Ditto.
+
+	* lib/adlint/c/interp.rb : Add notification about expression-statement
+	  evaluation.
+	* lib/adlint/c/mediator.rb : Ditto.
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0088 detection not to
+	  warn about controlling expression of a for-statement.
+
+Tue Oct 16 16:39:52 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/exam/c_builtin/c_check.rb : Fix W0609 and w0610 detections
+	  not to over-warn about explicit controlling expressions of
+	  for-statements by adding workarounds for the abstract interpreter.
+	* lib/adlint/c/syntax.rb : Ditto.
+	* lib/adlint/c/interp.rb : Ditto.
+
 Mon Oct 15 13:27:34 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
 
 	* release.ga : 2.4.10

data/MANIFEST

@@ -45,6 +45,7 @@ features/code_check/W0025.feature
 features/code_check/W0026.feature
 features/code_check/W0070.feature
 features/code_check/W0071.feature
+features/code_check/W0088.feature
 features/code_check/W0093.feature
 features/code_check/W0104.feature
 features/code_check/W0109.feature
@@ -206,7 +207,9 @@ features/code_check/W0500.feature
 features/code_check/W0501.feature
 features/code_check/W0502.feature
 features/code_check/W0573.feature
+features/code_check/W0582.feature
 features/code_check/W0583.feature
+features/code_check/W0584.feature
 features/code_check/W0606.feature
 features/code_check/W0635.feature
 features/code_check/W0641.feature
@@ -243,6 +246,7 @@ features/code_check/W0716.feature
 features/code_check/W0717.feature
 features/code_check/W0718.feature
 features/code_check/W0719.feature
+features/code_check/W0722.feature
 features/code_check/W0723.feature
 features/code_check/W0726.feature
 features/code_check/W0732.feature

data/NEWS

@@ -21,6 +21,25 @@
 
 ++
 
+=== \AdLint 2.6.0 is released (2012-10-22)
+
+==== Changes since the 2.4.10 release
+
+* Fix W0609 and w0610 detections not to over-warn about explicit controlling
+  expressions of for-statements by adding workarounds for the interpreter
+* Fix W0088 detection not to warn about controlling expression of for-statement
+* Fix W0723 detection in order to correctly warn about signed `-' expression
+* Fix bad parameter type convertibility check and bad type convertibility check
+  of pointer to arbitrary types to void-pointer
+* Revise string representation of typedefed type so that message and metric
+  show typedefed type name itself
+* Clarify W9003 message text by adding destination type name of the implicit
+  conversion
+
+See the file
+{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
+for more details.
+
 === \AdLint 2.4.10 is released (2012-10-15)
 
 ==== Changes since the 2.4.6 release
@@ -35,10 +54,6 @@
 * Fix W0488, W0489, W0490, W0495, W0496, W0497, W0498, W0499, W0500, W0501 and
   W0502 detections to warn when a problematic expression is grouped entirely
 
-See the file
-{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
-for more details.
-
 === \AdLint 2.4.6 is released (2012-10-09)
 
 ==== Changes since the 2.4.0 release

data/etc/mesg.d/c_builtin/en_US/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.10"
+version: "2.6.0"
 
 message_definition:
   W0001:
@@ -2991,7 +2991,7 @@ message_definition:
   W9003:
     classes:
       - "UNC:X99"
-    format: "An object typed `%s' is implicitly converted into an object of other type."
+    format: "An object typed `%s' is implicitly converted into an object of type `%s'."
   C0001:
     classes:
       - "INF:X99"

data/etc/mesg.d/c_builtin/ja_JP/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.10"
+version: "2.6.0"
 
 message_definition:
   W0001:
@@ -2991,7 +2991,7 @@ message_definition:
   W9003:
     classes:
       - "UNC:X99"
-    format: "暗黙的に `%s' 型のオブジェクトが異なる型のオブジェクトに変換されています。"
+    format: "暗黙的に `%s' 型のオブジェクトが `%s' 型のオブジェクトに変換されています。"
   C0001:
     classes:
       - "INF:X99"

data/etc/mesg.d/core/en_US/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.10"
+version: "2.6.0"
 
 message_definition:
   X0001:

data/etc/mesg.d/core/ja_JP/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.10"
+version: "2.6.0"
 
 message_definition:
   X0001:

data/features/code_check/W0088.feature

@@ -0,0 +1,153 @@
+Feature: W0088
+
+  W0088 detects that right-hand-side of the logical-expression in a standalone
+  expression-statement has no side-effect.
+
+  Scenario: no side-effect in a standalone expression-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int n)
+      {
+          int i = bar();
+          (i < n) && (i < 10); /* W0088 */
+          return i;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0109 | 3    | 16     |
+      | W0088 | 4    | 13     |
+      | W0100 | 3    | 9      |
+      | W0104 | 1    | 20     |
+      | W0629 | 1    | 12     |
+      | W0085 | 4    | 5      |
+      | W0628 | 1    | 12     |
+
+  Scenario: side-effect in a standalone expression-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int n)
+      {
+          int i = bar();
+          (i < n) && (i++); /* OK */
+          return i;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0109 | 3    | 16     |
+      | W0104 | 1    | 20     |
+      | W0629 | 1    | 12     |
+      | W0508 | 4    | 13     |
+      | W0735 | 4    | 16     |
+      | W0512 | 4    | 18     |
+      | W0628 | 1    | 12     |
+
+  Scenario: no side-effect in controlling expression of for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int n)
+      {
+          int i, j = 0;
+          for (i = 0; (i < n) && (i < 10); i++) { /* OK */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0104 | 1    | 20     |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: no side-effect in right-most expression of a standalone
+            expression-statement
+    Given a target source named "fixture.c" with:
+      """
+      extern int foo(int);
+      extern int bar(int);
+
+      static void baz(int i, int j, int k)
+      {
+          (i > 0) && foo(i) && bar(j) && k; /* W0088 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0118 | 2    | 12     |
+      | W1076 | 4    | 13     |
+      | W0088 | 6    | 33     |
+      | W0104 | 4    | 21     |
+      | W0104 | 4    | 28     |
+      | W0104 | 4    | 35     |
+      | W0629 | 4    | 13     |
+      | W0488 | 6    | 5      |
+      | W0508 | 6    | 23     |
+      | W0508 | 6    | 13     |
+      | W0628 | 4    | 13     |
+
+  Scenario: no side-effect in right-most expression of an assignment-expression
+    Given a target source named "fixture.c" with:
+      """
+      extern int foo(int);
+      extern int bar(int);
+
+      static void baz(int i, int j, int k)
+      {
+          int l = 0;
+          l = (i > 0) && foo(i) && bar(j) && k; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0118 | 2    | 12     |
+      | W1076 | 4    | 13     |
+      | W0104 | 4    | 21     |
+      | W0104 | 4    | 28     |
+      | W0104 | 4    | 35     |
+      | W0629 | 4    | 13     |
+      | W0488 | 7    | 5      |
+      | W0508 | 7    | 27     |
+      | W0508 | 7    | 17     |
+      | W0628 | 4    | 13     |
+
+  Scenario: no side-effect in argument expressions of function-call-expression
+    Given a target source named "fixture.c" with:
+      """
+      extern int foo(int);
+      extern int bar(int);
+      extern void baz(const char *, ...);
+
+      static void qux(int i, int j, int k)
+      {
+          baz("", (i > 0) && foo(i) && bar(i || j) && k); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0118 | 2    | 12     |
+      | W0118 | 3    | 13     |
+      | W1076 | 5    | 13     |
+      | W0104 | 5    | 21     |
+      | W0104 | 5    | 28     |
+      | W0104 | 5    | 35     |
+      | W0629 | 5    | 13     |
+      | W0488 | 7    | 13     |
+      | W0947 | 7    | 9      |
+      | W0508 | 7    | 31     |
+      | W0508 | 7    | 21     |
+      | W0628 | 5    | 13     |