adlint 2.4.10 → 2.6.0

data/features/code_check/W0734.feature

@@ -30,15 +30,10 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 17     |
       | W0734 | 5    | 9      |
-      | W0088 | 6    | 17     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0628 | 1    | 13     |
 
@@ -69,15 +64,11 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 17     |
       | W0734 | 5    | 9      |
       | W0508 | 6    | 17     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0108 | 6    | 23     |
       | W0628 | 1    | 13     |
@@ -109,15 +100,10 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 17     |
       | W0734 | 5    | 9      |
-      | W0088 | 6    | 17     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0628 | 1    | 13     |
 
@@ -148,15 +134,11 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 17     |
       | W0734 | 5    | 9      |
       | W0508 | 6    | 17     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0108 | 6    | 23     |
       | W0628 | 1    | 13     |
@@ -191,15 +173,10 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0734 | 5    | 9      |
-      | W0088 | 6    | 18     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0628 | 1    | 13     |
 
@@ -233,15 +210,10 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0734 | 5    | 9      |
-      | W0088 | 6    | 18     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0628 | 1    | 13     |
 
@@ -275,15 +247,11 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0734 | 5    | 9      |
       | W0508 | 6    | 18     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0108 | 6    | 24     |
       | W0628 | 1    | 13     |
@@ -318,15 +286,11 @@ Feature: W0734
       | W0104 | 1    | 29     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0734 | 5    | 9      |
       | W0508 | 6    | 18     |
       | W0734 | 6    | 9      |
-      | W0088 | 7    | 17     |
       | W0734 | 7    | 9      |
-      | W0088 | 8    | 17     |
       | W0734 | 8    | 9      |
-      | W0088 | 9    | 17     |
       | W0734 | 9    | 9      |
       | W0108 | 6    | 24     |
       | W0628 | 1    | 13     |

data/features/code_check/W0735.feature

@@ -30,15 +30,10 @@ Feature: W0735
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 11     |
       | W0735 | 5    | 14     |
-      | W0088 | 6    | 11     |
       | W0735 | 6    | 14     |
-      | W0088 | 7    | 11     |
       | W0735 | 7    | 14     |
-      | W0088 | 8    | 11     |
       | W0735 | 8    | 14     |
-      | W0088 | 9    | 11     |
       | W0735 | 9    | 14     |
       | W0628 | 1    | 13     |
 
@@ -69,15 +64,10 @@ Feature: W0735
       | W0104 | 1    | 36     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0735 | 5    | 21     |
-      | W0088 | 6    | 17     |
       | W0735 | 6    | 20     |
-      | W0088 | 7    | 18     |
       | W0735 | 7    | 21     |
-      | W0088 | 8    | 17     |
       | W0735 | 8    | 20     |
-      | W0088 | 9    | 18     |
       | W0735 | 9    | 21     |
       | W0108 | 6    | 12     |
       | W0628 | 1    | 13     |
@@ -109,15 +99,10 @@ Feature: W0735
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 11     |
       | W0735 | 5    | 14     |
-      | W0088 | 6    | 11     |
       | W0735 | 6    | 14     |
-      | W0088 | 7    | 11     |
       | W0735 | 7    | 14     |
-      | W0088 | 8    | 11     |
       | W0735 | 8    | 14     |
-      | W0088 | 9    | 11     |
       | W0735 | 9    | 14     |
       | W0628 | 1    | 13     |
 
@@ -148,15 +133,10 @@ Feature: W0735
       | W0104 | 1    | 36     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0735 | 5    | 21     |
-      | W0088 | 6    | 17     |
       | W0735 | 6    | 20     |
-      | W0088 | 7    | 18     |
       | W0735 | 7    | 21     |
-      | W0088 | 8    | 17     |
       | W0735 | 8    | 20     |
-      | W0088 | 9    | 18     |
       | W0735 | 9    | 21     |
       | W0108 | 6    | 12     |
       | W0628 | 1    | 13     |
@@ -191,15 +171,10 @@ Feature: W0735
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 11     |
       | W0735 | 5    | 14     |
-      | W0088 | 6    | 11     |
       | W0735 | 6    | 14     |
-      | W0088 | 7    | 11     |
       | W0735 | 7    | 14     |
-      | W0088 | 8    | 11     |
       | W0735 | 8    | 14     |
-      | W0088 | 9    | 11     |
       | W0735 | 9    | 14     |
       | W0628 | 1    | 13     |
 
@@ -233,15 +208,10 @@ Feature: W0735
       | W0104 | 1    | 29     |
       | W0104 | 1    | 36     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 11     |
       | W0735 | 5    | 14     |
-      | W0088 | 6    | 11     |
       | W0735 | 6    | 14     |
-      | W0088 | 7    | 11     |
       | W0735 | 7    | 14     |
-      | W0088 | 8    | 11     |
       | W0735 | 8    | 14     |
-      | W0088 | 9    | 11     |
       | W0735 | 9    | 14     |
       | W0628 | 1    | 13     |
 
@@ -275,15 +245,10 @@ Feature: W0735
       | W0104 | 1    | 36     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0735 | 5    | 21     |
-      | W0088 | 6    | 17     |
       | W0735 | 6    | 20     |
-      | W0088 | 7    | 18     |
       | W0735 | 7    | 21     |
-      | W0088 | 8    | 17     |
       | W0735 | 8    | 20     |
-      | W0088 | 9    | 18     |
       | W0735 | 9    | 21     |
       | W0108 | 6    | 12     |
       | W0628 | 1    | 13     |
@@ -318,15 +283,10 @@ Feature: W0735
       | W0104 | 1    | 36     |
       | W0104 | 1    | 43     |
       | W0629 | 1    | 13     |
-      | W0088 | 5    | 18     |
       | W0735 | 5    | 21     |
-      | W0088 | 6    | 17     |
       | W0735 | 6    | 20     |
-      | W0088 | 7    | 18     |
       | W0735 | 7    | 21     |
-      | W0088 | 8    | 17     |
       | W0735 | 8    | 20     |
-      | W0088 | 9    | 18     |
       | W0735 | 9    | 21     |
       | W0108 | 6    | 12     |
       | W0628 | 1    | 13     |

data/features/code_check/W0745.feature

@@ -23,6 +23,7 @@ Feature: W0745
       | mesg  | line | column |
       | W0118 | 1    | 12     |
       | W0117 | 3    | 5      |
+      | W0723 | 6    | 21     |
       | W0745 | 6    | 21     |
       | W0100 | 6    | 13     |
       | W0104 | 3    | 13     |

data/features/code_check/W9003.feature

@@ -182,3 +182,88 @@ Feature: W9003
       | W0031 | 3    | 13     |
       | W0104 | 3    | 13     |
       | W0628 | 3    | 5      |
+
+  Scenario: implicit conversion to void pointer
+    Given a target source named "fixture.c" with:
+      """
+      typedef struct foo { int i; } foo_t;
+      extern void foo(foo_t *);
+
+      typedef struct bar { int i; } bar_t;
+      extern void bar(bar_t *);
+
+      extern void baz(void *);
+
+      static void qux(foo_t *f, bar_t *b)
+      {
+          foo(b); /* W9003 */
+          bar(f); /* W9003 */
+          foo(f); /* OK */
+          baz(f); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 2    | 13     |
+      | W0118 | 5    | 13     |
+      | W0118 | 7    | 13     |
+      | W1076 | 9    | 13     |
+      | W9003 | 11   | 9      |
+      | W9003 | 12   | 9      |
+      | W0104 | 9    | 24     |
+      | W0104 | 9    | 34     |
+      | W0105 | 9    | 24     |
+      | W0105 | 9    | 34     |
+      | W0629 | 9    | 13     |
+      | W0628 | 9    | 13     |
+
+  Scenario: implicit convertion from void pointer
+    Given a target source named "fixture.c" with:
+      """
+      typedef struct foo { int i; } foo_t;
+      extern void *foo(foo_t *);
+
+      static void bar(void *p)
+      {
+          foo_t *f = foo(p); /* legal but W9003 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 2    | 14     |
+      | W1076 | 4    | 13     |
+      | W9003 | 6    | 20     |
+      | W9003 | 6    | 19     |
+      | W0100 | 6    | 12     |
+      | W0104 | 4    | 23     |
+      | W0105 | 4    | 23     |
+      | W0629 | 4    | 13     |
+      | W0628 | 4    | 13     |
+
+  Scenario: implicit convertion of constant pointer
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(void *p)
+      {
+          int *p1 = NULL; /* OK */
+          int *p2 = 0; /* OK */
+          int *p3 = p; /* legal but W9003 */
+          int *p4 = 3; /* W9003 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W9003 | 5    | 15     |
+      | W9003 | 6    | 15     |
+      | W0100 | 3    | 10     |
+      | W0100 | 4    | 10     |
+      | W0100 | 5    | 10     |
+      | W0100 | 6    | 10     |
+      | W0104 | 1    | 23     |
+      | W0105 | 1    | 23     |
+      | W0629 | 1    | 13     |
+      | W0628 | 1    | 13     |

data/lib/adlint/c/conv.rb

@@ -86,6 +86,33 @@ module C #:nodoc:
       end
     end
 
+    def untyped_pointer_conversion?(from_type, to_type, from_value)
+      return false unless to_type.pointer?
+
+      # NOTE: Untyped pointer conversion is defined as below;
+      #
+      #           from_type     |     to_type      |      result
+      #       ------------------+------------------+-----------------
+      #        void pointer     | void pointer     | true
+      #        void pointer     | non-void pointer | true
+      #        non-void pointer | void pointer     | true
+      #        non-void pointer | non-void pointer | false
+      #        non-enum integer | void pointer     | from_value == 0
+      #        non-enum integer | non-void pointer | from_value == 0
+      #        enum             | void pointer     | false
+      #        enum             | non-void pointer | false
+      #        other            | void pointer     | true
+      #        other            | non-void pointer | false
+      case
+      when from_type.pointer?
+        void_pointer?(from_type) || void_pointer?(to_type)
+      when from_type.integer?
+        !from_type.enum? && from_value.must_be_equal_to?(ScalarValue.of(0))
+      else
+        void_pointer?(to_type)
+      end
+    end
+
     private
     def wrap_around_value(original, to_type)
       return original.value unless original.type.scalar? && to_type.scalar?
@@ -105,6 +132,11 @@ module C #:nodoc:
 
       original.value
     end
+
+    def void_pointer?(type)
+      unqualified_type = type.unqualify
+      unqualified_type.pointer? && unqualified_type.base_type.void?
+    end
   end
 
   # Host class of this module must include StandardTypeCatalogAccessor.

data/lib/adlint/c/interp.rb

@@ -314,6 +314,14 @@ module C #:nodoc:
                             :assignment_expression, :lhs_variable,
                             :rhs_variable
 
+    # NOTE: Notified when the interpreter starts execution of a
+    #       expression-statement.
+    def_plugin_and_notifier :expression_stmt_started, :expression_statement
+
+    # NOTE: Notified when the interpreter ends execution of a
+    #       expression-statement.
+    def_plugin_and_notifier :expression_stmt_ended, :expression_statement
+
     # NOTE: Notified when the interpreter starts execution of a
     #       switch-statement.
     def_plugin_and_notifier :switch_stmt_started, :switch_statement
@@ -1008,7 +1016,11 @@ module C #:nodoc:
       checkpoint(node.location)
 
       node.executed = true
+      notify_expression_stmt_started(node)
+
       interpret(node.expression) if node.expression
+    ensure
+      notify_expression_stmt_ended(node)
     end
 
     def visit_if_statement(node)
@@ -1278,7 +1290,11 @@ module C #:nodoc:
           #       controlling variable is referred by the controlling
           #       expression at the last iteration.
           # FIXME: This re-interpretation of the controlling expression may
-          #        causes duplicative warning messages.
+          #        cause duplicative warning messages.
+          # FIXME: This re-interpretation of the controlling expression always
+          #        causes "logical-expression must be false" warnings about a
+          #        one-time-for-loop.  To avoid this, now, workarounds are in
+          #        builtin code checks W0609 and W0610.
           interpret(explicit_ctrlexpr)
         end
       end

data/lib/adlint/c/mediator.rb

@@ -222,6 +222,8 @@ module C #:nodoc:
     def_delegator :interpreter, :notify_prefix_decrement_expr_evaled
     def_delegator :interpreter, :notify_postfix_decrement_expr_evaled
     def_delegator :interpreter, :notify_assignment_expr_evaled
+    def_delegator :interpreter, :notify_expression_stmt_started
+    def_delegator :interpreter, :notify_expression_stmt_ended
     def_delegator :interpreter, :notify_switch_stmt_started
     def_delegator :interpreter, :notify_switch_stmt_ended
     def_delegator :interpreter, :notify_while_stmt_started

data/lib/adlint/c/syntax.rb

@@ -325,6 +325,28 @@ module C #:nodoc:
     end
     module_function :collect_additive_expressions
 
+    def collect_relational_expressions(node)
+      if node
+        RelationalExpressionCollector.new.tap { |collector|
+          node.accept(collector)
+        }.relational_expressions
+      else
+        []
+      end
+    end
+    module_function :collect_relational_expressions
+
+    def collect_equality_expressions(node)
+      if node
+        EqualityExpressionCollector.new.tap { |collector|
+          node.accept(collector)
+        }.equality_expressions
+      else
+        []
+      end
+    end
+    module_function :collect_equality_expressions
+
     def collect_logical_and_expressions(node)
       if node
         LogicalAndExpressionCollector.new.tap { |collector|
@@ -336,6 +358,17 @@ module C #:nodoc:
     end
     module_function :collect_logical_and_expressions
 
+    def collect_logical_or_expressions(node)
+      if node
+        LogicalOrExpressionCollector.new.tap { |collector|
+          node.accept(collector)
+        }.logical_or_expressions
+      else
+        []
+      end
+    end
+    module_function :collect_logical_or_expressions
+
     def collect_generic_labeled_statements(node)
       if node
         GenericLabeledStatementCollector.new.tap { |collector|
@@ -5611,6 +5644,32 @@ module C #:nodoc:
     end
   end
 
+  class RelationalExpressionCollector < SyntaxTreeVisitor
+    def initialize
+      @relational_expressions = []
+    end
+
+    attr_reader :relational_expressions
+
+    def visit_relational_expression(node)
+      super
+      @relational_expressions.push(node)
+    end
+  end
+
+  class EqualityExpressionCollector < SyntaxTreeVisitor
+    def initialize
+      @equality_expressions = []
+    end
+
+    attr_reader :equality_expressions
+
+    def visit_equality_expression(node)
+      super
+      @equality_expressions.push(node)
+    end
+  end
+
   class LogicalAndExpressionCollector < SyntaxTreeVisitor
     def initialize
       @logical_and_expressions = []
@@ -5624,6 +5683,19 @@ module C #:nodoc:
     end
   end
 
+  class LogicalOrExpressionCollector < SyntaxTreeVisitor
+    def initialize
+      @logical_or_expressions = []
+    end
+
+    attr_reader :logical_or_expressions
+
+    def visit_logical_or_expression(node)
+      super
+      @logical_or_expressions.push(node)
+    end
+  end
+
   class GenericLabeledStatementCollector < SyntaxTreeVisitor
     def initialize
       @generic_labeled_statements = []