adlint 3.0.8 → 3.0.10

data/features/code_check/W0093.feature

@@ -1,6 +1,6 @@
 Feature: W0093
 
-  W0093 detects that a division-by-zero may occur.
+  W0093 detects that a multiplicative-expression may cause division-by-zero.
 
   Scenario: narrowing denominator variable by an iteration controlling
             variable which has same value domain of the denominator

data/features/code_check/W0097.feature

@@ -0,0 +1,30 @@
+Feature: W0097
+
+  W0097 detects that a multiplicative-expression must cause division-by-zero.
+
+  Scenario: dividing by global constant variable initialized with 0
+    Given a target source named "fixture.c" with:
+      """
+      static const int i = 0;
+
+      static int foo(void)
+      {
+          return 3 / i; /* W0097 */
+      }
+
+      static int bar(void)
+      {
+          return 3 / i; /* W0097 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W0097 | 5    | 14     |
+      | W1076 | 8    | 12     |
+      | W0097 | 10   | 14     |
+      | W0629 | 3    | 12     |
+      | W0629 | 8    | 12     |
+      | W0628 | 3    | 12     |
+      | W0628 | 8    | 12     |

data/features/code_check/W0100.feature

@@ -0,0 +1,66 @@
+Feature: W0100
+
+  W0100 detects that a variable is not reassigned since the initial value is
+  assigned.
+
+  Scenario: reassigning value to an array element of the indefinite subscript
+    Given a target source named "fixture.c" with:
+      """
+      void foo(int i)
+      {
+          int a[3]; /* OK not W0100 */
+          a[i] = 0;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0705 | 4    | 7      |
+      | W0104 | 1    | 14     |
+      | W0950 | 3    | 11     |
+      | W0628 | 1    | 6      |
+
+  Scenario: reassigning value to a nested array element of the indefinite
+            subscript
+    Given a target source named "fixture.c" with:
+      """
+      void foo(int i)
+      {
+          int a[3][3]; /* OK not W0100 */
+          a[i][i] = 0;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0705 | 4    | 7      |
+      | W0705 | 4    | 10     |
+      | W0104 | 1    | 14     |
+      | W0950 | 3    | 14     |
+      | W0950 | 3    | 11     |
+      | W0628 | 1    | 6      |
+
+  Scenario: only reference to a nested array element of the indefinite
+            subscript
+    Given a target source named "fixture.c" with:
+      """
+      void foo(int i)
+      {
+          int a[3][3]; /* W0100 */
+          a[i][i];
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0705 | 4    | 7      |
+      | W0705 | 4    | 10     |
+      | W0100 | 3    | 9      |
+      | W0104 | 1    | 14     |
+      | W0950 | 3    | 14     |
+      | W0950 | 3    | 11     |
+      | W0085 | 4    | 5      |
+      | W0628 | 1    | 6      |

data/features/code_check/W0422.feature

@@ -126,3 +126,160 @@ Feature: W0422
       | W1071 | 3    | 6      |
       | W0948 | 5    | 21     |
       | W0628 | 3    | 6      |
+
+  Scenario: value of the global pointer is correctly null-checked by the
+            controlling-expression of while-statement
+    Given a target source named "fixture.c" with:
+      """
+      int *ptr = NULL;
+
+      static void foo(void)
+      {
+          while (ptr) {
+              int i, *p = ptr;
+              i = *p; /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W1076 | 3    | 13     |
+      | W0100 | 6    | 17     |
+      | W0629 | 3    | 13     |
+      | W0114 | 5    | 5      |
+      | W0425 | 6    | 17     |
+      | W0628 | 3    | 13     |
+      | W0589 | 1    | 6      |
+      | W0593 | 1    | 6      |
+
+  Scenario: global pointer array as the controlling-expression of if-statement
+    Given a target source named "fixture.c" with:
+      """
+      int *a[3] = { 0 };
+
+      int foo(void)
+      {
+          if (a[2] == NULL) {
+              return *a[2];
+          }
+          else if (a[2] == 1) {
+              return *a[2];
+          }
+          return *a[2]; /* OK not W0422 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0117 | 3    | 5      |
+      | W0421 | 6    | 16     |
+      | W9003 | 8    | 22     |
+      | W0027 | 8    | 19     |
+      | W1071 | 3    | 5      |
+      | W0950 | 1    | 8      |
+      | W1069 | 5    | 5      |
+      | W0628 | 3    | 5      |
+      | W0589 | 1    | 6      |
+      | W0593 | 1    | 6      |
+
+  Scenario: global pointer as the controlling-expression of if-statement
+    Given a target source named "fixture.c" with:
+      """
+      int *ptr = 0;
+
+      int bar(void)
+      {
+          if (ptr == NULL) {
+              return *ptr;
+          }
+          else if (ptr == 1) {
+              return *ptr;
+          }
+          return *ptr; /* OK not W0422 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0117 | 3    | 5      |
+      | W0421 | 6    | 16     |
+      | W9003 | 8    | 21     |
+      | W0027 | 8    | 18     |
+      | W1071 | 3    | 5      |
+      | W1069 | 5    | 5      |
+      | W0628 | 3    | 5      |
+      | W0589 | 1    | 6      |
+      | W0593 | 1    | 6      |
+
+  Scenario: global pointer as the controlling-expression of if-statement in an
+            iteration-statement
+    Given a target source named "fixture.c" with:
+      """
+      int *a[3] = { 0 };
+
+      int foo(unsigned int ui)
+      {
+          for (; ui < 3; ui++) {
+              if (a[ui] == NULL) {
+                  break;
+              }
+              return *a[ui]; /* OK not W0422 */
+          }
+          return 0;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0117 | 3    | 5      |
+      | W0534 | 5    | 10     |
+      | W0167 | 5    | 17     |
+      | W0147 | 6    | 15     |
+      | W0147 | 9    | 19     |
+      | W0104 | 3    | 22     |
+      | W1071 | 3    | 5      |
+      | W0950 | 1    | 8      |
+      | W0628 | 3    | 5      |
+      | W0589 | 1    | 6      |
+      | W0593 | 1    | 6      |
+
+  Scenario: global pointer as the controlling-expression of if-statement in an
+            iteration-statement
+    Given a target source named "fixture.c" with:
+      """
+      int *ptr = 0;
+
+      int bar(unsigned int ui)
+      {
+          for (; ui < 3; ui++) {
+              if (ptr == NULL) {
+                  break;
+              }
+              else if (ptr == 1) {
+                  return *ptr; /* OK */
+              }
+              return *ptr; /* OK not W0422 */
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0117 | 3    | 5      |
+      | W0534 | 5    | 10     |
+      | W0167 | 5    | 17     |
+      | W9003 | 9    | 25     |
+      | W0027 | 9    | 22     |
+      | W0697 | 3    | 5      |
+      | W0104 | 3    | 22     |
+      | W1071 | 3    | 5      |
+      | W1069 | 6    | 9      |
+      | W0628 | 3    | 5      |
+      | W0589 | 1    | 6      |
+      | W0593 | 1    | 6      |

data/features/code_check/W0459.feature

@@ -0,0 +1,118 @@
+Feature: W0459
+
+  W0459 detects that the variable is not initialized at point of the expression
+  evaluation.
+
+  Scenario: variable initialization by a function via the output parameter
+    Given a target source named "fixture.c" with:
+      """
+      extern void foo(int ***);
+      extern void bar(int **);
+
+      void baz(int i)
+      {
+          int **p;
+          foo(i == 0 ? NULL : &p);
+          bar(p);
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 13     |
+      | W0118 | 2    | 13     |
+      | W0117 | 4    | 6      |
+      | W0459 | 7    | 25     |
+      | W0100 | 6    | 11     |
+      | W0104 | 4    | 14     |
+      | W0501 | 7    | 16     |
+      | W0628 | 4    | 6      |
+
+  Scenario: reference to the uninitialized nested array element of the
+            indefinite subscript
+    Given a target source named "fixture.c" with:
+      """
+      int foo(int i)
+      {
+          int a[3][3]; /* W0100 */
+          return a[i][i]; /* W0459 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0705 | 4    | 14     |
+      | W0705 | 4    | 17     |
+      | W0459 | 4    | 16     |
+      | W0100 | 3    | 9      |
+      | W0104 | 1    | 13     |
+      | W0950 | 3    | 14     |
+      | W0950 | 3    | 11     |
+      | W0628 | 1    | 5      |
+
+  Scenario: reference to the initialized array element of the indefinite
+            subscript
+    Given a target source named "fixture.c" with:
+      """
+      int foo(int i)
+      {
+          int a[3] = { 0 };
+
+          if (i < 3) {
+              return a[i]; /* OK not W0459 */
+          }
+          return 0;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0705 | 6    | 18     |
+      | W0100 | 3    | 9      |
+      | W0104 | 1    | 13     |
+      | W1071 | 1    | 5      |
+      | W0950 | 3    | 11     |
+      | W0628 | 1    | 5      |
+
+  Scenario: assign value to the variable in a switch-statement in an
+            iteration-statement
+    Given a target source named "fixture.c" with:
+      """
+      extern void bar(int *);
+
+      int foo(int a[])
+      {
+          int i;
+          int j;
+
+          for (i = 0; a[i]; i++) {
+              switch (a[i]) {
+              case 0:
+                  bar(&j);
+                  break;
+              case 2:
+                  bar(&j);
+                  break;
+              default:
+                  break;
+              }
+          }
+
+          return j; /* OK but W0460 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 13     |
+      | W0117 | 3    | 5      |
+      | W0459 | 14   | 17     |
+      | W0460 | 21   | 12     |
+      | W0104 | 3    | 13     |
+      | W9001 | 10   | 9      |
+      | W9001 | 11   | 13     |
+      | W9001 | 12   | 13     |
+      | W0114 | 8    | 5      |
+      | W0628 | 3    | 5      |

data/features/code_check/W0461.feature

@@ -0,0 +1,115 @@
+Feature: W0461
+
+  W0461 detects that a pointer to the undefined value is passed as an argument.
+
+  Scenario: pointer to the global constant array initialized with a
+            string-literal
+    Given a target source named "fixture.c" with:
+      """
+      static const char str[] = "str";
+
+      extern void foo(const void *);
+
+      static void bar(void)
+      {
+          foo(str); /* OK */
+      }
+
+      static void baz(void)
+      {
+          foo(str); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 3    | 13     |
+      | W1076 | 5    | 13     |
+      | W1076 | 10   | 13     |
+      | W0629 | 5    | 13     |
+      | W0629 | 10   | 13     |
+      | W0947 | 1    | 27     |
+      | W0628 | 5    | 13     |
+      | W0628 | 10   | 13     |
+
+  Scenario: pointer to the global constant explicitly sized array initialized
+            with a string-literal
+    Given a target source named "fixture.c" with:
+      """
+      static const char str[4] = "str";
+
+      extern void foo(const void *);
+
+      static void bar(void)
+      {
+          foo(str); /* OK */
+      }
+
+      static void baz(void)
+      {
+          foo(str); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 3    | 13     |
+      | W1076 | 5    | 13     |
+      | W1076 | 10   | 13     |
+      | W0629 | 5    | 13     |
+      | W0629 | 10   | 13     |
+      | W0947 | 1    | 28     |
+      | W0950 | 1    | 23     |
+      | W0628 | 5    | 13     |
+      | W0628 | 10   | 13     |
+
+  Scenario: array elements may be initialized according to a parameter value
+    Given a target source named "fixture.c" with:
+      """
+      extern void bar(const int *);
+
+      void baz(int i)
+      {
+          int a[5];
+
+          for (; i < 2; i++) {
+              a[i] = i;
+          }
+
+          bar(a); /* OK not W0461 but W0462 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 13     |
+      | W0117 | 3    | 6      |
+      | W0534 | 7    | 10     |
+      | W0705 | 8    | 11     |
+      | W0462 | 11   | 9      |
+      | W0950 | 5    | 11     |
+      | W0628 | 3    | 6      |
+
+  Scenario: array elements is initialized by an iteration-statement
+    Given a target source named "fixture.c" with:
+      """
+      extern void bar(const int *);
+
+      void baz(void)
+      {
+          int a[3];
+
+          for (int i = 0; i < 3; i++) {
+              a[i] = i;
+          }
+
+          bar(a); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 13     |
+      | W0117 | 3    | 6      |
+      | W0950 | 5    | 11     |
+      | W0628 | 3    | 6      |