adlint 2.6.2 → 2.6.10

data/features/code_check/W0611.feature

@@ -0,0 +1,138 @@
+Feature: W0611
+
+  W0611 detects that a controlling expression of the iteration-statement always
+  be true.
+
+  Scenario: controlling variable of for-statement is not updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          for (; i < 10; ) { /* W0611 */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0534 | 4    | 10     |
+      | W0609 | 4    | 14     |
+      | W0708 | 5    | 10     |
+      | W0611 | 4    | 14     |
+      | W0100 | 3    | 9      |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: controlling variable of for-statement is updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          for (; i < 10; i++) { /* OK */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0534 | 4    | 10     |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: controlling variable of while-statement is not updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          while (i < 10) { /* W0611 */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0609 | 4    | 14     |
+      | W0611 | 4    | 14     |
+      | W0100 | 3    | 9      |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: controlling variable of while-statement is updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          while (i < 10) { /* OK */
+              i++;
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: controlling variable of do-statement is not updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          do {
+              j++;
+          } while (i < 10); /* W0611 */
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0609 | 6    | 16     |
+      | W0611 | 6    | 16     |
+      | W0100 | 3    | 9      |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: controlling variable of do-statement is updated
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0, j = 0;
+          do {
+              i++;
+              j++;
+          } while (i < 10); /* OK */
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0629 | 1    | 12     |
+      | W0425 | 3    | 16     |
+      | W0628 | 1    | 12     |

data/features/code_check/W0708.feature

@@ -0,0 +1,66 @@
+Feature: W0708
+
+  W0708 detects that a controlling variable of for-statement is updated in the
+  loop body.
+
+  Scenario: address of the controlling variable is passed to a function in the
+            controlling part of for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static void foo(void)
+      {
+          int i;
+          for (i = 0; (bar(&i)) && (i < 10); ) { /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0629 | 3    | 13     |
+      | W0628 | 3    | 13     |
+
+  Scenario: address of the controlling variable is passed to a function in the
+            controlling part of for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static void foo(void)
+      {
+          int i;
+          for (i = 0; (bar(&i)) && (i < 10); i++) { /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0629 | 3    | 13     |
+      | W0628 | 3    | 13     |
+
+  Scenario: address of the controlling variable is passed to a function in the
+            controlling part of for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static void foo(void)
+      {
+          int i;
+          for (i = 0; (bar(&i)) && (i < 10); i++) {
+              if (i == 5) { i++; } /* W0708 */
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0708 | 7    | 24     |
+      | W0629 | 3    | 13     |
+      | W0628 | 3    | 13     |

data/features/code_check/W1069.feature

@@ -126,3 +126,30 @@ Feature: W1069
       | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0628 | 1    | 12     |
+
+  Scenario: incomplete `if-else-if' statement chain in a complete `if-else'
+            statement
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i)
+      {
+          if (i == 0) {
+              return;
+          }
+          else {
+              if (i == 1) { /* W1069 */
+              }
+              else if (i == 2) {
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 21     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W1069 | 7    | 9      |
+      | W0628 | 1    | 13     |

data/features/code_check/W1073.feature

@@ -141,3 +141,145 @@ Feature: W1073
       | W0010 | 5    | 23     |
       | W0086 | 5    | 23     |
       | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of if-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int i = 0;
+          if (bar(&i)) { /* OK */
+              return i;
+          }
+          return 0;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of if-else-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int i = 0;
+          if (bar(&i)) { /* OK */
+              return i;
+          } else {
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of while-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int i = 0;
+          while (bar(&i)) { /* OK */
+              i++;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of do-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int i = 0;
+          do {
+              i++;
+          } while (bar(&i)); /* OK */
+          return i;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int i, j = 0;
+          for (i = 0; bar(&i); i++) { /* OK */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0425 | 5    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: standalone function-call-expression as the controlling expression
+            of c99-for-statement
+    Given a target source named "fixture.c" with:
+      """
+      static int bar(int *);
+
+      static int foo(void)
+      {
+          int j = 0;
+          for (int i = 0; bar(&i); i++) { /* OK */
+              j++;
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0114 | 6    | 5      |
+      | W0628 | 3    | 12     |

data/lib/adlint/c/ctrlexpr.rb

@@ -71,15 +71,10 @@ module C #:nodoc:
 
       if target_expr
         new_manip = ValueDomainNarrower.new(@interpreter, target_expr)
-        begin
-          if @branch.implicit_condition?
-            @interpreter._quiet = true
-          end
+        if @branch.implicit_condition?
+          eval_quietly { new_manip.prepare! }
+        else
           new_manip.prepare!
-        ensure
-          if @branch.implicit_condition?
-            @interpreter._quiet = false
-          end
         end
       else
         new_manip = NilValueDomainNarrower.new(@interpreter, @branch.group)
@@ -94,15 +89,10 @@ module C #:nodoc:
 
       if target_expr
         new_manip = ValueDomainWidener.new(@interpreter, target_expr)
-        begin
-          if @branch.implicit_condition?
-            @interpreter._quiet = true
-          end
+        if @branch.implicit_condition?
+          eval_quietly { new_manip.prepare! }
+        else
           new_manip.prepare!
-        ensure
-          if @branch.implicit_condition?
-            @interpreter._quiet = false
-          end
         end
       else
         new_manip = NilValueDomainWidener.new(@interpreter, @branch.group)
@@ -133,6 +123,19 @@ module C #:nodoc:
       #       complex to thin value domains of controlling variables.
       @target_expr && !collect_logical_and_expressions(@target_expr).empty?
     end
+
+    private
+    def eval_quietly(&block)
+      originally_quiet = @interpreter.quiet?
+      if @branch.implicit_condition? && !originally_quiet
+        @interpreter._quiet = true
+      end
+      yield
+    ensure
+      if @branch.implicit_condition? && !originally_quiet
+        @interpreter._quiet = false
+      end
+    end
   end
 
   class ValueDomainManipulator < SyntaxTreeVisitor
@@ -596,6 +599,9 @@ module C #:nodoc:
         @narrowed_values = manip.narrowed_values.merge(@narrowed_values)
       end
     ensure
+      if result && result.variable?
+        notify_variable_value_referred(node, result)
+      end
       if seqp = node.subsequent_sequence_point
         notify_sequence_point_reached(seqp)
       end

data/lib/adlint/c/interp.rb

@@ -981,7 +981,10 @@ module C #:nodoc:
         ctrlexpr_val = ScalarValue.of_arbitrary
         ctrlexpr = nil
       else
-        ctrlexpr_val = value_of(interpret(orig_ctrlexpr))
+        ctrlexpr_var = object_to_variable(interpret(orig_ctrlexpr))
+        ctrlexpr_val = value_of(ctrlexpr_var)
+        notify_variable_value_referred(orig_ctrlexpr, ctrlexpr_var)
+        notify_sequence_point_reached(SequencePoint.new(orig_ctrlexpr))
         ctrlexpr = orig_ctrlexpr.to_normalized_logical
       end
       notify_if_ctrlexpr_evaled(node, ctrlexpr_val)
@@ -1011,7 +1014,10 @@ module C #:nodoc:
         ctrlexpr_val = ScalarValue.of_arbitrary
         ctrlexpr = nil
       else
-        ctrlexpr_val = value_of(interpret(orig_ctrlexpr))
+        ctrlexpr_var = object_to_variable(interpret(orig_ctrlexpr))
+        ctrlexpr_val = value_of(ctrlexpr_var)
+        notify_variable_value_referred(orig_ctrlexpr, ctrlexpr_var)
+        notify_sequence_point_reached(SequencePoint.new(orig_ctrlexpr))
         ctrlexpr = orig_ctrlexpr.to_normalized_logical
       end
       notify_if_else_ctrlexpr_evaled(node, ctrlexpr_val)
@@ -1046,7 +1052,10 @@ module C #:nodoc:
 
       widen_varying_variable_value_domain(node)
 
-      ctrlexpr_val = value_of(interpret(node.expression))
+      ctrlexpr_var = object_to_variable(interpret(node.expression))
+      ctrlexpr_val = value_of(ctrlexpr_var)
+      notify_variable_value_referred(node.expression, ctrlexpr_var)
+      notify_sequence_point_reached(SequencePoint.new(node.expression))
       notify_while_ctrlexpr_evaled(node, ctrlexpr_val)
 
       orig_ctrlexpr, ctrlexpr = node.deduct_controlling_expression
@@ -1094,7 +1103,10 @@ module C #:nodoc:
         leave_iteration_statement(orig_ctrlexpr)
       end
 
-      ctrlexpr_val = value_of(interpret(node.expression))
+      ctrlexpr_var = object_to_variable(interpret(node.expression))
+      ctrlexpr_val = value_of(ctrlexpr_var)
+      notify_variable_value_referred(node.expression, ctrlexpr_var)
+      notify_sequence_point_reached(SequencePoint.new(node.expression))
       notify_do_ctrlexpr_evaled(node, ctrlexpr_val)
     ensure
       notify_do_stmt_ended(node)
@@ -1113,7 +1125,10 @@ module C #:nodoc:
 
       node.condition_statement.executed = true
       if explicit_ctrlexpr = node.condition_statement.expression
-        ctrlexpr_val = value_of(interpret(explicit_ctrlexpr))
+        ctrlexpr_var = object_to_variable(interpret(explicit_ctrlexpr))
+        ctrlexpr_val = value_of(ctrlexpr_var)
+        notify_variable_value_referred(explicit_ctrlexpr, ctrlexpr_var)
+        notify_sequence_point_reached(SequencePoint.new(explicit_ctrlexpr))
         notify_for_ctrlexpr_evaled(node, ctrlexpr_val)
       else
         ctrlexpr_val = ScalarValue.of_true
@@ -1143,7 +1158,10 @@ module C #:nodoc:
 
         node.condition_statement.executed = true
         if explicit_ctrlexpr = node.condition_statement.expression
-          ctrlexpr_val = value_of(interpret(explicit_ctrlexpr))
+          ctrlexpr_var = object_to_variable(interpret(explicit_ctrlexpr))
+          ctrlexpr_val = value_of(ctrlexpr_var)
+          notify_variable_value_referred(explicit_ctrlexpr, ctrlexpr_var)
+          notify_sequence_point_reached(SequencePoint.new(explicit_ctrlexpr))
           notify_c99_for_ctrlexpr_evaled(node, ctrlexpr_val)
         else
           ctrlexpr_val = ScalarValue.of_true
@@ -1243,7 +1261,9 @@ module C #:nodoc:
           #        causes "logical-expression must be false" warnings about a
           #        one-time-for-loop.  To avoid this, now, workarounds are in
           #        builtin code checks W0609 and W0610.
-          interpret(explicit_ctrlexpr)
+          var = object_to_variable(interpret(explicit_ctrlexpr))
+          notify_variable_value_referred(explicit_ctrlexpr, var)
+          notify_sequence_point_reached(SequencePoint.new(explicit_ctrlexpr))
         end
       end
     ensure
@@ -1616,12 +1636,15 @@ module C #:nodoc:
       checkpoint(node.location)
 
       ctrlexpr = node.condition
-      ctrlexpr_var = interpret(ctrlexpr, QUIET)
+      ctrlexpr_var = object_to_variable(interpret(ctrlexpr))
       ctrlexpr_val = value_of(ctrlexpr_var)
+      notify_variable_value_referred(ctrlexpr, ctrlexpr_var)
+      notify_sequence_point_reached(ctrlexpr.subsequent_sequence_point)
+      ctrlexpr = ctrlexpr.to_normalized_logical
 
       then_var = nil
       if ctrlexpr_val.may_be_true?
-        branched_eval(ctrlexpr, NARROWING) do
+        branched_eval(ctrlexpr, NARROWING, IMPLICIT_COND) do
           then_var = object_to_variable(interpret(node.then_expression))
         end
       end