adlint 2.6.14 → 3.0.0

data/features/code_check/W1062.feature

@@ -0,0 +1,162 @@
+Feature: W1062
+
+  W1062 detects that a value of the inconsistently typed non-constant
+  expression is assigned to an enum typed variable.
+
+  Scenario: non-constant `int' typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      static enum Color foo(const int i)
+      {
+          enum Color c;
+
+          c = i + 1; /* W1062 */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 4    | 19     |
+      | W0723 | 8    | 11     |
+      | W0727 | 8    | 11     |
+      | W9003 | 8    | 11     |
+      | W1054 | 8    | 7      |
+      | W1062 | 8    | 7      |
+      | W0100 | 6    | 16     |
+      | W0629 | 4    | 19     |
+      | W0628 | 4    | 19     |
+
+  Scenario: non-constant consistent enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      extern enum Color color(void);
+
+      static enum Color foo(void)
+      {
+          enum Color c;
+
+          c = color(); /* OK */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 4    | 19     |
+      | W1076 | 6    | 19     |
+      | W0100 | 8    | 16     |
+      | W0629 | 6    | 19     |
+      | W0628 | 6    | 19     |
+
+  Scenario: non-constant inconsistent enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      extern enum Fruit fruit(void);
+
+      static enum Color foo(void)
+      {
+          enum Color c;
+
+          c = fruit(); /* W1062 */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 4    | 19     |
+      | W1076 | 6    | 19     |
+      | W0727 | 10   | 14     |
+      | W9003 | 10   | 14     |
+      | W1057 | 10   | 7      |
+      | W1062 | 10   | 7      |
+      | W0100 | 8    | 16     |
+      | W0629 | 6    | 19     |
+      | W0628 | 6    | 19     |
+
+  Scenario: constant consistent `int' typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static enum Color foo(void)
+      {
+          enum Color c;
+
+          c = 2; /* OK but W1054 */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 19     |
+      | W9003 | 7    | 9      |
+      | W1054 | 7    | 7      |
+      | W0100 | 5    | 16     |
+      | W0629 | 3    | 19     |
+      | W0628 | 3    | 19     |
+
+  Scenario: constant consistent enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static enum Color foo(void)
+      {
+          enum Color c;
+
+          c = RED + 1; /* OK */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 19     |
+      | W9003 | 7    | 15     |
+      | W0100 | 5    | 16     |
+      | W0629 | 3    | 19     |
+      | W0628 | 3    | 19     |
+
+  Scenario: constant inconsistent enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      static enum Color foo(void)
+      {
+          enum Color c;
+
+          c = ORANGE + 1; /* OK but W0729 */
+
+          return c;
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 4    | 19     |
+      | W9003 | 8    | 18     |
+      | W0727 | 8    | 16     |
+      | W9003 | 8    | 16     |
+      | W0729 | 8    | 7      |
+      | W0100 | 6    | 16     |
+      | W0629 | 4    | 19     |
+      | W0628 | 4    | 19     |

data/features/code_check/W1063.feature

@@ -0,0 +1,123 @@
+Feature: W1063
+
+  W1063 detects that a function of enum return type is returning a value of the
+  inconsistently typed non-constant expression.
+
+  Scenario: returning a value of the non-constant `int' typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static enum Color foo(const enum Color c)
+      {
+          int i = 0;
+
+          if (c == RED) {
+              i = 2;
+          }
+
+          return i + 1; /* W1063 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 19     |
+      | W9003 | 11   | 14     |
+      | W1055 | 11   | 14     |
+      | W1063 | 11   | 14     |
+      | W0629 | 3    | 19     |
+      | W0628 | 3    | 19     |
+
+  Scenario: returning a value of the non-constant `double' typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static enum Color foo(const enum Color c)
+      {
+          double d = .0;
+
+          if (c == RED) {
+              d = .2;
+          }
+
+          return d + 1.0; /* W1063 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 19     |
+      | W9003 | 11   | 14     |
+      | W1055 | 11   | 14     |
+      | W1063 | 11   | 14     |
+      | W0629 | 3    | 19     |
+      | W0628 | 3    | 19     |
+
+  Scenario: returning a value of the non-constant same enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      extern enum Color foo(void);
+
+      static enum Color bar(void)
+      {
+          return foo() + 1; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 3    | 19     |
+      | W1076 | 5    | 19     |
+      | W9003 | 7    | 20     |
+      | W0723 | 7    | 18     |
+      | W0629 | 5    | 19     |
+      | W0628 | 5    | 19     |
+
+  Scenario: returning a value of the non-constant inconsistent enum typed
+            expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      extern enum Fruit foo(void);
+
+      static enum Color bar(void)
+      {
+          return foo() + 1; /* W1063 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 4    | 19     |
+      | W1076 | 6    | 19     |
+      | W9003 | 8    | 20     |
+      | W0723 | 8    | 18     |
+      | W0727 | 8    | 18     |
+      | W9003 | 8    | 18     |
+      | W1058 | 8    | 18     |
+      | W1063 | 8    | 18     |
+      | W0629 | 6    | 19     |
+      | W0628 | 6    | 19     |
+
+  Scenario: returning a value of the constant same enum typed expression
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static enum Color foo(void)
+      {
+          return BLUE; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 19     |
+      | W0629 | 3    | 19     |
+      | W0628 | 3    | 19     |

data/features/code_check/W1064.feature

@@ -0,0 +1,83 @@
+Feature: W1064
+
+  W1064 detects that an integer constant is specified to the case-label in the
+  switch-statement with an enum typed controlling variable.
+
+  Scenario: an integer constant
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static int foo(const enum Color c)
+      {
+          switch (c) {
+          case 0: /* W1064 */
+              return 1;
+          case 1: /* W1064 */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1064 | 6    | 10     |
+      | W1064 | 8    | 10     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: enumerator of the same enum type
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static int foo(const enum Color c)
+      {
+          switch (c) {
+          case RED: /* OK */
+              return 1;
+          case BLUE: /* OK */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: enum typed variable of the same enum type
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static int foo(const enum Color c)
+      {
+          const enum Color col = RED;
+
+          switch (c) {
+          case col: /* OK */
+              return 1;
+          case BLUE: /* OK */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |

data/features/code_check/W1065.feature

@@ -0,0 +1,82 @@
+Feature: W1065
+
+  W1065 detects that an enum type of the case-label's value is different from
+  the enum type of controlling variable.
+
+  Scenario: different enum types
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+      enum Fruit { APPLE, BANANA, ORANGE, GRAPE };
+
+      static int foo(const enum Color c)
+      {
+          switch (c) {
+          case RED: /* OK */
+              return 1;
+          case ORANGE: /* W1065 */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 4    | 12     |
+      | W1065 | 9    | 10     |
+      | W1071 | 4    | 12     |
+      | W0629 | 4    | 12     |
+      | W0628 | 4    | 12     |
+
+  Scenario: same enum types
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static int foo(const enum Color c)
+      {
+          switch (c) {
+          case RED: /* OK */
+              return 1;
+          case GREEN: /* OK */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: enum type and `int'
+    Given a target source named "fixture.c" with:
+      """
+      enum Color { RED, BLUE, GREEN };
+
+      static int foo(const enum Color c)
+      {
+          switch (c) {
+          case RED: /* OK */
+              return 1;
+          case 1: /* OK but W1064 */
+              return 2;
+          default:
+              return 0;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 12     |
+      | W1064 | 8    | 10     |
+      | W1071 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |