adlint 2.4.0 → 2.4.6

data/ChangeLog

@@ -1,3 +1,66 @@
+Tue Oct  9 10:49:00 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.ga : 2.4.6
+	  - Fix bad controlling statement evaluation in order to manage value
+	    domain of the controlling variable correctly.
+	  - Fix bad argument type specification of `%s', `%p' and `%n'
+	    conversion-specifiers of *printf standard functions in order to
+	    detect W0635 correctly.
+
+Fri Oct  5 16:54:09 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.5
+	  - Fix bad argument type specification of `%s', `%p' and `%n'
+	    conversion-specifiers of *printf standard functions in order to
+	    detect W0635 correctly.
+
+Fri Oct  5 15:07:03 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* features/code_check/W0635.feature : Add W0635 specification.
+	* MANIFEST : Ditto.
+
+	* lib/adlint/c/format.rb : Fix bad argument type specification of `%s',
+	  `%p' and `%n' conversion-specifiers of *printf standard functions in
+	  order to detect W0635 correctly.
+
+Fri Oct  5 15:01:55 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* spec/adlint/c/type_spec.rb : Add `==' and `convertible?' unit
+	  specifications of QualifiedType.
+
+	* lib/adlint/c/type.rb : Fix bad type convertibility check of
+	  cv-qualified types.
+
+Fri Oct  5 11:11:56 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.3
+	  - Fix abend problem of iteration-statement evaluation.
+
+Fri Oct  5 11:02:33 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/interp.rb : Fix abend problem of iteration-statement
+	  evaluation.
+	* lib/adlint/c/branch.rb : Ditto.
+	* lib/adlint/c/option.rb : Ditto.
+
+Thu Oct  4 18:11:13 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 2.4.1
+	  - Fix bad controlling statement evaluation in order to manage value
+	    domain of the controlling variable correctly.
+
+Thu Oct  4 17:56:03 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/syntax.rb : Add expression transformation in order to
+	  correctly deduct controlling expression of an iteration-statement.
+	* lib/adlint/c/operator.rb : Ditto.
+
+	* lib/adlint/c/object.rb : Remove FrozenValue value wrapper.
+	* lib/adlint/c/ctrlexpr.rb : Ditto.
+
+	* lib/adlint/c/interp.rb : Fix bad controlling statement evaluation to
+	  manage value domain of the controlling variable correctly.
+
 Fri Sep 21 15:00:34 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
 
 	* release.ga : 2.4.0

data/MANIFEST

@@ -197,6 +197,7 @@ features/code_check/W0483.feature
 features/code_check/W0573.feature
 features/code_check/W0583.feature
 features/code_check/W0606.feature
+features/code_check/W0635.feature
 features/code_check/W0641.feature
 features/code_check/W0643.feature
 features/code_check/W0644.feature

data/NEWS

@@ -21,6 +21,18 @@
 
 ++
 
+=== \AdLint 2.4.6 is released (2012-10-09)
+
+* Fix bad controlling statement evaluation in order to manage value domain of
+  the controlling variable correctly
+* Fix bad argument type specification of `%s', `%p' and `%n'
+  conversion-specifiers of *printf standard functions in order to detect W0635
+  correctly
+
+See the file
+{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
+for more details.
+
 === \AdLint 2.4.0 is released (2012-09-21)
 
 ==== Changes since the 2.2.0 release
@@ -44,10 +56,6 @@
 * Fix #include directive evaluation in order to correctly read header file with
   an absolute path when any include_path items are not specified
 
-See the file
-{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
-for more details.
-
 === \AdLint 2.2.0 is released (2012-09-12)
 
 ==== Changes since the 2.0.10 release

data/etc/mesg.d/c_builtin/en_US/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.0"
+version: "2.4.6"
 
 message_definition:
   W0001:

data/etc/mesg.d/c_builtin/ja_JP/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.0"
+version: "2.4.6"
 
 message_definition:
   W0001:

data/etc/mesg.d/core/en_US/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.0"
+version: "2.4.6"
 
 message_definition:
   X0001:

data/etc/mesg.d/core/ja_JP/messages.yml

@@ -49,7 +49,7 @@
 #         - "ERR:X99"
 #       format: "Your custom message for the error of E9999."
 
-version: "2.4.0"
+version: "2.4.6"
 
 message_definition:
   X0001:

data/features/code_check/W0635.feature

@@ -0,0 +1,57 @@
+Feature: W0635
+
+  W0635 detects that the argument type is not suitable for the corresponding
+  conversion-specifier.
+
+  Scenario: `%s' conversion-specifiers with various arguments
+    Given a target source named "fixture.c" with:
+      """
+      #include <stdio.h>
+
+      int main(void)
+      {
+          const char * const foo = "foo";
+          const unsigned char * const bar = "bar";
+          signed char *baz = "baz";
+          char * const qux = "qux";
+
+          return printf("%s %s %s %s", foo, bar, baz, qux); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W9003 | 7    | 24     |
+      | W0100 | 7    | 18     |
+      | W0947 | 5    | 30     |
+      | W0947 | 6    | 39     |
+      | W0947 | 7    | 24     |
+      | W0947 | 8    | 24     |
+      | W0947 | 10   | 19     |
+
+
+  Scenario: `%s' conversion-specifiers with bad arguments
+    Given a target source named "fixture.c" with:
+      """
+      #include <stdio.h>
+
+      int main(void)
+      {
+          int foo = 0;
+          const int bar = 0;
+          const int * const baz = 0;
+
+          return printf("%s %s %s", foo, bar, baz); /* W0635 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W9003 | 7    | 29     |
+      | W0635 | 9    | 19     |
+      | W0635 | 9    | 19     |
+      | W0635 | 9    | 19     |
+      | W0100 | 5    | 9      |
+      | W0947 | 9    | 19     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0644.feature

@@ -389,6 +389,7 @@ Feature: W0644
       | W0118 | 1    | 13     |
       | W0117 | 3    | 5      |
       | W0644 | 5    | 11     |
+      | W0035 | 5    | 11     |
       | W0644 | 9    | 14     |
       | W0035 | 9    | 14     |
       | W0104 | 3    | 13     |
@@ -420,6 +421,7 @@ Feature: W0644
       | W0118 | 1    | 13     |
       | W0117 | 3    | 5      |
       | W0644 | 5    | 15     |
+      | W0035 | 5    | 15     |
       | W0644 | 9    | 18     |
       | W0035 | 9    | 18     |
       | W1071 | 3    | 5      |
@@ -449,6 +451,7 @@ Feature: W0644
       | W0118 | 1    | 13     |
       | W0117 | 3    | 5      |
       | W0644 | 5    | 11     |
+      | W0035 | 5    | 11     |
       | W0644 | 9    | 14     |
       | W0035 | 9    | 14     |
       | W0104 | 3    | 13     |
@@ -480,6 +483,7 @@ Feature: W0644
       | W0118 | 1    | 13     |
       | W0117 | 3    | 5      |
       | W0644 | 5    | 15     |
+      | W0035 | 5    | 15     |
       | W0644 | 9    | 18     |
       | W0035 | 9    | 18     |
       | W1071 | 3    | 5      |

data/features/code_check/W1071.feature

@@ -53,8 +53,8 @@ Feature: W1071
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0117 | 1    | 6      |
-      | W0613 | 3    | 12     |
       | W0610 | 3    | 12     |
+      | W0613 | 3    | 12     |
       | W0104 | 1    | 23     |
       | W9001 | 4    | 9      |
       | W0628 | 1    | 6      |

data/features/code_check/W1074.feature

@@ -22,9 +22,9 @@ Feature: W1074
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
-      | W0612 | 5    | 21     |
       | W0168 | 5    | 24     |
       | W0609 | 5    | 21     |
+      | W0612 | 5    | 21     |
       | W0629 | 1    | 12     |
       | W1074 | 5    | 15     |
       | W9001 | 9    | 9      |
@@ -49,10 +49,10 @@ Feature: W1074
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
-      | W0613 | 5    | 33     |
       | W0168 | 5    | 16     |
       | W0168 | 5    | 36     |
       | W0610 | 5    | 33     |
+      | W0613 | 5    | 33     |
       | W0629 | 1    | 12     |
       | W1074 | 5    | 26     |
       | W9001 | 6    | 9      |
@@ -77,9 +77,9 @@ Feature: W1074
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
-      | W0612 | 5    | 20     |
       | W0168 | 5    | 23     |
       | W0609 | 5    | 20     |
+      | W0612 | 5    | 20     |
       | W0629 | 1    | 12     |
       | W1074 | 5    | 17     |
       | W9001 | 9    | 9      |
@@ -105,9 +105,9 @@ Feature: W1074
       | mesg  | line | column |
       | W0118 | 1    | 12     |
       | W1076 | 3    | 12     |
-      | W0612 | 5    | 23     |
       | W0168 | 5    | 26     |
       | W0609 | 5    | 23     |
+      | W0612 | 5    | 23     |
       | W1073 | 5    | 19     |
       | W0629 | 3    | 12     |
       | W1074 | 5    | 15     |
@@ -135,9 +135,9 @@ Feature: W1074
       | W0118 | 1    | 12     |
       | W1077 | 1    | 12     |
       | W1076 | 3    | 12     |
-      | W0612 | 5    | 22     |
       | W0168 | 5    | 25     |
       | W0609 | 5    | 22     |
+      | W0612 | 5    | 22     |
       | W0629 | 3    | 12     |
       | W9001 | 9    | 9      |
       | W0628 | 3    | 12     |

data/lib/adlint/c/branch.rb

@@ -75,7 +75,7 @@ module C #:nodoc:
     end
 
     def implicit_condition?
-      @options.include?(IMPLICIT_CONDITION)
+      @options.include?(IMPLICIT_COND)
     end
 
     def execute(interpreter, expression = nil, &block)

data/lib/adlint/c/builtin.rb

@@ -74,7 +74,7 @@ module C #:nodoc:
     def call(interpreter, funcall_expr, args)
       puts "__adlint__eval"
       char_array = interpreter.pointee_of(args.first.first)
-      if char_array.type.array?
+      if char_array && char_array.type.array?
         without_nil = char_array.value.to_single_value.values[0..-2]
         program_text = without_nil.map { |char| char.unique_sample.chr }.join
         if program_text.empty?

data/lib/adlint/c/ctrlexpr.rb

@@ -47,6 +47,8 @@ module C #:nodoc:
   #  +-> ValueDomainManipulator
   #      | <-- ValueDomainNarrower
   #      | <-- ValueDomainWidener
+  #      | <-- WithoutExpressionValueDomainNarrower
+  #      | <-- WithoutExpressionValueDomainWidener
   #      |
   #      +-> ValueDomainNarrowing
   #            <-- ValueComparison
@@ -973,8 +975,8 @@ module C #:nodoc:
       super(named_variable)
 
       @base_variable = named_variable
-      @phantom_value = phantom_value ?
-        phantom_value : named_variable.memory.read_modifiable.dup
+      @phantom_value =
+        phantom_value ? phantom_value : named_variable.memory.read.dup
     end
 
     def value

data/lib/adlint/c/format.rb

@@ -1371,9 +1371,10 @@ module C #:nodoc:
         #        or G conversion specifier.
         case length_modifier
         when "l"
-          [pointer_type(wchar_type)]
+          [pointer_type(qualified_type(wchar_type, :const))]
         else
-          [pointer_type(signed_char_type), pointer_type(unsigned_char_type)]
+          [pointer_type(qualified_type(signed_char_type, :const)),
+            pointer_type(qualified_type(unsigned_char_type, :const))]
         end
       end
 
@@ -1410,7 +1411,7 @@ module C #:nodoc:
         if conversion_argument && conversion_argument.type.pointer?
           [conversion_argument.type.unqualify]
         else
-          [pointer_type(void_type)]
+          [pointer_type(qualified_type(void_type, :const))]
         end
       end
 
@@ -1502,24 +1503,24 @@ module C #:nodoc:
         #        specifier applies to a pointer to a ptrdiff_t argument.
         case length_modifier
         when "hh"
-          [pointer_type(signed_char_type)]
+          [pointer_type(qualified_type(signed_char_type, :const))]
         when "h"
-          [pointer_type(signed_short_type)]
+          [pointer_type(qualified_type(signed_short_type, :const))]
         when "l"
-          [pointer_type(signed_long_type)]
+          [pointer_type(qualified_type(signed_long_type, :const))]
         when "ll"
-          [pointer_type(signed_long_long_type)]
+          [pointer_type(qualified_type(signed_long_long_type, :const))]
         when "j"
           # FIXME: `intmax_t' is not supported yet.
-          [pointer_type(signed_long_long_type)]
+          [pointer_type(qualified_type(signed_long_long_type, :const))]
         when "z"
           # FIXME: `size_t' is not supported yet.
-          [pointer_type(signed_long_type)]
+          [pointer_type(qualified_type(signed_long_type, :const))]
         when "t"
           # FIXME: `ptrdiff_t' is not supported yet.
-          [pointer_type(signed_int_type)]
+          [pointer_type(qualified_type(signed_int_type, :const))]
         else
-          [pointer_type(signed_int_type)]
+          [pointer_type(qualified_type(signed_int_type, :const))]
         end
       end