adlint 1.8.10 → 1.10.0

data/features/message_detection/W0703.feature

@@ -0,0 +1,73 @@
+Feature: W0703
+
+  W0703 detects that a tag name is hiding other tag names.
+
+  Scenario: tag hiding declaration in function-definition
+    Given a target source named "W0703.c" with:
+      """
+      struct Foo {
+          int i;
+      };
+
+      int main(void)
+      {
+          union Foo { /* W0703 */
+              int i;
+              int j;
+          } foo = { 0 };
+
+          return foo.i;
+      }
+      """
+    When I successfully run `adlint W0703.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0703 | 7    | 11     |
+      | W0785 | 7    | 11     |
+      | W0552 | 10   | 7      |
+      | W0100 | 10   | 7      |
+      | W0551 | 7    | 11     |
+
+  Scenario: tag hiding declaration in the global scope
+    Given a target source named "W0703.c" with:
+      """
+      struct Foo {
+          int i;
+      };
+
+      static union Foo { /* W0703 */
+          int i;
+          int j;
+      } foo = { 0 };
+      """
+    When I successfully run `adlint W0703.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0703 | 5    | 14     |
+      | W0785 | 5    | 14     |
+      | W0552 | 8    | 3      |
+      | W0551 | 5    | 14     |
+
+  Scenario: enum declaration in global and function scope
+    Given a target source named "W0703.c" with:
+      """
+      enum E { FOO, BAR };
+
+      int main(void)
+      {
+          enum E { BAR, BAZ } e = FOO; /* W0703 */
+          return e;
+      }
+      """
+    When I successfully run `adlint W0703.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0703 | 5    | 10     |
+      | W0704 | 5    | 14     |
+      | W0785 | 5    | 10     |
+      | W0789 | 5    | 14     |
+      | W1060 | 6    | 12     |
+      | W0100 | 5    | 25     |
+      | W0425 | 5    | 25     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0716.feature

@@ -0,0 +1,67 @@
+Feature: W0716
+
+  W0716 detects that operands of both sides of bitwise expression or arithmetic
+  expression are `effectively boolean'.
+
+  Scenario: an arithmetic expression
+    Given a target source named "W0716.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a > b) + (c > d); /* W0716 */
+      }
+      """
+    When I successfully run `adlint W0716.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0723 | 3    | 20     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0716 | 3    | 20     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a bitwise expression
+    Given a target source named "W0716.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a > b) ^ (c > d); /* W0716 */
+      }
+      """
+    When I successfully run `adlint W0716.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0716 | 3    | 20     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a shift expression
+    Given a target source named "W0716.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a > b) << (c > d); /* W0716 */
+      }
+      """
+    When I successfully run `adlint W0716.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0570 | 3    | 20     |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0716 | 3    | 20     |
+      | W0628 | 1    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0717.feature

@@ -0,0 +1,64 @@
+Feature: W0717
+
+  W0717 detects that operand of left side of bitwise expression or arithmetic
+  expression is `effectively boolean'.
+
+  Scenario: an arithmetic expression
+    Given a target source named "W0717.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return (a > b) + c; /* W0717 */
+      }
+      """
+    When I successfully run `adlint W0717.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0723 | 3    | 20     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0717 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a bitwise expression
+    Given a target source named "W0717.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return (a > b) ^ c; /* W0717 */
+      }
+      """
+    When I successfully run `adlint W0717.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0717 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a shift expression
+    Given a target source named "W0717.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return (a > b) << c; /* W0717 */
+      }
+      """
+    When I successfully run `adlint W0717.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0570 | 3    | 20     |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0717 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0718.feature

@@ -0,0 +1,64 @@
+Feature: W0718
+
+  W0718 detects that operand of right side of bitwise expression or arithmetic
+  expression is `effectively boolean'.
+
+  Scenario: an arithmetic expression
+    Given a target source named "W0718.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return a + (b > c); /* W0718 */
+      }
+      """
+    When I successfully run `adlint W0718.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0723 | 3    | 14     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0718 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a bitwise expression
+    Given a target source named "W0718.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return a ^ (b > c); /* W0718 */
+      }
+      """
+    When I successfully run `adlint W0718.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0572 | 3    | 14     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0718 | 3    | 16     |
+      | W0628 | 1    | 12     |
+
+  Scenario: a shift expression
+    Given a target source named "W0718.c" with:
+      """
+      static int func(int a, int b, int c)
+      {
+          return a << (b > c); /* W0718 */
+      }
+      """
+    When I successfully run `adlint W0718.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0570 | 3    | 14     |
+      | W0572 | 3    | 14     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W0104 | 1    | 35     |
+      | W0629 | 1    | 12     |
+      | W0718 | 3    | 17     |
+      | W0628 | 1    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0723.feature

@@ -0,0 +1,18 @@
+Feature: W0723
+
+  W0723 detects that an arithmetic operation of signed values may be overflow.
+
+  Scenario: an arithmetic operation in initializer of a global variable
+    Given a target source named "W0723.c" with:
+      """
+      static int i = 5;
+      static unsigned int j = (unsigned int) &i + 1; /* OK */
+      """
+    When I successfully run `adlint W0723.c` on noarch
+    Then the output should not match with /2:.*:W0723/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0567 | 2    | 25     |
+      | W0167 | 2    | 45     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1031.feature

@@ -0,0 +1,328 @@
+Feature: W1031
+
+  W1031 detects that two or more object declarations have inconsistent
+  storage-class-specifiers.
+
+  Scenario: function declaration with `static' and function definition without
+            storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      static int foo(long);
+
+      int foo(long l) { /* OK */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0104 | 3    | 14     |
+      | W0629 | 3    | 5      |
+      | W0628 | 3    | 5      |
+
+  Scenario: function declaration with `extern' and function definition without
+            storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      extern int foo(long);
+
+      int foo(long l) { /* OK */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 5      |
+
+  Scenario: function declaration without storage-class-specifier and function
+            definition without storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long);
+
+      int foo(long l) { /* OK */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 5      |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 5      |
+
+  Scenario: function declaration without storage-class-specifier and function
+            definition with `static'.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long);
+
+      static int foo(long l) { /* W1031 */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 5      |
+      | W1031 | 3    | 12     |
+      | W0104 | 3    | 21     |
+      | W0628 | 3    | 12     |
+
+  Scenario: function declaration without storage-class-specifier and function
+            definition with `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long);
+
+      extern int foo(long l) { /* OK */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 5      |
+      | W0104 | 3    | 21     |
+      | W0628 | 3    | 12     |
+
+  Scenario: function declaration with `static' and function definition with
+            `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      static int foo(long);
+
+      extern int foo(long l) { /* W1031 */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W1031 | 3    | 12     |
+      | W0104 | 3    | 21     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: function declaration with `extern' and function definition with
+            `static'.
+    Given a target source named "W1031.c" with:
+      """
+      extern int foo(long);
+
+      static int foo(long l) { /* W1031 */
+          return (int) l;
+      }
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /3:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1031 | 3    | 12     |
+      | W0104 | 3    | 21     |
+      | W0628 | 3    | 12     |
+
+  Scenario: variable declaration with `extern' and variable definition without
+            storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      extern int i;
+      int i = 0; /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /2:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+
+  Scenario: variable definition without storage-class-specifier and variable
+            declaration with `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      int i;
+      extern int i; /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /2:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0118 | 2    | 12     |
+
+  Scenario: function declaration with `static' and function definition with
+            `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      static int i;
+      extern int i = 0; /* W1031 */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /2:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W1031 | 2    | 12     |
+
+  Scenario: variable declaration with `extern' and variable definition with
+            `static'.
+    Given a target source named "W1031.c" with:
+      """
+      extern int i;
+      static int i = 0; /* W1031 */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /2:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1031 | 2    | 12     |
+
+  Scenario: function definition with `static' and function declaration without
+            storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      static int foo(long l) {
+          return (int) l;
+      }
+
+      int foo(long); /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0104 | 1    | 21     |
+      | W0629 | 1    | 12     |
+      | W0543 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: function definition with `extern' and function declaration without
+            storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      extern int foo(long l) {
+          return (int) l;
+      }
+
+      int foo(long); /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 12     |
+      | W0104 | 1    | 21     |
+      | W0118 | 5    | 5      |
+      | W0543 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: function definition without storage-class-specifier and function
+            declaration without storage-class-specifier.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long l) {
+          return (int) l;
+      }
+
+      int foo(long); /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0104 | 1    | 14     |
+      | W0118 | 5    | 5      |
+      | W0543 | 1    | 5      |
+      | W0628 | 1    | 5      |
+
+  Scenario: function definition without storage-class-specifier and function
+            declaration with `static'.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long l) {
+          return (int) l;
+      }
+
+      static int foo(long); /* W1031 */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0104 | 1    | 14     |
+      | W0118 | 5    | 12     |
+      | W1031 | 5    | 12     |
+      | W0543 | 1    | 5      |
+      | W0628 | 1    | 5      |
+
+  Scenario: function definition without storage-class-specifier and function
+            declaration with `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      int foo(long l) {
+          return (int) l;
+      }
+
+      extern int foo(long); /* OK */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should not match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0104 | 1    | 14     |
+      | W0118 | 5    | 12     |
+      | W0543 | 1    | 5      |
+      | W0628 | 1    | 5      |
+
+  Scenario: function definition with `static' and function declaration with
+            `extern'.
+    Given a target source named "W1031.c" with:
+      """
+      static int foo(long l) {
+          return (int) l;
+      }
+
+      extern int foo(long l); /* W1031 */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0104 | 1    | 21     |
+      | W1031 | 5    | 12     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: function definition with `extern' and function declaration with
+            `static'.
+    Given a target source named "W1031.c" with:
+      """
+      extern int foo(long l) {
+          return (int) l;
+      }
+
+      static int foo(long); /* W1031 */
+      """
+    When I successfully run `adlint W1031.c` on noarch
+    Then the output should match with /5:.*:W1031/
+    And the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 12     |
+      | W0104 | 1    | 21     |
+      | W0118 | 5    | 12     |
+      | W1031 | 5    | 12     |
+      | W0543 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/step_definitions/message_detection_steps.rb

@@ -0,0 +1,45 @@
+Given /^a target source named "(.*)" with:$/ do |src_name, content|
+  write_file(src_name, content + "\n")
+end
+
+Given /^expected messages of "(.*)" are:$/ do |src_name, mesg_table|
+  write_file("#{src_name}.expected", mesg_table.hashes.map { |row|
+    "#{row[:mesg]} #{row[:line]} #{row[:column]}" }.join("\n"))
+end
+
+When /^I successfully run `(.*)` on noarch$/ do |abbrev_cmd|
+  write_file("noarch_traits.yml", NOARCH_TRAITS)
+  write_file("empty_pinit.h", "\n")
+  write_file("empty_cinit.h", "\n")
+  run_simple(unescape(abbrev_cmd + " -t noarch_traits.yml"))
+end
+
+Then /^the output should match with \/(.*)\/$/ do |pattern|
+  all_output.should =~ /#{pattern}/
+end
+
+Then /^the output should not match with \/(.*)\/$/ do |pattern|
+  all_output.should_not =~ /#{pattern}/
+end
+
+Then /^the output should match with expected messages of "(.*)"$/ do |src_name|
+  prep_for_fs_check do
+    expected = File.read("#{src_name}.expected").each_line.map { |line|
+      fields = line.chomp.split(" ")
+      /#{fields[1]}:#{fields[2]}:.*:#{fields[0]}/
+    }
+    all_output.each_line.zip(expected).each do |line, pattern|
+      line.should =~ pattern
+    end
+  end
+end
+
+Then /^the output should exactly match with:$/ do |mesg_table|
+  all_output.each_line.zip(mesg_table.hashes).each do |line, row|
+    if row
+      line.should =~ /#{row[:line]}:#{row[:column]}:.*:#{row[:mesg]}/
+    else
+      line.should =~ /::.*:/
+    end
+  end
+end