adlint 1.4.0 → 1.6.0

data/lib/adlint/c/phase.rb

@@ -551,7 +551,9 @@ module C #:nodoc:
         W0570.new(context),
         W0571.new(context),
         W0572.new(context),
+        W0573.new(context),
         W0578.new(context),
+        W0579.new(context),
         W0580.new(context),
         W0581.new(context),
         W0582.new(context),
@@ -614,6 +616,8 @@ module C #:nodoc:
         W0682.new(context),
         W0683.new(context),
         W0684.new(context),
+        W0685.new(context),
+        W0686.new(context),
         W0698.new(context),
         W0699.new(context),
         W0703.new(context),
@@ -670,8 +674,12 @@ module C #:nodoc:
         W0777.new(context),
         W0778.new(context),
         W0779.new(context),
+        W0781.new(context),
         W0785.new(context),
         W0786.new(context),
+        W0787.new(context),
+        W0788.new(context),
+        W0789.new(context),
         W0790.new(context),
         W0795.new(context),
         W0796.new(context),
@@ -680,6 +688,7 @@ module C #:nodoc:
         W0799.new(context),
         W0800.new(context),
         W0801.new(context),
+        W0809.new(context),
         W0810.new(context),
         W0827.new(context),
         W0828.new(context),
@@ -690,6 +699,7 @@ module C #:nodoc:
         W1027.new(context),
         W1028.new(context),
         W1029.new(context),
+        W1030.new(context),
         W1031.new(context),
         W1032.new(context),
         W1033.new(context),
@@ -698,6 +708,17 @@ module C #:nodoc:
         W1050.new(context),
         W1051.new(context),
         W1052.new(context),
+        W1053.new(context),
+        W1054.new(context),
+        W1055.new(context),
+        W1056.new(context),
+        W1057.new(context),
+        W1058.new(context),
+        W1059.new(context),
+        W1060.new(context),
+        W1061.new(context),
+        W1062.new(context),
+        W1063.new(context),
         W1064.new(context),
         W1065.new(context),
         W9001.new(context)

data/lib/adlint/c/syntax.rb

@@ -31,6 +31,7 @@
 
 require "adlint/symbol"
 require "adlint/util"
+require "adlint/c/enum"
 require "adlint/c/seqp"
 
 module AdLint #:nodoc:
@@ -411,10 +412,16 @@ module C #:nodoc:
       subclass_responsibility
     end
 
-    def constant?
-      visitor = ObjectSpecifierCollector.new
-      accept(visitor)
-      visitor.object_specifiers.empty?
+    def constant?(enumerator_table)
+      object_specifiers.all? { |object_specifier|
+        enumerator_table.lookup(object_specifier.identifier.value)
+      }
+    end
+
+    def object_specifiers
+      ObjectSpecifierCollector.new.tap { |collector|
+        self.accept(collector)
+      }.object_specifiers
     end
 
     def to_s

data/lib/adlint/c/type.rb

@@ -7558,7 +7558,7 @@ module C #:nodoc:
         end
         size ||= 0
       else
-        if size_expression.constant?
+        if size_expression.object_specifiers.empty?
           object = Interpreter.new(@type_table).execute(size_expression)
           if object.variable? && object.value.scalar?
             size = object.value.unique_sample

data/lib/adlint/cpp.rb

@@ -29,6 +29,7 @@
 #
 #++
 
+require "adlint/cpp/asm"
 require "adlint/cpp/code"
 require "adlint/cpp/eval"
 require "adlint/cpp/constexpr"

data/lib/adlint/cpp/asm.rb

@@ -0,0 +1,73 @@
+# Inline assembly notations.
+#
+# Author::    Yutaka Yanoh <mailto:yanoh@users.sourceforge.net>
+# Copyright:: Copyright (C) 2010-2012, OGIS-RI Co.,Ltd.
+# License::   GPLv3+: GNU General Public License version 3 or later
+#
+# Owner::     Yutaka Yanoh <mailto:yanoh@users.sourceforge.net>
+
+#--
+#     ___    ____  __    ___   _________
+#    /   |  / _  |/ /   / / | / /__  __/           Source Code Static Analyzer
+#   / /| | / / / / /   / /  |/ /  / /                   AdLint - Advanced Lint
+#  / __  |/ /_/ / /___/ / /|  /  / /
+# /_/  |_|_____/_____/_/_/ |_/  /_/   Copyright (C) 2010-2012, OGIS-RI Co.,Ltd.
+#
+# This file is part of AdLint.
+#
+# AdLint is free software: you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation, either version 3 of the License, or (at your option) any later
+# version.
+#
+# AdLint is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# AdLint.  If not, see <http://www.gnu.org/licenses/>.
+#
+#++
+
+require "adlint/cpp/subst"
+
+module AdLint #:nodoc:
+module Cpp #:nodoc:
+
+  module InlineAssemblyDefinition
+    def create_inline_assembly_substitutions(source)
+      [create_cxx_asm_definition(source)] +
+        create_extended_asm_definitions(source)
+    end
+
+    def create_cxx_asm_definition(source)
+      CodeSubstitution.new("asm(__adlint__any);", "").tap do |subst|
+        subst.on_substitution += lambda { |location, matched|
+          source.on_inline_assembly.invoke(location, matched)
+        }
+      end
+    end
+
+    def create_extended_asm_definitions(source)
+      [
+        "__asm(__adlint__any);",
+        "asm { __adlint__any }",
+        "__asm { __adlint__any }",
+        "__asm__(__adlint__any);",
+        "__asm__ volatile (__adlint__any);",
+        "__asm__ __volatile__ (__adlint__any);",
+        "asm(__adlint__any);",
+        "asm volatile (__adlint__any);",
+        "asm __volatile__ (__adlint__any);"
+      ].map do |pattern|
+        CodeSubstitution.new(pattern, "").tap { |subst|
+          subst.on_substitution += lambda { |location, matched|
+            source.on_inline_assembly.invoke(location, matched)
+          }
+        }
+      end
+    end
+  end
+
+end
+end

data/lib/adlint/cpp/message.rb

@@ -771,6 +771,19 @@ module Cpp #:nodoc:
     end
   end
 
+  class W0541 < PassiveMessageDetection
+    # NOTE: W0541 may be duplicative when the same header which has the token
+    #       sequence of the compiler specific extension is included twice or
+    #       more.
+    ensure_uniqueness_of :W0541
+
+    def initialize(context)
+      super
+      context[:c_source].on_inline_assembly +=
+        lambda { |location, matched| W(:W0541, location) }
+    end
+  end
+
   class W0549 < PassiveMessageDetection
     # NOTE: W0549 may be duplicative when the same header which causes this
     #       warning is included twice or more.

data/lib/adlint/cpp/message_shima.rb

@@ -147,5 +147,41 @@ module Cpp #:nodoc:
     end
   end
 
+  class W0807 < W0687
+    # NOTE: W0807 may be duplicative when the same header which causes this
+    #       warning is included twice or more.
+    ensure_uniqueness_of :W0807
+
+    private
+    def check(undef_line, macro)
+      if macro.kind_of?(SpecialMacro)
+        identifier = undef_line.identifier
+        W(:W0807, identifier.location, identifier.value)
+      end
+    end
+  end
+
+  class W0808 < PassiveMessageDetection
+    # NOTE: W0808 may be duplicative when the same header which causes this
+    #       warning is included twice or more.
+    ensure_uniqueness_of :W0808
+
+    def initialize(context)
+      super
+      interp = context[:cpp_interpreter]
+      interp.on_object_like_macro_defined += method(:check)
+      @macro_table = context[:cpp_macro_table]
+    end
+
+    private
+    def check(define_line, macro)
+      identifier = define_line.identifier
+
+      if @macro_table.lookup(identifier.value)
+        W(:W0808, identifier.location, identifier.value)
+      end
+    end
+  end
+
 end
 end

data/lib/adlint/cpp/phase.rb

@@ -94,6 +94,7 @@ module Cpp #:nodoc:
         W0483.new(context),
         W0511.new(context),
         W0528.new(context),
+        W0541.new(context),
         W0549.new(context),
         W0554.new(context),
         W0574.new(context),
@@ -108,6 +109,8 @@ module Cpp #:nodoc:
         W0696.new(context),
         W0804.new(context),
         W0806.new(context),
+        W0807.new(context),
+        W0808.new(context),
         W0831.new(context),
         W9002.new(context)
       ]

data/lib/adlint/cpp/source.rb

@@ -31,12 +31,15 @@
 
 require "adlint/token"
 require "adlint/util"
+require "adlint/cpp/asm"
 require "adlint/cpp/subst"
 
 module AdLint #:nodoc:
 module Cpp #:nodoc:
 
   class PreprocessedSource
+    include InlineAssemblyDefinition
+
     def initialize(root_fpath)
       @root_fpath = root_fpath
       @tokens = []
@@ -45,6 +48,7 @@ module Cpp #:nodoc:
     extend Pluggable
 
     def_plugin :on_language_extension
+    def_plugin :on_inline_assembly
 
     attr_reader :root_fpath
 
@@ -68,6 +72,11 @@ module Cpp #:nodoc:
         substitution = create_arbitrary_substitution(pattern, replacement)
         @tokens = substitution.execute(@tokens)
       end
+
+      create_inline_assembly_substitutions(self).each do |substitution|
+        @tokens = substitution.execute(@tokens)
+      end
+
       self
     end
 

data/lib/adlint/version.rb

@@ -32,9 +32,9 @@
 module AdLint #:nodoc:
 
   MAJOR_VERSION = 1
-  MINOR_VERSION = 4
+  MINOR_VERSION = 6
   PATCH_VERSION = 0
-  RELEASE_DATE  = "2012-03-29"
+  RELEASE_DATE  = "2012-04-06"
 
   TRAITS_SCHEMA_VERSION = "1.0.0"
 
@@ -64,7 +64,7 @@ module AdLint #:nodoc:
 EOS
 
   AUTHOR = <<EOS
-Written by Yutaka Yanoh, Rie Shima and Code Quality Assessment Team of OGIS-RI Co.,Ltd.
+Written by Yutaka Yanoh, Rie Shima and OGIS-RI Co.,Ltd.
 
 EOS
 

data/share/demo/Makefile

@@ -11,6 +11,7 @@ bad_conv \
 bad_enum \
 bad_indent \
 bad_init \
+bad_label \
 bad_line \
 bad_macro \
 bad_return \
@@ -32,6 +33,7 @@ implicit_conv \
 implicit_int \
 incomplete_type \
 indirect_recur \
+inline_asm \
 intro_demo \
 invalid_call \
 kandr_fundef \
@@ -60,6 +62,8 @@ octal_const \
 output_by_param \
 overflow \
 press_release \
+redundant_select \
+reserved_ident \
 retn_lvar_addr \
 sequence_point \
 shift_expr \

data/share/demo/bad_conv/bad_conv.c

@@ -44,5 +44,17 @@ int main(void)
     scanf("%3llc %fc\n", &i, &ii);
     scanf("%3llz %c\n", &i, &ii);
 
+    scanf("%[z-a]\n", &i);
+    scanf("%[abcd]\n", &i);
+    scanf("%[abca]\n", &i);
+
     return 0;
 }
+
+static void foo(void)
+{
+    char buf[256];
+
+    printf("%s", buf);
+    scanf("%s", buf);
+}

data/share/demo/bad_enum/bad_enum.c

@@ -3,24 +3,70 @@ enum Bar { BAR_A = 1, BAR_B, BAR_C };
 enum Baz { BAZ_A = 2, BAZ_B = 4, BAZ_C = 8 };
 
 extern void func1(enum Foo f);
+int func3(int i)
+{
+    const enum Foo foo = FOO_A;
+
+    foo1(i);
+    foo = i;
+    foo = FOO_A + i;
+
+    switch (i) {
+    case FOO_A:
+        return foo;
+    case FOO_B:
+        return FOO_B;
+    case FOO_C:
+        return i;
+    default:
+        return (int) BAR_A;
+    }
+}
 
-enum Foo func2(const enum Foo param)
+enum Foo func2(const enum Foo param, const int i)
 {
     enum Foo foo = BAR_A;
+    enum Bar bar = BAZ_A;
+    enum Baz baz = FOO_A;
+
     foo = FOO_A;
+    bar = BAR_A;
+    baz = BAZ_A;
+
+    func3(foo);
+    func3(BAR_A);
+    func3((int) BAZ_C);
 
     switch (param) {
     case FOO_A:
         foo = BAR_A;
         func1(BAR_A);
+        func1(1);
+        func1(baz);
+        foo = 1;
+        foo = bar;
         return BAR_B;
     case BAR_B:
     case 5:
         foo = BAZ_C;
         func1(BAZ_C);
+        func1(0x2);
+        baz = BAZ_C;
+        func1(baz);
+        foo = 0x2;
+        foo = baz;
         return BAZ_C;
     case 6:
-        return 10;
+        return FOO_A + 10;
+    case 7:
+        return FOO_A + i;
+    case 8:
+        return bar;
+    case 9:
+        baz = BAZ_C;
+        return baz;
+    case 10:
+        return i;
     }
 
     return FOO_C;

data/share/demo/bad_label/bad_label.c

@@ -0,0 +1,26 @@
+int foo(const int i)
+{
+    if (i == 0) {
+label:
+        return 0;
+    }
+
+    if (i < 0) {
+        goto label;
+    }
+
+label:
+    return 1;
+}
+
+int bar(const int i)
+{
+    if (i == 0) {
+        goto label;
+    }
+
+    i = 0;
+
+label:
+    return i;
+}