adiwg-mdtranslator 2.9.2 → 2.10.0

data/lib/adiwg/mdtranslator/readers/fgdc/modules/mapProjections/projection_stereographic.rb

@@ -37,8 +37,7 @@ module ADIWG
                      if paramCount == 4
                         return hProjection
                      else
-                        hResponseObj[:readerExecutionMessages] << 'stereographic projection is missing one or more parameters'
-                        return nil
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: Stereographic projection is missing one or more parameters'
                      end
                   end
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/mapProjections/projection_transverseMercator.rb

@@ -38,8 +38,7 @@ module ADIWG
                      if paramCount == 5
                         return hProjection
                      else
-                        hResponseObj[:readerExecutionMessages] << 'transverse mercator projection is missing one or more parameters'
-                        return nil
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: Transverse Mercator projection is missing one or more parameters'
                      end
                   end
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/mapProjections/projection_vanDerGrinten.rb

@@ -32,8 +32,7 @@ module ADIWG
                      if paramCount == 3
                         return hProjection
                      else
-                        hResponseObj[:readerExecutionMessages] << 'van der grinten projection is missing one or more parameters'
-                        return nil
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: Van Der Grinten projection is missing one or more parameters'
                      end
                   end
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_attribute.rb

@@ -25,22 +25,28 @@ module ADIWG
                   intMetadataClass = InternalMetadata.new
                   hAttribute = intMetadataClass.newEntityAttribute
 
-                  # entity attribute 5.1.2.1 (attrlabl) - attribute name
+                  # entity attribute 5.1.2.1 (attrlabl) - attribute name (required)
                   # -> dataDictionary.entities.attributes.attributeCode
                   code = xAttribute.xpath('./attrlabl').text
                   unless code.empty?
                      hAttribute[:attributeName] = code
                      hAttribute[:attributeCode] = code
                   end
+                  if code.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: attribute label is missing'
+                  end
 
-                  # entity attribute 5.1.2.2 (attrdef) - attribute definition
+                  # entity attribute 5.1.2.2 (attrdef) - attribute definition (required)
                   # -> dataDictionary.entities.attributes.attributeDefinition
                   definition = xAttribute.xpath('./attrdef').text
                   unless definition.empty?
                      hAttribute[:attributeDefinition] = definition
                   end
+                  if definition.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: attribute definition is missing'
+                  end
 
-                  # entity attribute 5.1.2.3 (attrdefs) - attribute definition source
+                  # entity attribute 5.1.2.3 (attrdefs) - attribute definition source (required)
                   # -> dataDictionary.entities.attributes.attributeReference.title
                   reference = xAttribute.xpath('./attrdefs').text
                   unless reference.empty?
@@ -48,8 +54,11 @@ module ADIWG
                      hCitation[:title] = reference
                      hAttribute[:attributeReference] = hCitation
                   end
+                  if reference.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: attribute reference source is missing'
+                  end
 
-                  # entity attribute 5.1.2.4 (attrdomv) - attribute domain value
+                  # entity attribute 5.1.2.4 (attrdomv) - attribute domain value (required)
                   axDomain = xAttribute.xpath('./attrdomv')
                   unless axDomain.empty?
 
@@ -88,6 +97,9 @@ module ADIWG
                      end
 
                   end
+                  if axDomain.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: attribute domain is missing'
+                  end
 
                   # add domainId to attribute
                   # fgdc allows multiple domain definitions

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_citation.rb

@@ -46,28 +46,41 @@ module ADIWG
                         end
                      end
                   end
+                  havePR = false
                   unless aContacts.empty?
                      hResponsibility = Responsibility.unpack(aContacts, 'originator', hResponseObj)
                      unless hResponsibility.nil?
                         hCitation[:responsibleParties] << hResponsibility
+                        havePR = true
                      end
                   end
+                  unless havePR
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: citation originator is missing'
+                  end
 
-                  # citation 8.2/8.3 (pubdate/pubtime) - publication date/time {date} (required) {time} (optional)
+                  # citation 8.2/8.3 (pubdate/pubtime) - publication date/time {date} (required) - {time} (optional)
+                  haveDate = false
                   pubDate = xCiteInfo.xpath('./pubdate').text
                   pubTime = xCiteInfo.xpath('./pubtime').text
                   unless pubDate.empty?
                      hDate = Date.unpack(pubDate, pubTime, 'publication', hResponseObj)
                      unless hDate.nil?
                         hCitation[:dates] << hDate
+                        haveDate = true
                      end
                   end
+                  unless haveDate
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: citation publication date is missing'
+                  end
 
                   # citation 8.4 (title) - citation title (required)
                   title = xCiteInfo.xpath('./title').text
                   unless title.empty?
                      hCitation[:title] = title
                   end
+                  if title.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: citation title is missing'
+                  end
 
                   # citation 8.5 (edition) - edition
                   edition = xCiteInfo.xpath('./edition').text

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_codeSet.rb

@@ -32,14 +32,17 @@ module ADIWG
                         hDomain[:domainDescription] = 'FGDC codeSet domain'
 
 
-                        # entity attribute 5.1.2.4.3.1 (codesetn) - codeset name
+                        # entity attribute 5.1.2.4.3.1 (codesetn) - codeset name (required)
                         # -> dataDictionary.domains.commonName
                         name = xCodeSet.xpath('./codesetn').text
                         unless name.empty?
                            hDomain[:domainName] = name
                         end
+                        if name.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: codeset domain name is missing'
+                        end
 
-                        # entity attribute 5.1.2.4.3.2 (codesets) - codeset source {citation}
+                        # entity attribute 5.1.2.4.3.2 (codesets) - codeset source name (required)
                         # -> dataDictionary.domains.domainReference.title
                         hCitation = intMetadataClass.newCitation
                         title = xCodeSet.xpath('./codesets').text
@@ -47,6 +50,9 @@ module ADIWG
                            hCitation[:title] = title
                            hDomain[:domainReference] = hCitation
                         end
+                        if title.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: codeset domain source is missing'
+                        end
 
                         aDomains << hDomain
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_contact.rb

@@ -63,7 +63,6 @@ module ADIWG
                         # person primary 10.1.2 (cntorg) - name of organization
                         personName = xPerson.xpath('./cntper').text
                         orgName = xPerson.xpath('./cntorg').text
-                        return nil if personName.empty?
 
                      end
 
@@ -76,10 +75,21 @@ module ADIWG
                         # organization primary 10.1.2 (cntorg) - name of organization
                         personName = xOrg.xpath('./cntper').text
                         orgName = xOrg.xpath('./cntorg').text
-                        return nil if orgName.empty?
 
                      end
 
+                     # error handling
+                     if contactType.nil?
+                        hResponseObj[:readerExecutionMessages] << 'ERROR: FGDC reader: contact is neither person or organization'
+                        return nil
+                     end
+                     if contactType == 'person' && personName == ''
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact person name is missing'
+                     end
+                     if contactType == 'organization' && orgName == ''
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact organization name is missing'
+                     end
+
                      # add new contacts to contact array
                      unless contactType.nil?
                         personId = Fgdc.add_contact(personName, false) unless personName.empty?
@@ -106,15 +116,18 @@ module ADIWG
                            hContact[:positionName] = position
                         end
 
-                        # contact 10.4 (cntaddr) - contact address []
+                        # contact 10.4 (cntaddr) - contact address [] (required)
                         axAddress = xContactInfo.xpath('./cntaddr')
                         unless axAddress.empty?
                            axAddress.each do |xAddress|
                               hAddress = intMetadataClass.newAddress
 
-                              # address 10.4.1 (addrtype) - address type
+                              # address 10.4.1 (addrtype) - address type (required)
                               addType = xAddress.xpath('./addrtype').text
                               hAddress[:addressTypes] << addType unless addType.empty?
+                              if addType.empty?
+                                 hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact address type is missing'
+                              end
 
                               # address 10.4.2 (address) - address lines []
                               axAddLines = xAddress.xpath('./address')
@@ -125,17 +138,26 @@ module ADIWG
                                  end
                               end
 
-                              # address 10.4.3 (city) - city
+                              # address 10.4.3 (city) - city (required)
                               city = xAddress.xpath('./city').text
                               hAddress[:city] = city unless city.empty?
+                              if city.empty?
+                                 hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact address city is missing'
+                              end
 
-                              # address 10.4.4 (state) - state or province
+                              # address 10.4.4 (state) - state (required)
                               state = xAddress.xpath('./state').text
                               hAddress[:adminArea] = state unless state.empty?
+                              if state.empty?
+                                 hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact address state is missing'
+                              end
 
-                              # address 10.4.5 (postal) - postal code
+                              # address 10.4.5 (postal) - postal code (required)
                               postal = xAddress.xpath('./postal').text
                               hAddress[:postalCode] = postal unless postal.empty?
+                              if postal.empty?
+                                 hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact address zip code is missing'
+                              end
 
                               # address 10.4.6 (country) - country
                               country = xAddress.xpath('./country').text
@@ -165,8 +187,11 @@ module ADIWG
 
                            end
                         end
+                        if axAddress.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact address is missing'
+                        end
 
-                        # contact 10.5 (cntvoice) - contact voice phone number []
+                        # contact 10.5 (cntvoice) - contact voice phone number [] (required)
                         axVoice = xContactInfo.xpath('./cntvoice')
                         unless axVoice.empty?
                            axVoice.each do |xPhone|
@@ -176,6 +201,9 @@ module ADIWG
                               end
                            end
                         end
+                        if axVoice.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: contact voice phone is missing'
+                        end
 
                         # contact 10.6 (cnttdd) - contact TDD/TTY phone number []
                         axTDD = xContactInfo.xpath('./cnttdd')

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_date.rb

@@ -24,13 +24,13 @@ module ADIWG
                   hDate = intMetadataClass.newDate
 
                   if date.nil? || date == ''
-                     hResponseObj[:readerExecutionMessages] << 'date string is missing from date conversion'
+                     hResponseObj[:readerExecutionMessages] << 'ERROR: FGDC reader: date missing from dateType creation'
                      hResponseObj[:readerExecutionPass] = false
                      return nil
                   end
 
                   if type.nil? || type == ''
-                     hResponseObj[:readerExecutionMessages] << 'date type is missing from date conversion'
+                     hResponseObj[:readerExecutionMessages] << 'ERROR: FGDC reader: role missing from dateType creation'
                      hResponseObj[:readerExecutionPass] = false
                      return nil
                   end

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_dateTime.rb

@@ -23,7 +23,7 @@ module ADIWG
                   hDateTime = intMetadataClass.newDateTime
 
                   if date.nil? || date == ''
-                     hResponseObj[:readerExecutionMessages] << 'date string is missing from dateTime'
+                     hResponseObj[:readerExecutionMessages] << 'ERROR: FGDC reader: date missing from dateTime creation'
                      hResponseObj[:readerExecutionPass] = false
                      return nil
                   end
@@ -87,7 +87,7 @@ module ADIWG
                   # if dateTimeFromString fails, [0] = nil; [1] = 'ERROR'
                   aDateTimeReturn = AdiwgDateTimeFun.dateTimeFromString(dtIn)
                   if aDateTimeReturn[1] == 'ERROR'
-                     hResponseObj[:readerExecutionMessages] << 'Date string is invalid'
+                     hResponseObj[:readerExecutionMessages] << 'ERROR: FGDC reader: Conversion of dateTime string to object failed'
                      hResponseObj[:readerExecutionPass] = false
                      return nil
                   end

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_digitalForm.rb

@@ -24,13 +24,16 @@ module ADIWG
                   intMetadataClass = InternalMetadata.new
                   hTransfer = intMetadataClass.newTransferOption
 
-                  # distribution 6.4.2.1 (digtinfo) - digital transfer information
+                  # distribution 6.4.2.1 (digtinfo) - digital transfer information (required)
                   xTranInfo = xDigiForm.xpath('./digtinfo')
                   unless xTranInfo.empty?
                      TransferInfo.unpack(xTranInfo, hTransfer, techPre, hResponseObj)
                   end
+                  if xTranInfo.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: order process transfer info is missing'
+                  end
 
-                  # distribution 6.4.2.2 (digtopt) - digital transfer option
+                  # distribution 6.4.2.2 (digtopt) - digital transfer option (required)
                   xDigiOption = xDigiForm.xpath('./digtopt')
                   unless xDigiOption.empty?
 
@@ -57,6 +60,9 @@ module ADIWG
                      end
 
                   end
+                  if xDigiOption.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: order process transfer option is missing'
+                  end
 
                   return hTransfer
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_distribution.rb

@@ -25,7 +25,7 @@ module ADIWG
                   hDistribution = intMetadataClass.newDistribution
                   hDistributor = intMetadataClass.newDistributor
 
-                  # distribution 6.1 (distrib) - distributor {contact}
+                  # distribution 6.1 (distrib) - distributor {contact} (required)
                   # -> distribution.distributor.contact.responsibility(distributor)
                   xContact = xDistribution.xpath('./distrib')
                   unless xContact.empty?
@@ -35,6 +35,9 @@ module ADIWG
                         hDistributor[:contact] = hResponsibility
                      end
                   end
+                  if xContact.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: distribution distributor is missing'
+                  end
 
                   # distribution 6.2 (resdesc) - resource description
                   # -> distribution.description
@@ -43,12 +46,15 @@ module ADIWG
                      hDistribution[:description] = description
                   end
 
-                  # distribution 6.3 (distliab) - distribution liability
+                  # distribution 6.3 (distliab) - distribution liability (required)
                   # -> distribution.liabilityStatement
                   liability = xDistribution.xpath('./distliab').text
                   unless liability.empty?
                      hDistribution[:liabilityStatement] = liability
                   end
+                  if liability.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: distribution liability is missing'
+                  end
 
                   # distribution 6.6 (techpreq) - technical prerequisites
                   # -> distribution.distributor[all].transferOption[all].distributionFormat[all].technicalPrerequisite

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_entity.rb

@@ -32,21 +32,27 @@ module ADIWG
                      hEntity = intMetadataClass.newEntity
                      hEntity[:entityId] = UUIDTools::UUID.random_create.to_s
 
-                     # entity attribute 5.1.1.1 (enttypl) - entity name
+                     # entity attribute 5.1.1.1 (enttypl) - entity name (required)
                      # -> dataDictionary.entities.entityCode
                      code = xEntity.xpath('./enttypl').text
                      unless code.empty?
                         hEntity[:entityCode] = code
                      end
+                     if code.empty?
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: entity type name is missing'
+                     end
 
-                     # entity attribute 5.1.1.2 (enttypd) - entity definition
+                     # entity attribute 5.1.1.2 (enttypd) - entity definition (required)
                      # -> dataDictionary.entities.entityDefinition
                      definition = xEntity.xpath('./enttypd').text
                      unless definition.empty?
                         hEntity[:entityDefinition] = definition
                      end
+                     if definition.empty?
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: entity type definition is missing'
+                     end
 
-                     # entity attribute 5.1.1.3 (enttypds) - entity definition source
+                     # entity attribute 5.1.1.3 (enttypds) - entity definition source (required)
                      # -> dataDictionary.entities.entityReference.title
                      reference = xEntity.xpath('./enttypds').text
                      unless reference.empty?
@@ -54,6 +60,9 @@ module ADIWG
                         hCitation[:title] = reference
                         hEntity[:entityReferences] << hCitation
                      end
+                     if reference.empty?
+                        hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: entity type definition source is missing'
+                     end
 
                      # entity attribute 5.1.2 (attr) - characteristics of an attribute
                      axAttribute = xDetail.xpath('./attr')

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_entityAttribute.rb

@@ -47,6 +47,11 @@ module ADIWG
                      end
                   end
 
+                  # error messages
+                  if axDetail.empty? && axOverview.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: entityAttribute description is missing'
+                  end
+
                   return hDictionary
 
                end

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_entityOverview.rb

@@ -24,12 +24,15 @@ module ADIWG
                   hEntity[:entityName] = 'Entity Overview'
                   hEntity[:entityCode] = 'overview'
 
-                  # entity attribute 5.2.1 (eaover) - entity attribute overview
+                  # entity attribute 5.2.1 (eaover) - entity attribute overview (required)
                   # -> dataDictionary.entities.entityDefinition
                   definition = xOverview.xpath('./eaover').text
                   unless definition.empty?
                      hEntity[:entityDefinition] = definition
                   end
+                  if definition.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: entityAttribute overview definition is missing'
+                  end
 
                   # entity attribute 5.2.2 (eadetcit) - entity attribute detail citation []
                   # -> dataDictionary.entities.entityReference.title

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_enumerated.rb

@@ -32,28 +32,37 @@ module ADIWG
                      axValues.each do |xValue|
                         hItem = intMetadataClass.newDomainItem
 
-                        # entity attribute 5.1.2.4.1.1 (edomv) - enumerated domain value
+                        # entity attribute 5.1.2.4.1.1 (edomv) - enumerated domain value (required)
                         # -> dataDictionary.domainItems.itemValue
                         value = xValue.xpath('./edomv').text
                         unless value.empty?
                            hItem[:itemName] = value
                            hItem[:itemValue] = value
                         end
+                        if value.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: enumerated domain value is missing'
+                        end
 
-                        # entity attribute 5.1.2.4.1.2 (edomvd) - enumerated domain value definition
+                        # entity attribute 5.1.2.4.1.2 (edomvd) - enumerated domain value definition (required)
                         # -> dataDictionary.domainItems.itemDefinition
                         definition = xValue.xpath('./edomvd').text
                         unless definition.empty?
                            hItem[:itemDefinition] = definition
                         end
+                        if definition.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: enumerated domain value definition is missing'
+                        end
 
-                        # entity attribute 5.1.2.4.1.3 (edomvds) - enumerated domain value definition source
+                        # entity attribute 5.1.2.4.1.3 (edomvds) - enumerated domain value definition source (required)
                         source = xValue.xpath('./edomvds').text
                         unless source.empty?
                            hCitation = intMetadataClass.newCitation
                            hCitation[:title] = source
                            hItem[:itemReference] = hCitation
                         end
+                        if source.empty?
+                           hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: enumerated domain value definition source is missing'
+                        end
 
                         hDomain[:domainItems] << hItem
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_fgdc.rb

@@ -53,7 +53,7 @@ module ADIWG
                      Identification.unpack(xIdInfo, intObj, hResponseObj)
                   end
                   if xIdInfo.empty?
-                     hResponseObj[:readerExecutionMessages] << 'FGDC is missing identification information section (idinfo)'
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: identification information section (idinfo) missing'
                   end
 
                   # metadata (dataqual 2) - data quality
@@ -103,7 +103,7 @@ module ADIWG
                      end
                   end
                   if xMetaInfo.empty?
-                     hResponseObj[:readerExecutionMessages] << 'FGDC is missing metadata information section (metainfo)'
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: metadata information section (metainfo) missing'
                   end
 
                   return intObj

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_geodeticReference.rb

@@ -14,7 +14,7 @@ module ADIWG
 
             module GeodeticReference
 
-               def self.unpack(xHorizontalRef)
+               def self.unpack(xHorizontalRef, hResponseObj)
 
                   # instance classes needed in script
                   intMetadataClass = InternalMetadata.new
@@ -29,19 +29,25 @@ module ADIWG
                      hGeodetic[:datumName] = datumName
                   end
 
-                  # geodetic model 4.1.4.2 (ellips) - ellipsoid name
+                  # geodetic model 4.1.4.2 (ellips) - ellipsoid name (required)
                   # -> referenceSystemParameters.geodetic.ellipsoidName
                   ellipsoidName = xGeodetic.xpath('./ellips').text
                   unless ellipsoidName.empty?
                      hGeodetic[:ellipsoidName] = ellipsoidName
                   end
+                  if ellipsoidName.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geodetic reference ellipsoid name is missing'
+                  end
 
-                  # geodetic model 4.1.4.3 (semiaxis) - semi-major axis
+                  # geodetic model 4.1.4.3 (semiaxis) - semi-major axis (required)
                   # -> referenceSystemParameters.geodetic.semiMajorAxis
                   semiAxis = xGeodetic.xpath('./semiaxis').text
                   unless semiAxis.empty?
                      hGeodetic[:semiMajorAxis] = semiAxis.to_f
                   end
+                  if semiAxis.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geodetic reference semi-major axis is missing'
+                  end
 
                   # geodetic model 4.1.2.4.4 (plandu) - distance units
                   # take value from the first 'planar' section with 'plandu' specified
@@ -58,12 +64,15 @@ module ADIWG
                      end
                   end
 
-                  # geodetic model 4.1.4.4 (denflat) - denominator of flattening ratio
+                  # geodetic model 4.1.4.4 (denflat) - denominator of flattening ratio (required)
                   # -> referenceSystemParameters.geodetic.denominatorOfFlatteningRatio
                   flattening = xGeodetic.xpath('./denflat').text
                   unless flattening.empty?
                      hGeodetic[:denominatorOfFlatteningRatio] = flattening.to_f
                   end
+                  if flattening.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geodetic reference flattening ratio is missing'
+                  end
 
                   hReferenceSystem = intMetadataClass.newSpatialReferenceSystem
                   hSystemParameters = intMetadataClass.newReferenceSystemParameterSet

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_geographicResolution.rb

@@ -14,7 +14,7 @@ module ADIWG
 
             module GeographicResolution
 
-               def self.unpack(xGeographic)
+               def self.unpack(xGeographic, hResponseObj)
 
                   # instance classes needed in script
                   intMetadataClass = InternalMetadata.new
@@ -22,26 +22,35 @@ module ADIWG
                   hResolution = intMetadataClass.newSpatialResolution
                   hGeoResolution = intMetadataClass.newGeographicResolution
 
-                  # geographic reference 4.1.1.1 (latres) - latitude resolution
+                  # geographic reference 4.1.1.1 (latres) - latitude resolution (required)
                   # -> spatialResolution.geographicResolution.latitudeResolution
                   latResolution = xGeographic.xpath('./latres').text
                   unless latResolution.empty?
                      hGeoResolution[:latitudeResolution] = latResolution.to_f
                   end
+                  if latResolution.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geographic latitude resolution is missing'
+                  end
 
-                  # geographic reference 4.1.1.2 (longres) - longitude resolution
+                  # geographic reference 4.1.1.2 (longres) - longitude resolution (required)
                   # -> spatialResolution.geographicResolution.longitudeResolution
                   longResolution = xGeographic.xpath('./longres').text
                   unless longResolution.empty?
                      hGeoResolution[:longitudeResolution] = longResolution.to_f
                   end
+                  if longResolution.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geographic longitude resolution is missing'
+                  end
 
-                  # geographic reference 4.1.1.3 (geogunit) - latitude/longitude units
+                  # geographic reference 4.1.1.3 (geogunit) - latitude/longitude units (required)
                   # -> spatialResolution.geographicResolution.unitOfMeasure
                   unitMeasure = xGeographic.xpath('./geogunit').text
                   unless unitMeasure.empty?
                      hGeoResolution[:unitOfMeasure] = unitMeasure
                   end
+                  if unitMeasure.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: geographic latitude/longitude units are missing'
+                  end
 
                   hResolution[:geographicResolution] = hGeoResolution
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_geologicAge.rb

@@ -26,12 +26,18 @@ module ADIWG
                   unless scale.empty?
                      intGeoAge[:ageTimeScale] = scale
                   end
+                  if scale.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: BIO geologic age time scale is missing'
+                  end
 
                   # geologic age bio (geolest) - age estimate (required)
                   estimate = xGeoAge.xpath('./geolest').text
                   unless estimate.empty?
                      intGeoAge[:ageEstimate] = estimate
                   end
+                  if estimate.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: BIO geologic age estimate is missing'
+                  end
 
                   # geologic age bio (geolun) - age estimate uncertainty
                   uncertain = xGeoAge.xpath('./geolun').text