adiwg-mdtranslator 2.18.4 → 2.19.0.pre.beta.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee12914b52bf9c3e2d2cda21512ad9ec11d1f6130bd2c648af133d8cf34c4bb7
-  data.tar.gz: fea1b82372e6fa3709e232e3ce51402dd59d77513688757b2c2d04d992f9ebbf
+  metadata.gz: f456de4448d18685a212969b02c6195b206d8e461372b317fce02e0066de15d6
+  data.tar.gz: 42027d3093840bbd6a3a896000950bef3145d3518d1a41a372e02fc199f25701
 SHA512:
-  metadata.gz: ec33267110576817cb630c1e89b93ff42819221fcbf04be01f60619c156ab4b3e118f039900aec28be75defa4291c5a5d6bdf77eb1542395e864e68d2c5fda85
-  data.tar.gz: 594b0a6433071bd297f907886e3ef07a7bc5568cbb055dd1cb173f629412f3c2cf3beaa836842b4dd07dea777423fe94b514b4181a66342961e73395dc69e7b6
+  metadata.gz: d7af3c590f3c28b7f49e6192000ee20c289ce0718e644029c04b0b21d8258422dcb3e1d28183ba945bd3dafcf8cd191a3cc33f086a4e4f06b888b21096fd9159
+  data.tar.gz: 482f497b01253e0a7376023afafa051b821ed9dec53346a4e5237ae8b40dbfab0d5a9944333b948af56490c4e2e3ed0ae35d39d2485e378a0d6c833e2fd3bade

data/.github/workflows/test.yml

@@ -0,0 +1,14 @@
+name: Tests
+
+on: [push]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@ec02537da5712d66d4d50a0f33b7eb52773b5ed1
+        with:
+          ruby-version: "3.1" # Not needed with a .ruby-version file
+      - run: bundle install
+      - run: bundle exec rake

data/Gemfile.lock

@@ -1,16 +1,16 @@
 PATH
   remote: .
   specs:
-    adiwg-mdtranslator (2.18.4)
-      adiwg-mdcodes (= 2.8.4)
-      adiwg-mdjson_schemas (= 2.8.1)
+    adiwg-mdtranslator (2.19.0.pre.beta.7)
+      adiwg-mdcodes (= 2.9.2)
+      adiwg-mdjson_schemas (= 2.9.1)
       builder (~> 3.2)
       coderay (~> 1.1)
       jbuilder (~> 2.5)
       json (~> 2.0)
       json-schema (~> 2.7)
       kramdown (>= 1.13, < 3.0)
-      nokogiri (~> 1.7)
+      nokogiri (~> 1.15)
       thor (~> 0.19)
       uuidtools (~> 2.1)
 
@@ -30,9 +30,9 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.8.5)
       public_suffix (>= 2.0.2, < 6.0)
-    adiwg-mdcodes (2.8.4)
+    adiwg-mdcodes (2.9.2)
       json (~> 2.0)
-    adiwg-mdjson_schemas (2.8.1)
+    adiwg-mdjson_schemas (2.9.1)
     builder (3.2.4)
     coderay (1.1.3)
     concurrent-ruby (1.2.2)
@@ -51,11 +51,13 @@ GEM
     loofah (2.21.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    mini_portile2 (2.4.0)
     minitest (5.20.0)
-    nokogiri (1.10.10)
-      mini_portile2 (~> 2.4.0)
+    nokogiri (1.15.5-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.15.5-x86_64-linux)
+      racc (~> 1.4)
     public_suffix (4.0.7)
+    racc (1.7.3)
     rails-dom-testing (2.1.1)
       activesupport (>= 5.0.0)
       minitest

data/adiwg-mdtranslator.gemspec

@@ -34,11 +34,11 @@ Gem::Specification.new do |spec|
    spec.add_runtime_dependency "thor", "~> 0.19"
    spec.add_runtime_dependency "uuidtools", "~> 2.1"
    spec.add_runtime_dependency "json-schema", "~> 2.7"
-   spec.add_runtime_dependency "adiwg-mdjson_schemas", "2.8.1"
-   spec.add_runtime_dependency "adiwg-mdcodes", "2.8.4"
+   spec.add_runtime_dependency "adiwg-mdjson_schemas", "2.9.1"
+   spec.add_runtime_dependency "adiwg-mdcodes", "2.9.2"
    spec.add_runtime_dependency "jbuilder", "~> 2.5"
    spec.add_runtime_dependency "kramdown", ">= 1.13", "< 3.0"
    spec.add_runtime_dependency "coderay", "~> 1.1"
-   spec.add_runtime_dependency "nokogiri", "~> 1.7"
+   spec.add_runtime_dependency "nokogiri", "~> 1.15"
 
 end

data/lib/adiwg/mdtranslator/internal/internal_metadata_obj.rb

@@ -513,6 +513,14 @@ class InternalMetadata
       }
    end
 
+   def newRangeElementDescription
+      {
+         name: nil,
+         definition: nil,
+         rangeElement: []
+      }
+   end
+
    def newImageDescription
       {
          illuminationElevationAngle: nil,
@@ -650,13 +658,22 @@ class InternalMetadata
       }
    end
 
+   def newQualityResultFile
+      {
+         fileName: nil,
+         fileType: nil,
+         fileDescription: nil,
+         fileFormat: {}
+      }
+   end
+
    def newCoverageResult
       {
          dateTime: nil,
          scope: {},
-         spatialRepresentationType: {},
+         spatialRepresentationType: nil,
          spatialRepresentation: {},
-         resultContent: [],
+         resultContentDescription: {},
          resourceFormat: {},
          resultFile: {}
       }
@@ -705,23 +722,22 @@ class InternalMetadata
 
    def newDataQualityReport
       {
-         # standaloneQualityReportDetails: nil,
-         conformanceResult: [],
-         coverageResult: [],
-         # derivedElementReport: [],
-         descriptiveResult: [],
-         evaluationMethod: {},
+         type: nil,
+         standaloneQualityReportDetails: nil,
          qualityMeasure: {},
+         evaluationMethod: {},
          quantitativeResult: [],
-         # relatedElementReport: []
+         descriptiveResult: [],
+         conformanceResult: [],
+         coverageResult: [],
+         derivedElementReport: []
       }
    end
 
    def newStandaloneReport
       {
-         reportReference: {},
          abstract: nil,
-         elementReports: []
+         reportReference: {},
       }
    end
 

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_dataQuality.rb

@@ -0,0 +1,149 @@
+# Reader - fgdc to internal data structure
+# unpack fgdc data quality
+
+# History:
+#  Stan Smith 2017-08-15 original script
+
+require 'nokogiri'
+require 'adiwg/mdtranslator/internal/internal_metadata_obj'
+require_relative 'module_lineage'
+
+module ADIWG
+   module Mdtranslator
+      module Readers
+         module Fgdc
+
+            module DataQuality
+
+               def self.unpack(xDataQual, hMetadata, hDataQuality, hResponseObj)
+                  intMetadataClass = InternalMetadata.new
+
+                  hDataQuality[:scope] = intMetadataClass.newScope
+                  hDataQuality[:scope][:scopeCode] = 'tabularDataset'
+
+                  hDataQuality[:systemIdentifier] = {
+                     uid: UUIDTools::UUID.random_create.to_s,
+                     label: "CSDGM Data Quality"
+                  }
+
+                  # data quality 2.1 (attracc) - attribute accuracy
+                  xAccuracy = xDataQual.xpath('./attracc')
+                  accuracyReport = xAccuracy.xpath('./attraccr').text
+                  report = intMetadataClass.newDataQualityReport
+                  report[:type] = 'NonQuantitativeAttributeAccuracy'
+                  descriptiveResult = intMetadataClass.newDescriptiveResult
+                  descriptiveResult[:statement] = accuracyReport
+                  report[:descriptiveResult] << descriptiveResult
+                  hDataQuality[:report] << report
+
+                  # data quality 2.1 (qattracc) - Quantitative Attribute Accuracy Assessment
+                  xQuantitativeAccuracy = xDataQual.xpath('./qattracc')
+                  unless xQuantitativeAccuracy.xpath('./attraccv').empty?
+                     value = xQuantitativeAccuracy.xpath('./attraccv').text
+                     report = intMetadataClass.newDataQualityReport
+                     report[:type] = 'QuantitativeAttributeAccuracy'
+                     quantitativeResult = intMetadataClass.newQuantitativeResult
+                     quantitativeResult[:values] << value
+                     report[:quantitativeResult] << quantitativeResult
+                     hDataQuality[:report] << report
+                  end
+
+                  # data quality 2.2 (logic) - logical consistency (required) (not implemented)
+                  xLogic = xDataQual.xpath('./logic')
+                  if xLogic.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: data quality logical consistency section is missing'
+                  else
+                     logic = xLogic.text
+                     report = intMetadataClass.newDataQualityReport
+                     report[:type] = 'ConceptualConsistency'
+                     report[:qualityMeasure] = intMetadataClass.newQualityMeasure
+                     report[:qualityMeasure][:description] = logic
+                     hDataQuality[:report] << report
+                  end
+
+                  # data quality 2.3 (complete) - completion report (required)
+                  xComplete = xDataQual.xpath('./complete')
+                  if xComplete.empty?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: data quality completion report section is missing'
+                  else
+                     complete = xComplete.text
+                     report = intMetadataClass.newDataQualityReport
+                     report[:type] = 'CompletenessOmission'
+                     descriptiveResult = intMetadataClass.newDescriptiveResult
+                     descriptiveResult[:statement] = complete
+                     report[:descriptiveResult] << descriptiveResult
+                     hDataQuality[:report] << report
+                  end
+
+                  # data quality 2.4 (position) - positional accuracy
+                  xPositionalAccuracy = xDataQual.xpath('./posacc')
+                  unless xPositionalAccuracy.empty?
+                     # horizontal positional accuracy
+                     xHorizontal = xPositionalAccuracy.xpath('./horizpa')
+                     unless xHorizontal.empty?
+                        report = intMetadataClass.newDataQualityReport
+                        report[:type] = 'AbsoluteExternalPositionalAccuracy'
+                        unless xHorizontal.xpath('qhorizpa/horizpae').empty?
+                           report[:qualityMeasure] = intMetadataClass.newQualityMeasure
+                           report[:qualityMeasure][:description] = xHorizontal.xpath('qhorizpa/horizpae').text
+                           name = 'Horizontal Positional Accuracy Report'
+                           report[:qualityMeasure][:nameOfMeasure] << name
+                        end
+                        unless xHorizontal.xpath('horizpar').empty?
+                           report[:evaluationMethod] = intMetadataClass.newEvaluationMethod
+                           report[:evaluationMethod][:methodDescription] = xHorizontal.xpath('horizpar').text
+                        end
+                        unless xHorizontal.xpath('qhorizpa/horizpav').empty?
+                           quantitativeResult = intMetadataClass.newQuantitativeResult
+                           value = xHorizontal.xpath('qhorizpa/horizpav').text
+                           quantitativeResult[:values] << value
+                           report[:quantitativeResult] << quantitativeResult
+                        end
+                        hDataQuality[:report] << report
+                     end
+                     # vertical positional accuracy
+                     xVertical = xPositionalAccuracy.xpath('./vertacc')
+                     unless xVertical.empty?
+                        report = intMetadataClass.newDataQualityReport
+                        report[:type] = 'AbsoluteExternalPositionalAccuracy'
+                        unless xVertical.xpath('qvertpa/vertacce').empty?
+                           report[:qualityMeasure] = intMetadataClass.newQualityMeasure
+                           report[:qualityMeasure][:description] = xVertical.xpath('qvertpa/vertacce').text
+                           name = 'Vertical Positional Accuracy Report'
+                           report[:qualityMeasure][:nameOfMeasure] << name
+                        end
+                        unless xVertical.xpath('vertaccr').empty?
+                           report[:evaluationMethod] = intMetadataClass.newEvaluationMethod
+                           report[:evaluationMethod][:methodDescription] = xVertical.xpath('vertaccr').text
+                        end
+                        unless xVertical.xpath('qvertpa/vertaccv').empty?
+                           quantitativeResult = intMetadataClass.newQuantitativeResult
+                           value = xVertical.xpath('qvertpa/vertaccv').text
+                           quantitativeResult[:values] << value
+                           report[:quantitativeResult] << quantitativeResult
+                        end
+                        hDataQuality[:report] << report
+                     end
+                  end
+
+                  # data quality 2.5 (lineage) - lineage (required)
+                  xLineage = xDataQual.xpath('./lineage')
+                  unless xLineage.empty?
+                     hLineage = Lineage.unpack(xLineage, hResponseObj)
+                     unless hLineage.nil?
+                        hMetadata[:lineageInfo] << hLineage
+                     end
+                  end
+                  if xLineage.nil?
+                     hResponseObj[:readerExecutionMessages] << 'WARNING: FGDC reader: data quality lineage section is missing'
+                  end
+
+                  return hDataQuality
+               end
+
+            end
+
+         end
+      end
+   end
+end

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_fgdc.rb

@@ -10,7 +10,7 @@ require 'uuidtools'
 require 'adiwg/mdtranslator/internal/internal_metadata_obj'
 require_relative '../version'
 require_relative 'module_identification'
-require_relative 'module_quality'
+require_relative 'module_dataQuality'
 require_relative 'module_spatialOrganization'
 require_relative 'module_spatialReference'
 require_relative 'module_entityAttribute'
@@ -70,7 +70,7 @@ module ADIWG
                   # metadata (dataqual 2) - data quality
                   xDataQual = xMetadata.xpath('./dataqual')
                   unless xDataQual.empty?
-                     dataQuality = Quality.unpack(xDataQual, hMetadata, hDataQuality, hResponseObj)
+                     dataQuality = DataQuality.unpack(xDataQual, hMetadata, hDataQuality, hResponseObj)
                      hMetadata[:dataQuality] << dataQuality
                   end
 

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_conformanceResult.rb

@@ -8,7 +8,7 @@ module ADIWG
 
         module ConformanceResult
 
-          def self.unpack(hConformanceResult, responseObj, inContext = nil)
+          def self.unpack(hConformanceResult, responseObj)
 
             intMetadataClass = InternalMetadata.new
             intConformanceResult = intMetadataClass.newConformanceResult

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_coverageResult.rb

@@ -1,5 +1,8 @@
 require_relative 'module_scope'
 require_relative 'module_spatialRepresentation'
+require_relative 'module_qualityResultFile'
+require_relative 'module_format'
+require_relative 'module_coverageDescription'
 
 module ADIWG
   module Mdtranslator
@@ -7,7 +10,7 @@ module ADIWG
       module MdJson
 
         module CoverageResult
-          def self.unpack(hResult, responseObj, inContext)
+          def self.unpack(hResult, responseObj)
 
             intMetadataClass = InternalMetadata.new
             intResult = intMetadataClass.newCoverageResult
@@ -25,7 +28,6 @@ module ADIWG
 
 
             # spatialRepresentationType
-            # https://github.com/ISO-TC211/XML/blob/master/standards.iso.org/iso/19115/resources/Codelists/gml/MD_SpatialRepresentationTypeCode.xml
             if hResult.has_key?('spatialRepresentationType')
               intResult[:spatialRepresentationType] = hResult['spatialRepresentationType']
             end
@@ -38,21 +40,20 @@ module ADIWG
 
 
             # resultContent
-            if hResult.has_key?('resultContent')
-              intResult[:resultContent] = hResult['resultContent']
+            if hResult.has_key?('resultContentDescription')
+              intResult[:resultContentDescription] = CoverageDescription.unpack(hResult['resultContentDescription'], responseObj)
             end
 
 
             # resourceFormat
             if hResult.has_key?('resourceFormat')
-              intResult[:resourceFormat] = hResult['resourceFormat']
+              intResult[:resourceFormat] = Format.unpack(hResult['resourceFormat'], responseObj)
             end
 
 
             # resultFile
-            resultFile
             if hResult.has_key?('resultFile')
-              intResult[:resultFile] = hResult['resultFile']
+              intResult[:resultFile] = QualiltyResultFile.unpack(hResult['resultFile'], responseObj)
             end
 
             return intResult

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_dataQuality.rb

@@ -38,11 +38,11 @@ module ADIWG
             if hDataQuality.has_key?('standaloneQualityReport')
               hObject = hDataQuality['standaloneQualityReport']
               unless hObject.empty?
-                intDataQuality[:standaloneQualityReport] = {}
-                intDataQuality[:standaloneQualityReport][:abstract] = hObject["abstract"]
+                intDataQuality[:standaloneReport] = {}
+                intDataQuality[:standaloneReport][:abstract] = hObject["abstract"]
 
-                unless hObject["reportRefereence"].nil? || hObject["reportReference"].empty?
-                  intDataQuality[:standaloneQualityReport][:reportReference] = Citation.unpack(hObject["reportReference"], responseObj, inContext)
+                unless hObject["reportReference"].nil? || hObject["reportReference"].empty?
+                  intDataQuality[:standaloneReport][:reportReference] = Citation.unpack(hObject["reportReference"], responseObj, inContext)
                 end
               end
             end

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_dataQualityReport.rb

@@ -4,6 +4,7 @@ require_relative 'module_coverageResult'
 require_relative 'module_descriptiveResult'
 require_relative 'module_quantitativeResult'
 require_relative 'module_evaluationMethod'
+require_relative 'module_qualityMeasure'
 
 module ADIWG
   module Mdtranslator
@@ -28,6 +29,10 @@ module ADIWG
 
             intReport[:type] = hReport["type"]
 
+            if hReport.has_key?('standaloneQualityReportDetails')
+              intReport[:standaloneQualityReportDetails] = hReport['standaloneQualityReportDetails']
+            end
+
             if hReport.has_key?('conformanceResult')
               hReport['conformanceResult'].each do |item|
                 hReturn = ConformanceResult.unpack(item, responseObj)
@@ -68,23 +73,10 @@ module ADIWG
             end
 
             if hReport.has_key?('qualityMeasure')
-              qualityMeasure = hReport['qualityMeasure']
-              identifier = qualityMeasure['identifier']
-
-              intReport[:qualityMeasure] = {}
-
-              if identifier
-                intReport[:qualityMeasure][:identifier] = {
-                  identifier: identifier['identifier'],
-                  namespace: identifier['namespace'],
-                  version: identifier['version'],
-                  description: identifier['description']
-                }
-              end
+              hReturn = QualityMeasure.unpack(hReport['qualityMeasure'], responseObj)
 
-              if qualityMeasure
-                intReport[:qualityMeasure][:name] = qualityMeasure['name']
-                intReport[:qualityMeasure][:description] = qualityMeasure['description']
+              unless hReturn.nil?
+                intReport[:qualityMeasure] = hReturn
               end
             end
 

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_evaluationMethod.rb

@@ -6,7 +6,7 @@ module ADIWG
       module MdJson
 
         module EvaluationMethod
-          def self.unpack(hMethod, responseObj, inContext = nil)
+          def self.unpack(hMethod, responseObj)
 
             intMetadataClass = InternalMetadata.new
             intMethod = intMetadataClass.newEvaluationMethod

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_legalConstraint.rb

@@ -34,21 +34,21 @@ module ADIWG
 
                   haveLegal = false
 
-                  # legal constraint - use constraint []
-                  if hLegalCon.has_key?('useConstraint')
-                     hLegalCon['useConstraint'].each do |item|
+                  # legal constraint - access constraint []
+                  if hLegalCon.has_key?('accessConstraint')
+                     hLegalCon['accessConstraint'].each do |item|
                         unless item == ''
-                           intLegalCon[:useCodes] << item
+                           intLegalCon[:accessCodes] << item
                            haveLegal = true
                         end
                      end
                   end
 
-                  # legal constraint - access constraint []
-                  if hLegalCon.has_key?('accessConstraint')
-                     hLegalCon['accessConstraint'].each do |item|
+                  # legal constraint - use constraint []
+                  if hLegalCon.has_key?('useConstraint')
+                     hLegalCon['useConstraint'].each do |item|
                         unless item == ''
-                           intLegalCon[:accessCodes] << item
+                           intLegalCon[:useCodes] << item
                            haveLegal = true
                         end
                      end

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_qualityMeasure.rb

@@ -0,0 +1,34 @@
+require_relative 'module_identifier'
+
+module ADIWG
+    module Mdtranslator
+        module Readers
+            module MdJson
+
+                module QualityMeasure
+                    def self.unpack(hQualityMeasure, responseObj)
+
+                        intMetadataClass = InternalMetadata.new
+                        intQualityMeasure = intMetadataClass.newQualityMeasure
+
+                        intQualityMeasure[:description] = hQualityMeasure['description']
+
+                        if hQualityMeasure.has_key?('name')
+                            intQualityMeasure[:nameOfMeasure] = hQualityMeasure['name']
+                        end
+
+                        if hQualityMeasure.has_key?('identifier')
+                            hReturn = Identifier.unpack(hQualityMeasure['identifier'], responseObj)
+                            unless hReturn.nil?
+                                intQualityMeasure[:identifier] = hReturn
+                            end
+                        end
+
+                        return intQualityMeasure
+
+                    end
+                end
+            end
+        end
+    end
+end

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_qualityResultFile.rb

@@ -0,0 +1,72 @@
+require_relative 'module_format'
+
+module ADIWG
+   module Mdtranslator
+      module Readers
+         module MdJson
+
+            module QualiltyResultFile
+
+                def self.unpack(hContent, responseObj)
+                    @MessagePath = ADIWG::Mdtranslator::Readers::MdJson::MdJson
+
+                    # return nil object if input is empty
+                    if hContent.empty?
+                        @MessagePath.issueWarning(130, responseObj)
+                        return nil
+                    end
+
+                    # instance classes needed in script
+                    intMetadataClass = InternalMetadata.new
+                    intContent = intMetadataClass.newQualityResultFile
+
+                    # content information - file name (required)
+                    if hContent.has_key?('fileName')
+                        unless hContent['fileName'] == ''
+                        intContent[:fileName] = hContent['fileName']
+                        end
+                    end
+                    if intContent[:fileName].nil?
+                        @MessagePath.issueError(131, responseObj)
+                    end
+
+                    # content information - file description (required)
+                    if hContent.has_key?('fileDescription')
+                        unless hContent['fileDescription'] == ''
+                        intContent[:fileDescription] = hContent['fileDescription']
+                        end
+                    end
+                    if intContent[:fileDescription].nil?
+                        @MessagePath.issueError(132, responseObj)
+                    end
+
+                    # content information - file type
+                    if hContent.has_key?('fileType')
+                        unless hContent['fileType'] == ''
+                        intContent[:fileType] = hContent['fileType']
+                        end
+                    end
+                    if intContent[:fileType].nil?
+                        @MessagePath.issueError(131, responseObj)
+                    end
+
+                    if hContent.has_key?('fileFormat')
+                        hObject = hContent['fileFormat']
+                        unless hObject.empty?
+                            hReturn = Format.unpack(hObject, responseObj)
+                            unless hReturn.nil?
+                                intContent[:fileFormat] = hReturn
+                            end
+                        end
+                    end
+
+                    return intContent
+
+                end
+
+            end
+
+         end
+      end
+   end
+end

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_rangeElementDescription.rb

@@ -23,8 +23,8 @@ module ADIWG
               intRangeElementDescription[:definition] = hRangeElementDescription['definition']
             end
 
-            if hRangeElementDescription.has_key?('rangeElements')
-              intRangeElementDescription[:rangeElements] = hRangeElementDescription['rangeElements']
+            if hRangeElementDescription.has_key?('rangeElement')
+              intRangeElementDescription[:rangeElement] = hRangeElementDescription['rangeElement']
             end
 
             return intRangeElementDescription

data/lib/adiwg/mdtranslator/readers/sbJson/modules/module_contact.rb

@@ -249,6 +249,19 @@ module ADIWG
                            end
                         end
 
+                        # orcId - external contact identifier
+                        if hSbContact.has_key?('orcId') && hSbContact['contactType'] == 'person'
+                           hContact[:externalIdentifier] ||= []
+                           unless hSbContact['orcId'].nil? || hSbContact['orcId'] == ''
+                              hExternalIdentifier = {
+                                 "identifier": hSbContact['orcId'],
+                                 "namespace": "ORCID",
+                                 "description": "Open Researcher and Contributor Id"
+                              }
+                              hContact[:externalIdentifier] << hExternalIdentifier
+                           end
+                        end
+
                         aContacts << hContact
                         aContacts << hContactOrg unless hContactOrg.empty?
 

data/lib/adiwg/mdtranslator/version.rb

@@ -109,7 +109,7 @@
 module ADIWG
    module Mdtranslator
       # current mdtranslator version
-      VERSION = "2.18.4"
+      VERSION = "2.19.0-beta.7"
    end
 end