adiwg-mdtranslator 2.10.0 → 2.12.0.pre

data/lib/adiwg/mdtranslator/writers/fgdc/classes/class_verticalDatum.rb

@@ -2,6 +2,7 @@
 # FGDC CSDGM writer output in XML
 
 # History:
+#  Stan Smith 2018-03-27 refactored error and warning messaging
 #  Stan Smith 2018-01-16 original script
 
 module ADIWG
@@ -14,6 +15,7 @@ module ADIWG
                def initialize(xml, hResponseObj)
                   @xml = xml
                   @hResponseObj = hResponseObj
+                  @NameSpace = ADIWG::Mdtranslator::Writers::Fgdc
                end
 
                def writeXML(aSpaceRefs)
@@ -32,8 +34,7 @@ module ADIWG
                                     @xml.tag!('depthdn', hVDatum[:datumName])
                                  end
                                  if hVDatum[:datumName].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Depth Datum is missing datum name'
+                                    @NameSpace.issueWarning(460, 'depthdn')
                                  end
 
                                  # vertical datum 4.2.1.2 (depthres) - depth units resolution (required)
@@ -41,8 +42,7 @@ module ADIWG
                                     @xml.tag!('depthres', hVDatum[:verticalResolution])
                                  end
                                  if hVDatum[:verticalResolution].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Depth Datum is missing depth units resolution'
+                                    @NameSpace.issueWarning(461, 'depthres')
                                  end
 
                                  # vertical datum 4.2.1.3 (depthdu) - depth units (required)
@@ -50,17 +50,15 @@ module ADIWG
                                     @xml.tag!('depthdu', hVDatum[:unitOfMeasure])
                                  end
                                  if hVDatum[:unitOfMeasure].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Depth Datum is missing depth units'
+                                    @NameSpace.issueWarning(462, 'depthdu')
                                  end
 
-                                 # vertical datum 4.2.1.4 (depthem) - depth units (required)
+                                 # vertical datum 4.2.1.4 (depthem) - encoding method (required)
                                  unless hVDatum[:encodingMethod].nil?
                                     @xml.tag!('depthem', hVDatum[:encodingMethod])
                                  end
                                  if hVDatum[:encodingMethod].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Depth Datum is missing depth encoding method'
+                                    @NameSpace.issueWarning(463, 'depthem')
                                  end
 
                               end
@@ -73,8 +71,7 @@ module ADIWG
                                     @xml.tag!('altdatum', hVDatum[:datumName])
                                  end
                                  if hVDatum[:datumName].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Altitude Datum is missing datum name'
+                                    @NameSpace.issueWarning(464, 'altdatum')
                                  end
 
                                  # altitude datum 4.2.2.2 (altres) - altitude units resolution (required)
@@ -82,8 +79,7 @@ module ADIWG
                                     @xml.tag!('altres', hVDatum[:verticalResolution])
                                  end
                                  if hVDatum[:verticalResolution].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Altitude Datum is missing depth units resolution'
+                                    @NameSpace.issueWarning(465, 'altres')
                                  end
 
                                  # altitude datum 4.2.2.3 (altunits) - altitude units (required)
@@ -91,8 +87,7 @@ module ADIWG
                                     @xml.tag!('altunits', hVDatum[:unitOfMeasure])
                                  end
                                  if hVDatum[:unitOfMeasure].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Altitude Datum is missing depth units'
+                                    @NameSpace.issueWarning(466, 'altunits')
                                  end
 
                                  # altitude datum 4.2.2.4 (altenc) - altitude units (required)
@@ -100,8 +95,7 @@ module ADIWG
                                     @xml.tag!('altenc', hVDatum[:encodingMethod])
                                  end
                                  if hVDatum[:encodingMethod].nil?
-                                    @hResponseObj[:writerPass] = false
-                                    @hResponseObj[:writerMessages] << 'Vertical Altitude Datum is missing depth encoding method'
+                                    @NameSpace.issueWarning(467, 'altenc')
                                  end
 
                               end

data/lib/adiwg/mdtranslator/writers/fgdc/fgdc_writer.rb

@@ -3,6 +3,7 @@
 # History:
 #  Stan Smith 2017-11-16 original script
 
+require 'yaml'
 require 'builder'
 require_relative 'version'
 require_relative 'classes/class_fgdc'
@@ -17,16 +18,22 @@ module ADIWG
                # make objects available to the instance
                @intObj = intObj
                @contacts = intObj[:contacts]
+               @hResponseObj = responseObj
+
+               # load error message array
+               file = File.join(File.dirname(__FILE__), 'fgdc_writer_messages_eng') + '.yml'
+               hMessageList = YAML.load_file(file)
+               @aMessagesList = hMessageList['messageList']
 
                # set the format of the output file based on the writer
                responseObj[:writerOutputFormat] = 'xml'
                responseObj[:writerVersion] = ADIWG::Mdtranslator::Writers::Fgdc::VERSION
 
                # create new XML document
-               xml = Builder::XmlMarkup.new(indent: 3)
+               @xml = Builder::XmlMarkup.new(indent: 3)
 
                # start writing the FGDC XML record
-               metadataWriter = Fgdc.new(xml, responseObj)
+               metadataWriter = Fgdc.new(@xml, responseObj)
                metadata = metadataWriter.writeXML(intObj)
 
                return metadata
@@ -56,10 +63,53 @@ module ADIWG
                return aParties
             end
 
-            def  self.get_intObj
+            def self.get_intObj
                return @intObj
             end
 
+            def self.findMessage(messageId)
+               @aMessagesList.each do |hMessage|
+                  if hMessage['id'] == messageId
+                     return hMessage['message']
+                  end
+               end
+               return nil
+            end
+
+            def self.issueError(messageId, context = nil)
+               message = findMessage(messageId)
+               unless message.nil?
+                  message += ': CONTEXT is ' + context unless context.nil?
+                  @hResponseObj[:writerMessages] << 'ERROR: FGDC writer: ' + message
+                  @hResponseObj[:writerPass] = false
+               end
+            end
+
+            def self.issueWarning(messageId, tag = nil, context = nil)
+               message = findMessage(messageId)
+               unless message.nil?
+                  message += ': CONTEXT is ' + context unless context.nil?
+                  if @hResponseObj[:writerForceValid]
+                     if tag.nil?
+                        issueError(messageId, context)
+                     else
+                        @xml.tag!(tag, 'missing')
+                        @hResponseObj[:writerMessages] << 'WARNING: FGDC writer: ' + message
+                     end
+                  else
+                     @hResponseObj[:writerMessages] << 'WARNING: FGDC writer: ' + message
+                  end
+               end
+            end
+
+            def self.issueNotice(messageId, context = nil)
+               message = findMessage(messageId)
+               unless message.nil?
+                  message += ': CONTEXT is ' + context unless context.nil?
+                  @hResponseObj[:writerMessages] << 'NOTICE: FGDC writer: ' + message
+               end
+            end
+
          end
       end
    end

data/lib/adiwg/mdtranslator/writers/fgdc/fgdc_writer_messages_eng.yml

@@ -0,0 +1,213 @@
+# Writer - messages for FGDC CSDGM FGDC-STD-001-1998
+
+# History:
+#  Stan Smith 2018-03-17 original script
+
+messageList:
+   - {id: 1, message: "contact address type is missing"}
+   - {id: 2, message: "contact address city is missing"}
+   - {id: 3, message: "contact address state is missing"}
+   - {id: 4, message: "contact address postal code is missing"}
+   - {id: 5, message: "contact voice phone is missing"}
+
+   - {id: 10, message: "attribute label is missing"}
+   - {id: 11, message: "attribute definition is missing"}
+   - {id: 12, message: "attribute definition source is missing"}
+   - {id: 13, message: "attribute range value minimum is missing"}
+   - {id: 14, message: "attribute range value maximum is missing"}
+   - {id: 15, message: "attribute date range beginning date is missing"}
+   - {id: 16, message: "attribute date range ending date is missing"}
+
+   - {id: 20, message: "browse graphic name is missing"}
+   - {id: 21, message: "browse graphic description is missing"}
+   - {id: 22, message: "browse graphic file type is missing"}
+
+   - {id: 30, message: "citation originator role is missing"}
+   - {id: 31, message: "citation publication date is missing"}
+   - {id: 32, message: "citation title is missing"}
+
+   - {id: 40, message: "access constraint is missing"}
+   - {id: 41, message: "use constraint is missing"}
+
+   - {id: 50, message: "organization contact name is missing"}
+   - {id: 51, message: "individual contact name is missing"}
+   - {id: 52, message: "contact type is missing"}
+   - {id: 53, message: "individual contact name is missing"}
+   - {id: 54, message: "organization contact name is missing"}
+   - {id: 55, message: "contact address is missing"}
+
+   - {id: 60, message: "description abstract is missing"}
+   - {id: 61, message: "description purpose is missing"}
+
+   - {id: 70, message: "dictionary domain ID was not found"}
+   - {id: 71, message: "enumerated domain value is missing"}
+   - {id: 72, message: "enumerated domain value definition is missing"}
+   - {id: 73, message: "enumerated domain value source is missing"}
+   - {id: 74, message: "codeset domain name is missing"}
+   - {id: 75, message: "codeset domain reference is missing"}
+   - {id: 76, message: "enumerated domain value source is missing"}
+
+   - {id: 80, message: "data dictionary requires at least one detail or overview entity"}
+
+   - {id: 90, message: "entity type label is missing"}
+   - {id: 91, message: "entity type definition is missing"}
+   - {id: 92, message: "entity type definition source is missing"}
+
+   - {id: 100, message: "entity overview definition is missing"}
+
+   - {id: 110, message: "distributor contact is missing"}
+   - {id: 111, message: "distributor liability statement is missing"}
+
+   - {id: 120, message: "offline option media name is missing"}
+   - {id: 121, message: "offline option recording density is missing"}
+   - {id: 122, message: "offline option recording density units are missing"}
+   - {id: 123, message: "offline option recording format is missing"}
+
+   - {id: 130, message: "online option network address is missing"}
+
+   - {id: 140, message: "standard order process fees is missing"}
+
+   - {id: 150, message: "geodetic coordinate system ellipsoid name is missing"}
+   - {id: 151, message: "geodetic coordinate system semi-major axis is missing"}
+   - {id: 152, message: "geodetic coordinate system denominator of flattening ratio is missing"}
+
+   - {id: 160, message: "geographic resolution latitude resolution is missing"}
+   - {id: 161, message: "geographic resolution longitude resolution is missing"}
+   - {id: 162, message: "geographic resolution unit of measure is missing"}
+
+   - {id: 170, message: "geologic age time scale is missing"}
+   - {id: 171, message: "geologic age estimate is missing"}
+   - {id: 172, message: "geologic age range starting age is missing"}
+   - {id: 173, message: "geologic age range ending age is missing"}
+
+   - {id: 180, message: "main resource citation is missing"}
+   - {id: 181, message: "description is missing"}
+   - {id: 182, message: "time period is missing"}
+   - {id: 183, message: "keywords are missing"}
+   - {id: 184, message: "access constraint is missing"}
+   - {id: 185, message: "use constraint is missing"}
+   - {id: 186, message: "multiple taxonomic structures were specified, CSDGM allows for only one"}
+   - {id: 187, message: "the first taxonomic structure was written to the metadata record"}
+
+   - {id: 190, message: "keyword set thesaurus is missing"}
+
+   - {id: 200, message: "lineage source process steps are missing"}
+
+   - {id: 210, message: "lineage method type is missing"}
+   - {id: 211, message: "lineage method description is missing"}
+   - {id: 212, message: "lineage method citation is missing"}
+
+   - {id: 220, message: "lineage method keyword set is missing"}
+   - {id: 221, message: "lineage method keyword set thesaurus is missing"}
+
+   - {id: 230, message: "lineage source abbreviation code (source id) is missing"}
+   - {id: 231, message: "lineage source citation is missing"}
+   - {id: 232, message: "lineage source media type (description) is missing"}
+   - {id: 233, message: "lineage source time period is missing"}
+   - {id: 234, message: "lineage source citation abbreviation (id) is missing"}
+   - {id: 235, message: "lineage source contribution (description) is missing"}
+
+   - {id: 240, message: "lineage process step description is missing"}
+   - {id: 241, message: "lineage process step process date is missing"}
+
+   - {id: 250, message: "local coordinate system description is missing"}
+   - {id: 251, message: "local coordinate system georeference information is missing"}
+
+   - {id: 260, message: "planar coordinate information encoding method is missing"}
+   - {id: 261, message: "coordinate representation abscissa resolution is missing"}
+   - {id: 262, message: "coordinate representation ordinate resolution is missing"}
+   - {id: 263, message: "coordinate representation planar distance units are missing"}
+   - {id: 264, message: "bearing-distance representation distance resolution is missing"}
+   - {id: 265, message: "bearing-distance representation bearing resolution is missing"}
+   - {id: 266, message: "bearing-distance representation bearing units are missing"}
+   - {id: 267, message: "bearing-distance representation bearing reference direction is missing"}
+   - {id: 268, message: "bearing-distance representation bearing reference meridian is missing"}
+   - {id: 269, message: "bearing-distance representation planar distance units are missing"}
+   - {id: 270, message: "planar coordinate information section is missing"}
+
+   - {id: 280, message: "map projection name is missing projection type"}
+   - {id: 281, message: "map projection false easting is missing"}
+   - {id: 282, message: "map projection false northing is missing"}
+   - {id: 283, message: "map projection standard parallel is missing"}
+   - {id: 284, message: "map projection longitude of central meridian is missing"}
+   - {id: 285, message: "map projection latitude of projection origin is missing"}
+   - {id: 286, message: "map projection height of perspective point above surface is missing"}
+   - {id: 287, message: "map projection longitude of projection center is missing"}
+   - {id: 288, message: "map projection latitude of projection center is missing"}
+   - {id: 289, message: "map projection scale factor at equator is missing"}
+   - {id: 290, message: "map projection scale factor at center line is missing"}
+   - {id: 291, message: "map projection scale factor at projection origin is missing"}
+   - {id: 292, message: "map projection scale factor at central meridian is missing"}
+   - {id: 293, message: "map projection oblique line azimuth angle is missing"}
+   - {id: 294, message: "map projection oblique line measure point longitude is missing"}
+   - {id: 295, message: "map projection oblique line azimuth information is missing"}
+   - {id: 296, message: "map projection oblique line point latitude is missing"}
+   - {id: 297, message: "map projection oblique line point longitude is missing"}
+   - {id: 298, message: "map projection straight vertical longitude from pole is missing"}
+   - {id: 299, message: "map projection landsat number is missing"}
+   - {id: 300, message: "map projection landsat path is missing"}
+   - {id: 301, message: "map projection other projection description is missing"}
+   - {id: 302, message: "map projection local planar description is missing"}
+   - {id: 303, message: "map projection local planar georeference information is missing"}
+
+   - {id: 310, message: "map grid universal transverse mercator zone is missing"}
+   - {id: 311, message: "map grid universal polar stereographic zone is missing"}
+   - {id: 312, message: "map grid state plane coordinate system zone is missing"}
+   - {id: 313, message: "map grid equal arc-second coordinate system zone is missing"}
+
+   - {id: 320, message: "metadata creation date is missing"}
+   - {id: 321, message: "metadata contact is missing"}
+
+   - {id: 330, message: "publication place is missing"}
+   - {id: 331, message: "publication name is missing"}
+
+   - {id: 340, message: "security classification system is missing"}
+   - {id: 341, message: "security classification is missing"}
+   - {id: 342, message: "security handling instructions are missing"}
+
+   - {id: 350, message: "lineage section is missing"}
+
+   - {id: 360, message: "series name is missing"}
+   - {id: 361, message: "series issue is missing"}
+
+   - {id: 370, message: "spatial domain geographic description is missing"}
+   - {id: 371, message: "altitude bounding box minimum altitude is missing"}
+   - {id: 372, message: "altitude bounding box maximum altitude is missing"}
+   - {id: 373, message: "spatial domain bounding box is missing"}
+
+   - {id: 380, message: "raster spatial organization raster type is missing"}
+
+   - {id: 390, message: "progress is missing"}
+   - {id: 391, message: "maintenance frequency is missing"}
+   - {id: 392, message: "status section is missing"}
+
+   - {id: 400, message: "taxonomic classification is missing"}
+
+   - {id: 410, message: "taxonomic classification taxon rank is missing"}
+   - {id: 411, message: "taxonomic classification taxon value (latin name) is missing"}
+
+   - {id: 420, message: "taxonomy keyword set thesaurus is missing"}
+   - {id: 421, message: "taxonomy keyword set must have at least one keyword"}
+   - {id: 422, message: "taxonomy keyword set is missing"}
+
+   - {id: 430, message: "taxonomic classification system citation is missing"}
+   - {id: 431, message: "taxonomic classification system is missing"}
+   - {id: 432, message: "taxonomic procedures are missing"}
+   - {id: 433, message: "taxonomic voucher specimen is missing"}
+   - {id: 434, message: "taxonomic voucher repository is missing"}
+
+   - {id: 440, message: "time period age and date items are missing"}
+   - {id: 441, message: "time period must be either geologic age or conventional dates, not both"}
+   - {id: 442, message: "time period will default to conventional date"}
+   - {id: 443, message: "time info currentness is missing"}
+
+   - {id: 450, message: "distribution format name is missing"}
+
+   - {id: 460, message: "vertical depth datum name is missing"}
+   - {id: 461, message: "vertical depth resolution is missing"}
+   - {id: 462, message: "vertical depth units of measure is missing"}
+   - {id: 463, message: "vertical depth encoding method is missing"}
+   - {id: 464, message: "vertical altitude datum name is missing"}
+   - {id: 465, message: "vertical altitude resolution is missing"}
+   - {id: 466, message: "vertical altitude units of measure is missing"}
+   - {id: 467, message: "vertical altitude encoding method is missing"}

data/lib/adiwg/mdtranslator/writers/fgdc/version.rb

@@ -1,5 +1,6 @@
 # fgdc version history
-#  Stan Smith 2.1.0 2017-11-16 original script
+#  Stan Smith 1.1.0 2018-03-22 refactored message system and minor bug fixes
+#  Stan Smith 1.0.0 2017-11-16 original script
 
 module ADIWG
    module Mdtranslator
@@ -7,7 +8,7 @@ module ADIWG
          module Fgdc
 
             # current version of fgdc writer
-            VERSION = '1.0.0'
+            VERSION = '1.1.0'
 
          end
       end

data/lib/adiwg/mdtranslator/writers/html/sections/html_allocation.rb

@@ -5,6 +5,7 @@
 #  Stan Smith 2017-08-31 refactored for mdJson 2.3 schema update
 #  Stan Smith 2017-04-04 original script
 
+require_relative 'html_responsibility'
 require_relative 'html_onlineResource'
 
 module ADIWG
@@ -21,6 +22,7 @@ module ADIWG
                def writeHtml(hAllocation)
 
                   # classes used
+                  responsibilityClass = Html_Responsibility.new(@html)
                   onlineClass = Html_OnlineResource.new(@html)
 
                   # allocation - id
@@ -75,7 +77,17 @@ module ADIWG
                      @html.br
                   end
 
-                  # allocation - online resource []
+                  # allocation - responsible parties [] {responsibleParty}
+                  hAllocation[:responsibleParties].each do |hResponsibility|
+                     @html.details do
+                        @html.summary(hResponsibility[:roleName], 'class' => 'h5')
+                        @html.section(:class => 'block') do
+                           responsibilityClass.writeHtml(hResponsibility)
+                        end
+                     end
+                  end
+
+                  # allocation - online resource [] {onlineResource}
                   hAllocation[:onlineResources].each do |hOnline|
                      @html.details do
                         @html.summary('Online Resource', {'class' => 'h5'})

data/lib/adiwg/mdtranslator/writers/html/sections/html_resourceInfo.rb

@@ -2,6 +2,7 @@
 # resource information
 
 # History:
+#  Stan Smith 2018-04-06 changed taxonomy to an array
 #  Stan Smith 2017-05-19 removed iso topicCategory (now presented as keywords)
 #  Stan Smith 2017-03-25 refactored for mdTranslator 2.0
 #  Stan Smith 2015-07-16 refactored to remove global namespace $HtmlNS
@@ -337,7 +338,16 @@ module ADIWG
                      @html.details do
                         @html.summary('Taxonomy', {'id' => 'resourceInfo-taxonomy', 'class' => 'h3'})
                         @html.section(:class => 'block') do
-                           taxonomyClass.writeHtml(hResource[:taxonomy])
+                           counter = 0
+                           hResource[:taxonomy].each do |hTaxonomy|
+                              counter += 1
+                              @html.details do
+                                 @html.summary('Taxonomic Structure '+counter.to_s, 'class' => 'h5')
+                                 @html.section(:class => 'block') do
+                                    taxonomyClass.writeHtml(hTaxonomy)
+                                 end
+                              end
+                           end
                         end
                      end
                   end

data/lib/adiwg/mdtranslator/writers/html/sections/html_taxonomy.rb

@@ -38,6 +38,16 @@ module ADIWG
                      end
                   end
 
+                  # taxonomy - taxonomic class
+                  unless hTaxonomy[:taxonClass].empty?
+                     @html.details do
+                        @html.summary('Taxonomic Classification', {'class' => 'h5'})
+                        @html.section(:class => 'block') do
+                           taxonomicClass.writeHtml(hTaxonomy[:taxonClass])
+                        end
+                     end
+                  end
+
                   # taxonomy - identification procedures
                   unless hTaxonomy[:idProcedure].nil?
                      @html.em('Identification Procedures: ')
@@ -80,16 +90,6 @@ module ADIWG
                      end
                   end
 
-                  # taxonomy - taxonomic class
-                  unless hTaxonomy[:taxonClass].empty?
-                     @html.details do
-                        @html.summary('Taxonomic Classification', {'class' => 'h5'})
-                        @html.section(:class => 'block') do
-                           taxonomicClass.writeHtml(hTaxonomy[:taxonClass])
-                        end
-                     end
-                  end
-
                   # taxonomy - identification references
                   hTaxonomy[:idReferences].each do |hReference|
                      @html.details do

data/lib/adiwg/mdtranslator/writers/html/sections/html_taxonomyClass.rb

@@ -30,16 +30,16 @@ module ADIWG
                      @html.br
                   end
 
-                  # taxonomic classification - rank
+                  # taxonomic classification - level
                   unless hTaxon[:taxonRank].nil?
-                     @html.em('Taxonomic Rank: ')
+                     @html.em('Taxonomic Level: ')
                      @html.text!(hTaxon[:taxonRank])
                      @html.br
                   end
 
-                  # taxonomic classification - value
+                  # taxonomic classification - name
                   unless hTaxon[:taxonValue].nil?
-                     @html.em('Taxonomic Value: ')
+                     @html.em('Taxonomic Name: ')
                      @html.text!(hTaxon[:taxonValue])
                      @html.br
                   end

data/lib/adiwg/mdtranslator/writers/iso19110/classes/class_baseUnit.rb

@@ -2,41 +2,41 @@
 # writer output in XML
 
 # History:
+#  Stan Smith 2015-07-14 refactored to eliminate namespace globals $WriterNS and $IsoNS
+#  Stan Smith 2015-07-14 refactored to make iso19110 independent of iso19115_2 classes
+#  Stan Smith 2015-06-22 replace global ($response) with passed in object (responseObj)
+#  Stan Smith 2014-12-12 refactored to handle namespacing readers and writers
 # 	Stan Smith 2014-12-03 original script
-#   Stan Smith 2014-12-12 refactored to handle namespacing readers and writers
-#   Stan Smith 2015-06-22 replace global ($response) with passed in object (responseObj)
-#   Stan Smith 2015-07-14 refactored to make iso19110 independent of iso19115_2 classes
-#   Stan Smith 2015-07-14 refactored to eliminate namespace globals $WriterNS and $IsoNS
 
 module ADIWG
-    module Mdtranslator
-        module Writers
-            module Iso19110
+   module Mdtranslator
+      module Writers
+         module Iso19110
 
-                class BaseUnit
+            class BaseUnit
 
-                    def initialize(xml, responseObj)
-                        @xml = xml
-                        @hResponseObj = responseObj
-                    end
+               def initialize(xml, responseObj)
+                  @xml = xml
+                  @hResponseObj = responseObj
+               end
 
-                    def writeXML(hBase)
+               def writeXML(hBase)
 
-                        # create and identity for the unit
-                        @hResponseObj[:writerMissingIdCount] = @hResponseObj[:writerMissingIdCount].succ
-                        unitID = 'unit' + @hResponseObj[:writerMissingIdCount]
-                        @xml.tag!('gml:BaseUnit', {'gml:id' => unitID}) do
-                            @xml.tag!('gml:identifier', {'codeSpace' => hBase[:codeSpace]}, hBase[:identifier])
-                            @xml.tag!('gml:name', hBase[:name])
-                            @xml.tag!('gml:catalogSymbol', hBase[:catalogSymbol])
-                            @xml.tag!('gml:unitsSystem', {'xlink:href' => hBase[:unitsSystem]})
-                        end
+                  # create and identity for the unit
+                  @hResponseObj[:writerMissingIdCount] = @hResponseObj[:writerMissingIdCount].succ
+                  unitID = 'unit' + @hResponseObj[:writerMissingIdCount]
+                  @xml.tag!('gml:BaseUnit', {'gml:id' => unitID}) do
+                     @xml.tag!('gml:identifier', {'codeSpace' => hBase[:codeSpace]}, hBase[:identifier])
+                     @xml.tag!('gml:name', hBase[:name])
+                     @xml.tag!('gml:catalogSymbol', hBase[:catalogSymbol])
+                     @xml.tag!('gml:unitsSystem', {'xlink:href' => hBase[:unitsSystem]})
+                  end
 
-                    end
-
-                end
+               end
 
             end
-        end
-    end
+
+         end
+      end
+   end
 end

data/lib/adiwg/mdtranslator/writers/iso19110/classes/class_citation.rb

@@ -2,8 +2,10 @@
 # 19110 writer output in XML
 
 # History:
+#  Stan Smith 2018-03-30 refactored error and warning messaging
 # 	Stan Smith 2017-11-02 original script.
 
+require_relative '../iso19110_writer'
 require_relative 'class_codelist'
 require_relative 'class_responsibleParty'
 require_relative 'class_date'
@@ -20,6 +22,7 @@ module ADIWG
                def initialize(xml, hResponseObj)
                   @xml = xml
                   @hResponseObj = hResponseObj
+                  @NameSpace = ADIWG::Mdtranslator::Writers::Iso19110
                end
 
                def writeXML(hCitation)
@@ -38,7 +41,7 @@ module ADIWG
                         # citation - title (required)
                         s = hCitation[:title]
                         if s.nil?
-                           @xml.tag!('gmd:title', {'gco:nilReason' => 'missing'})
+                           @NameSpace.issueWarning(1, 'gmd:title')
                         else
                            @xml.tag!('gmd:title') do
                               @xml.tag!('gco:CharacterString', s)
@@ -64,7 +67,7 @@ module ADIWG
                            end
                         end
                         if aDate.empty?
-                           @xml.tag!('gmd:date', {'gco:nilReason' => 'missing'})
+                           @NameSpace.issueWarning(2,'gmd:date')
                         end
 
                         # citation - edition