adf_builder 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d362b1ad0b8a252bd6e941a5c1c2572b098d1b0fb98da0eed415fa3074297fff
-  data.tar.gz: 8319bcc2fd7289ac3e0dfd46be7deb46166b1b2b1cbea247ad1b5eeac2f86b87
+  metadata.gz: 440064d9196befba72c7a471b56db7a5b31f28b0521b7d2fbd0588e09fe9d0d9
+  data.tar.gz: fd917e6692abc141a2d1aa4e8c84c47b3ce7ce2ea3061cf6006364d8d51dbf9a
 SHA512:
-  metadata.gz: f49bb434697231563e420d4da2123b38370b61ac8b83ae5e6e6d7ad3517c6308acdd7a4db70e7a3866f5c578c4f2bd012a7830d94a69dc0ca8aacd6c941f9dbc
-  data.tar.gz: 5441957e0585459da711b7943e8e5d0eca3b4d596c54159178a71656c6a532c185dcf5395765eae75dbe46c3a6df5d8c80eb02a8e9101f1cc25b09698c32549f
+  metadata.gz: a1f11e9074f3a54daa855ac0a1ba732cc7924552ac717efda4f62d2db53aee311d960221eb226a163853a3f7aac52c05feabcdb4b6dc2af554288129123b42ab
+  data.tar.gz: 9a0f287c7182b673ce9230d01f609f0644e5e4094117a794aab5fc5f53a96b86f8115dd89357b0f07e7ccf9ff4e8e965128e2fe06aa6c9a3d6a1f6da9b906f7a

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [1.4.0] - 2026-01-19
+- **Vendor & Customer Validation Improvements**:
+  - `Vendor`: Now requires `vendorname` and `contact`.
+  - `Customer`: Now requires `contact`.
+  - `Contact`: Refactored to use declarative `validates_presence_of :name` (previously manual check).
+  - Added comprehensive specs for new presence validations.
+
+## [1.3.1] - 2026-01-19
+- **Validation Refinement**: `Address` now strictly enforces 1 to 5 `street` lines.
+
 ## [1.3.0] - 2026-01-19
 - **Customer & Contact Validations**:
   - `Contact`: Requires Name and at least one Phone or Email.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    adf_builder (1.2.2)
+    adf_builder (1.3.1)
       ox (~> 2.14)
 
 GEM

data/lib/adf_builder/nodes/customer.rb

@@ -7,6 +7,8 @@ module AdfBuilder
         super
         @tag_name = :customer
       end
+      validates_presence_of :contact
+
 
       def contact(&block)
         remove_children(:contact)

data/lib/adf_builder/nodes/shared.rb

@@ -66,10 +66,16 @@ module AdfBuilder
         @attributes[:type] = type if type
       end
 
-      def street(value, line: nil)
-        # Line validation 1-5
-        raise AdfBuilder::Error, "Street line must be 1-5" if line && !line.to_s.match?(/^[1-5]$/)
+      def validate!
+        super
+        streets = @children.select { |c| c.tag_name == :street }
+        raise AdfBuilder::Error, "Address must have at least one street line" if streets.empty?
+        return unless streets.size > 5
 
+        raise AdfBuilder::Error, "Address can have at most 5 street lines"
+      end
+
+      def street(value, line: nil)
         node = GenericNode.new(:street, { line: line }.compact, value)
         add_child(node)
       end
@@ -88,6 +94,7 @@ module AdfBuilder
 
     class Contact < Node
       validates_inclusion_of :primarycontact, in: [0, 1, "0", "1"]
+      validates_presence_of :name
 
       def initialize(primary_contact: nil)
         super()
@@ -97,9 +104,6 @@ module AdfBuilder
 
       def validate!
         super
-        # Custom Validation: Name is required
-        raise AdfBuilder::Error, "Contact must have a Name" unless @children.any? { |c| c.tag_name == :name }
-
         # Custom Validation: At least one Phone OR Email
         return if @children.any? { |c| %i[phone email].include?(c.tag_name) }
 

data/lib/adf_builder/nodes/vendor.rb

@@ -7,6 +7,7 @@ module AdfBuilder
         super
         @tag_name = :vendor
       end
+      validates_presence_of :vendorname, :contact
 
       def id(value, sequence: nil, source: nil)
         add_child(Id.new(value, sequence: sequence, source: source))

data/lib/adf_builder/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AdfBuilder
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adf_builder
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - marcus.salinas