adf_builder 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24b99369efbb491a84bd7a472de00624914228c6de3334e806ab46c7adbb9fa9
-  data.tar.gz: c9b0e631fa1118938a976d80e3be092d958c7fc35b7d2fe547bb291c4d4bbff9
+  metadata.gz: d362b1ad0b8a252bd6e941a5c1c2572b098d1b0fb98da0eed415fa3074297fff
+  data.tar.gz: 8319bcc2fd7289ac3e0dfd46be7deb46166b1b2b1cbea247ad1b5eeac2f86b87
 SHA512:
-  metadata.gz: 8e46cdda771a5c61882464d1e21a4e1117d156c13603877a7cb35e50bc0cd45ef480236a8aa2add261b983e5ed11142f655e9611e6f97cf04c7944305b6c3640
-  data.tar.gz: 4560e7057db7c62d8a6bdc90e3b5413c99ae273c5f70a1fd66d621e3a8c3d574ee80e619797c0faf32ce6a6c6fbfd33976fadc3cbda26d66c1a24e673b911447
+  metadata.gz: f49bb434697231563e420d4da2123b38370b61ac8b83ae5e6e6d7ad3517c6308acdd7a4db70e7a3866f5c578c4f2bd012a7830d94a69dc0ca8aacd6c941f9dbc
+  data.tar.gz: 5441957e0585459da711b7943e8e5d0eca3b4d596c54159178a71656c6a532c185dcf5395765eae75dbe46c3a6df5d8c80eb02a8e9101f1cc25b09698c32549f

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [1.3.0] - 2026-01-19
+- **Customer & Contact Validations**:
+  - `Contact`: Requires Name and at least one Phone or Email.
+  - `Address`: Validates Country against ISO 3166-1 alpha-2 codes.
+  - `Timeframe`: Validates ISO 8601 dates and requires earliest/latest date if present.
+  - `Phone/Email`: Enforces valid types and preference flags.
+
+## [1.2.2] - 2026-01-19
+- **Strict Validations**: Added ISO 4217 currency validation for `Price`, `Amount`, and `Balance`.
+
 ## [1.2.1] - 2026-01-19
 - **Strict Validations**: Added `presence` validation for `Vehicle` (year, make, model required).
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    adf_builder (1.2.0)
+    adf_builder (1.2.2)
       ox (~> 2.14)
 
 GEM

data/lib/adf_builder/nodes/customer.rb

@@ -39,20 +39,41 @@ module AdfBuilder
         @tag_name = :timeframe
       end
 
+      def validate!
+        super
+        # If timeframe is present, earliestdate or latestdate is required
+        return if @children.any? { |c| %i[earliestdate latestdate].include?(c.tag_name) }
+
+        raise AdfBuilder::Error, "Timeframe must have at least one of earliestdate or latestdate"
+      end
+
       def description(value)
         remove_children(:description)
         add_child(GenericNode.new(:description, {}, value))
       end
 
       def earliestdate(value)
+        validate_iso8601(value)
         remove_children(:earliestdate)
         add_child(GenericNode.new(:earliestdate, {}, value))
       end
 
       def latestdate(value)
+        validate_iso8601(value)
         remove_children(:latestdate)
         add_child(GenericNode.new(:latestdate, {}, value))
       end
+
+      private
+
+      def validate_iso8601(value)
+        # Simple ISO 8601 check (YYYY-MM-DDT...)
+        # Using a basic regex for now or standard library
+        require "date"
+        Date.iso8601(value.to_s)
+      rescue ArgumentError
+        raise AdfBuilder::Error, "Invalid ISO 8601 date: #{value}"
+      end
     end
   end
 end

data/lib/adf_builder/nodes/shared.rb

@@ -14,7 +14,14 @@ module AdfBuilder
       end
     end
 
+    # Common ISO 3166-1 alpha-2 codes
+    ISO_3166 = %w[US CA MX GB DE FR GR IT ES JP CN IN BR RU ZA AU NZ KR SE NO FI DK NL BE CH].freeze
+
     class Phone < Node
+      validates_inclusion_of :type, in: %i[phone fax cellphone pager]
+      validates_inclusion_of :time, in: %i[morning afternoon evening nopreference day]
+      validates_inclusion_of :preferredcontact, in: [0, 1, "0", "1"]
+
       def initialize(value, type: nil, time: nil, preferredcontact: nil)
         super()
         @tag_name = :phone
@@ -26,6 +33,8 @@ module AdfBuilder
     end
 
     class Email < Node
+      validates_inclusion_of :preferredcontact, in: [0, 1, "0", "1"]
+
       def initialize(value, preferredcontact: nil)
         super()
         @tag_name = :email
@@ -35,6 +44,9 @@ module AdfBuilder
     end
 
     class Name < Node
+      validates_inclusion_of :part, in: %i[first middle suffix last full]
+      validates_inclusion_of :type, in: %i[individual business]
+
       def initialize(value, part: nil, type: nil)
         super()
         @tag_name = :name
@@ -45,6 +57,9 @@ module AdfBuilder
     end
 
     class Address < Node
+      validates_inclusion_of :type, in: %i[work home delivery]
+      validates_inclusion_of :country, in: ISO_3166
+
       def initialize(type: nil)
         super()
         @tag_name = :address
@@ -52,6 +67,9 @@ module AdfBuilder
       end
 
       def street(value, line: nil)
+        # Line validation 1-5
+        raise AdfBuilder::Error, "Street line must be 1-5" if line && !line.to_s.match?(/^[1-5]$/)
+
         node = GenericNode.new(:street, { line: line }.compact, value)
         add_child(node)
       end
@@ -59,16 +77,33 @@ module AdfBuilder
       # Simple elements
       %i[apartment city regioncode postalcode country].each do |tag|
         define_method(tag) do |value|
+          if tag == :country && !ISO_3166.include?(value.to_s.upcase)
+            raise AdfBuilder::Error, "Invalid country code: #{value}"
+          end
+
           add_child(GenericNode.new(tag, {}, value))
         end
       end
     end
 
     class Contact < Node
-      def initialize(primary_contact: false)
+      validates_inclusion_of :primarycontact, in: [0, 1, "0", "1"]
+
+      def initialize(primary_contact: nil)
         super()
         @tag_name = :contact
-        # primary_contact might be useful for logic but not an attribute
+        @attributes[:primarycontact] = primary_contact if primary_contact
+      end
+
+      def validate!
+        super
+        # Custom Validation: Name is required
+        raise AdfBuilder::Error, "Contact must have a Name" unless @children.any? { |c| c.tag_name == :name }
+
+        # Custom Validation: At least one Phone OR Email
+        return if @children.any? { |c| %i[phone email].include?(c.tag_name) }
+
+        raise AdfBuilder::Error, "Contact must have at least one Phone or Email"
       end
 
       def name(value, part: nil, type: nil)

data/lib/adf_builder/nodes/vehicle_nodes.rb

@@ -67,10 +67,21 @@ module AdfBuilder
       end
     end
 
+    # Common ISO 4217 codes (Top valid ones per spec/common usage)
+    # Keeping it as a constant for reuse.
+    # This list can be expanded but covers major currencies.
+    ISO_4217 = %w[
+      USD EUR GBP JPY AUD CAD CHF CNY SEK NZD
+      MXN SGD HKD NOK KRW TRY RUB INR BRL ZAR
+      DKK PLN TWD THB IDR HUF CZK ILS CLP PHP
+      AED COP SAR MYR RON PEN VND NGN
+    ].freeze
+
     class Price < Node
       validates_inclusion_of :type, in: %i[quote offer msrp invoice call appraisal asking]
       validates_inclusion_of :delta, in: %i[absolute relative percentage]
       validates_inclusion_of :relativeto, in: %i[msrp invoice]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :quote, currency: nil, delta: nil, relativeto: nil, source: nil)
         super()
@@ -87,6 +98,7 @@ module AdfBuilder
     class Amount < Node
       validates_inclusion_of :type, in: %i[downpayment monthly total]
       validates_inclusion_of :limit, in: %i[maximum minimum exact]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :total, limit: :maximum, currency: nil)
         super()
@@ -100,6 +112,7 @@ module AdfBuilder
 
     class Balance < Node
       validates_inclusion_of :type, in: %i[finance residual]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :finance, currency: nil)
         super()

data/lib/adf_builder/validations.rb

@@ -31,7 +31,11 @@ module AdfBuilder
           next if value.nil?
 
           allowed = validation[:in]
-          unless allowed.include?(value)
+          # Normalize for comparison (allow string/symbol interchangeably)
+          value_s = value.to_s
+          allowed_s = allowed.map(&:to_s)
+
+          unless allowed_s.include?(value_s)
             raise AdfBuilder::Error,
                   "Invalid value for #{validation[:attribute]}: #{value}. Allowed: #{allowed.join(", ")}"
           end

data/lib/adf_builder/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AdfBuilder
-  VERSION = "1.2.1"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adf_builder
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - marcus.salinas