adf_builder 1.1.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ded72167a643d102957459b6d439bbaae8f01833303a3eca082ce4a6f0e264dd
-  data.tar.gz: 64486e697bd4feefa5fdbc8c6cbe01d3d0492878225748ffdf3c8ed1650b8b09
+  metadata.gz: f5c6497310cd559356bd6e358243d2dd2ed5d2a859330fe403ae959b32592b0b
+  data.tar.gz: 77e66f74d658adc2022d401d85a037549f8f92c91d984c265db337a33c05353c
 SHA512:
-  metadata.gz: b868564c56972b958839382c2d5c5706ce1b7864ea13e2c7eb38dddccb82f6481a66bc471f679f79589533a8fa9fd29897a387d53d4426ee8bc5490242912b45
-  data.tar.gz: 0c25a32fec2c3015e402fdbe26e0c2af23a2a91ea64840097a7a86acd7c88c4e89a809362b1ea35b8eebaa112dc130534b82f1a3647173ab5f0d1f3aa2b19fa0
+  metadata.gz: 8aba468994e77c3af346c7f6dccbdd4eed16fd858ccf6206226c90d97a5e1126d75bc5083440d40ce1ac3233d2b6f0395b899fcce70afc76ccba7691867e779f
+  data.tar.gz: 215970d63f001f71e21c55651368c9ebab28dafd9e5f26d19519dbff6c897ed4859443623f01d3a99a5c014743d00f8e74b351eda0b371d28e578edc744d5582

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [1.2.2] - 2026-01-19
+- **Strict Validations**: Added ISO 4217 currency validation for `Price`, `Amount`, and `Balance`.
+
+## [1.2.1] - 2026-01-19
+- **Strict Validations**: Added `presence` validation for `Vehicle` (year, make, model required).
+
+## [1.2.0] - 2026-01-19
+- **Strict Validations**: Added validation for `Vehicle` condition, `Option` weighting (range), `Finance` method, and required `ID` source.
+
 ## [1.1.0] - 2026-01-19
 - **Feature Complete**: Implemented all ADF 1.0 nodes and attributes including `Vendor`, `Provider`, and complex `Vehicle` tags (`Finance`, `Option`, `Odometer`, `ColorCombination`, `ImageTag`, `Price`).
 - **Singular Field logic**: Methods for singular fields (e.g. `vehicle.year`) now correctly replace existing values instead of appending.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    adf_builder (1.1.0)
+    adf_builder (1.2.1)
       ox (~> 2.14)
 
 GEM

data/lib/adf_builder/nodes/shared.rb

@@ -3,12 +3,14 @@
 module AdfBuilder
   module Nodes
     class Id < Node
-      def initialize(value, sequence: nil, source: nil)
+      def initialize(value, source:, sequence: nil)
         super()
+        raise ArgumentError, "Source is required" if source.nil?
+
         @tag_name = :id
         @value = value
         @attributes[:sequence] = sequence if sequence
-        @attributes[:source] = source if source
+        @attributes[:source] = source
       end
     end
 

data/lib/adf_builder/nodes/vehicle.rb

@@ -5,6 +5,7 @@ module AdfBuilder
     class Vehicle < Node
       validates_inclusion_of :status, in: %i[new used]
       validates_inclusion_of :interest, in: %i[buy lease sell trade-in test-drive]
+      validates_presence_of :year, :make, :model
 
       def initialize
         super
@@ -14,13 +15,19 @@ module AdfBuilder
       end
 
       # Simple Text Elements (Singular)
-      %i[year make model vin stock trim doors bodystyle transmission condition pricecomments comments].each do |tag|
+      # Simple Text Elements (Singular)
+      %i[year make model vin stock trim doors bodystyle transmission pricecomments comments].each do |tag|
         define_method(tag) do |value|
           remove_children(tag)
           add_child(GenericNode.new(tag, {}, value))
         end
       end
 
+      def condition(value)
+        remove_children(:condition)
+        add_child(Condition.new(value))
+      end
+
       def interest(value)
         @attributes[:interest] = value
       end

data/lib/adf_builder/nodes/vehicle_nodes.rb

@@ -26,10 +26,62 @@ module AdfBuilder
       end
     end
 
+    class Condition < Node
+      VALID_VALUES = %w[excellent good fair poor unknown].freeze
+
+      def initialize(value)
+        super()
+        @tag_name = :condition
+        unless VALID_VALUES.include?(value.to_s.downcase)
+          raise AdfBuilder::Error, "Invalid condition: #{value}. Must be one of: #{VALID_VALUES.join(", ")}"
+        end
+
+        @value = value
+      end
+    end
+
+    class Weighting < Node
+      def initialize(value)
+        super()
+        @tag_name = :weighting
+        int_val = value.to_i
+        unless int_val.between?(-100, 100)
+          raise AdfBuilder::Error, "Weighting must be between -100 and 100. Got: #{value}"
+        end
+
+        @value = value
+      end
+    end
+
+    class FinanceMethod < Node
+      VALID_VALUES = %w[cash finance lease].freeze
+
+      def initialize(value)
+        super()
+        @tag_name = :method
+        unless VALID_VALUES.include?(value.to_s.downcase)
+          raise AdfBuilder::Error, "Invalid finance method: #{value}. Must be one of: #{VALID_VALUES.join(", ")}"
+        end
+
+        @value = value
+      end
+    end
+
+    # Common ISO 4217 codes (Top valid ones per spec/common usage)
+    # Keeping it as a constant for reuse.
+    # This list can be expanded but covers major currencies.
+    ISO_4217 = %w[
+      USD EUR GBP JPY AUD CAD CHF CNY SEK NZD
+      MXN SGD HKD NOK KRW TRY RUB INR BRL ZAR
+      DKK PLN TWD THB IDR HUF CZK ILS CLP PHP
+      AED COP SAR MYR RON PEN VND NGN
+    ].freeze
+
     class Price < Node
       validates_inclusion_of :type, in: %i[quote offer msrp invoice call appraisal asking]
       validates_inclusion_of :delta, in: %i[absolute relative percentage]
       validates_inclusion_of :relativeto, in: %i[msrp invoice]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :quote, currency: nil, delta: nil, relativeto: nil, source: nil)
         super()
@@ -46,6 +98,7 @@ module AdfBuilder
     class Amount < Node
       validates_inclusion_of :type, in: %i[downpayment monthly total]
       validates_inclusion_of :limit, in: %i[maximum minimum exact]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :total, limit: :maximum, currency: nil)
         super()
@@ -59,6 +112,7 @@ module AdfBuilder
 
     class Balance < Node
       validates_inclusion_of :type, in: %i[finance residual]
+      validates_inclusion_of :currency, in: ISO_4217
 
       def initialize(value, type: :finance, currency: nil)
         super()
@@ -76,7 +130,8 @@ module AdfBuilder
       end
 
       def method(value)
-        add_child(GenericNode.new(:method, {}, value))
+        remove_children(:method)
+        add_child(FinanceMethod.new(value))
       end
 
       def amount(value, type: :total, limit: :maximum, currency: nil)
@@ -107,7 +162,7 @@ module AdfBuilder
       end
 
       def weighting(value)
-        add_child(GenericNode.new(:weighting, {}, value))
+        add_child(Weighting.new(value))
       end
 
       def price(value, **attrs)

data/lib/adf_builder/serializer.rb

@@ -4,8 +4,10 @@ require "ox"
 
 module AdfBuilder
   class Serializer
-    def self.to_xml(node)
-      new(node).to_xml
+    class << self
+      def to_xml(root_node)
+        new(root_node).to_xml
+      end
     end
 
     def initialize(root_node)
@@ -13,7 +15,10 @@ module AdfBuilder
     end
 
     def to_xml
-      doc = Ox::Document.new
+      # Validate the entire tree before serializing to ensure data integrity
+      @root_node.validate!
+
+      doc = Ox::Document.new(version: "1.0")
 
       # XML Instruction
       instruct = Ox::Instruct.new(:xml)

data/lib/adf_builder/validations.rb

@@ -12,6 +12,13 @@ module AdfBuilder
         @validations << { type: :inclusion, attribute: attribute, in: binding.local_variable_get(:in) }
       end
 
+      def validates_presence_of(*attributes)
+        @validations ||= []
+        attributes.each do |attr|
+          @validations << { type: :presence, attribute: attr }
+        end
+      end
+
       def validations
         @validations || []
       end
@@ -19,15 +26,22 @@ module AdfBuilder
 
     def validate!
       self.class.validations.each do |validation|
-        value = @attributes[validation[:attribute]]
-        next if value.nil? # Allow nil unless presence validation is added
-
-        next unless validation[:type] == :inclusion
+        if validation[:type] == :inclusion
+          value = @attributes[validation[:attribute]]
+          next if value.nil?
 
-        allowed = validation[:in]
-        unless allowed.include?(value)
-          raise AdfBuilder::Error,
-                "Invalid value for #{validation[:attribute]}: #{value}. Allowed: #{allowed.join(", ")}"
+          allowed = validation[:in]
+          unless allowed.include?(value)
+            raise AdfBuilder::Error,
+                  "Invalid value for #{validation[:attribute]}: #{value}. Allowed: #{allowed.join(", ")}"
+          end
+        elsif validation[:type] == :presence
+          # Check children for a node with tag_name == attribute
+          target_tag = validation[:attribute]
+          found = @children.any? { |c| c.tag_name == target_tag }
+          unless found
+            raise AdfBuilder::Error, "Missing required Element: #{target_tag} in #{tag_name || self.class.name}"
+          end
         end
       end
 

data/lib/adf_builder/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AdfBuilder
-  VERSION = "1.1.0"
+  VERSION = "1.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adf_builder
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.2
 platform: ruby
 authors:
 - marcus.salinas