address-matcher 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d2d27af283ba186e00ff6ddbb3055b509b8e0b4
-  data.tar.gz: 5ceafeb2391eb02c0b3b037f5142f4b8e6082024
+  metadata.gz: a5ad7065d7364b08e5790c9a167dfd7cf8ac4f2b
+  data.tar.gz: d45880a4f355aa72a7e60f32eb751073fea926d5
 SHA512:
-  metadata.gz: 106dc2f97921d4cf2c5a0d19a815574477ca537106bad49e2cd67eb03ae7e75411a96ad91f21e4f77e1e6e2d6f637e8e9724c94983d8271c7200466e1b5b25a2
-  data.tar.gz: a0b5921cb6120bfae41c0e630c813fee91f28d968b4f3049f1f2280a2a401306be8faa1b0308b5f2bcf797e6a9195c04f470925e7495730214a9ce2b642f0d22
+  metadata.gz: 4c22c19bbf32d8695713f82741f90c3d43b49c5f08324dc818da039e3fd5433997503cab82e1912f5f65c7683507ab05a63a9513d03409d0ddc39f766dda48cc
+  data.tar.gz: ab353263bf9c8223dbcce9ca2c504b3b0cdff1571d2bfd2a3d2f95ee06033d741246131f1d8b8878787c060a60801ac177d2118164aaf365c911afb765ecf111

data/README.md

@@ -10,9 +10,9 @@ if they are close enough.
 
 ## Usage
 
-`$ gem install address_matcher`
+`$ gem install address-matcher`
 
-`require address_matcher`
+`require address-matcher`
 
 Create an `AddressLibrary` with all of the "known" address strings that you want
 to match against:

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/address_matcher.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'address-matcher'
-  s.version     = '0.1.0'
+  s.version     = '0.1.1'
   s.date        = '2015-04-07'
   s.summary     = "Matches addresses by geocoding"
   s.description = "Uses geocoding to perform fuzzy match on address strings"

data/lib/address_matcher/address_library.rb

@@ -15,7 +15,9 @@ class AddressLibrary
 
   def add_address(address_string)
     coords = geocode(address_string)
-    store[latitude_index(coords)][longitude_index(coords)][coords] = address_string
+    if coords
+      store[latitude_index(coords)][longitude_index(coords)][coords] = address_string
+    end
     self
   end
 
@@ -25,17 +27,20 @@ class AddressLibrary
 
   def match(address_string)
     coords = geocode(address_string)
-    group = store[latitude_index(coords)][longitude_index(coords)]
-    group.match(coords)
+    if coords
+      group = store[latitude_index(coords)][longitude_index(coords)]
+      group.match(coords)
+    end
   end
 
   private
   attr_reader :store
 
   def geocode(address_string)
-    Geocoder.search(address_string)
-            .first
-            .coordinates
+    response = Geocoder.search(address_string).first
+    if response
+      response.coordinates
+    end
   end
 
   def latitude_index(coords)

data/spec/address_library_spec.rb

@@ -24,6 +24,12 @@ describe AddressLibrary do
     )
   end
 
+  it 'does not add an address if the geocode does not return coordinates' do
+    expect do
+      AddressLibrary.new.add_address(not_found.address)
+    end.not_to raise_error
+  end
+
   it 'adds multiple nearby addresses to the same AddressGroup' do
     lib = AddressLibrary.new
                         .add_address(met_art_avenue.address)
@@ -120,5 +126,21 @@ describe AddressLibrary do
       expect(match_1).to eq met_art_ave.address
       expect(match_2).to eq met_opera_short.address
     end
+
+    it 'returns nil if there are no addresses near enough to match' do
+      lib = AddressLibrary.new.add_address(met_opera_short.address)
+
+      match = lib.match(boco.address)
+
+      expect(match).to be_nil
+    end
+
+    it 'returns nil if the address cannot geocode' do
+      lib = AddressLibrary.new.add_address(met_opera_short.address)
+
+      match = lib.match(not_found.address)
+
+      expect(match).to be_nil
+    end
   end
 end

data/spec/support/geocoder.rb

@@ -9,6 +9,10 @@ module Locations
       OpenStruct.new(data.merge(coords: [data['latitude'], data['longitude']]))
     end
   end
+
+  define_method :not_found do
+    OpenStruct.new(address: '123 Main St. Mars')
+  end
 end
 
 Locations::TEST_DATA.values.each do |location|
@@ -25,3 +29,5 @@ Locations::TEST_DATA.values.each do |location|
     ]
   )
 end
+
+Geocoder::Lookup::Test.add_stub('123 Main St. Mars', [])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: address-matcher
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Stuart Terrett