additional_tags 1.0.6 → 3.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05656ef90d3c7c796b1bd3d510f6a349fc77c8b1adbf43ca6135af8e48ca705e
-  data.tar.gz: a22552cd9d096d6963dd9349c207da4755b1e3ba1d8dec560d404b3207ee1458
+  metadata.gz: c412788c20ba3626ad2707dea2a34a96b9d2e0378c70b55bd5b8f116d92dc8cf
+  data.tar.gz: 6b2dd7625fe8b4e4249631bee75ad0e2a0f1be4a481382e1f346026683059246
 SHA512:
-  metadata.gz: 2eb18bdccf79be5d1f1b4327c11c3c838e434c8737edcfa096d62d61925170e53be4a6ae45fb486e0c5b3a008933dc30e3bd2c36de9db929fe1fb1e71225adf2
-  data.tar.gz: 97fd974a51bcdf337c0246cd95c0313639d43aa73f19ac9a81f0f9efa87da0e3c02736970b5c8148566ded5bb3e670a2fb332a03f99d85f59caed219d12410be
+  metadata.gz: 9293e12799c232dca72262bf3af55c84a23481e0fd1b0c6a38199f145ce3f7dca95ee218bb661f764eb49251de602abaefef41dc4da1463f4e97714097d0aa93
+  data.tar.gz: 57377f76241c07b63651ddece4ee6a14f983dd1faea0544b2d7ca5e3453a302142b19442252b6d71c1884c54fed4083eb84f818dc72e0b0f91927de39b381b8f

data/README.md

@@ -4,16 +4,35 @@
 
 ## Features
 
-- Tags for issues
-- Tags for wiki pages
+- Tags for issues. To use them you need to:
+  -  *Activate issue tags* in the plugin configuration
+  -  and update your role permissions in the Redmine administration *Roles & permissions / Issue tracking*.
+- Tags for wiki pages. To use them  you need to:
+  - *Activate wiki tags* in the plugin configuration 
+  -  and update your role permissions in the Redmine administration *Roles & permissions / Wiki*
+- Available role permissions for issue tags (section *Issue tracking*): 
+  - Add issue tags
+  - Edit issue tags
+  - Display issue tags
+- Available role permissions wiki tags (section *Wiki*):
+  - Add wiki tags
+- Managing tags centrally in the plugin settings (edit, delete, merge)- 
+- Grouped tags.
+  - Grouping of tags possible, when using a colon in tag (all tags with same base name get the same color). Typo example: ``Plugin:HRM``
+- Scoped tags:
+  - Grouping of tags via *Scoped tags* possible, when using two colons in tag. Typo example: ``Product::Sprint 1``
+  - Only one tag of the same base name is allowed for an entity
+  - Base name and tag value are displayed seperatly
 - Accented and non-latin characters supported for tag order
-- View, edit and create tag permissions for issues
-- Create permission for wiki tags
-- Managing tags
-- Custom tags and tagging tables (additional_tags and additional_taggings). If a other plugin
-  used tags or tagging tables for issue or wiki tagging, there tags will be migrated automatically
+- Color theme selection possible
+- Custom tags and tagging tables (additional_tags and additional_taggings). If another plugin
+  used tags or tagging tables for issue or wiki tagging, tags will be migrated automatically there
 - Based on the very popular [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on)
 
+![screenshot](https://raw.githubusercontent.com/AlphaNodes/additional_tags/master/doc/images/tag-overview.png)
+
+The screenshot shows: regular tags, grouped tags and scoped tags. The colors are assigned randomly. But you can change the color by choosing a *Color theme* in the plugin settings.
+
 ![screenshot](https://raw.githubusercontent.com/AlphaNodes/additional_tags/master/doc/images/additional-tags.gif)
 
 Other plugins use additional_tags as framework in order to support tags for their entities.

data/app/controllers/additional_tags_controller.rb

@@ -33,15 +33,6 @@ class AdditionalTagsController < ApplicationController
 
   def edit; end
 
-  def destroy
-    @tags.each do |tag|
-      tag.reload.destroy!
-    rescue ::ActiveRecord::RecordNotFound, ::ActiveRecord::RecordNotDestroyed
-      Rails.logger.warn "Tag #{tag} could not be deleted"
-    end
-    redirect_back_or_default @tag_list_path
-  end
-
   def update
     @tag.name = params[:tag][:name] if params[:tag]
     if @tag.save
@@ -59,6 +50,15 @@ class AdditionalTagsController < ApplicationController
     end
   end
 
+  def destroy
+    @tags.each do |tag|
+      tag.reload.destroy!
+    rescue ::ActiveRecord::RecordNotFound, ::ActiveRecord::RecordNotDestroyed
+      Rails.logger.warn "Tag #{tag} could not be deleted"
+    end
+    redirect_back_or_default @tag_list_path
+  end
+
   def context_menu
     @tag = @tags.first if @tags.size == 1
     @back = back_url

data/app/controllers/issue_tags_controller.rb

@@ -19,6 +19,7 @@ class IssueTagsController < ApplicationController
 
     @issue_tags.sort!
     @most_used_tags = Issue.available_tags.most_used 10
+    @append = params[:append] == 'true'
   end
 
   def update
@@ -33,7 +34,11 @@ class IssueTagsController < ApplicationController
 
       Issue.transaction do
         @issues.each do |issue|
-          issue.tag_list = tags
+          issue.init_journal User.current
+          # add tags added in placeholder for a single/multiple issue or overwrite tags for single issue
+          params[:append] == 'true' ? issue.tag_list << tags : issue.tag_list = tags
+
+          issue.tags_to_journal issue.tag_list_was&.to_s, issue.tag_list.to_s
           issue.save!
         end
       end

data/app/helpers/additional_tags_helper.rb

@@ -53,7 +53,7 @@ module AdditionalTagsHelper
     when 'name:desc'
       tags = AdditionalTags::Tags.sort_tag_list(tags).reverse
     when 'count:asc'
-      tags.sort! { |a, b| a.count <=> b.count }
+      tags.sort_by!(&:count)
     when 'count:desc'
       tags.sort! { |a, b| b.count <=> a.count }
     else
@@ -66,7 +66,11 @@ module AdditionalTagsHelper
   def render_tags_list(tags, **options)
     return if tags.blank?
 
-    style = options.delete :style
+    options[:show_count] = AdditionalTags.setting? :show_with_count unless options.key? :show_count
+    options[:color_theme] = AdditionalTags.setting :tags_color_theme unless options.key? :color_theme
+    options[:use_colors] = AdditionalTags.use_colors? unless options.key? :use_colors
+
+    style = options.key?(:style) ? options.delete(:style) : AdditionalTags.setting(:tags_sidebar).to_sym
     tags = tags.all.to_a if tags.respond_to? :all
     tags = sort_tags_for_list tags
 
@@ -94,22 +98,36 @@ module AdditionalTagsHelper
     content_tag(list_el, content, class: 'tags-cloud', style: (style == :simple_cloud ? 'text-align: left;' : ''))
   end
 
-  def additional_tag_link(tag_object, link: nil, link_wiki_tag: false, show_count: false, use_colors: nil, name: nil, **options)
-    tag_name = []
-    tag_name << if name.nil?
-                  tag_object.name
-                else
-                  name
-                end
-
+  def additional_tag_link(tag_object,
+                          link: nil,
+                          link_wiki_tag: false,
+                          show_count: false,
+                          use_colors: nil,
+                          name: nil,
+                          color_theme: nil,
+                          **options)
     options[:project] = @project if options[:project].blank? && @project.present?
-    use_colors = AdditionalTags.setting? :use_colors if use_colors.nil?
+    if !options.key?(:display_type) && @query && @query.display_type != @query.default_display_type
+      options[:display_type] = @query.display_type
+    end
+
+    use_colors = AdditionalTags.use_colors? if use_colors.nil?
+    color_theme = AdditionalTags.setting :tags_color_theme if color_theme.nil?
+
+    tag_info = AdditionalTag.new name: name.nil? ? tag_object.name : name,
+                                 disable_grouping: !use_colors,
+                                 color_theme: color_theme
+    tag_name = [tag_info.tag_name]
+
+    tag_style = "background-color: #{tag_info.tag_bg_color}; color: #{tag_info.tag_fg_color}" if use_colors
 
-    tag_style = if use_colors
-                  tag_bg_color = additional_tag_color tag_object.name
-                  tag_fg_color = additional_tag_fg_color tag_bg_color
-                  "background-color: #{tag_bg_color}; color: #{tag_fg_color}"
-                end
+    if tag_info.scoped?
+      tag_name << if show_count
+                    tag.span tag_info.group_value, class: 'tag-group-value'
+                  else
+                    tag.span tag_info.group_value, class: 'tag-group-value tag-group-nocount'
+                  end
+    end
 
     tag_name << tag.span(tag_object.count, class: 'tag-count') if show_count
 
@@ -139,20 +157,6 @@ module AdditionalTagsHelper
     tag.span content, **style
   end
 
-  def additional_tag_color(tag_name)
-    "##{Digest::SHA256.hexdigest(tag_name)[0..5]}"
-  end
-
-  def additional_tag_fg_color(bg_color)
-    # calculate contrast text color according to YIQ method
-    # https://24ways.org/2010/calculating-color-contrast/
-    # https://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color
-    r = bg_color[1..2].hex
-    g = bg_color[3..4].hex
-    b = bg_color[5..6].hex
-    (r * 299 + g * 587 + b * 114) >= 128_000 ? 'black' : 'white'
-  end
-
   # plain list of tags
   def additional_plain_tag_list(tags, sep: nil)
     sep ||= "#{Query.additional_csv_separator} "
@@ -177,12 +181,16 @@ module AdditionalTagsHelper
     unsorted = options.delete :unsorted
     tag_list = AdditionalTags::Tags.sort_tag_list tag_list unless unsorted
 
+    # set defaults if not defined
+    options[:use_colors] = AdditionalTags.use_colors? unless options.key? :use_colors
+    options[:color_theme] = AdditionalTags.setting :tags_color_theme unless options.key? :color_theme
+
     safe_join tag_list.map { |tag| additional_tag_link tag, **options },
               additional_tag_sep(use_colors: options[:use_colors])
   end
 
   def link_to_issue_tags_totals(entries:, project:, open_issues_only:)
-    sum = if entries.blank? || entries.size.zero?
+    sum = if entries.blank? || entries.empty?
             0
           else
             query = IssueQuery.new project: project, name: '_'
@@ -208,7 +216,7 @@ module AdditionalTagsHelper
 
   private
 
-  def tag_url(tag_name, filter: nil, tag_action: nil, tag_controller: nil, project: nil)
+  def tag_url(tag_name, filter: nil, tag_action: nil, tag_controller: nil, project: nil, display_type: nil)
     action = tag_action.presence || (controller_name == 'hrm_user_resources' ? 'show' : 'index')
 
     fields = [:tags]
@@ -225,6 +233,7 @@ module AdditionalTagsHelper
     { controller: tag_controller.presence || controller_name,
       action: action,
       set_filter: 1,
+      display_type: display_type,
       project_id: project,
       f: fields,
       v: values,

data/app/helpers/additional_tags_issues_helper.rb

@@ -10,8 +10,18 @@ module AdditionalTagsIssuesHelper
        AdditionalTags.setting?(:active_issue_tags) && User.current.allowed_to?(:view_issue_tags, @project)
 
       api.array :tags do
-        @issue.tags.each do |tag|
-          api.tag id: tag.id, name: tag.name
+        # support tags, which are not saved to database
+        if @issue.tag_list.present?
+          if @issue.tags.present? && @issue.tags.map(&:name) == @issue.tag_list
+            @issue.tags.each do |tag|
+              api.tag id: tag.id, name: tag.name
+            end
+          else
+            @issue.tag_list.each do |tag_name|
+              # there is no id for unsaved tags
+              api.tag name: tag_name
+            end
+          end
         end
       end
     end
@@ -44,9 +54,7 @@ module AdditionalTagsIssuesHelper
   end
 
   def render_sidebar_tags
-    options = { show_count: AdditionalTags.setting?(:show_with_count),
-                filter: AdditionalTags.setting?(:open_issues_only) ? { field: :status_id, operator: 'o' } : nil,
-                style: AdditionalTags.setting(:tags_sidebar).to_sym,
+    options = { filter: AdditionalTags.setting?(:open_issues_only) ? { field: :status_id, operator: 'o' } : nil,
                 project: @project }
 
     options[:tag_action] = 'show' if %w[gantts calendars].include? controller_name

data/app/helpers/additional_tags_wiki_helper.rb

@@ -10,9 +10,7 @@ module AdditionalTagsWikiHelper
   end
 
   def render_sidebar_tags
-    options = { show_count: AdditionalTags.setting?(:show_with_count),
-                style: AdditionalTags.setting(:tags_sidebar).to_sym,
-                link_wiki_tag: true,
+    options = { link_wiki_tag: true,
                 project: @project }
 
     render_tags_list sidebar_tags, **options
@@ -20,12 +18,15 @@ module AdditionalTagsWikiHelper
 
   def render_wiki_index_title(project: nil, name: nil, tag: nil, title: :label_wiki)
     if tag.present?
+      tag_object = ActsAsTaggableOn::Tag.new name: tag
+
       if project
-        t :label_wiki_index_for_tag_html, tag: tag
+        safe_join [l(:label_wiki_index_for_tag), additional_tag_link(tag_object, link: '#')], ' '
       else
         title = [link_to(l(title), wiki_index_path)]
         title << Additionals::LIST_SEPARATOR
-        title << t(:label_wiki_index_for_tag_html, tag: tag)
+        title << l(:label_wiki_index_for_tag)
+        title << additional_tag_link(tag_object, link: '#')
         safe_join title, ' '
       end
     elsif name.present?

data/app/models/additional_tag.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+class AdditionalTag
+  GROUP_SEP = ':'
+  SCOPE_SEP = '::'
+
+  class << self
+    def valid_mutually_exclusive_tag(tag_list)
+      return true if tag_list.blank?
+
+      tags = tag_list.select { |t| t.include? SCOPE_SEP }
+      return true if tags.blank?
+
+      groups = tags.map { |t| new(name: t).group_name }
+      groups == groups.uniq
+    end
+  end
+
+  # NOTE: only use bg_color parameter, if background color should not
+  #       calculated by AdditionalTag - if you want to assign manual color
+  def initialize(name:, disable_grouping: false, color_theme: nil, bg_color: nil)
+    @tag_name = name.to_s
+    @disable_grouping = disable_grouping
+    @color_theme = color_theme.to_s
+    @bg_color = bg_color
+  end
+
+  def name_for_color
+    # different colors for non-grouped, grouped and scoped tag
+    name = if scoped? || grouped?
+             "#{group_name}#{sep}"
+           else
+             tag_name
+           end
+
+    if @color_theme.present? && @color_theme != '0' && @color_theme != '1'
+      "#{name}#{@color_theme}"
+    else
+      name
+    end
+  end
+
+  def tag_bg_color
+    @tag_bg_color ||= @bg_color || "##{Digest::SHA256.hexdigest(name_for_color)[0..5]}"
+  end
+
+  # calculate contrast text color according to YIQ method
+  # https://24ways.org/2010/calculating-color-contrast/
+  # https://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color
+  def tag_fg_color
+    @tag_fg_color ||= begin
+      r = tag_bg_color[1..2].hex
+      g = tag_bg_color[3..4].hex
+      b = tag_bg_color[5..6].hex
+      (r * 299 + g * 587 + b * 114) >= 128_000 ? 'black' : 'white'
+    end
+  end
+
+  def sep
+    scoped? ? SCOPE_SEP : GROUP_SEP
+  end
+
+  def tag_name
+    scoped? ? group_name : @tag_name
+  end
+
+  def labels
+    @labels ||= scoped? ? scope_labels : group_labels
+  end
+
+  def scope_labels
+    @scope_labels ||= @tag_name.split(SCOPE_SEP).map(&:strip)
+  end
+
+  def group_labels
+    @group_labels ||= @tag_name.split(GROUP_SEP).map(&:strip)
+  end
+
+  def group_name
+    if labels.length > 2
+      labels[0...-1].join sep
+    else
+      labels.first
+    end
+  end
+
+  def group_value
+    labels.last
+  end
+
+  def scoped?
+    !@disable_grouping && scope_labels.length > 1
+  end
+
+  def grouped?
+    !@disable_grouping && group_labels.length > 1
+  end
+end

data/app/views/additional_tags/_tag_list.html.slim

@@ -15,17 +15,23 @@
         span.contextual
           = link_to l(:label_edit_tags),
                     {},
-                    onclick: "$('#edit_tags_form').show(); $('#tags-data').hide(); return false;",
-                    id: 'edit_tags_link'
+                    onclick: "$('#edit-tags-form').show(); $('#tags-data').hide(); return false;",
+                    id: 'edit-tags-link'
 
-      #edit_tags_form.hidden
+      #edit-tags-form.hidden
         = form_tag update_url, method: :put do
           = render defined?(tags_form) ? tags_form : 'tags_form',
                    css_id: defined?(css_id) ? css_id : nil
           '
           = submit_tag l(:button_save), class: 'button-small'
           '
-          = link_to l(:button_cancel), {}, onclick: "$('#edit_tags_form').hide(); $('#tags-data').show(); return false;"
+          = link_to l(:button_cancel), {}, onclick: "$('#edit-tags-form').hide(); $('#tags-data').show(); return false;"
+
+      javascript:
+        $(function() {
+          var eventSelect = $('#issue_tag_list');
+          eventSelect.on('select2:close', function(e) { fixScopedTags(e, eventSelect); });
+        })
 
     - else
       = additional_tag_links entry.tags,

data/app/views/additional_tags/merge.html.slim

@@ -8,7 +8,6 @@ h2
   = error_messages_for 'tag'
   = additional_tag_links @tags,
                          show_count: true,
-                         use_colors: AdditionalTags.setting?(:use_colors),
                          link: '#'
   .box
     p

data/app/views/additional_tags/settings/_general.html.slim

@@ -23,7 +23,13 @@ fieldset.settings
                                   options_for_select(%w[name last_created count].collect { |v| [l("tags_order_by_#{v}"), v] },
                                                      @settings['tags_suggestion_order'])
   p
-    = additionals_settings_checkbox :use_colors
+    = additionals_settings_select :tags_color_theme, options_for_select([[l(:label_tags_without_color), '0'],
+                                                                         [l(:label_tag_color_theme, value: 1), '1'],
+                                                                         [l(:label_tag_color_theme, value: 2), 'a'],
+                                                                         [l(:label_tag_color_theme, value: 3), 'b'],
+                                                                         [l(:label_tag_color_theme, value: 4), 'c'],
+                                                                         [l(:label_tag_color_theme, value: 5), 'd']],
+                                                                        @settings['tags_color_theme'])
 
 fieldset.settings
   legend = l :label_issue_plural

data/app/views/additional_tags/settings/_manage_tags.html.slim

@@ -13,11 +13,18 @@
             th = column_values[:label]
           th
       tbody
+        - use_colors = AdditionalTags.use_colors?
+        - color_theme = AdditionalTags.setting :tags_color_theme
         - tags.each do |tag|
           tr.hascontextmenu id="#{tag.id}"
             td.checkbox.hide-when-print
               = check_box_tag 'ids[]', tag.id, false, id: nil
-            td = additional_tag_link tag, link: edit_additional_tag_path(tag)
+            td
+              = additional_tag_link tag,
+                                    link: edit_additional_tag_path(tag),
+                                    use_colors: use_colors,
+                                    color_theme: color_theme
+
             - manageable_tag_column_values(tag).each do |column|
               td = column
             td.buttons

data/app/views/context_menus/_issues_tags.html.slim

@@ -5,6 +5,12 @@
     ul
       li
         = context_menu_link l(:button_add),
-                            edit_issue_tags_path(ids: @issue_ids, search: params[:search]),
+                            edit_issue_tags_path(ids: @issue_ids, search: params[:search], append: 'true'),
                             remote: true,
                             class: 'icon icon-add'
+      - if @issue_ids.size == 1
+        li
+          = context_menu_link l(:button_edit),
+                              edit_issue_tags_path(ids: @issue_ids, search: params[:search]),
+                              remote: true,
+                              class: 'icon icon-edit'

data/app/views/dashboards/blocks/_issue_tags.html.slim

@@ -28,13 +28,15 @@ h3 = block_definition[:label]
             th = l :label_closed_issues_plural
             th = l :label_total
       tbody
+        - color_theme = AdditionalTags.setting :tags_color_theme
         - tags.each do |tag|
           tr
             td.name = additional_tag_link tag,
                                           tag_action: 'index',
                                           tag_controller: 'issues',
                                           filter: issue_tag_status_filter(open_issues_only: open_issues_only),
-                                          use_colors: RedminePluginKit.true?(settings[:use_colors])
+                                          use_colors: RedminePluginKit.true?(settings[:use_colors]),
+                                          color_theme: color_theme
             - unless open_issues_only
               td.value = additional_tag_link tag,
                                              tag_action: 'index',

data/app/views/issue_tags/_edit_modal.html.slim

@@ -1,4 +1,4 @@
-h3.title = l :label_add_tags
+h3.title = @append ? l(:label_add_tags) : l(:label_edit_tags)
 
 - if @is_bulk_editing
   h3 = l :label_bulk_edit_selected_issues
@@ -9,24 +9,24 @@ h3.title = l :label_add_tags
   h3
     span = link_to_issue @issues.first
 
-= form_tag issue_tags_path(ids: @issue_ids, search: params[:search]) do
+= form_tag issue_tags_path(ids: @issue_ids, search: params[:search], append: @append.to_s) do
   fieldset.box
     legend = l :field_tags
     #issue_tags
       = additionals_select2_tag 'issue[tag_list]',
-                                options_for_select(@issue_tags.map { |tag| [tag, tag] }, @issue_tags),
+                                options_for_select(@append ? {} : @issue_tags.map { |tag| [tag, tag] }, @issue_tags),
                                 multiple: true,
                                 style: 'width: 100%;',
                                 url: issue_tags_auto_completes_path(project_id: @project),
                                 placeholder: @is_bulk_editing ? t(:label_no_change_option) : '+ add tag',
                                 tags: User.current.allowed_to?(:create_issue_tags, @project)
-    p.most_used_tags
-      = safe_join @most_used_tags.collect { |t| tag.span t.name, class: 'most_used_tag' }, ', '
+    p.most-used-tags
+      = safe_join @most_used_tags.collect { |t| tag.span t.name, class: 'most-used-tag' }, ', '
 
   .buttons
-    = submit_tag l(:button_add), name: nil
+    = submit_tag l(@append ? :button_add : :button_save), name: nil
     '
-    = link_to_function l(:button_cancel), 'hideModal(this);'
+    = link_to_function l(:button_cancel), 'hideModal(this)'
 
 javascript:
   var mostUsedTags = #{raw @most_used_tags.map(&:name)};

data/app/views/issues/_tags.html.slim

@@ -5,4 +5,9 @@
            editable: issue.editable?(User.current),
            css_id: 'issue_tag_list_show',
            update_url: issue_path(issue),
-           use_colors: AdditionalTags.setting?(:use_colors)
+           use_colors: AdditionalTags.use_colors?
+
+  - if issue.editable? User.current
+    javascript:
+      var eventSelect = $('#issue_tag_list_show');
+      eventSelect.on('select2:close', function(e) { fixScopedTags(e, eventSelect); });

data/app/views/issues/_tags_bulk_edit.html.slim

@@ -1,7 +1,8 @@
-- tags = defined?(form) ? form.object.tag_list : []
+- tags = Issue.common_tag_list_from_issues(@issues.map(&:id))
 = additionals_select2_tag 'issue[tag_list]',
                            options_for_select(tags.map { |tag| [tag, tag] }, tags),
                            multiple: true,
                            url: issue_tags_auto_completes_path,
                            placeholder: l(:label_add_tags),
                            tags: true
+= hidden_field_tag 'common_tags', tags.to_s

data/app/views/wiki/_tags_form.html.slim

@@ -5,3 +5,7 @@
                           url: wiki_tags_auto_completes_path(project_id: @project),
                           placeholder: l(:label_add_tags),
                           tags: true
+
+javascript:
+  var eventSelect = $('#wiki_page_tag_list');
+  eventSelect.on('select2:close', function(e) { fixScopedTags(e, eventSelect); });

data/app/views/wiki/_tags_show.html.slim

@@ -6,4 +6,4 @@
              link_wiki_tag: true,
              editable: User.current.allowed_to?(:add_wiki_tags, @project),
              update_url: update_tags_project_wiki_page_path(@project, page.title),
-             use_colors: AdditionalTags.setting?(:use_colors)
+             use_colors: AdditionalTags.use_colors?

data/assets/javascripts/tags.js

@@ -1,6 +1,6 @@
 /* global mostUsedTags:writable */
 $(function() {
-  $('body').on('click', '.most_used_tags .most_used_tag', function(e) {
+  $('body').on('click', '.most-used-tags .most-used-tag', function(e) {
     var $tagsSelect = $('select#issue_tag_list');
     var tag = e.target.innerText;
     if ($tagsSelect.find('option[value=\'' + tag + '\']').length === 0) {
@@ -10,10 +10,10 @@ $(function() {
 
     mostUsedTags = $.grep(mostUsedTags, function(t) { return t != tag; });
     var tagsHtml = mostUsedTags.map(function(tag) {
-      return '<span class="most_used_tag">' + tag + '</span>';
+      return '<span class="most-used-tag">' + tag + '</span>';
     }).join(', ');
 
-    var $mostUsedTagsContainer = $(e.target).parent('.most_used_tags');
+    var $mostUsedTagsContainer = $(e.target).parent('.most-used-tags');
     $mostUsedTagsContainer.empty();
     $mostUsedTagsContainer.append(tagsHtml);
   });