additional_tags 1.0.1 → 1.0.4

data/app/helpers/additional_tags_helper.rb

@@ -1,4 +1,4 @@
-require 'digest/md5'
+# frozen_string_literal: true
 
 module AdditionalTagsHelper
   include ActsAsTaggableOn::TagsHelper
@@ -12,15 +12,15 @@ module AdditionalTagsHelper
 
     columns = {}
 
-    if AdditionalTags.setting?(:active_issue_tags)
+    if AdditionalTags.setting? :active_issue_tags
       columns[:issue] = { label: l(:label_issue_plural),
                           tag_controller: :issues,
-                          counts: Issue.available_tags.map { |tag| [tag.id, tag.count] }.to_h }
+                          counts: Issue.available_tags.to_h { |tag| [tag.id, tag.count] } }
     end
 
-    if AdditionalTags.setting?(:active_wiki_tags)
+    if AdditionalTags.setting? :active_wiki_tags
       columns[:wiki] = { label: l(:label_wiki),
-                         counts: WikiPage.available_tags.map { |tag| [tag.id, tag.count] }.to_h }
+                         counts: WikiPage.available_tags.to_h { |tag| [tag.id, tag.count] } }
     end
 
     call_hook :helper_additional_manageable_tag_columns, columns: columns
@@ -43,13 +43,13 @@ module AdditionalTagsHelper
     columns
   end
 
-  def render_tags_list(tags, options = {})
-    return if tags.blank?
+  def sort_tags_for_list(tags, sort_by: nil, sort_order: nil)
+    return tags if tags.size < 2
 
-    style = options.delete(:style)
-    tags = tags.all.to_a if tags.respond_to?(:all)
+    sort_by = AdditionalTags.setting :tags_sort_by if sort_by.blank?
+    sort_order = AdditionalTags.setting :tags_sort_order if sort_order.blank?
 
-    case "#{AdditionalTags.setting :tags_sort_by}:#{AdditionalTags.setting :tags_sort_order}"
+    case "#{sort_by}:#{sort_order}"
     when 'name:desc'
       tags = AdditionalTags::Tags.sort_tag_list(tags).reverse
     when 'count:asc'
@@ -60,6 +60,16 @@ module AdditionalTagsHelper
       tags = AdditionalTags::Tags.sort_tag_list tags
     end
 
+    tags
+  end
+
+  def render_tags_list(tags, **options)
+    return if tags.blank?
+
+    style = options.delete :style
+    tags = tags.all.to_a if tags.respond_to? :all
+    tags = sort_tags_for_list tags
+
     case style
     when :list
       list_el = 'ul'
@@ -71,7 +81,7 @@ module AdditionalTagsHelper
       raise 'Unknown list style'
     end
 
-    content = ''.html_safe
+    content = +''.html_safe
     if style == :list && AdditionalTags.setting(:tags_sort_by) == 'name'
       tags.group_by { |tag| tag.name.downcase.first }.each do |letter, grouped_tags|
         content << content_tag(item_el, letter.upcase, class: 'letter')
@@ -84,26 +94,30 @@ module AdditionalTagsHelper
     content_tag(list_el, content, class: 'tags-cloud', style: (style == :simple_cloud ? 'text-align: left;' : ''))
   end
 
-  def additional_tag_link(tag_object, options = {})
+  def additional_tag_link(tag_object, link: nil, link_wiki_tag: false, show_count: false, use_colors: nil, name: nil, **options)
     tag_name = []
-    tag_name << tag_object.name
+    tag_name << if name.nil?
+                  tag_object.name
+                else
+                  name
+                end
 
     options[:project] = @project if options[:project].blank? && @project.present?
+    use_colors = AdditionalTags.setting? :use_colors if use_colors.nil?
 
-    use_colors = AdditionalTags.setting?(:use_colors)
-    if use_colors
-      tag_bg_color = additional_tag_color tag_object.name
-      tag_fg_color = additional_tag_fg_color tag_bg_color
-      tag_style = "background-color: #{tag_bg_color}; color: #{tag_fg_color}"
-    end
+    tag_style = if use_colors
+                  tag_bg_color = additional_tag_color tag_object.name
+                  tag_fg_color = additional_tag_fg_color tag_bg_color
+                  "background-color: #{tag_bg_color}; color: #{tag_fg_color}"
+                end
 
-    tag_name << tag.span("(#{tag_object.count})", class: 'tag-count') if options[:show_count]
+    tag_name << tag.span(tag_object.count, class: 'tag-count') if show_count
 
-    content = if options[:link]
+    content = if link
                 link_to safe_join(tag_name),
-                        options[:link],
+                        link,
                         style: tag_style
-              elsif options[:link_wiki_tag]
+              elsif link_wiki_tag
                 link = if options[:project].present?
                          project_wiki_index_path options[:project], tag: tag_object.name
                        else
@@ -112,7 +126,7 @@ module AdditionalTagsHelper
                 link_to safe_join(tag_name), link, style: tag_style
               else
                 link_to safe_join(tag_name),
-                        tag_url(tag_object.name, options),
+                        tag_url(tag_object.name, **options),
                         style: tag_style
               end
 
@@ -122,11 +136,11 @@ module AdditionalTagsHelper
               { class: 'tag-label' }
             end
 
-    tag.span content, style
+    tag.span content, **style
   end
 
   def additional_tag_color(tag_name)
-    "##{Digest::MD5.hexdigest(tag_name)[0..5]}"
+    "##{Digest::SHA256.hexdigest(tag_name)[0..5]}"
   end
 
   def additional_tag_fg_color(bg_color)
@@ -140,53 +154,78 @@ module AdditionalTagsHelper
   end
 
   # plain list of tags
-  def additional_plain_tag_list(tags, sep = ' ')
-    s = if tags.blank?
-          ['']
-        else
-          tags.map(&:name)
-        end
+  def additional_plain_tag_list(tags, sep: nil)
+    sep ||= "#{Query.additional_csv_separator} "
+
+    s = tags.present? ? tags.map(&:name) : ['']
     s.join sep
   end
 
-  def additional_tag_sep(use_colors)
-    if use_colors.nil? || use_colors
-      ' '
-    else
-      ', '
-    end
+  def additional_tag_sep(use_colors: true)
+    use_colors ? ' ' : ', '
+  end
+
+  def additional_tags_from_params(str)
+    tags = str.is_a?(Array) ? str : str.to_s.split(',')
+    tags.map!(&:strip)
+    tags.reject(&:blank?)
   end
 
-  def additional_tag_links(tag_list, options = {})
+  def additional_tag_links(tag_list, **options)
     return if tag_list.blank?
 
-    unsorted = options.delete(:unsorted)
-    tag_list = AdditionalTags::Tags.sort_tag_list(tag_list) unless unsorted
+    unsorted = options.delete :unsorted
+    tag_list = AdditionalTags::Tags.sort_tag_list tag_list unless unsorted
+
+    safe_join tag_list.map { |tag| additional_tag_link tag, **options },
+              additional_tag_sep(use_colors: options[:use_colors])
+  end
+
+  def link_to_issue_tags_totals(entries:, project:, open_issues_only:)
+    sum = if entries.blank? || entries.size.zero?
+            0
+          else
+            query = IssueQuery.new project: project, name: '_'
+            query.add_filter 'tags', '*'
+            query.filters['status_id'][:operator] = '*' if !open_issues_only && query.filters.key?('status_id')
+
+            query.issue_count
+          end
+
+    link_to sum, _project_issues_path(project,
+                                      set_filter: 1,
+                                      tags: '*',
+                                      status_id: open_issues_only ? 'o' : '*')
+  end
 
-    safe_join tag_list.map { |tag| additional_tag_link tag, options },
-              additional_tag_sep(options[:use_colors])
+  def issue_tag_status_filter(operator: nil, open_issues_only: false)
+    if operator
+      { field: :status_id, operator: operator }
+    elsif open_issues_only
+      { field: :status_id, operator: 'o' }
+    end
   end
 
   private
 
-  def tag_url(tag_name, options = {})
-    action = options[:tag_action].presence || (controller_name == 'hrm_user_resources' ? 'show' : 'index')
+  def tag_url(tag_name, filter: nil, tag_action: nil, tag_controller: nil, project: nil)
+    action = tag_action.presence || (controller_name == 'hrm_user_resources' ? 'show' : 'index')
 
     fields = [:tags]
     values = { tags: [tag_name] }
     operators = { tags: '=' }
 
-    if options[:filter].present?
-      field = options[:filter][:field]
+    if filter.present?
+      field = filter[:field]
       fields << field
-      operators[field] = options[:filter][:operator]
-      values[field] = options[:filter][:value] if options[:filter].key?(:value)
+      operators[field] = filter[:operator]
+      values[field] = filter[:value] if filter.key? :value
     end
 
-    { controller: options[:tag_controller].presence || controller_name,
+    { controller: tag_controller.presence || controller_name,
       action: action,
       set_filter: 1,
-      project_id: options[:project],
+      project_id: project,
       f: fields,
       v: values,
       op: operators }
@@ -195,7 +234,7 @@ module AdditionalTagsHelper
   def add_tags(style, tags, content, item_el, options)
     tag_cloud tags, (1..8).to_a do |tag, weight|
       content << ' '.html_safe + content_tag(item_el,
-                                             additional_tag_link(tag, options),
+                                             additional_tag_link(tag, **options),
                                              class: "tag-nube-#{weight}",
                                              style: (style == :simple_cloud ? 'font-size: 1em;' : '')) + ' '.html_safe
     end

data/app/helpers/additional_tags_issues_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AdditionalTagsIssuesHelper
   # Hacked render_api_custom_values to add plugin values to issue api
   def render_api_custom_values(custom_values, api)
@@ -5,11 +7,21 @@ module AdditionalTagsIssuesHelper
 
     if @issue.present? &&
        (defined?(controller_name) && controller_name == 'issues' && action_name == 'show' || !defined?(controller_name)) &&
-       User.current.allowed_to?(:view_issues, @project)
+       AdditionalTags.setting?(:active_issue_tags) && User.current.allowed_to?(:view_issue_tags, @project)
 
       api.array :tags do
         @issue.tags.each do |tag|
-          api.tag(id: tag.id, name: tag.name)
+          api.tag id: tag.id, name: tag.name
+        end
+      end
+    end
+
+    if @time_entry.present? &&
+       (defined?(controller_name) && controller_name == 'timelog' && action_name == 'show' || !defined?(controller_name)) &&
+       AdditionalTags.setting?(:active_issue_tags) && User.current.allowed_to?(:view_issue_tags, @project)
+      api.array :issue_tags do
+        @time_entry.issue_tags.each do |tag|
+          api.tag id: tag.id, name: tag.name
         end
       end
     end
@@ -38,6 +50,6 @@ module AdditionalTagsIssuesHelper
                 project: @project }
 
     options[:tag_action] = 'show' if %w[gantts calendars].include? controller_name
-    render_tags_list sidebar_tags, options
+    render_tags_list sidebar_tags, **options
   end
 end

data/app/helpers/additional_tags_wiki_helper.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module AdditionalTagsWikiHelper
   def sidebar_tags
     unless @sidebar_tags
       @sidebar_tags = []
-      @sidebar_tags = WikiPage.available_tags(project: @project) if AdditionalTags.show_sidebar_tags?
+      @sidebar_tags = WikiPage.available_tags project: @project if AdditionalTags.show_sidebar_tags?
     end
     @sidebar_tags
   end
@@ -13,7 +15,7 @@ module AdditionalTagsWikiHelper
                 link_wiki_tag: true,
                 project: @project }
 
-    render_tags_list sidebar_tags, options
+    render_tags_list sidebar_tags, **options
   end
 
   def render_wiki_index_title(project, tag = nil)
@@ -30,28 +32,4 @@ module AdditionalTagsWikiHelper
       l :label_wiki
     end
   end
-
-  def wiki_pages_with_tag(tag, project = nil)
-    wiki = project&.wiki
-
-    scope = if wiki
-              wiki.pages
-            else
-              WikiPage.joins(wiki: :project)
-            end
-
-    scope = scope.visible(User.current, project: project) if scope.respond_to? :visible
-
-    scope = scope.joins(AdditionalTags::Tags.tag_to_joins(WikiPage))
-                 .where("LOWER(#{ActiveRecord::Base.connection.quote_table_name(ActsAsTaggableOn.tags_table)}.name) = LOWER(:p)",
-                        p: tag.to_s.strip)
-                 .with_updated_on
-                 .joins(wiki: :project)
-
-    if wiki.nil?
-      scope.order "#{Project.table_name}.name, #{WikiPage.table_name}.title"
-    else
-      scope.includes(:parent).order "#{WikiPage.table_name}.title"
-    end
-  end
 end

data/app/jobs/additional_tags_job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdditionalTagsJob < AdditionalsJob
   queue_as :additional_tags
 end

data/app/jobs/additional_tags_remove_unused_tag_job.rb

@@ -1,5 +1,12 @@
+# frozen_string_literal: true
+
 class AdditionalTagsRemoveUnusedTagJob < AdditionalTagsJob
   def perform
+    # only once a minute to reduce load
+    cache_key = self.class.to_s
+    return if Rails.cache.read(cache_key) && !Rails.env.test?
+
+    Rails.cache.write cache_key, true, expires_in: 60
     AdditionalTags::Tags.remove_unused_tags
   end
 end

data/app/models/migrate_tag.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MigrateTag < ActiveRecord::Base
   self.table_name = 'tags'
   has_many :migrate_taggings, dependent: :destroy, foreign_key: :tag_id, inverse_of: :migrate_tag

data/app/models/migrate_tagging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MigrateTagging < ActiveRecord::Base
   self.table_name = 'taggings'
   belongs_to :migrate_tag, foreign_key: :tag_id, inverse_of: :migrate_taggings

data/app/models/query_tags_column.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class QueryTagsColumn < QueryRelationsColumn
+  def initialize(name = :tags, **options)
+    super name, **options
+  end
+end

data/app/views/additional_tags/_body_bottom.html.slim

@@ -0,0 +1,19 @@
+= additionals_transform_to_select2 'assignee',
+                                    format_state: 'formatNameWithIcon',
+                                    multiple: true,
+                                    url: assignee_auto_completes_path(project_id: @project)
+
+= additionals_transform_to_select2 'author',
+                                    format_state: 'formatNameWithIcon',
+                                    multiple: true,
+                                    url: grouped_users_auto_completes_path(project_id: @project, with_ano: true, with_me: true)
+
+= additionals_transform_to_select2 'user_with_me',
+                                    format_state: 'formatNameWithIcon',
+                                    multiple: true,
+                                    url: grouped_users_auto_completes_path(project_id: @project, with_me: true)
+
+= additionals_transform_to_select2 'user',
+                                    format_state: 'formatNameWithIcon',
+                                    multiple: true,
+                                    url: grouped_users_auto_completes_path(project_id: @project)

data/app/views/additional_tags/_html_head.html.slim

@@ -1,6 +1,3 @@
 = stylesheet_link_tag 'tags', plugin: 'additional_tags'
 = javascript_include_tag 'tags', plugin: 'additional_tags'
-- if User.current.allowed_to?(:edit_issue_tags, @project, global: true) || \
-     User.current.allowed_to?(:create_issue_tags, @project, global: true) || \
-     User.current.allowed_to?(:add_wiki_tags, @project, global: true)
-  = additionals_library_load :select2
+= additionals_library_load :select2

data/app/views/additional_tags/_tag_list.html.slim

@@ -2,7 +2,7 @@
   .tags.attribute
     - unless defined? hide_label
       span.label
-        = l(:field_tag_list)
+        = l :field_tag_list
         ' :
     - if defined?(editable) && editable
       #tags-data

data/app/views/additional_tags/merge.html.slim

@@ -6,9 +6,10 @@ h2
 
 = form_tag merge_additional_tags_path(ids: @tags.map(&:id)), class: 'tabular' do
   = error_messages_for 'tag'
-  = additional_tag_links @tags, { show_count: true,
-                                  use_colors: AdditionalTags.setting?(:use_colors),
-                                  link: '#' }
+  = additional_tag_links @tags,
+                         show_count: true,
+                         use_colors: AdditionalTags.setting?(:use_colors),
+                         link: '#'
   .box
     p
       label[for="tag_name"]

data/app/views/additional_tags/settings/_manage_tags.html.slim

@@ -1,29 +1,30 @@
 - tags = manageable_tags
 - if tags.present?
-  table.list.issues
-    thead
-      tr
-        th.checkbox.hide-when-print
-          = check_box_tag 'ids[]', '', false, class: 'toggle-selection',
-                          title: "#{l :button_check_all}/#{l :button_uncheck_all}"
+  .autoscroll
+    table.list.issues
+      thead
+        tr
+          th.checkbox.hide-when-print
+            = check_box_tag 'ids[]', '', false, class: 'toggle-selection',
+                            title: "#{l :button_check_all}/#{l :button_uncheck_all}"
 
-        th = l :field_name
-        - manageable_tag_columns.each do |_column, column_values|
-          th = column_values[:label]
-        th
-    tbody
-      - tags.each do |tag|
-        tr.hascontextmenu id="#{tag.id}"
-          td.checkbox.hide-when-print
-           = check_box_tag('ids[]', tag.id, false, id: nil)
-          td = additional_tag_link tag, link: edit_additional_tag_path(tag)
-          - manageable_tag_column_values(tag).each do |column|
-            td = column
-          td.buttons
-            = link_to l(:button_edit), edit_additional_tag_path(tag),
-                      class: 'icon icon-edit'
-            = link_to l(:button_delete), additional_tags_path(ids: tag), method: :delete,
-                      data: { confirm: l(:text_are_you_sure) }, class: 'icon icon-del'
+          th = l :field_name
+          - manageable_tag_columns.each do |_column, column_values|
+            th = column_values[:label]
+          th
+      tbody
+        - tags.each do |tag|
+          tr.hascontextmenu id="#{tag.id}"
+            td.checkbox.hide-when-print
+              = check_box_tag 'ids[]', tag.id, false, id: nil
+            td = additional_tag_link tag, link: edit_additional_tag_path(tag)
+            - manageable_tag_column_values(tag).each do |column|
+              td = column
+            td.buttons
+              = link_to l(:button_edit), edit_additional_tag_path(tag),
+                        class: 'icon icon-edit'
+              = link_to l(:button_delete), additional_tags_path(ids: tag), method: :delete,
+                        data: { confirm: l(:text_are_you_sure) }, class: 'icon icon-del'
 - else
   p.nodata = l :label_no_data
 

data/app/views/common/_tag_summary_block.html.slim

@@ -0,0 +1,11 @@
+ul.reporting-list.tag-summary
+  li.amount-tags
+    = l :label_amount_tags
+    ' :
+    span.value
+      = tags.to_a.size
+  li.amount-entities-with-tags
+    = l :label_amount_entities_with_tags, name: entities_label
+    ' :
+    span.value
+      = totals_link

data/app/views/context_menus/_issues_tags.html.slim

@@ -5,6 +5,6 @@
     ul
       li
         = context_menu_link l(:button_add),
-                            edit_issue_tags_path(ids: @issue_ids),
+                            edit_issue_tags_path(ids: @issue_ids, search: params[:search]),
                             remote: true,
                             class: 'icon icon-add'

data/app/views/dashboards/blocks/_issue_tags.html.slim

@@ -0,0 +1,58 @@
+h3 = block_definition[:label]
+
+- open_issues_only = RedminePluginKit.true? settings[:open_issues_only]
+- tags = Issue.available_tags project: @project, open_issues_only: open_issues_only
+- counts = AdditionalTags::Tags.entity_group_by scope: Issue.group_by_status_with_tags(@project),
+                                                tags: tags,
+                                                statuses: { true => :closed, false => :open },
+                                                group_id_is_bool: true
+
+= render partial: 'common/tag_summary_block',
+         locals: { tags: tags,
+                   entities_label: l(:label_issue_plural),
+                   totals_link: link_to_issue_tags_totals(entries: counts,
+                                                          project: @project,
+                                                          open_issues_only: open_issues_only) }
+
+- if RedminePluginKit.true? settings[:with_table_of_values]
+  - if tags.present?
+    - tags = sort_tags_for_list tags.to_a
+    table.list.tags
+      thead
+        tr
+          th = l :field_name
+          - if open_issues_only
+            th = l :label_quantity
+          - else
+            th = l :label_open_issues_plural
+            th = l :label_closed_issues_plural
+            th = l :label_total
+      tbody
+        - tags.each do |tag|
+          tr
+            td.name = additional_tag_link tag,
+                                          tag_action: 'index',
+                                          tag_controller: 'issues',
+                                          filter: issue_tag_status_filter(open_issues_only: open_issues_only),
+                                          use_colors: RedminePluginKit.true?(settings[:use_colors])
+            - unless open_issues_only
+              td.value = additional_tag_link tag,
+                                             tag_action: 'index',
+                                             tag_controller: 'issues',
+                                             filter: issue_tag_status_filter(operator: 'o'),
+                                             use_colors: false,
+                                             name: counts[tag.name][:open]
+              td.value = additional_tag_link tag,
+                                             tag_action: 'index',
+                                             tag_controller: 'issues',
+                                             filter: issue_tag_status_filter(operator: 'c'),
+                                             use_colors: false,
+                                             name: counts[tag.name][:closed]
+            td.value = additional_tag_link tag,
+                                           tag_action: 'index',
+                                           tag_controller: 'issues',
+                                           filter: issue_tag_status_filter(open_issues_only: open_issues_only),
+                                           use_colors: false,
+                                           name: open_issues_only ? counts[tag.name][:open] : counts[tag.name][:total]
+  - else
+    p.nodata = l :label_no_data

data/app/views/dashboards/blocks/_issue_tags_settings.html.slim

@@ -0,0 +1,20 @@
+.box.tabular.settings
+  p
+    = additionals_settings_checkbox :with_table_of_values,
+                                    active_value: settings[:with_table_of_values],
+                                    tag_name: "settings[#{block}][with_table_of_values]"
+
+  / p
+  /   = additionals_settings_checkbox :with_chart,
+  /                                   active_value: settings[:with_chart],
+  /                                   tag_name: "settings[#{block}][with_chart]"
+
+  p
+    = additionals_settings_checkbox :open_issues_only,
+                                    active_value: settings[:open_issues_only],
+                                    tag_name: "settings[#{block}][open_issues_only]"
+
+  p
+    = additionals_settings_checkbox :use_colors,
+                                    active_value: settings[:use_colors],
+                                    tag_name: "settings[#{block}][use_colors]"

data/app/views/issue_tags/_edit_modal.html.slim

@@ -9,7 +9,7 @@ h3.title = l :label_add_tags
   h3
     span = link_to_issue @issues.first
 
-= form_tag issue_tags_path(ids: @issue_ids) do
+= form_tag issue_tags_path(ids: @issue_ids, search: params[:search]) do
   fieldset.box
     legend = l :field_tags
     #issue_tags
@@ -21,10 +21,12 @@ h3.title = l :label_add_tags
                                 placeholder: @is_bulk_editing ? t(:label_no_change_option) : '+ add tag',
                                 tags: User.current.allowed_to?(:create_issue_tags, @project)
     p.most_used_tags
-      = safe_join @most_used_tags.collect { |t| tag.span(t.name, class: 'most_used_tag') }, ', '
-    = javascript_tag "var mostUsedTags = #{@most_used_tags.map(&:name)}"
+      = safe_join @most_used_tags.collect { |t| tag.span t.name, class: 'most_used_tag' }, ', '
 
   .buttons
     = submit_tag l(:button_add), name: nil
     '
-    = submit_tag l(:button_cancel), name: nil, onclick: 'hideModal(this);', type: 'button'
+    = link_to_function l(:button_cancel), 'hideModal(this);'
+
+javascript:
+  var mostUsedTags = #{raw @most_used_tags.map(&:name)};

data/app/views/issues/_tags_form.html.slim

@@ -1,4 +1,4 @@
-- project = defined?(project) ? project : @project
+- project = @project unless defined?(project)
 - options = { multiple: true,
               width: '95%',
               url: issue_tags_auto_completes_path(project_id: project),

data/assets/javascripts/tags.js

@@ -1,5 +1,6 @@
-$(function () {
-  $('body').on('click', '.most_used_tags .most_used_tag', function (e) {
+/* global mostUsedTags:writable */
+$(function() {
+  $('body').on('click', '.most_used_tags .most_used_tag', function(e) {
     var $tagsSelect = $('select#issue_tag_list');
     var tag = e.target.innerText;
     if ($tagsSelect.find('option[value=\'' + tag + '\']').length === 0) {
@@ -7,7 +8,7 @@ $(function () {
       $tagsSelect.append(newOption).trigger('change');
     }
 
-    var mostUsedTags = $.grep(mostUsedTags, function(t) { return t != tag; });
+    mostUsedTags = $.grep(mostUsedTags, function(t) { return t != tag; });
     var tagsHtml = mostUsedTags.map(function(tag) {
       return '<span class="most_used_tag">' + tag + '</span>';
     }).join(', ');