adapi 0.1.1 → 0.1.2

data/lib/adapi/campaign.rb

@@ -85,6 +85,8 @@ module Adapi
     # setter for converting budget to GoogleApi
     # budget can be integer (amount) or hash
     #
+    # TODO return error for missing :amount 
+    #
     def budget=(params = {})
       # if it's single value, it's a budget amount
       params = { amount: params } unless params.is_a?(Hash)
@@ -93,7 +95,7 @@ module Adapi
         params[:amount] = { micro_amount: Api.to_micro_units(params[:amount]) }
       end
 
-      @budget = params.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
+      @budget = params.clone
     end
 
     # setter for campaign settings (array of hashes)
@@ -117,6 +119,9 @@ module Adapi
     def create
       return false unless self.valid?      
       
+      # set defaults for budget for campaign.create only
+      self.budget = budget.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
+
       # create basic campaign attributes
       operand = Hash[
         [ :name, :status, :start_date, :end_date,

data/lib/adapi/version.rb

@@ -1,10 +1,13 @@
 # encoding: utf-8
 
 module Adapi
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 
   # CHANGELOG:
   #
+  # 0.1.2
+  # fixed bug in campaign.update
+  #
   # 0.1.1
   # fixed bug in campaign.budget settings
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adapi
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-ads-common
-  requirement: &19366880 !ruby/object:Gem::Requirement
+  requirement: &25840920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -21,10 +21,10 @@ dependencies:
         version: 0.8.0
   type: :runtime
   prerelease: false
-  version_requirements: *19366880
+  version_requirements: *25840920
 - !ruby/object:Gem::Dependency
   name: google-adwords-api
-  requirement: &19365480 !ruby/object:Gem::Requirement
+  requirement: &25840080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -32,10 +32,10 @@ dependencies:
         version: 0.7.0
   type: :runtime
   prerelease: false
-  version_requirements: *19365480
+  version_requirements: *25840080
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &19364740 !ruby/object:Gem::Requirement
+  requirement: &25839320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *19364740
+  version_requirements: *25839320
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &19363960 !ruby/object:Gem::Requirement
+  requirement: &25838320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *19363960
+  version_requirements: *25838320
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &19362440 !ruby/object:Gem::Requirement
+  requirement: &25837080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 0.9.2
   type: :runtime
   prerelease: false
-  version_requirements: *19362440
+  version_requirements: *25837080
 - !ruby/object:Gem::Dependency
   name: curb
-  requirement: &19361700 !ruby/object:Gem::Requirement
+  requirement: &25836240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *19361700
+  version_requirements: *25836240
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &19360660 !ruby/object:Gem::Requirement
+  requirement: &25835200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: '0.8'
   type: :development
   prerelease: false
-  version_requirements: *19360660
+  version_requirements: *25835200
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &19359580 !ruby/object:Gem::Requirement
+  requirement: &25850680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: '0.9'
   type: :development
   prerelease: false
-  version_requirements: *19359580
+  version_requirements: *25850680
 - !ruby/object:Gem::Dependency
   name: turn
-  requirement: &19375280 !ruby/object:Gem::Requirement
+  requirement: &25849960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 0.9.6
   type: :development
   prerelease: false
-  version_requirements: *19375280
+  version_requirements: *25849960
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &19374560 !ruby/object:Gem::Requirement
+  requirement: &25849260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *19374560
+  version_requirements: *25849260
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &19373760 !ruby/object:Gem::Requirement
+  requirement: &25848340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -131,10 +131,10 @@ dependencies:
         version: '1.3'
   type: :development
   prerelease: false
-  version_requirements: *19373760
+  version_requirements: *25848340
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &19373080 !ruby/object:Gem::Requirement
+  requirement: &25847740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -142,10 +142,10 @@ dependencies:
         version: '3.3'
   type: :development
   prerelease: false
-  version_requirements: *19373080
+  version_requirements: *25847740
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &19372440 !ruby/object:Gem::Requirement
+  requirement: &25847240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -153,7 +153,7 @@ dependencies:
         version: '3.3'
   type: :development
   prerelease: false
-  version_requirements: *19372440
+  version_requirements: *25847240
 description: This gem provides user-friendly interface to Google Adwords API.
 email:
 - lucastej@gmail.com
@@ -252,7 +252,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 199503239866394864
+      hash: 426078939289165673
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -261,7 +261,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 199503239866394864
+      hash: 426078939289165673
 requirements: []
 rubyforge_project: adapi
 rubygems_version: 1.8.15