actv 1.1.0

data/spec/actv/client_spec.rb

@@ -0,0 +1,140 @@
+require 'spec_helper'
+
+describe ACTV::Client do
+
+  subject do
+    client = ACTV::Client.new
+    # client.class_eval{public *ACTV::Client.private_instance_methods}
+    client
+  end
+
+  context "with module configuration" do
+
+    before  do
+      ACTV.configure do |config|
+        ACTV::Configurable.keys.each do |key|
+          config.send("#{key}=", key)
+        end
+      end
+    end
+
+    after do
+      ACTV.reset!
+    end
+
+    it "inherits the module configuration" do
+      client = ACTV::Client.new
+      ACTV::Configurable.keys.each do |key|
+        client.instance_variable_get("@#{key}").should eq key
+      end
+    end
+
+    context "with class configuration" do
+
+      before do
+        @configuration = {
+          :connection_options => {:timeout => 10},
+          :consumer_key => 'CK',
+          :consumer_secret => 'CS',
+          :endpoint => 'http://tumblr.com/',
+          :media_endpoint => 'http://upload.twitter.com',
+          :middleware => Proc.new{},
+          :oauth_token => 'OT',
+          :oauth_token_secret => 'OS',
+          :search_endpoint => 'http://search.twitter.com',
+          :api_key => 'TEST'
+        }
+      end
+
+      context "during initialization" do
+        it "overrides the module configuration" do
+          client = ACTV::Client.new(@configuration)
+          ACTV::Configurable.keys.each do |key|
+            client.instance_variable_get("@#{key}").should eq @configuration[key]
+          end
+        end
+      end
+
+      context "after initilization" do
+        it "overrides the module configuration after initialization" do
+          client = ACTV::Client.new
+          client.configure do |config|
+            @configuration.each do |key, value|
+              config.send("#{key}=", value)
+            end
+          end
+          ACTV::Configurable.keys.each do |key|
+            client.instance_variable_get("@#{key}").should eq @configuration[key]
+          end
+        end
+      end
+
+    end
+
+  end
+
+  describe "#credentials?" do
+    it "returns true if all credentials are present" do
+      client = ACTV::Client.new(:consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT', :oauth_token_secret => 'OS')
+      client.credentials?.should be_true
+    end
+    # it "returns false if any credentials are missing" do
+    #   client = ACTV::Client.new(:consumer_key => 'CK', :consumer_secret => 'CS', :oauth_token => 'OT')
+    #   client.credentials?.should be_false
+    # end
+  end
+
+  describe "#connection" do
+    it "looks like Faraday connection" do
+      subject.connection.should respond_to(:run_request)
+    end
+    it "memoizes the connection" do
+      c1, c2 = subject.connection, subject.connection
+      c1.object_id.should eq c2.object_id
+    end
+  end
+
+  describe "#request" do
+    before do
+      @client = ACTV::Client.new({:consumer_key => "CK", :consumer_secret => "CS", :oauth_token => "OT", :oauth_token_secret => "OS"})
+    end
+
+    it "does something" do
+      stub_request(:get, "https://api.active.com/system_health").
+        with(:headers => {'Accept'=>'application/json'}).
+        to_return(:status => 200, :body => '{"status":"not implemented"}', :headers => {})
+
+      @client.request(:get, "/system_health", {}, {})[:body].should eql({status: "not implemented"})
+    end
+
+    it "encodes the entire body when no uploaded media is present" do
+    #   stub_post("/1/statuses/update.json").
+    #     with(:body => {:status => "Update"}).
+    #     to_return(:body => fixture("status.json"), :headers => {:content_type => "application/json; charset=utf-8"})
+    #   @client.update("Update")
+    #   a_post("/1/statuses/update.json").
+    #     with(:body => {:status => "Update"}).
+    #     should have_been_made
+    end
+    # it "encodes none of the body when uploaded media is present" do
+    #   stub_post("/1/statuses/update_with_media.json", "https://upload.twitter.com").
+    #     to_return(:body => fixture("status_with_media.json"), :headers => {:content_type => "application/json; charset=utf-8"})
+    #   @client.update_with_media("Update", fixture("pbjt.gif"))
+    #   a_post("/1/statuses/update_with_media.json", "https://upload.twitter.com").
+    #     should have_been_made
+    # end
+    # it "catches Faraday errors" do
+    #   subject.stub!(:connection).and_raise(Faraday::Error::ClientError.new("Oups"))
+    #   lambda do
+    #     subject.request(:get, "/path", {}, {})
+    #   end.should raise_error(Twitter::Error::ClientError, "Oups")
+    # end
+  end
+
+  ACTV::Configurable::CONFIG_KEYS.each do |key|
+    it "has a default #{key.to_s.gsub('_', ' ')}" do
+      subject.send(key).should eq ACTV::Default.options[key]
+    end
+  end
+
+end

data/spec/actv/event_spec.rb

@@ -0,0 +1,331 @@
+require 'spec_helper'
+require "active_support/time"
+
+describe ACTV::Event do
+  before do
+    stub_get("/v2/assets/valid_event.json").to_return(body: fixture("valid_event.json"), headers: { content_type: "application/json; charset=utf-8" })
+  end
+
+  subject { ACTV.event('valid_event') }
+
+  def format_date date
+    date.strftime('%Y-%m-%dT%H:%M:%S')
+  end
+
+  def format_date_in_utc date
+    format_date(date) << ' UTC'
+  end
+
+  # describe "available methods" do
+  #   subject { ACTV::Event.new(assetGuid: 1) }
+  #   it { should respond_to :online_registration_available? }
+  #   it { should respond_to :registration_not_yet_open? }
+  #   it { should respond_to :registration_open? }
+  #   it { should respond_to :registration_closed? }
+  #   it { should respond_to :event_ended? }
+  # end
+
+  describe '#online_registration_available?' do
+    context 'when online_registration_available is true' do
+      before do
+        subject.legacy_data.stub(:onlineRegistration).and_return("true")
+        subject.stub(:registrationUrlAdr).and_return("something")
+      end
+
+      its(:online_registration_available?) { should be_true }
+    end
+
+    context "when online_registration_available is not true" do
+      before do
+        subject.legacy_data.stub(:onlineRegistration).and_return("false")
+        subject.stub(:registrationUrlAdr).and_return("something")
+      end
+
+      its(:online_registration_available?) { should be_false }
+    end
+
+    context "when online_registration_available is not present" do
+      before do
+        subject.legacy_data.stub(:onlineRegistration).and_return(nil)
+      end
+
+      context "when registrationUrlAdr is present" do
+        before { subject.stub(:registrationUrlAdr).and_return("something") }
+        its(:online_registration_available?) { should be_true }
+      end
+
+      context "when registrationUrlAdr is not present" do
+        before { subject.stub(:registrationUrlAdr).and_return(nil) }
+        its(:online_registration_available?) { should be_false }
+      end
+    end
+
+    context "when legacy_data is not present" do
+      before { subject.stub(:legacy_data).and_return(nil) }
+
+      context "when registrationUrlAdr is present" do
+        before { subject.stub(:registrationUrlAdr).and_return("something") }
+        its(:online_registration_available?) { should be_true }
+      end
+
+      context "when registrationUrlAdr is not present" do
+        before { subject.stub(:registrationUrlAdr).and_return(nil) }
+        its(:online_registration_available?) { should be_false }
+      end
+    end
+  end
+
+  describe '#registration_open_date' do
+    before { subject.stub(:sales_start_date).and_return format_date 1.day.from_now }
+    it "returns the correct date in the correct timezone" do
+      subject.registration_open_date.should be_within(1.second).of Time.parse format_date_in_utc 1.day.from_now
+    end
+  end
+
+  describe '#registration_close_date' do
+    before { subject.stub(:sales_end_date).and_return format_date 1.day.from_now }
+    it "returns the correct date in the correct timezone" do
+      subject.registration_close_date.should be_within(1.second).of Time.parse format_date_in_utc 1.day.from_now
+    end
+  end
+
+  describe '#event_start_date' do
+    before do
+      subject.stub(:activity_start_date).and_return("2013-05-10T00:00:00")
+      subject.stub(:timezone_offset).and_return(-4)
+    end
+    it "returns the correct date in the correct timezone" do
+      subject.event_start_date.should eq Time.parse "2013-05-10T00:00:00 -0400"
+    end
+  end
+
+  describe '#event_end_date' do
+    before do
+      subject.stub(:activity_end_date).and_return("2013-05-10T00:00:00")
+      subject.stub(:timezone_offset).and_return(-4)
+    end
+    it "returns the correct date in the correct timezone" do
+      subject.event_end_date.should eq Time.parse "2013-05-10T00:00:00 -0400"
+    end
+  end
+
+  describe '#registration_not_yet_open' do
+
+    context 'when the event has sales start date' do
+      context 'when now is before the date' do
+        before do
+          subject.stub(:sales_start_date).and_return format_date 1.day.from_now
+          subject.stub(:registrationUrlAdr).and_return("something")
+        end
+        its(:registration_not_yet_open?) { should be_true }
+      end
+      context 'when now is after the date' do
+        before do
+          subject.stub(:sales_start_date).and_return format_date 1.day.ago
+        end
+        its(:registration_not_yet_open?) { should be_false }
+      end
+    end
+    context 'when the event does not have a sales start date' do
+      before do
+        subject.stub(:sales_start_date).and_return nil
+      end
+      its(:registration_not_yet_open?) { should be_false }
+
+      context 'when the event has no dates' do
+        before do
+          subject.stub(:sales_start_date).and_return nil
+          subject.stub(:sales_end_date).and_return nil
+          subject.stub(:activity_start_date).and_return nil
+          subject.stub(:activity_end_date).and_return nil
+        end
+        its(:registration_not_yet_open?) { should be_false }
+      end
+    end
+  end
+
+  describe '#registration_closed' do
+
+    context 'when the event has sales end date' do
+      context 'when now is before the date' do
+        before do
+          subject.stub(:sales_end_date).and_return format_date 1.day.from_now
+        end
+        its(:registration_closed?) { should be_false }
+      end
+      context 'when now is after the date' do
+        before do
+          subject.stub(:sales_end_date).and_return format_date 1.day.ago
+          subject.stub(:registrationUrlAdr).and_return("something")
+        end
+        its(:registration_closed?) { should be_true }
+      end
+    end
+    context 'when the event does not have a sales end date' do
+      before do
+        subject.stub(:sales_end_date).and_return nil
+      end
+      context 'when the event has an activity end date' do
+        context 'when now is before the date' do
+          before do
+            subject.stub(:activity_end_date).and_return format_date 1.day.from_now
+          end
+          its(:registration_closed?) { should be_false }
+        end
+        context 'when now is after the date' do
+          before do
+            subject.stub(:activity_end_date).and_return format_date 1.day.ago
+            subject.stub(:registrationUrlAdr).and_return("something")
+          end
+          its(:registration_closed?) { should be_true }
+        end
+      end
+      context 'when the event has no dates' do
+        before do
+          subject.stub(:sales_start_date).and_return nil
+          subject.stub(:sales_end_date).and_return nil
+          subject.stub(:activity_start_date).and_return nil
+          subject.stub(:activity_end_date).and_return nil
+        end
+        its(:registration_closed?) { should be_false }
+      end
+    end
+  end
+
+  describe '#registration_open' do
+    subject { ACTV.event('valid_event') }
+
+    context 'when the event is unregisterable' do
+      before do
+        subject.stub(:online_registration_available?).and_return false
+      end
+      its(:registration_open?) { should be_false }
+    end
+
+    context 'when the event has sales start and end dates' do
+      context 'when now is between start and end dates' do
+        before do
+          subject.stub(:sales_start_date).and_return format_date 1.day.ago
+          subject.stub(:sales_end_date).and_return format_date 1.day.from_now
+          subject.stub(:registrationUrlAdr).and_return("something")
+        end
+        its(:registration_open?) { should be_true }
+      end
+
+      context 'when now is before start' do
+        before do
+          subject.stub(:sales_start_date).and_return format_date 1.day.from_now
+          subject.stub(:sales_end_date).and_return format_date 2.days.from_now
+        end
+        its(:registration_open?) { should be_false }
+      end
+
+      context 'when now is after end' do
+        before do
+          subject.stub(:sales_start_date).and_return format_date 2.days.ago
+          subject.stub(:sales_end_date).and_return format_date 1.day.ago
+        end
+        its(:registration_open?) { should be_false }
+      end
+    end
+
+    context 'when the event does not have sales start and end dates' do
+      before do
+        subject.stub(:sales_start_date).and_return nil
+        subject.stub(:sales_end_date).and_return nil
+      end
+      context 'when the event has activity start and end dates' do
+        before do
+          subject.stub(:activity_start_date).and_return format_date 2.days.ago
+          subject.stub(:activity_end_date).and_return format_date 2.days.from_now
+        end
+        context 'when now is between start and end dates' do
+          before do
+            subject.stub(:activity_start_date).and_return format_date 2.days.ago
+            subject.stub(:activity_end_date).and_return format_date 2.days.from_now
+            subject.stub(:registrationUrlAdr).and_return("something")
+          end
+          its(:registration_open?) { should be_true }
+        end
+        context 'when now is after end' do
+          before do
+            subject.stub(:activity_start_date).and_return format_date 3.days.ago
+            subject.stub(:activity_end_date).and_return format_date 2.days.ago
+          end
+          its(:registration_open?) { should be_false }
+        end
+      end
+      context 'when the event does not have activity start and end dates' do
+        before do
+          subject.stub(:activity_start_date).and_return nil
+          subject.stub(:activity_end_date).and_return nil
+          subject.stub(:registrationUrlAdr).and_return("something")
+        end
+        its(:registration_open?) { should be_true } # Huiwen says this is correct
+      end
+    end
+  end
+
+  describe "Fixes for LH bugs" do
+    describe "LH-925" do
+      context "when the sales dates are not available" do
+        before do
+          subject.stub(:sales_start_date).and_return nil
+          subject.stub(:sales_end_date).and_return nil
+        end
+        context "when the activity start and end date are the same" do
+          before do
+            subject.stub(:activity_start_date).and_return format_date 1.month.ago
+            subject.stub(:activity_end_date).and_return format_date Date.today
+            subject.stub(:registrationUrlAdr).and_return("something")
+          end
+          its(:event_ended?) { should be_false }
+          its(:registration_open?) { should be_true }
+        end
+      end
+    end
+
+    describe "LH-906" do
+      context 'when the sales_start_date is nil, sales_end_date is in the past and today is between activity start and end' do
+        before do
+          subject.stub(:sales_start_date).and_return nil
+          subject.stub(:sales_end_date).and_return format_date 2.days.ago
+          subject.stub(:activity_start_date).and_return format_date 1.day.ago
+          subject.stub(:activity_end_date).and_return format_date 1.day.from_now
+          subject.stub(:registrationUrlAdr).and_return("something")
+        end
+        its(:registration_not_yet_open?)  { should be_false }
+        its(:registration_open?)          { should be_false }
+        its(:registration_closed?)        { should be_true }
+      end
+    end
+  end
+
+  describe '#disply_close_date' do
+    context 'when tag is not set' do
+      before do
+        subject.stub(:tag_by_description).with("displayclosedate").and_return nil
+      end
+
+      its(:display_close_date?) { should eq true }
+    end
+
+    context 'when tag is set' do
+      context 'when true' do
+        before do
+          subject.stub(:tag_by_description).with("displayclosedate").and_return 'true'
+        end
+
+        its(:display_close_date?) { should eq true }
+      end
+
+      context 'when false' do
+        before do
+          subject.stub(:tag_by_description).with("displayclosedate").and_return 'false'
+        end
+
+        its(:display_close_date?) { should eq false }
+      end
+    end
+  end
+end