acts_more_seo 0.4.0 → 0.4.1

data/CHANGELOG.rdoc

@@ -22,3 +22,5 @@ Backward compatibility improvements
 * Downcase fix
 = Version 0.4.0
 * Seo url history support for updating and searching
+= Version 0.4.1
+* Case sensitive/insensitive support

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_more_seo', '0.4.0') do |p|
+Echoe.new('acts_more_seo', '0.4.1') do |p|
   p.description    = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   p.url            = "https://github.com/mensfeld/Css-Image-Embedder"
   p.author         = "Maciej Mensfeld"

data/acts_more_seo.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = "acts_more_seo"
-  s.version = "0.4.0"
+  s.version = "0.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Maciej Mensfeld"]
-  s.date = "2012-02-25"
+  s.date = "2012-02-27"
   s.description = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   s.email = "maciej@mensfeld.pl"
   s.extra_rdoc_files = ["CHANGELOG.rdoc", "README.md", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb", "lib/string_ext.rb"]

data/lib/acts_more_seo.rb

@@ -20,6 +20,7 @@ module Acts
         columns = params[:column] || params[:columns] || :name
         use_id  = !params[:use_id].nil? ? params[:use_id] : true
         history = params[:history] || false
+        case_sensitive = params[:case_sensitive] || false
 
         if columns.is_a?(Array)
           columns.collect!{|a| a.to_sym}
@@ -30,6 +31,7 @@ module Acts
         cattr_accessor :seo_columns
         cattr_accessor :seo_use_id
         cattr_accessor :seo_history
+        cattr_accessor :case_sensitive
 
         before_update :update_seo_url
         after_create  :set_seo_url
@@ -37,6 +39,7 @@ module Acts
         self.seo_columns = columns
         self.seo_history = history
         self.seo_use_id  = use_id
+        self.case_sensitive = case_sensitive
 
         if self.seo_history
           has_many :seo_histories,

data/lib/seo_finder.rb

@@ -9,6 +9,7 @@ module Acts
       end
 
       def search(name)
+        name = name.downcase if !@klass.case_sensitive && name.is_a?(String)
         ret = search_in_table(name)
 
         if !ret && @klass.seo_history?
@@ -19,6 +20,7 @@ module Acts
       end
 
       def search!(name)
+        name = name.downcase if !@klass.case_sensitive && name.is_a?(String)
         search_in_table!(name)
       rescue ActiveRecord::RecordNotFound => e
         if @klass.seo_history?

data/spec/acts_more_seo_spec.rb

@@ -20,7 +20,10 @@ class BestElement < ActiveRecord::Base
 end
 
 class HistorableElement < ActiveRecord::Base
-    acts_more_seo :columns => :name, :use_id => false, :history => true
+    acts_more_seo :columns => :name, 
+      :use_id => false, 
+      :history => true,
+      :case_sensitive => true
 end
 
 describe CoolElement do
@@ -178,9 +181,10 @@ describe BestElement do
   end
 
   context "when we have a class which has use_id => false" do
-    it "should find element only when seo_url is same (or by id)" do
+    it "should find element only when seo_url is same (or by id) case insensitive" do
       a = subject.create(:name => 'bla bla bla')
       subject.find_by_seo!(a.seo_url).should eql(a)
+      subject.find_by_seo!('Bla-bLa-blA').should eql(a)
       lambda { subject.find_by_seo!("#{a.to_param}aaa") }.should raise_error(ActiveRecord::RecordNotFound)
     end
   end
@@ -270,7 +274,15 @@ describe HistorableElement do
         nr.should eql Acts::MoreSeo::SeoHistory.count
       end
     end
+  end
 
+  context "when searching for a case sensitive element" do
+    it "shoudl find only if case is same" do
+      a = subject.create(:name => 'Kraj Żelaza')
+      subject.find_by_seo('kraj-zelaza').should eql a
+      lambda { subject.find_by_seo!('kraj-zelazA') }.should raise_error(ActiveRecord::RecordNotFound)    
+    end
   end
 
 end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_more_seo
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-25 00:00:00.000000000Z
+date: 2012-02-27 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: babosa
-  requirement: &11903760 !ruby/object:Gem::Requirement
+  requirement: &15529440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *11903760
+  version_requirements: *15529440
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &11902800 !ruby/object:Gem::Requirement
+  requirement: &15528640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *11902800
+  version_requirements: *15528640
 - !ruby/object:Gem::Dependency
   name: active_record
-  requirement: &11902200 !ruby/object:Gem::Requirement
+  requirement: &15528020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *11902200
+  version_requirements: *15528020
 description: Gem makes your ActiveRecord models more SEO friendly. Changes URL to
   look way better
 email: maciej@mensfeld.pl