acts_as_votable 0.12.1 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2009307e736be800daee0e8ee1ab174eaf9d0bcf
-  data.tar.gz: 1a1bd0c1391488334ca8509fb8a18d6e95bcfb88
+SHA256:
+  metadata.gz: b1843c2e0892abc19c5ecc63dd48e38fe8d48e1cdb7affc3c90d67b0419725e1
+  data.tar.gz: b05a72a3a7310c362233e9d54301a695a03fb72c9fb6068b2fde8e58d1e238bb
 SHA512:
-  metadata.gz: '0882bea0b7292e43280c383002f2955ad8fc254a8afd838d1525d5a4bb0afe76774a1c104dd8448bb82099d086b4b668c19323f9e0bba6d19a91ecd8556987ad'
-  data.tar.gz: 26cb45e05dce7f060a69fded4c613daf51d6090cacf4c0dab62d2d97cf7d594f0fb128000c34994205a02369369bc767b7277863ee59b6bc2bee2d0a6e1807ca
+  metadata.gz: a125832f11dd75fa540f90791b5bdc092b92ade7c2a34218947fa1621aae21487eb38d8664636d1113885bb878927805a10f0db5edb786c48a8339832859bd68
+  data.tar.gz: 23bb31cc323d1173f982b2d12895b834e26b1ede7a6293cc1343538140f2fe3f7f9c0c89daf4de4ea67d72a69b4b4bbca2c4ec53555500ec965f26ca8fb1f475

data/.github/workflows/main.yml

@@ -0,0 +1,44 @@
+name: CI
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
+
+jobs:
+  tests:
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu
+        ruby:
+          - 2.5
+          - 2.6
+          - 2.7
+        gemfile:
+          - gemfiles/rails_5_1.gemfile
+          - gemfiles/rails_5_2.gemfile
+          - gemfiles/rails_6.gemfile
+          - gemfiles/rails_6_1.gemfile
+        continue-on-error:
+          - false
+
+    env:
+      BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
+    runs-on: ${{ matrix.os }}-latest
+    continue-on-error: ${{ matrix.continue-on-error }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Test
+        run: bundle exec rake spec
+
+# use this

data/.ruby-version

@@ -0,0 +1 @@
+2.5.3

data/Appraisals

@@ -1,17 +1,23 @@
 # frozen_string_literal: true
 
 appraise "rails-4" do
-  gem "rails", "4.2.10"
-end
-
-appraise "rails-5" do
-  gem "rails", "5.0.6"
+  gem "rails", "4.2.11"
 end
 
 appraise "rails-5-1" do
-  gem "rails", "5.1.4"
+  gem "rails", "5.1.7"
 end
 
 appraise "rails-5-2" do
-  gem "rails", "5.2.0"
+  gem "rails", "5.2.4"
 end
+
+appraise "rails-6" do
+  gem "rails", "6.0.3"
+  gem "sqlite3", "~> 1.4"
+end
+
+appraise "rails-6-1" do
+  gem "rails", "6.1.0"
+  gem "sqlite3", "~> 1.4"
+end

data/README.md

@@ -1,7 +1,6 @@
 # Acts As Votable (aka Acts As Likeable)
 
-[![Build Status](https://travis-ci.org/ryanto/acts_as_votable.svg?branch=master)](https://travis-ci.org/ryanto/acts_as_votable)
-[![Code Climate](https://codeclimate.com/github/ryanto/acts_as_votable.svg)](https://codeclimate.com/github/ryanto/acts_as_votable)
+![Build status](https://github.com/ryanto/acts_as_votable/workflows/CI/badge.svg)
 
 Acts As Votable is a Ruby Gem specifically written for Rails/ActiveRecord models.
 The main goals of this gem are:
@@ -24,7 +23,7 @@ The main goals of this gem are:
 Just add the following to your Gemfile to install the latest release.
 
 ```ruby
-gem 'acts_as_votable', '~> 0.12.0'
+gem 'acts_as_votable'
 ```
 
 And follow that up with a ``bundle install``.
@@ -35,7 +34,7 @@ Acts As Votable uses a votes table to store all voting information.  To
 generate and run the migration just use.
 
     rails generate acts_as_votable:migration
-    rake db:migrate
+    rails db:migrate
 
 You will get a performance increase by adding in cached columns to your model's
 tables.  You will have to do this manually through your own migrations.  See the
@@ -46,7 +45,7 @@ caching section of this document for more information.
 ### Votable Models
 
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   acts_as_votable
 end
 
@@ -193,15 +192,15 @@ You can add weight to your vote. The default value is 1.
 You can have your voters `acts_as_voter` to provide some reserve functionality.
 
 ```ruby
-class User < ActiveRecord::Base
+class User < ApplicationRecord
   acts_as_voter
 end
 
 @user.likes @article
 
-@article.votes.size # => 1
-@article.likes.size # => 1
-@article.dislikes.size # => 0
+@article.votes_for.size # => 1
+@article.get_likes.size # => 1
+@article.get_dislikes.size # => 0
 ```
 
 To check if a voter has voted on a model, you can use ``voted_for?``.  You can
@@ -274,8 +273,8 @@ because `@user` has already voted for `@shoe`.
 @user.likes @shoe
 @user.likes @shoe
 
-@shoe.votes # => 1
-@shoe.likes # => 1
+@shoe.votes_for.size # => 1
+@shoe.get_likes.size # => 1
 ```
 
 To check if a vote counted, or registered, use `vote_registered?` on your model
@@ -291,9 +290,9 @@ after voting.  For example:
 @hat.disliked_by @user
 @hat.vote_registered? # => true, because user changed their vote
 
-@hat.votes.size # => 1
-@hat.positives.size # => 0
-@hat.negatives.size # => 1
+@hat.votes_for.size # => 1
+@hat.get_positives.size # => 0
+@hat.get_negatives.size # => 1
 ```
 
 To permit duplicates entries of a same voter, use option duplicate. Also notice that this
@@ -368,7 +367,7 @@ not by passing `cacheable_strategy` option to `acts_as_votable` method.
 By default, `update` strategy is used. Pass `:update_columns` as
 `cacheable_strategy` if you don't want to touch model's `updated_at` column.
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   acts_as_votable cacheable_strategy: :update_columns
 end
 ```

data/gemfiles/rails_4.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "4.2.10"
+gem "rails", "4.2.11"
 
 gemspec path: "../"

data/gemfiles/rails_5_1.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "5.1.4"
+gem "rails", "5.1.7"
 
 gemspec path: "../"

data/gemfiles/rails_5_2.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "5.2.0"
+gem "rails", "5.2.4"
 
 gemspec path: "../"

data/gemfiles/rails_6.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.0.3"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

data/gemfiles/rails_6_1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.1.0"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

data/gemfiles/rails_6_rc1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.0.0.rc1"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

data/lib/acts_as_votable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsVotable
-  VERSION = "0.12.1"
+  VERSION = "0.13.0"
 end

data/lib/acts_as_votable/votable.rb

@@ -93,14 +93,16 @@ module ActsAsVotable
       #Allowing for a vote_weight to be associated with every vote. Could change with every voter object
       vote.vote_weight = (options[:vote_weight].to_i if options[:vote_weight].present?) || 1
 
+      vote_saved = false
       ActiveRecord::Base.transaction do
         self.vote_registered = false
-        return false unless vote.save
-
-        self.vote_registered = true if last_update != vote.updated_at
-        update_cached_votes(options[:vote_scope])
-        return true
+        vote_saved = vote.save
+        if vote_saved
+          self.vote_registered = true if last_update != vote.updated_at
+          update_cached_votes(options[:vote_scope])
+        end
       end
+      vote_saved
     end
 
     def unvote(args = {})

data/spec/shared_example/votable_model.rb

@@ -416,7 +416,7 @@ shared_examples "a votable_model" do
 
           it do
             expect(votable_cache.cached_votes_total).to eq(1)
-            expect(votable_cache.updated_at).to_not eq updated_at
+            expect(votable_cache.updated_at.to_i).to_not eq updated_at.to_i
           end
         end
 
@@ -425,7 +425,7 @@ shared_examples "a votable_model" do
 
           it do
             expect(votable_cache.cached_votes_total).to eq(1)
-            expect(votable_cache.updated_at).to eq updated_at
+            expect(votable_cache.updated_at.to_i).to eq updated_at.to_i
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_votable
 version: !ruby/object:Gem::Version
-  version: 0.12.1
+  version: 0.13.0
 platform: ruby
 authors:
 - Ryan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-07-18 00:00:00.000000000 Z
+date: 2020-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -101,9 +101,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".ruby-version"
 - Appraisals
 - Gemfile
 - README.md
@@ -114,6 +115,9 @@ files:
 - gemfiles/rails_5.gemfile
 - gemfiles/rails_5_1.gemfile
 - gemfiles/rails_5_2.gemfile
+- gemfiles/rails_6.gemfile
+- gemfiles/rails_6_1.gemfile
+- gemfiles/rails_6_rc1.gemfile
 - lib/acts_as_votable.rb
 - lib/acts_as_votable/cacheable.rb
 - lib/acts_as_votable/extenders/controller.rb
@@ -148,7 +152,7 @@ homepage: http://rubygems.org/gems/acts_as_votable
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -163,9 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.2.2
+signing_key:
 specification_version: 4
 summary: Rails gem to allowing records to be votable
 test_files:

data/.travis.yml

@@ -1,21 +0,0 @@
-language: ruby
-
-cache: bundler
-
-rvm:
-  - 2.3.4
-  - 2.4.2
-  - 2.5.1
-
-before_install:
-  - gem update --system
-  # Stay on Bundler 1.x (for dependency reasons as we want to support Rails 4.2.x and Ruby 2.3.x)
-  # More info here: https://docs.travis-ci.com/user/languages/ruby/#bundler-20
-  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
-  - gem install bundler -v '< 2'
-
-gemfile:
-  - gemfiles/rails_4.gemfile
-  - gemfiles/rails_5.gemfile
-  - gemfiles/rails_5_1.gemfile
-  - gemfiles/rails_5_2.gemfile