acts_as_votable 0.11.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ec62f24bb2a85474f561c476a47007e333dae16f
-  data.tar.gz: ab88ccd51c8d63225b05b7f6443056cd0defe2a5
+SHA256:
+  metadata.gz: 1d9154268f7a15b8f66a0dcf909ce0dffd9e675c97559924c653c3ba90f4cf14
+  data.tar.gz: 3cf9b07d912de5732d8867ad1fb16394244857ce4fb150682154c5e4a6b3e715
 SHA512:
-  metadata.gz: be0133a6030a9c0d83a6753b82360c100ed998a608f98829fd97bc4cbbf27f61990fb1bbc9eac9b9b46b0d4d7e122556e3fce47eb59eb7bf5d42a71a1f895512
-  data.tar.gz: ec1ee10e398a40bb5b20a568265334194e29ca8b05b75a8e8f8c87076e9d187f72225124704af321ffa3b615853906b51daf96a4837074f97bdda4cbe27a28a2
+  metadata.gz: 3c1c7c024425ec4e0a22432e820f6d47598d0b0adaef43930c37f9ea9fb9d7c832e831e60252b8545679d12125b9f4912e8cc14356ad34e32c26237ddfa0422c
+  data.tar.gz: f36cbcdc97e3f03470227dc669ad9f992f09e8d2e7ff66c5f0bd986ace5677dddcbf1552e6ee69e18148628ad70e5d5cd55357f4048f6f7fb503eca0a5c5a13f

data/.github/workflows/main.yml

@@ -0,0 +1,44 @@
+name: CI
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
+
+jobs:
+  tests:
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu
+        ruby:
+          - 2.5
+          - 2.6
+          - 2.7
+        gemfile:
+          - gemfiles/rails_5_1.gemfile
+          - gemfiles/rails_5_2.gemfile
+          - gemfiles/rails_6.gemfile
+          - gemfiles/rails_6_1.gemfile
+        continue-on-error:
+          - false
+
+    env:
+      BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
+    runs-on: ${{ matrix.os }}-latest
+    continue-on-error: ${{ matrix.continue-on-error }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Test
+        run: bundle exec rake spec
+
+# use this

data/.gitignore

@@ -1,6 +1,7 @@
 /.bundle/
 /.yardoc
 /Gemfile.lock
+/gemfiles/*.gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/.ruby-version

@@ -0,0 +1 @@
+2.5.3

data/Appraisals

@@ -1,13 +1,19 @@
 # frozen_string_literal: true
 
-appraise "rails-4" do
-  gem "rails", "4.2.9"
+appraise "rails-5-1" do
+  gem "rails", "5.1.7"
 end
 
-appraise "rails-5" do
-  gem "rails", "5.0.5"
+appraise "rails-5-2" do
+  gem "rails", "5.2.4"
 end
 
-appraise "rails-5-1" do
-  gem "rails", "5.1.4"
+appraise "rails-6" do
+  gem "rails", "6.0.3"
+  gem "sqlite3", "~> 1.4"
 end
+
+appraise "rails-6-1" do
+  gem "rails", "6.1.0"
+  gem "sqlite3", "~> 1.4"
+end

data/{README.markdown → README.md}

@@ -1,7 +1,6 @@
 # Acts As Votable (aka Acts As Likeable)
 
-[![Build Status](https://travis-ci.org/ryanto/acts_as_votable.png)](https://travis-ci.org/ryanto/acts_as_votable)
-[![Code Climate](https://codeclimate.com/github/ryanto/acts_as_votable.png)](https://codeclimate.com/github/ryanto/acts_as_votable)
+![Build status](https://github.com/ryanto/acts_as_votable/workflows/CI/badge.svg)
 
 Acts As Votable is a Ruby Gem specifically written for Rails/ActiveRecord models.
 The main goals of this gem are:
@@ -16,16 +15,15 @@ The main goals of this gem are:
 
 ### Supported Ruby and Rails versions
 
-* Ruby 2.2.0, 2.3.0 and 2.4.0
-* Rails 4.0, 4.1+
-* Rails 5.0, 5.1
+- Ruby >= 2.5.0
+- Rails >= 5.1
 
 ### Install
 
 Just add the following to your Gemfile to install the latest release.
 
 ```ruby
-gem 'acts_as_votable', '~> 0.10.0'
+gem 'acts_as_votable'
 ```
 
 And follow that up with a ``bundle install``.
@@ -35,8 +33,10 @@ And follow that up with a ``bundle install``.
 Acts As Votable uses a votes table to store all voting information.  To
 generate and run the migration just use.
 
-    rails generate acts_as_votable:migration
-    rake db:migrate
+```bash
+rails generate acts_as_votable:migration
+rails db:migrate
+```
 
 You will get a performance increase by adding in cached columns to your model's
 tables.  You will have to do this manually through your own migrations.  See the
@@ -47,7 +47,7 @@ caching section of this document for more information.
 ### Votable Models
 
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   acts_as_votable
 end
 
@@ -77,7 +77,6 @@ By default all votes are positive, so `@user3` has cast a 'good' vote for `@post
 
 `@user2` and `@user4` on the other had has voted against `@post`.
 
-
 Just about any word works for casting a vote in favor or against post.  Up/Down,
 Like/Dislike, Positive/Negative... the list goes on-and-on.  Boolean flags `true` and
 `false` are also applicable.
@@ -167,6 +166,7 @@ You can add a scope to your vote
 @post.find_votes_for(:vote_scope => 'week').size # => 1
 @post.find_votes_for(:vote_scope => 'month').size # => 1
 ```
+
 ### Adding weights to your votes
 
 You can add weight to your vote. The default value is 1.
@@ -194,15 +194,15 @@ You can add weight to your vote. The default value is 1.
 You can have your voters `acts_as_voter` to provide some reserve functionality.
 
 ```ruby
-class User < ActiveRecord::Base
+class User < ApplicationRecord
   acts_as_voter
 end
 
 @user.likes @article
 
-@article.votes.size # => 1
-@article.likes.size # => 1
-@article.dislikes.size # => 0
+@article.votes_for.size # => 1
+@article.get_likes.size # => 1
+@article.get_dislikes.size # => 0
 ```
 
 To check if a voter has voted on a model, you can use ``voted_for?``.  You can
@@ -275,8 +275,8 @@ because `@user` has already voted for `@shoe`.
 @user.likes @shoe
 @user.likes @shoe
 
-@shoe.votes # => 1
-@shoe.likes # => 1
+@shoe.votes_for.size # => 1
+@shoe.get_likes.size # => 1
 ```
 
 To check if a vote counted, or registered, use `vote_registered?` on your model
@@ -292,9 +292,9 @@ after voting.  For example:
 @hat.disliked_by @user
 @hat.vote_registered? # => true, because user changed their vote
 
-@hat.votes.size # => 1
-@hat.positives.size # => 0
-@hat.negatives.size # => 1
+@hat.votes_for.size # => 1
+@hat.get_positives.size # => 0
+@hat.get_negatives.size # => 1
 ```
 
 To permit duplicates entries of a same voter, use option duplicate. Also notice that this
@@ -312,35 +312,20 @@ to speed up @post we would use the following migration:
 
 ```ruby
 class AddCachedVotesToPosts < ActiveRecord::Migration
-  def self.up
-    add_column :posts, :cached_votes_total, :integer, :default => 0
-    add_column :posts, :cached_votes_score, :integer, :default => 0
-    add_column :posts, :cached_votes_up, :integer, :default => 0
-    add_column :posts, :cached_votes_down, :integer, :default => 0
-    add_column :posts, :cached_weighted_score, :integer, :default => 0
-    add_column :posts, :cached_weighted_total, :integer, :default => 0
-    add_column :posts, :cached_weighted_average, :float, :default => 0.0
-    add_index  :posts, :cached_votes_total
-    add_index  :posts, :cached_votes_score
-    add_index  :posts, :cached_votes_up
-    add_index  :posts, :cached_votes_down
-    add_index  :posts, :cached_weighted_score
-    add_index  :posts, :cached_weighted_total
-    add_index  :posts, :cached_weighted_average
+  def change
+    change_table :posts do |t|
+      t.integer :cached_votes_total, default: 0
+      t.integer :cached_votes_score, default: 0
+      t.integer :cached_votes_up, default: 0
+      t.integer :cached_votes_down, default: 0
+      t.integer :cached_weighted_score, default: 0
+      t.integer :cached_weighted_total, default: 0
+      t.float :cached_weighted_average, default: 0.0
+    end
 
     # Uncomment this line to force caching of existing votes
     # Post.find_each(&:update_cached_votes)
   end
-
-  def self.down
-    remove_column :posts, :cached_votes_total
-    remove_column :posts, :cached_votes_score
-    remove_column :posts, :cached_votes_up
-    remove_column :posts, :cached_votes_down
-    remove_column :posts, :cached_weighted_score
-    remove_column :posts, :cached_weighted_total
-    remove_column :posts, :cached_weighted_average
-  end
 end
 ```
 
@@ -348,36 +333,21 @@ If you have a scope for your vote, let's say `subscribe`, your migration will be
 
 ```ruby
 class AddCachedVotesToPosts < ActiveRecord::Migration
-  def self.up
-    add_column :posts, :cached_scoped_subscribe_votes_total, :integer, :default => 0
-    add_column :posts, :cached_scoped_subscribe_votes_score, :integer, :default => 0
-    add_column :posts, :cached_scoped_subscribe_votes_up, :integer, :default => 0
-    add_column :posts, :cached_scoped_subscribe_votes_down, :integer, :default => 0
-    add_column :posts, :cached_weighted_subscribe_score, :integer, :default => 0
-    add_column :posts, :cached_weighted_subscribe_total, :integer, :default => 0
-    add_column :posts, :cached_weighted_subscribe_average, :float, :default => 0.0
-    add_index  :posts, :cached_scoped_subscribe_votes_total
-    add_index  :posts, :cached_scoped_subscribe_votes_score
-    add_index  :posts, :cached_scoped_subscribe_votes_up
-    add_index  :posts, :cached_scoped_subscribe_votes_down
-    add_index  :posts, :cached_weighted_subscribe_score
-    add_index  :posts, :cached_weighted_subscribe_total
-    add_index  :posts, :cached_weighted_subscribe_average
-  end
-
-  def self.down
-    remove_column :posts, :cached_scoped_subscribe_votes_total
-    remove_column :posts, :cached_scoped_subscribe_votes_score
-    remove_column :posts, :cached_scoped_subscribe_votes_up
-    remove_column :posts, :cached_scoped_subscribe_votes_down
-    remove_column :posts, :cached_weighted_subscribe_score
-    remove_column :posts, :cached_weighted_subscribe_total
-    remove_column :posts, :cached_weighted_subscribe_average
+  def change
+    change_table :posts do |t|
+      t.integer :cached_scoped_subscribe_votes_total, default: 0
+      t.integer :cached_scoped_subscribe_votes_score, default: 0
+      t.integer :cached_scoped_subscribe_votes_up, default: 0
+      t.integer :cached_scoped_subscribe_votes_down, default: 0
+      t.integer :cached_weighted_subscribe_score, default: 0
+      t.integer :cached_weighted_subscribe_total, default: 0
+      t.float :cached_weighted_subscribe_average, default: 0.0
+    end
   end
 end
 ```
 
-`cached_weighted_average` can be helpful for a rating system, e.g.: 
+`cached_weighted_average` can be helpful for a rating system, e.g.:
 
 Order by average rating:
 
@@ -391,63 +361,30 @@ Display average rating:
 <%= post.weighted_average.round(2) %> / 5
 <!-- 3.5 / 5 -->
 ```
-## updated_at at Votable model
+
+## Votable model's `updated_at`
 
 You can control whether `updated_at` column of votable model will be touched or
 not by passing `cacheable_strategy` option to `acts_as_votable` method.
 
-By default, `update_attributes` strategy is used. Pass `:update_columns` as
+By default, `update` strategy is used. Pass `:update_columns` as
 `cacheable_strategy` if you don't want to touch model's `updated_at` column.
+
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   acts_as_votable cacheable_strategy: :update_columns
 end
 ```
 
-NOTE: this option does not work for ActiveRecord < 3.1
-
-
 ## Testing
 
 All tests follow the RSpec format and are located in the spec directory.
 They can be run with:
 
-```
+```bash
 rake spec
 ```
 
-## Changes  
-
-### Fixes for votable voter model  
-
-In version 0.8.0, there are bugs for a model that is both votable and voter.  
-Some name-conflicting methods are renamed:
-+ Renamed Votable.votes to votes_for  
-+ Renamed Votable.vote to vote_by,
-+ Removed Votable.vote_by alias (was an alias for :vote_up)
-+ Renamed Votable.unvote_for to unvote_by
-+ Renamed Votable.find_votes to find_votes_for
-+ Renamed Votable.up_votes to get_upvotes 
-  + and its aliases :get_true_votes, :get_ups, :get_upvotes, :get_likes, :get_positives, :get_for_votes
-+ Renamed Votable.down_votes to get_downvotes 
-  + and its aliases :get_false_votes, :get_downs, :get_downvotes, :get_dislikes, :get_negatives
-
-
 ## License
 
-Acts as votable is released under the [MIT
-License](http://www.opensource.org/licenses/MIT).
-
-## Next steps
-
-- Pass in a block of options when creating acts_as.  Allow for things
-  like disabling the aliasing
-
-- Smarter language syntax.  Example: `@user.likes` will return all of the votables
-that the user likes, while `@user.likes @model` will cast a vote for @model by
-@user.
-
-- The aliased methods are referred to by using the terms 'up/down' and/or
-'true/false'. Need to come up with guidelines for naming these methods.
-
-- Create more aliases. Specifically for counting votes and finding votes.
+Acts as votable is released under the [MIT License](http://www.opensource.org/licenses/MIT).

data/acts_as_votable.gemspec

@@ -15,17 +15,15 @@ Gem::Specification.new do |s|
   s.description = "Rails gem to allowing records to be votable"
   s.license     = "MIT"
 
-  s.rubyforge_project = "acts_as_votable"
-
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.add_development_dependency "rspec", "~> 3.6"
-  s.add_development_dependency "sqlite3", "~> 1.3"
+  s.add_development_dependency "sqlite3", "~> 1.3.6"
   s.add_development_dependency "rubocop", "~> 0.49.1"
   s.add_development_dependency "simplecov", "~> 0.15.0"
   s.add_development_dependency "appraisal", "~> 2.2"
-  s.add_development_dependency "factory_girl", "~> 4.8"
+  s.add_development_dependency "factory_bot", "~> 4.8"
 end

data/gemfiles/rails_4.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "4.2.9"
+gem "rails", "4.2.11"
 
 gemspec path: "../"

data/gemfiles/rails_5.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "5.0.5"
+gem "rails", "5.0.6"
 
 gemspec path: "../"

data/gemfiles/rails_5_1.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "5.1.4"
+gem "rails", "5.1.7"
 
 gemspec path: "../"

data/gemfiles/rails_5_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "5.2.4"
+
+gemspec path: "../"

data/gemfiles/rails_6.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.0.3"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

data/gemfiles/rails_6_1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.1.0"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

data/gemfiles/rails_6_rc1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "6.0.0.rc1"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"