acts_as_versioned-decisiv 3.2.0

data/lib/acts_as_versioned/version.rb

@@ -0,0 +1,7 @@
+module ActiveRecord
+  module Acts
+    module Versioned
+      VERSION = '3.2.0'
+    end
+  end
+end

data/test/helper.rb

@@ -0,0 +1,63 @@
+require 'rubygems'
+require 'bundler'
+require "bundler/setup"
+Bundler.require
+require 'acts_as_versioned'
+require 'active_record/base'
+require 'database_cleaner'
+require 'minitest/autorun'
+require 'logger'
+
+TEST_ROOT = File.expand_path('./test')
+ActiveRecord::Base.logger = nil # Logger.new("#{TEST_ROOT}/debug.log")
+ActiveRecord::Base.establish_connection :adapter => 'sqlite3', :database => ':memory:'
+DatabaseCleaner.strategy = :transaction
+
+require 'lib/schema'
+require 'lib/models'
+require 'lib/factories'
+require 'lib/fixtures'
+
+class AAVTestCase < MiniTest::Spec
+  
+  before { DatabaseCleaner.start }
+  after  { DatabaseCleaner.clean }
+  
+  protected
+  
+  def authors(name)
+    case name
+    when :caged then Author.find_by_name('caged')
+    when :mly then Author.find_by_name('mly')
+    end
+  end
+  
+  def pages(name)
+    case name
+    when :welcome then Page.find_by_title('Welcome to the weblog')
+    end
+  end
+  
+  def page_versions(name)
+    case name
+    when :welcome_1 then Page::Version.find_by_title('Welcome to the weblg')
+    when :welcome_2 then Page::Version.find_by_title('Welcome to the weblog')
+    end
+  end
+  
+  def locked_pages(name)
+    case name
+    when :welcome then LockedPage.find_by_title('Welcome to the weblog')
+    when :thinking then LockedPage.find_by_title('So I was thinking')
+    end
+  end
+  
+  def landmarks(name)
+    case name
+    when :washington then Landmark.find_by_name('Washington, D.C.')
+    end
+  end
+  
+end
+
+

data/test/lib/factories.rb

@@ -0,0 +1,36 @@
+require 'factory_girl'
+
+module Seed
+  class Page < ActiveRecord::Base ; self.table_name = 'pages' ; end
+  class PageVersion < ActiveRecord::Base ; self.table_name = 'page_versions' ; end
+  class LockedPage < ActiveRecord::Base ; self.table_name = 'locked_pages' ; end
+  class LockedPageRevision < ActiveRecord::Base ; self.table_name = 'locked_pages_revisions' ; end
+  class Author < ActiveRecord::Base ; self.table_name = 'authors' ; end
+  class Widget < ActiveRecord::Base ; self.table_name = 'widgets' ; end
+  class WidgetVersion < ActiveRecord::Base ; self.table_name = 'widget_versions' ; end
+  class Landmark < ActiveRecord::Base ; self.table_name = 'landmarks' ; end
+  class LandmarkVersion < ActiveRecord::Base ; self.table_name = 'landmark_versions' ; end
+end
+
+FactoryGirl.define do
+  
+  factory :page do
+    title  { Forgery(:lorem_ipsum).words(4) }
+    body   { Forgery(:lorem_ipsum).words(30) }
+  end
+  
+  factory :locked_page do
+    title  { Forgery(:lorem_ipsum).words(4) }
+  end
+  
+  # Seeds
+  
+  factory :seed_author,           :class => Seed::Author
+  factory :seed_page,             :class => Seed::Page
+  factory :seed_page_version,     :class => Seed::PageVersion
+  factory :seed_locked_page,      :class => Seed::LockedPage
+  factory :seed_locked_page_rev,  :class => Seed::LockedPageRevision
+  factory :seed_landmark,         :class => Seed::Landmark
+  factory :seed_landmark_version, :class => Seed::LandmarkVersion
+  
+end

data/test/lib/fixtures.rb

@@ -0,0 +1,57 @@
+
+# Authors
+
+@caged = FactoryGirl.create :seed_author, :name => 'caged'
+@mly = FactoryGirl.create :seed_author, :name => 'mly'
+
+# Pages
+
+@welcome_page = FactoryGirl.create :seed_page, 
+  :title => 'Welcome to the weblog', :body => 'Such a lovely day', 
+  :version => 24, :author_id => @caged.id, :revisor_id => @caged.id
+
+FactoryGirl.create :seed_page_version,
+  :title => 'Welcome to the weblg', :body => 'Such a lovely day',
+  :version => 23, :author_id => @mly.id, :revisor_id => @mly.id,
+  :page_id => @welcome_page.id
+
+FactoryGirl.create :seed_page_version,
+  :title => 'Welcome to the weblog', :body => 'Such a lovely day',
+  :version => 24, :author_id => @caged, :revisor_id => @caged,
+  :page_id => @welcome_page.id
+
+# Locked Pages
+
+@welcome_lpage = FactoryGirl.create :seed_locked_page,
+  :title => 'Welcome to the weblog', :lock_version => 24, :type => 'LockedPage'
+
+FactoryGirl.create :seed_locked_page_rev,
+  :title => 'Welcome to the weblg', :lock_version => 23, :version_type => 'LockedPage',
+  :page_id => @welcome_lpage.id
+
+FactoryGirl.create :seed_locked_page_rev,
+  :title => 'Welcome to the weblog', :lock_version => 24, :version_type => 'LockedPage',
+  :page_id => @welcome_lpage.id
+
+@thinking_lpage = FactoryGirl.create :seed_locked_page,
+  :title => 'So I was thinking', :lock_version => 24, :type => 'SpecialLockedPage'
+
+FactoryGirl.create :seed_locked_page_rev,
+  :title => 'So I was thinking!!!', :lock_version => 23, :version_type => 'SpecialLockedPage',
+  :page_id => @thinking_lpage.id
+
+FactoryGirl.create :seed_locked_page_rev,
+  :title => 'So I was thinking', :lock_version => 24, :version_type => 'SpecialLockedPage',
+  :page_id => @thinking_lpage.id
+
+# Landmarks
+
+@washington = FactoryGirl.create :seed_landmark,
+  :name => 'Washington, D.C.', :latitude => 38.895, :longitude => -77.036667,
+  :version => 1, :doesnt_trigger_version => 'This is not important'
+
+FactoryGirl.create :seed_landmark_version,
+  :name => 'Washington, D.C.', :latitude => 38.895, :longitude => -77.036667,
+  :version => 1, :doesnt_trigger_version => 'This is not important',
+  :landmark_id => @washington.id
+  

data/test/lib/models.rb

@@ -0,0 +1,57 @@
+
+class Author < ActiveRecord::Base
+  has_many :pages
+end
+
+class Page < ActiveRecord::Base
+  belongs_to :author
+  has_many   :authors,  :through => :versions, :order => 'name'
+  belongs_to :revisor,  :class_name => 'Author'
+  has_many   :revisors, :class_name => 'Author', :through => :versions, :order => 'name'
+  acts_as_versioned :if => :feeling_good? do
+    def self.included(base)
+      base.cattr_accessor :feeling_good
+      base.feeling_good = true
+      base.belongs_to :author
+      base.belongs_to :revisor, :class_name => 'Author'
+    end
+
+    def feeling_good?
+      self.class.feeling_good == true
+    end
+  end
+end
+
+module LockedPageExtension
+  def hello_world
+    'hello_world'
+  end
+end
+
+class LockedPage < ActiveRecord::Base
+  acts_as_versioned \
+    :inheritance_column => :version_type, 
+    :foreign_key        => :page_id, 
+    :table_name         => :locked_pages_revisions, 
+    :class_name         => 'LockedPageRevision',
+    :version_column     => :lock_version,
+    :limit              => 2,
+    :if_changed         => :title,
+    :extend             => LockedPageExtension
+end
+
+class SpecialLockedPage < LockedPage
+end
+
+class Landmark < ActiveRecord::Base
+  acts_as_versioned :if_changed => [ :name, :longitude, :latitude ]
+end
+
+class Widget < ActiveRecord::Base
+  acts_as_versioned :sequence_name => 'widgets_seq', :association_options => {
+    :dependent => :nullify, :order => 'version desc'
+  }
+  non_versioned_columns << 'foo'
+end
+
+

data/test/lib/schema.rb

@@ -0,0 +1,86 @@
+ActiveRecord::Base.class_eval do
+  silence do
+
+    connection.create_table :pages, :force => true do |t|
+      t.column :version, :integer
+      t.column :title, :string, :limit => 255
+      t.column :body, :text
+      t.column :created_on, :datetime
+      t.column :updated_on, :datetime
+      t.column :author_id, :integer
+      t.column :revisor_id, :integer
+    end
+
+    connection.create_table :page_versions, :force => true do |t|
+      t.column :page_id, :integer
+      t.column :version, :integer
+      t.column :title, :string, :limit => 255
+      t.column :body, :text
+      t.column :created_on, :datetime
+      t.column :updated_on, :datetime
+      t.column :author_id, :integer
+      t.column :revisor_id, :integer
+    end
+  
+    connection.add_index :page_versions, [:page_id, :version], :unique => true
+  
+    connection.create_table :authors, :force => true do |t|
+      t.column :page_id, :integer
+      t.column :name, :string
+    end
+  
+    connection.create_table :locked_pages, :force => true do |t|
+      t.column :lock_version, :integer
+      t.column :title, :string, :limit => 255
+      t.column :body, :text
+      t.column :type, :string, :limit => 255
+    end
+
+    connection.create_table :locked_pages_revisions, :force => true do |t|
+      t.column :page_id, :integer
+      t.column :lock_version, :integer
+      t.column :title, :string, :limit => 255
+      t.column :body, :text
+      t.column :version_type, :string, :limit => 255
+      t.column :updated_at, :datetime
+    end
+  
+    connection.add_index :locked_pages_revisions, [:page_id, :lock_version], :unique => true
+
+    connection.create_table :widgets, :force => true do |t|
+      t.column :name, :string, :limit => 50
+      t.column :foo, :string
+      t.column :version, :integer
+      t.column :updated_at, :datetime
+    end
+
+    connection.create_table :widget_versions, :force => true do |t|
+      t.column :widget_id, :integer
+      t.column :name, :string, :limit => 50
+      t.column :version, :integer
+      t.column :updated_at, :datetime
+    end
+  
+    connection.add_index :widget_versions, [:widget_id, :version], :unique => true
+  
+    connection.create_table :landmarks, :force => true do |t|
+      t.column :name, :string
+      t.column :latitude, :float
+      t.column :longitude, :float
+      t.column :doesnt_trigger_version,:string
+      t.column :version, :integer
+    end
+
+    connection.create_table :landmark_versions, :force => true do |t|
+      t.column :landmark_id, :integer
+      t.column :name, :string
+      t.column :latitude, :float
+      t.column :longitude, :float
+      t.column :doesnt_trigger_version,:string
+      t.column :version, :integer
+    end
+  
+    connection.add_index :landmark_versions, [:landmark_id, :version], :unique => true
+
+  end
+end

data/test/migration_test.rb

@@ -0,0 +1,34 @@
+require 'helper'
+
+class Thing < ActiveRecord::Base
+  attr_accessor :version
+  acts_as_versioned
+end
+
+class MigrationTest < AAVTestCase
+  
+  let(:mig_dir) { "#{TEST_ROOT}/migrations" }
+  
+  before do
+    ActiveRecord::Migration.verbose = false
+  end
+ 
+  def test_versioned_migration
+    assert_raises(ActiveRecord::StatementInvalid) { Thing.create :title => 'blah blah' }
+    # # take 'er up
+    ActiveRecord::Migrator.up(mig_dir)
+    t = Thing.create :title => 'blah blah', :price => 123.45, :type => 'Thing'
+    assert_equal 1, t.versions.size
+    # check that the price column has remembered its value correctly
+    assert_equal t.price,  t.versions.first.price
+    assert_equal t.title,  t.versions.first.title
+    assert_equal t[:type], t.versions.first[:type]
+    # make sure that the precision of the price column has been preserved
+    assert_equal 7, Thing::Version.columns.find{|c| c.name == "price"}.precision
+    assert_equal 2, Thing::Version.columns.find{|c| c.name == "price"}.scale
+    # # now lets take 'er back down
+    ActiveRecord::Migrator.down(mig_dir)
+    assert_raises(ActiveRecord::StatementInvalid) { Thing.create :title => 'blah blah' }
+  end
+  
+end

data/test/migrations/1_add_versioned_tables.rb

@@ -0,0 +1,17 @@
+class AddVersionedTables < ActiveRecord::Migration
+
+  def up
+    create_table("things") do |t|
+      t.column :title, :text
+      t.column :price, :decimal, :precision => 7, :scale => 2
+      t.column :type, :string
+    end
+    Thing.create_versioned_table
+  end
+  
+  def down
+    Thing.drop_versioned_table
+    drop_table "things" rescue nil
+  end
+
+end

data/test/versioned_test.rb

@@ -0,0 +1,344 @@
+require 'helper'
+
+class VersionedTest < AAVTestCase
+
+  def test_saves_versioned_copy
+    p = Page.create! :title => 'first title', :body => 'first body'
+    assert !p.new_record?
+    assert_equal 1, p.versions.size
+    assert_equal 1, p.version
+    assert_instance_of Page.versioned_class, p.versions.first
+  end
+  
+  def test_saves_without_revision
+    p = pages(:welcome)
+    old_versions = p.versions.count
+    p.save_without_revision
+    p.without_revision do
+      p.update_attributes :title => 'changed'
+    end
+    assert_equal old_versions, p.versions.count
+  end
+
+  def test_rollback_with_version_number
+    p = pages(:welcome)
+    assert_equal 24, p.version
+    assert_equal 'Welcome to the weblog', p.title
+    assert p.revert_to!(23), "Couldn't revert to 23"
+    assert_equal 23, p.version
+    assert_equal 'Welcome to the weblg', p.title
+  end
+  
+  def test_versioned_class_name
+    assert_equal 'Version', Page.versioned_class_name
+    assert_equal 'LockedPageRevision', LockedPage.versioned_class_name
+  end
+  
+  def test_versioned_class
+    assert_equal Page::Version,                  Page.versioned_class
+    assert_equal LockedPage::LockedPageRevision, LockedPage.versioned_class
+  end
+  
+  def test_special_methods
+    pages(:welcome).feeling_good?
+    pages(:welcome).versions.first.feeling_good?
+    locked_pages(:welcome).hello_world
+    locked_pages(:welcome).versions.first.hello_world
+  end
+  
+  def test_rollback_with_version_class
+    p = pages(:welcome)
+    assert_equal 24, p.version
+    assert_equal 'Welcome to the weblog', p.title
+    assert p.revert_to!(p.versions.find_by_version(23)), "Couldn't revert to 23"
+    assert_equal 23, p.version
+    assert_equal 'Welcome to the weblg', p.title
+  end
+  
+  def test_rollback_fails_with_invalid_revision
+    p = locked_pages(:welcome)
+    assert !p.revert_to!(locked_pages(:thinking))
+  end
+  
+  def test_saves_versioned_copy_with_options
+    p = LockedPage.create! :title => 'first title'
+    assert !p.new_record?
+    assert_equal 1, p.versions.size
+    assert_instance_of LockedPage.versioned_class, p.versions.first
+  end
+  
+  def test_rollback_with_version_number_with_options
+    p = locked_pages(:welcome)
+    assert_equal 'Welcome to the weblog', p.title
+    assert_equal 'LockedPage', p.versions.first.version_type
+    assert p.revert_to!(p.versions.first.lock_version), "Couldn't revert to 23"
+    assert_equal 'Welcome to the weblg', p.title
+    assert_equal 'LockedPage', p.versions.first.version_type
+  end
+  
+  def test_rollback_with_version_class_with_options
+    p = locked_pages(:welcome)
+    assert_equal 'Welcome to the weblog', p.title
+    assert_equal 'LockedPage', p.versions.first.version_type
+    assert p.revert_to!(p.versions.first), "Couldn't revert to 1"
+    assert_equal 'Welcome to the weblg', p.title
+    assert_equal 'LockedPage', p.versions.first.version_type
+  end
+  
+  def test_saves_versioned_copy_with_sti
+    p = SpecialLockedPage.create! :title => 'first title'
+    assert !p.new_record?
+    assert_equal 1, p.versions.size
+    assert_instance_of LockedPage.versioned_class, p.versions.first
+    assert_equal 'SpecialLockedPage', p.versions.first.version_type
+  end
+  
+  def test_rollback_with_version_number_with_sti
+    p = locked_pages(:thinking)
+    assert_equal 'So I was thinking', p.title
+    assert p.revert_to!(p.versions.first.lock_version), "Couldn't revert to 1"
+    assert_equal 'So I was thinking!!!', p.title
+    assert_equal 'SpecialLockedPage', p.versions.first.version_type
+  end
+  
+  def test_lock_version_works_with_versioning
+    p = locked_pages(:thinking)
+    p2 = LockedPage.find(p.id)
+    p.title = 'fresh title'
+    p.save
+    assert_equal 2, p.versions.size # limit!
+    assert_raises(ActiveRecord::StaleObjectError) do
+      p2.title = 'stale title'
+      p2.save
+    end
+  end
+  
+  def test_version_if_condition
+    p = Page.create! :title => "title"
+    assert_equal 1, p.version
+    Page.feeling_good = false
+    p.save
+    assert_equal 1, p.version
+    Page.feeling_good = true
+  end
+  
+  def test_version_if_condition2
+    # set new if condition
+    Page.class_eval do
+      def new_feeling_good() title[0..0] == 'a'; end
+      alias_method :old_feeling_good, :feeling_good?
+      alias_method :feeling_good?, :new_feeling_good
+    end
+    p = Page.create! :title => "title"
+    assert_equal 1, p.version # version does not increment
+    assert_equal 1, p.versions.count
+    p.update_attributes(:title => 'new title')
+    assert_equal 1, p.version # version does not increment
+    assert_equal 1, p.versions.count
+    p.update_attributes(:title => 'a title')
+    assert_equal 2, p.version
+    assert_equal 2, p.versions.count
+    # reset original if condition
+    Page.class_eval { alias_method :feeling_good?, :old_feeling_good }
+  end
+  
+  def test_version_if_condition_with_block
+    # set new if condition
+    old_condition = Page.version_condition
+    Page.version_condition = Proc.new { |page| page.title[0..0] == 'b' }
+    p = Page.create! :title => "title"
+    assert_equal 1, p.version # version does not increment
+    assert_equal 1, p.versions.count
+    p.update_attributes(:title => 'a title')
+    assert_equal 1, p.version # version does not increment
+    assert_equal 1, p.versions.count
+    p.update_attributes(:title => 'b title')
+    assert_equal 2, p.version
+    assert_equal 2, p.versions.count
+    # reset original if condition
+    Page.version_condition = old_condition
+  end
+  
+  def test_version_no_limit
+    p = Page.create! :title => "title", :body => 'first body'
+    p.save
+    p.save
+    5.times do |i|
+      p.title = "title#{i}"
+      p.save
+      assert_equal "title#{i}", p.title
+      assert_equal (i+2), p.version
+    end
+  end
+  
+  def test_version_max_limit
+    p = LockedPage.create! :title => "title"
+    p.update_attributes(:title => "title1")
+    p.update_attributes(:title => "title2")
+    5.times do |i|
+      p.title = "title#{i}"
+      p.save
+      assert_equal "title#{i}", p.title
+      assert_equal (i+4), p.lock_version
+      assert p.versions(true).size <= 2, "locked version can only store 2 versions"
+    end
+  end
+  
+  def test_track_altered_attributes_default_value
+    assert !Page.track_altered_attributes
+    assert LockedPage.track_altered_attributes
+    assert SpecialLockedPage.track_altered_attributes
+  end
+  
+  def test_track_altered_attributes
+    p = LockedPage.create! :title => "title"
+    assert_equal 1, p.lock_version
+    assert_equal 1, p.versions(true).size
+    p.body = 'whoa'
+    assert !p.save_version?
+    p.save
+    assert_equal 2, p.lock_version # still increments version because of optimistic locking
+    assert_equal 1, p.versions(true).size
+    p.title = 'updated title'
+    assert p.save_version?
+    p.save
+    assert_equal 3, p.lock_version
+    assert_equal 1, p.versions(true).size # version 1 deleted
+    p.title = 'updated title!'
+    assert p.save_version?
+    p.save
+    assert_equal 4, p.lock_version
+    assert_equal 2, p.versions(true).size # version 1 deleted
+  end
+  
+  def test_find_versions
+    assert_equal 1, locked_pages(:welcome).versions.find(:all, :conditions => ['title LIKE ?', '%weblog%']).size
+  end
+  
+  def test_find_version
+    assert_equal page_versions(:welcome_1), pages(:welcome).versions.find_by_version(23)
+  end
+  
+  def test_with_sequence
+    assert_equal 'widgets_seq', Widget.versioned_class.sequence_name
+    3.times { Widget.create! :name => 'new widget' }
+    assert_equal 3, Widget.count
+    assert_equal 3, Widget.versioned_class.count
+  end
+  
+  def test_has_many_through
+    assert_equal [authors(:caged), authors(:mly)], pages(:welcome).authors
+  end
+  
+  def test_has_many_through_with_custom_association
+    assert_equal [authors(:caged), authors(:mly)], pages(:welcome).revisors
+  end
+  
+  def test_referential_integrity
+    pages(:welcome).destroy
+    assert_equal 0, Page.count
+    assert_equal 0, Page::Version.count
+  end
+  
+  def test_association_options
+    association = Page.reflect_on_association(:versions)
+    options = association.options
+    assert_equal :delete_all, options[:dependent]
+    association = Widget.reflect_on_association(:versions)
+    options = association.options
+    assert_equal :nullify, options[:dependent]
+    assert_equal 'version desc', options[:order]
+    assert_equal 'widget_id', options[:foreign_key]
+    widget = Widget.create! :name => 'new widget'
+    assert_equal 1, Widget.count
+    assert_equal 1, Widget.versioned_class.count
+    widget.destroy
+    assert_equal 0, Widget.count
+    assert_equal 1, Widget.versioned_class.count
+  end
+  
+  def test_versioned_records_should_belong_to_parent
+    page = pages(:welcome)
+    page_version = page.versions.last
+    assert_equal page, page_version.page
+  end
+  
+  def test_unaltered_attributes
+    landmarks(:washington).attributes = landmarks(:washington).attributes.except("id")
+    assert !landmarks(:washington).changed?
+  end
+  
+  def test_unchanged_string_attributes
+    landmarks(:washington).attributes = landmarks(:washington).attributes.except("id").inject({}) { |params, (key, value)| params.update(key => value.to_s) }
+    assert !landmarks(:washington).changed?
+  end
+  
+  def test_should_find_earliest_version
+    assert_equal page_versions(:welcome_1), pages(:welcome).versions.earliest
+  end
+  
+  def test_should_find_latest_version
+    assert_equal page_versions(:welcome_2), pages(:welcome).versions.latest
+  end
+  
+  def test_should_find_previous_version
+    assert_equal page_versions(:welcome_1), page_versions(:welcome_2).previous
+    assert_equal page_versions(:welcome_1), pages(:welcome).versions.before(page_versions(:welcome_2))
+  end
+  
+  def test_should_find_next_version
+    assert_equal page_versions(:welcome_2), page_versions(:welcome_1).next
+    assert_equal page_versions(:welcome_2), pages(:welcome).versions.after(page_versions(:welcome_1))
+  end
+  
+  def test_should_find_version_count
+    assert_equal 2, pages(:welcome).versions.size
+  end
+  
+  def test_if_changed_creates_version_if_a_listed_column_is_changed
+    washington = landmarks(:washington)
+    washington.name = "Washington"
+    assert washington.changed?
+    assert washington.altered?
+  end
+  
+  def test_if_changed_creates_version_if_all_listed_columns_are_changed
+    washington = landmarks(:washington)
+    washington.name = "Washington"
+    washington.latitude = 1.0
+    washington.longitude = 1.0
+    assert washington.changed?
+    assert washington.altered?
+  end
+  
+  def test_if_changed_does_not_create_new_version_if_unlisted_column_is_changed
+    washington = landmarks(:washington)
+    washington.doesnt_trigger_version = "This should not trigger version"
+    assert washington.changed?
+    assert !washington.altered?
+  end
+  
+  def test_without_locking_temporarily_disables_optimistic_locking
+    enabled1 = false
+    block_called = false
+    ActiveRecord::Base.lock_optimistically = true
+    LockedPage.without_locking do
+      enabled1 = ActiveRecord::Base.lock_optimistically
+      block_called = true
+    end
+    enabled2 = ActiveRecord::Base.lock_optimistically
+    assert block_called
+    assert !enabled1
+    assert enabled2
+  end
+  
+  def test_without_locking_reverts_optimistic_locking_settings_if_block_raises_exception
+    assert_raises(RuntimeError) do
+      LockedPage.without_locking do
+        raise RuntimeError, "oh noes"
+      end
+    end
+    assert ActiveRecord::Base.lock_optimistically
+  end
+  
+end