acts_as_status_for 4.0.0 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5591d28000c93fd3bdb5c5286635e4611b03997b
-  data.tar.gz: e6d5543632a3438c0044ae8fb7f20df0319ee5a9
+  metadata.gz: 07a9c8433b356b5b2011722658b52dbdbd4a399b
+  data.tar.gz: 9be5879453318fa5066ed20669dbf9864ebfdcc4
 SHA512:
-  metadata.gz: 8a8175b982789ccb5bd1668f5bb487fafb28d473f641707c023320489605e8f39d81128dcd42fa7d67b19bcf6bbce368511dee197587a4782d57883c1e874715
-  data.tar.gz: a9fabdbb72d3cb1af8861020adb342cae53b19cc26f1c9f38cc4bf8791a39c13ae52604a3caf95cede5a15b23262e874c2dbdd55b103c6cd79a791f0e1af6155
+  metadata.gz: f2e083754627dccfb7fe5819aad07ed6f033d6ea05bf154461fc89cd39054ba49e2975c4dd53471451472ebdc432fdfafff683cac715803eaf92fc71f04ea5ee
+  data.tar.gz: fc3c7b6c581ae0bf7094b06a860ffacd85e42a07d0badbbd571ce55974e2d1bbc9bbcc746bb2f7f7f9794d1a7d03e4cfd520a86c3378d51a53f32833c8b22994

data/VERSION

@@ -1 +1 @@
-4.0.0
+4.1.0

data/acts_as_status_for.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: acts_as_status_for 4.0.0 ruby lib
+# stub: acts_as_status_for 4.1.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "acts_as_status_for"
-  s.version = "4.0.0"
+  s.version = "4.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Curtis Schofield"]
-  s.date = "2014-07-29"
+  s.date = "2015-02-11"
   s.description = "Given a list of datetime _at attributes allow an activerecord object to query status, change status and hold multiple states, these states can be used to build state machines or other constructs. "
   s.email = "github.com@robotarmyma.de"
   s.extra_rdoc_files = [

data/lib/acts_as_status_for.rb

@@ -146,13 +146,31 @@ module ActsAsStatusFor
       end
     end
     alias :current_status= :status=
-      def status
-        status_time = {}
-        self.class.on_at_events.each do | event |
-          time = self.send("#{event}_at")
+
+    def status
+      status_time = {}
+      get_on_at_events.each do | event |
+        time = self.send("#{event}_at")
         status_time[event] = time unless time.nil?
+      end
+      status_time.sort { |a,b| b.last <=> a.last }.collect(&:first).join(' ')
+    end
+
+    private
+    def get_on_at_events
+      current_klass = self.class
+      events = current_klass.on_at_events
+      while events.nil?
+        current_klass = current_klass.superclass
+        if current_klass.respond_to? :on_at_events
+          events = current_klass.on_at_events
+        else
+          puts "WARNING >> ActsAsStatusFor [ No status events found ] "
+          events = []
+          break
         end
-        status_time.sort { |a,b| b.last <=> a.last }.collect(&:first).join(' ')
       end
+      events
+    end
   end
 end

data/spec/acts_as_status_for_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 ActiveRecord::Migration.create_table :things do |t|
   t.string   :name
+  t.string   :type # allow single table inheritance
   t.datetime :on_hold_at
   t.datetime :archived_at
   t.datetime :featured_at
@@ -105,90 +106,119 @@ describe ActsAsStatusFor do
     end
   end
   context "#status" do
-    before do
-      Thing.instance_eval do
-        acts_as_status_for :on_hold, :archived, :featured
-      end
-    end
+    context "with multi object inheritance" do
+      before do
+        Thing.instance_eval do
+          acts_as_status_for :on_hold, :archived, :featured
+        end
+        class ThingA < Thing
 
-    it "defaults to ''" do
-      expect(subject.status).to eq('')
-    end
+        end
+        class ThingB < ThingA
 
-    it "allows negation of status using 'not_' prefix" do
-      subject.on_hold!
-      subject.archived!
-      expect(subject.status).to eq('archived on_hold')
-      subject.status = "not_archived"
-      expect(subject.status).to eq('on_hold')
+        end
+      end
+      context "it searches inheritance tree for on_at_methods" do
+        subject {
+          ThingB.new(:name => 'required')
+        }
+        it "defaults to ''" do
+          expect(subject.status).to eq('')
+        end
+        it "uses superclasse status" do
+          subject.on_hold!
+          expect(subject.status).to eq('on_hold')
+        end
+      end
     end
 
-    it "is sorted by event time" do
-      subject.on_hold!
-      expect(subject.status).to eq('on_hold')
-      subject.archived!
-      expect(subject.status).to eq('archived on_hold')
-      subject.featured!
-      expect(subject.status).to eq('featured archived on_hold')
-      subject.not_on_hold!
-      subject.on_hold!
-      expect(subject.status).to eq('on_hold featured archived')
-    end
+    context "with single object" do
+      before do
+        Thing.instance_eval do
+          acts_as_status_for :on_hold, :archived, :featured
+        end
+      end
 
-    it "setting it to blank clears all states" do
-      subject.on_hold!
-      subject.archived!
-      subject.featured!
-      subject.status = ''
-      expect(subject.status).to eq('')
-    end
+      it "defaults to ''" do
+        expect(subject.status).to eq('')
+      end
 
-    describe "audit trail is independent of scope" do
-      it "should recognize only the most recent" do
-        subject.featured_at = 3.days.ago
-        subject.on_hold_at = 1.days.ago
-        subject.archived_at = Time.now
-        subject.save
-        expect(subject.class.archived).to     include(subject)
-        expect(subject.class.not_on_hold).to  include(subject)
-        expect(subject.class.on_hold).not_to  include(subject)
-        expect(subject.class.not_featured).to include(subject)
-        expect(subject.class.featured).not_to include(subject)
+      it "allows negation of status using 'not_' prefix" do
+        subject.on_hold!
+        subject.archived!
+        expect(subject.status).to eq('archived on_hold')
+        subject.status = "not_archived"
+        expect(subject.status).to eq('on_hold')
       end
-    end
 
-    (ClassFinderMethods = {
-      # class finder method 
-      #          => [ list of event states that belong to finder]
-      #
-      :featured  => [:featured],
-      :on_hold   => [:on_hold],
-      :archived  => [:archived]
-    }).each do |scope,states|
-      states.each do |state|
-        it "can be used to set events" do
-          subject.status = state.to_s
-          expect(subject.send(%%#{state}?%)).to be_truthy
-          expect(subject.status).to include(state.to_s)
-        end
+      it "is sorted by event time" do
+        subject.on_hold!
+        expect(subject.status).to eq('on_hold')
+        subject.archived!
+        expect(subject.status).to eq('archived on_hold')
+        subject.featured!
+        expect(subject.status).to eq('featured archived on_hold')
+        subject.not_on_hold!
+        subject.on_hold!
+        expect(subject.status).to eq('on_hold featured archived')
+      end
 
-        it "can be reversed" do
-          subject.status = state.to_s
-          expect(subject.send("#{state}?")).to be_truthy
-          subject.status = "not_" + state.to_s
-          expect(subject.send("#{state}?")).to be_falsey
-        end
+      it "setting it to blank clears all states" do
+        subject.on_hold!
+        subject.archived!
+        subject.featured!
+        subject.status = ''
+        expect(subject.status).to eq('')
+      end
 
-        it "#{state} sets state string" do
-          subject.send("#{state}!")
-          expect(subject.send("#{state}?")).to be_truthy
-          expect(subject.status).to include(state.to_s)
+
+      describe "audit trail is independent of scope" do
+        it "should recognize only the most recent" do
+          subject.featured_at = 3.days.ago
+          subject.on_hold_at = 1.days.ago
+          subject.archived_at = Time.now
+          subject.save
+          expect(subject.class.archived).to     include(subject)
+          expect(subject.class.not_on_hold).to  include(subject)
+          expect(subject.class.on_hold).not_to  include(subject)
+          expect(subject.class.not_featured).to include(subject)
+          expect(subject.class.featured).not_to include(subject)
         end
+      end
 
-        it "#{state} is in the scope #{scope}" do
-          subject.send("#{state}!")
-          expect(subject.send("#{state}?")).to be_truthy
-          expect(subject.class.send(scope)).to include(subject)
+      (ClassFinderMethods = {
+        # class finder method 
+        #          => [ list of event states that belong to finder]
+        #
+        :featured  => [:featured],
+        :on_hold   => [:on_hold],
+        :archived  => [:archived]
+      }).each do |scope,states|
+        states.each do |state|
+          it "can be used to set events" do
+            subject.status = state.to_s
+            expect(subject.send(%%#{state}?%)).to be_truthy
+            expect(subject.status).to include(state.to_s)
+          end
+
+          it "can be reversed" do
+            subject.status = state.to_s
+            expect(subject.send("#{state}?")).to be_truthy
+            subject.status = "not_" + state.to_s
+            expect(subject.send("#{state}?")).to be_falsey
+          end
+
+          it "#{state} sets state string" do
+            subject.send("#{state}!")
+            expect(subject.send("#{state}?")).to be_truthy
+            expect(subject.status).to include(state.to_s)
+          end
+
+          it "#{state} is in the scope #{scope}" do
+            subject.send("#{state}!")
+            expect(subject.send("#{state}?")).to be_truthy
+            expect(subject.class.send(scope)).to include(subject)
+          end
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_status_for
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - Curtis Schofield
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-29 00:00:00.000000000 Z
+date: 2015-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord