acts_as_splittable 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50058ee03ea54fe96784f78b9fab607da4f9dcde
-  data.tar.gz: d04d4414b76cbb3d404f84529387ad02fc555595
+  metadata.gz: 3d4595fb64c43327405f29ae3530fe069a772599
+  data.tar.gz: e40f06000ded452b21769446530453e8eba7243d
 SHA512:
-  metadata.gz: 8e348b339fc458891a206818484dc6c7cb0492360da9f41e50f5e0e5f62e901829d4f75936624f64cae2437c6fc49f3a749aba6475ead80abb0cece633a698e3
-  data.tar.gz: 8356fac51d37d0ca44394aefca88fd8531124963457e709a6c3c42a249d983cee746f965037cff5408787f538c0eca75ea864d3db0c92ece8dc14fc6dcb41677
+  metadata.gz: 0b1ccfc10ca315b1b35d733c767c54b241c1c19996d30d1a0e5ccb6f0a2d88b50c966eaf4f723e704678fe25587d821025846a8b8eaf1888bae6e8a92d9bd814
+  data.tar.gz: 61a3e79425cad2336247816305eaaf51dec3e7579d4237a0fd46f5027df5d15cc728ae433617ac6f8a6d6e23560fe7e108b75e772cf43e634e2bed79d7379635

data/README.md

@@ -3,6 +3,27 @@ ActsAsSplittable
 
 Create virtual attributes.
 
+Installation
+--------------------
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'acts_as_splittable'
+```
+
+And then execute:
+
+```
+$ bundle
+```
+
+Or install it yourself as:
+
+```
+$ gem install acts_as_splittable
+```
+
 
 Usage
 --------------------
@@ -114,8 +135,8 @@ p splittable.email_domain #=> nil
 
 splittable.split_column_values!
 
-p splittable.email_local  #=> 'splittable'
-p splittable.email_domain #=> 'example.com'
+p splittable.email_local  #=> "splittable"
+p splittable.email_domain #=> "example.com"
 ```
 
 Contributing

data/lib/acts_as_splittable/version.rb

@@ -1,3 +1,3 @@
 module ActsAsSplittable
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/acts_as_splittable.rb

@@ -54,19 +54,21 @@ module ActsAsSplittable
         split, pattern, partials, on_split, on_join = self.class.splittable_columns[column]
         value                                       = send(column)
 
-        values = if on_split
-          on_split.is_a?(Symbol) ? send(on_split, value) : on_split.(value)
-        elsif value
-          if split
-            value.to_s.split *(split.is_a?(Array) ? split : [split])
-          else
-            matches = value.to_s.match(pattern)
-            matches[1..(matches.length - 1)]
+        unless value.nil?
+          values = if on_split
+            on_split.is_a?(Symbol) ? send(on_split, value) : on_split.(value)
+          elsif value
+            if split
+              value.to_s.split *(split.is_a?(Array) ? split : [split])
+            else
+              matches = value.to_s.match(pattern)
+              matches[1..(matches.length - 1)]
+            end
+          end || []
+
+          partials.each_with_index do |partial, index|
+            send :"#{partial}=", values[index]
           end
-        end || []
-
-        partials.each_with_index do |partial, index|
-          send :"#{partial}=", values[index]
         end
       end
 
@@ -80,7 +82,9 @@ module ActsAsSplittable
         split, pattern, partials, on_split, on_join = self.class.splittable_columns[column.to_sym]
         partials                                    = partials.map{|partial| send(partial) }
 
-        send :"#{column}=", on_join.is_a?(Symbol) ? send(on_join, partials) : on_join.(partials)
+        unless partials.any?(&:nil?)
+          send :"#{column}=", on_join.is_a?(Symbol) ? send(on_join, partials) : on_join.(partials)
+        end
       end
         
       self
@@ -92,4 +96,4 @@ module ActsAsSplittable
   end
 end
 
-ActiveRecord::Base.extend ActsAsSplittable
+ActiveRecord::Base.extend ActsAsSplittable

data/spec/models/splittable_spec.rb

@@ -59,5 +59,32 @@ require 'spec_helper'
       end
     end
 
+    context 'when nil includes in partials or value of column is nil' do
+      before :each do
+        @splittable1 = klass.new(name: "#{klass.name} 1")
+        @splittable1.save!
+
+        @splittable2 = klass.create!(
+          name: "#{klass.name} 2"
+        )
+
+        @splittables = [@splittable1, @splittable2]
+      end
+
+      it 'should not join partials before save' do
+        @splittables.each do |record|
+          record.email.should be_nil
+        end
+      end
+
+      it 'should not split columns after initialize' do
+        @splittables.each do |record|
+          splittable = Splittable.find(record.id)
+
+          splittable.email_local.should be_nil
+          splittable.email_domain.should be_nil
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_splittable
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - tatat
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-13 00:00:00.000000000 Z
+date: 2013-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails