acts_as_recursive_tree 2.2.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea1cf22b09ed91c55f3388b8c794a3d820eb353896feca3df3cd16bfadd1e1fb
-  data.tar.gz: 55605034be64624f710175f2bc5714273f87e39124799fa4952dfb8425f9719d
+  metadata.gz: 6cb3b3fef0f54be5c64a667f3ce289fb536bbdce72dc9758eae7a3c27385adf1
+  data.tar.gz: 5c65367bf564d3d12b70506ec2ecdaed1e9aaed535a822ccebff0b1aefe99b59
 SHA512:
-  metadata.gz: 4e357b5809c1aa3c28789af9c81d6ac17739f04b40cec8e43a6ecb2b690ea69e9d3752aab7cf3579fb38042b387132c9e02ddf5b3facc54b1206b33eb184d194
-  data.tar.gz: 97a0ecfa41d4085f2a6a14a964be479747f4857af9400e9412699f6b7a21324c2af3632bba5831576ac08156fa8ff01ff06025e09c46b0e51fe64221b8a8bef6
+  metadata.gz: 187193f5f118a30d1359cde9b40d239e2d89ed9166dce8c0e73469dd3baf28b86fd7874ed89c763f6bdeff4c8d012bb78fa6cd521998f28289134d7bd0cce13a
+  data.tar.gz: 6ca7d12b131992d6f901d462c857b79a976e323f40d0f198d6e1c26f3ce1ff36d6707226d695687b8b1bfb2a1209f7ca754ab4412bb23d581771add1ee1826bd

data/.github/workflows/ci.yml

@@ -0,0 +1,37 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ '**' ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.5', '2.6', '2.7']
+        gemfile: [ar_52, ar_60, ar_61]
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+    #  uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake

data/.github/workflows/lint.yml

@@ -0,0 +1,31 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: LINT
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ '**' ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+    #  uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      with:
+        ruby-version: 2.7
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run rubocop
+      run: bundle exec rubocop

data/.github/workflows/rubygem.yml

@@ -0,0 +1,37 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: Ruby Gem
+
+on:
+  # Manually publish
+  workflow_dispatch:
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+      contents: read
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+      - run: bundle install
+      - name: Publish to RubyGems
+        env:
+          GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 0600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+          gem build *.gemspec
+          gem push *.gem
+

data/.gitignore

@@ -15,4 +15,5 @@ mkmf.log
 /.idea
 db.log
 test.sqlite3
-/gemfiles
+/gemfiles/*.lock
+/gemfiles/.bundle

data/.rubocop.yml

@@ -1 +1,30 @@
-inherit_from: .rubocop_todo.yml
+require:
+  - rubocop-rails
+  - rubocop-rspec
+
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.5
+  NewCops: enable
+  SuggestExtensions: false
+
+Metrics/AbcSize:
+  Max: 20
+
+Rails/RakeEnvironment:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 4
+
+Style/Alias:
+  EnforcedStyle: prefer_alias
+
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'gemfiles/**/*'
+
+Style/StringLiterals:
+  Exclude:
+    - 'gemfiles/**/*'

data/.rubocop_todo.yml

@@ -1,321 +1,68 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-01-22 09:50:37 +0100 using RuboCop version 0.51.0.
+# on 2021-08-02 08:58:28 UTC using RuboCop version 1.18.4.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  EnforcedStyle: end
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/CommentIndentation:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterMagicComment:
-  Exclude:
-    - 'acts_as_recursive_tree.gemspec'
+# Offense count: 6
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 87
 
 # Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/model.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Layout/EmptyLines:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/model.rb'
-    - 'spec/db/models.rb'
-    - 'spec/model/node_spec.rb'
-    - 'spec/spec_helper.rb'
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+Metrics/MethodLength:
+  Max: 15
 
-# Offense count: 25
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
+# Offense count: 18
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
   Exclude:
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-    - 'spec/db/schema.rb'
+    - 'spec/builders_spec.rb'
     - 'spec/model/location_spec.rb'
     - 'spec/model/node_spec.rb'
     - 'spec/model/relation_spec.rb'
     - 'spec/values_spec.rb'
 
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundClassBody:
+# Offense count: 37
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
   Exclude:
-    - 'lib/acts_as_recursive_tree/builders/ancestors.rb'
-    - 'lib/acts_as_recursive_tree/builders/leaves.rb'
-    - 'lib/acts_as_recursive_tree/builders/relation_builder.rb'
-    - 'lib/acts_as_recursive_tree/options/depth_condition.rb'
-    - 'lib/acts_as_recursive_tree/options/query_options.rb'
-    - 'spec/db/models.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundMethodBody:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/acts_macro.rb'
-    - 'lib/acts_as_recursive_tree/builders/leaves.rb'
-    - 'lib/acts_as_recursive_tree/options/values.rb'
-    - 'spec/model/node_spec.rb'
-    - 'spec/model/relation_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/acts_macro.rb'
-    - 'lib/acts_as_recursive_tree/model.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Layout/FirstParameterIndentation:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/builders/leaves.rb'
-    - 'lib/acts_as_recursive_tree/model.rb'
-    - 'spec/model/relation_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SupportedStylesForEmptyBraces.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'spec/values_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: require_no_space, require_space
-Layout/SpaceInLambdaLiteral:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-    - 'spec/builders_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Exclude:
-    - 'spec/values_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'Rakefile'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/acts_macro.rb'
-    - 'lib/acts_as_recursive_tree/options/depth_condition.rb'
-    - 'lib/acts_as_recursive_tree/options/values.rb'
-    - 'spec/db/database.rb'
-    - 'spec/db/models.rb'
-    - 'spec/db/schema.rb'
     - 'spec/model/location_spec.rb'
     - 'spec/model/node_spec.rb'
     - 'spec/model/relation_spec.rb'
-    - 'spec/values_spec.rb'
-
-# Offense count: 14
-Lint/AmbiguousRegexpLiteral:
-  Exclude:
-    - 'spec/builders_spec.rb'
-    - 'spec/values_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Lint/DeprecatedClassMethods:
+RSpec/MultipleDescribes:
   Exclude:
-    - 'Rakefile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/options/values.rb'
-
-# Offense count: 1
-Lint/HandleExceptions:
-  Exclude:
-    - 'Rakefile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/builders/leaves.rb'
-
-# Offense count: 5
-Metrics/AbcSize:
-  Max: 44
-
-# Offense count: 8
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 89
-
-# Offense count: 41
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 291
+    - 'spec/builders_spec.rb'
 
 # Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 13
+RSpec/MultipleExpectations:
+  Max: 2
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Security/YAMLLoad:
-  Exclude:
-    - 'spec/db/database.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: prefer_alias, prefer_alias_method
-Style/Alias:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/acts_macro.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/BlockComments:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/ColonMethodCall:
-  Exclude:
-    - 'spec/db/database.rb'
-
-# Offense count: 20
+# Offense count: 17
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
     - 'lib/acts_as_recursive_tree.rb'
     - 'lib/acts_as_recursive_tree/acts_macro.rb'
-    - 'lib/acts_as_recursive_tree/associations.rb'
-    - 'lib/acts_as_recursive_tree/builders.rb'
     - 'lib/acts_as_recursive_tree/builders/ancestors.rb'
     - 'lib/acts_as_recursive_tree/builders/descendants.rb'
     - 'lib/acts_as_recursive_tree/builders/leaves.rb'
-    - 'lib/acts_as_recursive_tree/builders/relation_builder.rb'
     - 'lib/acts_as_recursive_tree/model.rb'
-    - 'lib/acts_as_recursive_tree/options.rb'
     - 'lib/acts_as_recursive_tree/options/depth_condition.rb'
     - 'lib/acts_as_recursive_tree/options/query_options.rb'
     - 'lib/acts_as_recursive_tree/options/values.rb'
     - 'lib/acts_as_recursive_tree/railtie.rb'
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: compact, expanded
-Style/EmptyMethod:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/options/values.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/Encoding:
-  Exclude:
-    - 'acts_as_recursive_tree.gemspec'
-    - 'spec/db/schema.rb'
-
-# Offense count: 1
+# Offense count: 9
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'spec/db/schema.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'spec/model/node_spec.rb'
-    - 'spec/model/relation_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: InverseMethods, InverseBlocks.
-Style/InverseMethods:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/model.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/MultilineIfModifier:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'Rakefile'
-    - 'acts_as_recursive_tree.gemspec'
-
-# Offense count: 17
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/acts_as_recursive_tree/acts_macro.rb'
-    - 'lib/acts_as_recursive_tree/associations.rb'
-    - 'lib/acts_as_recursive_tree/model.rb'
-    - 'lib/acts_as_recursive_tree/scopes.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/UnneededPercentQ:
-  Exclude:
-    - 'acts_as_recursive_tree.gemspec'
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 291