acts_as_readonlyable 0.0.5 → 0.0.6

data/README

@@ -40,7 +40,7 @@ dbs:
     host: slave-host
 
 
-Note: There is no need for more than one read-only database configuration in your database.yml since you can leverage traditional load balancing solutions for slaves. If you still want to use database.yml to spread the load, define multiple entries there and use acts_as_readonlyable [:first_read_only, :second_read_only]
+Note: There is no need for more than one read-only database configuration in your database.yml since you can leverage traditional load balancing solutions for slaves. If you still want to use database.yml to spread the load, define multiple entries there and use acts_as_readonlyable [:first_read_only, :second_read_only].
 
 === Sample Model
 
@@ -58,6 +58,11 @@ r.reload  # executes against the read_only db
 r.reload(:readonly => false)  # executes against the read_write db
 
 
+=== Transactional Tests Support
+
+Since there are two connections established, it breaks transactional tests that rely on the fact that all code lives within a single transaction/connection. To address that, the read only mode is disabled when there is no read-only database configuration entry defined in database.yml. In this case the warning is printed to the log file. 
+
+
 == Installation
 
 As plugin: 

data/lib/acts_as_readonlyable.rb

@@ -13,16 +13,25 @@ module ActiveRecord::Acts::ActsAsReadonlyable
     def acts_as_readonlyable(*readonly_dbs)
       @readonly_dbs = readonly_dbs.flatten.collect(&:to_s)
       @readonly_models = readonly_classes(@readonly_dbs)
-      self.extend(FinderClassOverrides)
-      self.send(:include, FinderObjectOverrides)
+      if @readonly_models.empty?
+        logger.warn("Read only mode is not activated for #{ self }")
+      else        
+        self.extend(FinderClassOverrides)
+      end
+      self.send(:include, FinderInstanceOverrides)
     end
     
   private
     
     def readonly_classes(dbs)
-      dbs.collect do |db|
-        define_readonly_class(db) unless ActiveRecord.const_defined?(readonly_class_name(db))
-        ActiveRecord.const_get(readonly_class_name(db))
+      dbs.inject([]) do |classes, db|
+        if configurations[RAILS_ENV][db]
+          define_readonly_class(db) unless ActiveRecord.const_defined?(readonly_class_name(db))
+          classes << ActiveRecord.const_get(readonly_class_name(db))
+        else
+          logger.warn("No db config entry defined for #{ db }")
+        end
+        classes
       end
     end 
        
@@ -110,7 +119,7 @@ module ActiveRecord::Acts::ActsAsReadonlyable
       
     end
     
-    module FinderObjectOverrides
+    module FinderInstanceOverrides
       
       # backport from 1.2.3 for 1.1.6
       def reload(options = nil)

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.2
 specification_version: 1
 name: acts_as_readonlyable
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
-date: 2007-04-28 00:00:00 -04:00
+  version: 0.0.6
+date: 2007-06-07 00:00:00 -04:00
 summary: acts_as_readonlyable allows to add read-only slaves DBs to models
 require_paths: 
 - lib