acts_as_ranked_list 0.2.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb250e95788139cb03e2e54560819ed5841904faebd13a8ecb5902f46d0d0a35
-  data.tar.gz: 36ad4c7c01156f08be41395994359fd9ddbae0280c821348086703da3b0138a7
+  metadata.gz: 3c665111b3d1da9b578d19b1c49203ae597e49a06e09f274e92cb7cecca03687
+  data.tar.gz: d4d682b766b048afcc9af37fabcb99e37e683a2d0924e32a2d4a3941a6c29f36
 SHA512:
-  metadata.gz: 6ef434d2c8b9dd945c6cafae76b6398b54cc2db33e2c96f518c3abf237d789a5da413322067627f1931e6acff9f0730fd61d077025530d85e94818e2a1583260
-  data.tar.gz: d225b605fa64c2af642895e7075e373edc1eab17944f2a49e508d80be5fdf2571bc0b69f58d5a0001a054e1447864c4acb0ba60169146ce48a431213cb6637a1
+  metadata.gz: cf228e285474e6ffdee7aeeb36c5a024ee897a640a8f9dbc486faf4e7b8fd431e2c11907137e1f15fec253e0ee4ec38e7b73cedf2883690b1482261032a9cd87
+  data.tar.gz: 922b5ad1fa695325e779a3a44db204b3457a84d0b5bcec539cb16c492c48abe3c82a92acf978984aa3d758846fc532fe1f9c829c41eed9fe4f764f6852414afa

data/CHANGELOG.md

@@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [0.4.0] - 2024-02-12
+
+- Fixes sporadic bug on postgres with `pluck` higher items.
+
+## [0.3.0] - 2024-02-11 [YANKED]
+
+- Fixes individual items updating timestamps even when `touch_on_update` is false.
+
+## [0.2.3] - 2023-12-31
+
+- Updates gem dependencies.
+
 ## [0.2.2] - 2023-04-24
 
 - ~~Allows unranked items in list by having `nil` values.~~ Implicitly allowed behaviour since v0.2.0, also able to add new items can also be added as unranked. Adds documentation to this feature.

data/README.md

@@ -258,7 +258,7 @@ You can spread ranks so that the difference between each rank and the next is se
 - Being able to rerank items again without overflowing column's max precision.
 - Human-readable viewing purposes. This is not recommended. The rank should be human-readable (or not viewable) at the view (presentation) layer.
 
-If `avoid_collisions = true (by default)`. Then you do not have to use spread ranks manually. If the database raises an overflow error when mutating a rank, then it could be time to recalibrate the ranks in the table. You should handle this case in your code, and spread ranks. This is very infrequent. For example, in postgres this error will be raised when using the default precision of `16_383` digits after the decimal of a `decimal` column type in postgres versions `9.1+`:
+If `avoid_collisions = true (by default)`. Then you do not have to use spread ranks manually. If the database raises an overflow error when mutating a rank, then it could be time to recalibrate the ranks in the table. You should handle this case in your code, and spread ranks. **This is very infrequent.** For example, in postgres this error will be raised when using the default precision of `16_383` digits after the decimal of a `decimal` column type in postgres versions `9.1+`:
 
 ```ruby
 ActiveRecord::RangeError: PG::NumericValueOutOfRange: ERROR:  value overflows numeric format
@@ -266,9 +266,10 @@ ActiveRecord::RangeError: PG::NumericValueOutOfRange: ERROR:  value overflows nu
 
 Items are spread in, ascending order of each, by:
 
-1. rank
-2. time updated columns (`updated_at` for example)
-3. primary key (`id` for example)
+1. scopes
+2. rank
+3. time updated columns (`updated_at` for example)
+4. primary key (`id` for example)
 
 To spread ranks:
 

data/acts_as_ranked_list.gemspec

@@ -32,15 +32,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   # Uncomment to register a new dependency of your gem
-  spec.add_dependency "rails", "~> 6.0.3", ">= 6.0.3.6" 
-  spec.add_dependency "rake", "~> 13.0"
-  spec.add_dependency "rspec", "~> 3.0"
-  spec.add_dependency "standard", "~> 1.3"
-  spec.add_dependency "rspec-rails", "5.1.2"
-  spec.add_development_dependency "byebug", "11.1.3"
-  spec.add_development_dependency "yard", "0.9.34"
-  spec.add_development_dependency "redcarpet", "3.6.0"
-  spec.add_development_dependency "sqlite3", "1.6.2"
+  spec.add_dependency "rails", ">= 6.0.3"
+  spec.add_dependency "rake", ">= 13.0"
+  spec.add_dependency "rspec", ">= 3.0"
+  spec.add_dependency "standard", ">= 1.3"
+  spec.add_dependency "rspec-rails", ">= 5.1.2"
+  spec.add_development_dependency "byebug", ">= 11.1.3"
+  spec.add_development_dependency "yard", ">= 0.9.34"
+  spec.add_development_dependency "redcarpet", ">= 3.6.0"
+  spec.add_development_dependency "sqlite3", ">= 1.6.2"
 
   # For more information and examples about making a new gem, check out our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/acts_as_ranked_list/active_record/rank_column.rb

@@ -198,7 +198,9 @@ module ActsAsRankedList #:nodoc:
 
           define_method :set_rank_above do |item|
             higher_items = get_higher_items(2, "DESC", item.current_rank, true, true)
-            padded_array = pad_array(higher_items.pluck(rank_column), 0)
+            # TODO: Why is higher_items and lower_items sometimes need to be converted to array.
+            # Is it related to if items are not found? Otherwise it returns an error
+            padded_array = pad_array(higher_items.to_a.pluck(rank_column), 0)
             new_rank = padded_array.sum / 2
 
             with_persistence do
@@ -223,7 +225,7 @@ module ActsAsRankedList #:nodoc:
             # new_rank = ::ActiveRecord::Base.connection.execute(sql).to_a.first.values.first
 
             lower_items = get_lower_items(2, "ASC", item.current_rank, true, true)
-            padded_array = pad_array(lower_items.pluck(rank_column))
+            padded_array = pad_array(lower_items.to_a.pluck(rank_column))
             new_rank = padded_array.sum / 2
 
             with_persistence do
@@ -312,7 +314,17 @@ module ActsAsRankedList #:nodoc:
           define_method :with_persistence do |items = [self], &blk|
             blk.call
 
+            item_record_timestamps = items.map do |i|
+              i.record_timestamps?
+            end
+
+            items.each { |i| i.record_timestamps = touch_on_update }
+
             items.each(&:save!) unless skip_persistence?
+
+            items.each_with_index do |i, idx|
+              i.record_timestamps = item_record_timestamps[idx]
+            end
           end
 
           define_method :pad_array do |array, value = nil, size = 2|

data/lib/acts_as_ranked_list/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsRankedList
-  VERSION = "0.2.2"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,145 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_ranked_list
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Farbafe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-24 00:00:00.000000000 Z
+date: 2024-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 6.0.3
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.3.6
+        version: 6.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 6.0.3
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.3.6
+        version: 6.0.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '13.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 5.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 5.1.2
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 11.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 11.1.3
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.34
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.34
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.6.2
 description: Orders ActiveRecord items by floating ranks for spaces in-between items.
@@ -193,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Orders ActiveRecord items by ranks. Influenced by gem ActsAsList.