acts_as_multipart_form 0.0.2 → 0.0.3

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 0.0.3
+
+* Moved capybara and sqlite to development gems
+
 == 0.0.2
 
 * Updating the readme

data/Gemfile

@@ -4,13 +4,15 @@ source "http://rubygems.org"
 #   gem "activesupport", ">= 2.3.5"
 
 gem "rails", "3.0.7"
-gem "capybara", ">= 0.4.0"
-gem "sqlite3"
 
 
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.
 group :development do
+
+  gem "capybara", ">= 0.4.0"
+  gem "sqlite3"
+
   gem 'ruby-debug19'
   gem "rspec", "~> 2.6.0"
   gem "rspec-rails", "~>2.6.1"

data/README.rdoc

@@ -1,6 +1,6 @@
 = acts_as_multipart_form
 
-Create multipart forms in rails without using multiple routes.  A controler mixin handles loading and saving data based on partials on a single route.
+Create multipart forms in rails without using multiple routes.  A controller mixin handles loading and saving data based on partials on a single route.
 
 = How to use
 
@@ -22,7 +22,7 @@ Each form has a polymorphic relationship with a single record.  This relationshi
 
 Two routes can be specified for the form system. The form route corresponds to the route to the form itself.  It's default value is model_name_form_name.  In the example, the specified value would be the default value.  The show route, specified with the tag :show_route is redirected to after the last part of the multipart form is submitted and passes validations.  It defauls to model_name to correspond with the model's view page.
 
-== Add the mixing to your model
+== Add the mixin to your model
 
     multipart_formable :forms => [:hire_form]
 
@@ -30,12 +30,17 @@ This is currently only used for validations.  If this is set, you can use a vali
 
     validates_presence_of :name, :if => :hire_form_personal_info?
 
-== Adding a breadcrumb to the form page
+== Setting up your form
 
     <%= render "multipart_form/breadcrumb" %>
 
-This adds links to each form page and next/previous links to the page.  It must be on a multipart form view to work.  The configuration options in the initializer can be used to change the output of the partial.
+    <%= form_for @form_subject, :url => person_hire_form_path(:id => @form_subject.id, :multipart_form_part => @next_multipart_form_part), :html => {:method => :post} do |f| %>
+      <%= render "multipart_form/all_errors" %>
+      <%= render @multipart_form_part, :locals => {:form => f}  %>
+      <%= f.submit "Submit" %>
+    <% end %>
 
+The breadcrumb adds links to the other multipart for parts.  The all_errors partial is a substitute for putting error handling on each individual partial.  The url and @form_subject instance variable are necessary to make the form submit and redirect correctly.
 == Adding form part links to the index page
 
 === On the controller
@@ -43,7 +48,7 @@ This adds links to each form page and next/previous links to the page.  It must
     @people = Person.all
     load_multipart_form_index_links(:hire_form, @people)
 
-=== On the view
+=== On the index view
 
     <%= render "multipart_form/index_links",  :locals => {:form_subject => person } %>
 
@@ -56,6 +61,8 @@ Creates links to each form part for the given form subject.  The load_multipart_
 * Improve the behavior of the previous and next links in the breadcrumb
 * Add A controller and views generator to generate the files in the rails project so they can be edited for project specific needs
 * Improve code quality of the mixin where it makes variables available to views
+* Move the logic in the multipart_form partials to heleprs
+* Find a fix for having to explicitly create the form subject in the code.  The current system pushes us towards models that only hold the form subject id.  The problem is that it is possible to use a multipart form without a specific form model.  This leads to orphaned or blank records.
 
 == Contributing to acts_as_multipart_form
  

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/acts_as_multipart_form.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{acts_as_multipart_form}
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Jeremiah Hemphill}, %q{Ethan Pemble}]
-  s.date = %q{2011-07-28}
+  s.date = %q{2011-08-01}
   s.description = %q{Multipart forms using custom routes}
   s.email = %q{jeremiah@cloudspace.com}
   s.extra_rdoc_files = [
@@ -28,6 +28,7 @@ Gem::Specification.new do |s|
     "acts_as_multipart_form.gemspec",
     "app/controllers/multipart_form/in_progress_forms_controller.rb",
     "app/models/multipart_form/in_progress_form.rb",
+    "app/views/multipart_form/_all_errors.html.erb",
     "app/views/multipart_form/_breadcrumb.html.erb",
     "app/views/multipart_form/_index_links.html.erb",
     "app/views/multipart_form/in_progress_form/index.html.erb",
@@ -74,6 +75,7 @@ Gem::Specification.new do |s|
     "spec/dummy/db/migrate/20110715180834_create_people.rb",
     "spec/dummy/db/migrate/20110722130249_create_multipart_form_tables.rb",
     "spec/dummy/db/schema.rb",
+    "spec/dummy/features/all_errors_partial.feature",
     "spec/dummy/features/form_breadcrumb.feature",
     "spec/dummy/features/form_submission.feature",
     "spec/dummy/features/index_links.feature",
@@ -114,8 +116,8 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<rails>, ["= 3.0.7"])
-      s.add_runtime_dependency(%q<capybara>, [">= 0.4.0"])
-      s.add_runtime_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<capybara>, [">= 0.4.0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
       s.add_development_dependency(%q<ruby-debug19>, [">= 0"])
       s.add_development_dependency(%q<rspec>, ["~> 2.6.0"])
       s.add_development_dependency(%q<rspec-rails>, ["~> 2.6.1"])

data/app/views/multipart_form/_all_errors.html.erb

@@ -0,0 +1,15 @@
+<div id="error_explanation">
+
+  <% vars = controller.instance_variable_names.select { |var| eval(var).is_a?(ActiveRecord::Base) && eval(var).errors.is_a?(ActiveModel::Errors)} %>
+  <% if vars.sum { |v| eval(v).errors.count } > 0 %>
+    <h2><%=pluralize(vars.sum { |v| eval(v).errors.count }, "error") %> prohibited this form from being saved:</h2>
+    <ul> 
+      <% vars.each do |var| %>
+        <% eval(var).errors.full_messages.each do |msg| %>
+          <li><%= eval(var).class.name + ": " + msg %></li>
+        <% end %> 
+      <% end %>   
+  </ul> 
+  <% end %>
+</div>
+

data/lib/acts_as_multipart_form/multipart_form_in_controller.rb

@@ -33,19 +33,21 @@ module ActsAsMultipartForm
       # def person_info_update
       #   @person = Person.find(params[:id])
       #   @person = Person.new if @person.nil?
+      #   @person.multipart_form_controller_action = "person_info_update"
       #
       #   valid = @person.update_attributes(params[:person])
-      #   return {:valid => valid, :errors => @person.errors}
+      #   return {:valid => valid}
       # end
       #
       # def job_info
       #   @job_position = JobPosition.new
       #   @job_position.person = Person.find(load_multipart_form_data(form_instance_id, :person))
+      #   @job_position.multipart_form_controller_action = "job_info_update"
       # end
       # 
       # def job_info_update
       #   valid = @job_position.update_attributes(params[:job_position])
-      #   return {:valid => valid, :errors => @job_position.errors}
+      #   return {:valid => valid}
       # end
       #
       # @param [Array] args An array of hashes that determines the data for a multipart form
@@ -205,7 +207,9 @@ module ActsAsMultipartForm
 
       # Given a form name and a form subject id, it creates the form subject
       # The form subject is defined by the id and the multipart form's model attribute
-      # The subject is created with values and saved without validations (this might change in the future)
+      #
+      # The subject is created with no values and saved without validations (this might change in the future)
+      # This is not a good situation but I don't know how to ensure the form subject gets saved otherwise
       #
       # @param [Symbol] form_name The name of the multipart form
       # @param [Integer] form_dubject_id The id of the form subject (could be nil)

data/spec/dummy/app/controllers/people_controller.rb

@@ -7,11 +7,14 @@ class PeopleController < ApplicationController
 
   def person_info_update
     @person = Person.find(params[:id])
-    if @person.update_attributes(params[:person])
-      return {:valid => true}
+    @person.multipart_form_controller_action = "person_info_update"
+    if params[:person] and params[:person][:person]
+      @person.update_attributes(params[:person][:person])
+      return { :valid => @person.valid? }
     else
-      return {:valid => false}
+      return { :valid => false }
     end
+    
   end
 
   def job_info
@@ -20,16 +23,17 @@ class PeopleController < ApplicationController
 
   def job_info_update
     @person = Person.find(params[:id])
+    @person.multipart_form_controller_action = "job_info_update"
     if @person.update_attributes(params[:person])
       return {:valid => true}
     else
-      return {:valid => false}
+      return {:valid => false }
     end
   end
 
   def hire_form
     #puts "stub method for the hire form"
-    @person = Person.find(params[:id])
+    #@person = Person.find(params[:id])
     
     respond_to do |format|
       format.html

data/spec/dummy/app/models/person.rb

@@ -1,5 +1,5 @@
 class Person < ActiveRecord::Base
   multipart_formable :forms => [:hire_form]
 
-  validates_presence_of :name, :if => :hire_form_personal_info?
+  validates_presence_of :name, :if => :hire_form_person_info_update?
 end

data/spec/dummy/app/views/people/_person_info.html.erb

@@ -2,7 +2,7 @@
   This is the personal info multipart form partial.
 </p>
 
-<div class="field">
-  <%= locals[:form].label :name %><br />
-  <%= locals[:form].text_field :name %>
-</div>
+<%= locals[:form].fields_for @person do |fp| %>
+  <%= fp.label :name %><br />
+  <%= fp.text_field :name %>
+<% end %>

data/spec/dummy/app/views/people/hire_form.html.erb

@@ -4,7 +4,8 @@
 
 <%= render "multipart_form/breadcrumb" %>
 
-<%= form_for @person, :url => person_hire_form_path(:id => @form_subject.id, :multipart_form_part => @next_multipart_form_part), :html => {:method => :post} do |f| %>
+<%= form_for @form_subject, :url => person_hire_form_path(:id => @form_subject.id, :multipart_form_part => @next_multipart_form_part), :html => {:method => :post} do |f| %>
+  <%= render "multipart_form/all_errors" %>
   <%= render @multipart_form_part, :locals => {:form => f}  %>
   <%= f.submit "Submit" %>
 <% end %>

data/spec/dummy/features/all_errors_partial.feature

@@ -0,0 +1,19 @@
+Feature: I should be able to see error messages
+
+  Scenario: Errors on the person info page
+    Given there are no People in the system
+    And a person with an incomplete multipart form exists
+    When I go to the person hire_form page for that person
+    And I fill in "person_person_name" with ""
+    And I press "Submit"
+    Then I should see "1 error prohibited this form from being saved:"
+    And I should see "Person: Name can't be blank"
+    
+  Scenario: No errors on the person info page
+    Given there are no People in the system
+    And a person with an incomplete multipart form exists
+    When I go to the person hire_form page for that person
+    And I fill in "person_person_name" with "Jeremiah"
+    And I press "Submit"
+    Then I should not see "0 errors prohibited this form from being saved:"
+    And I should not see "Person: Name can't be blank"

data/spec/dummy/features/form_submission.feature

@@ -8,7 +8,7 @@ Feature: I should be able to submit data using the multipart form system
     Given there are no People in the system
     And a person with an incomplete multipart form exists
     When I go to the person hire_form page for that person
-    And I fill in "person_name" with "Ethan"
+    And I fill in "person_person_name" with "Ethan"
     And I press "Submit"
     Then that person's information should have updated
     And I should be on the person hire_form page

data/spec/multipart_form_in_model_integration_spec.rb

@@ -3,15 +3,15 @@ require_relative 'spec_helper'
 describe Person do
   before(:each) do
     @person = Person.new 
-    @person.multipart_form_controller_action = "personal_info"
+    @person.multipart_form_controller_action = "person_info_update"
   end
   
-  it "should respond to hire_form_personal_info" do
-    @person.respond_to?(:hire_form_personal_info?).should be_true
+  it "should respond to hire_form_person_info_update" do
+    @person.respond_to?(:hire_form_person_info_update?).should be_true
   end
 
-  it "should return true for hire_form_personal_info" do
-    @person.hire_form_personal_info?.should be_true
+  it "should return true for hire_form_person_info_update" do
+    @person.hire_form_person_info_update?.should be_true
   end
 
   it "should call the name validation if the action is set" do

metadata

@@ -2,7 +2,7 @@
 name: acts_as_multipart_form
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Jeremiah Hemphill
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-28 00:00:00 Z
+date: 2011-08-01 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -32,7 +32,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version 
         version: 0.4.0
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
@@ -43,7 +43,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version 
         version: "0"
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -188,6 +188,7 @@ files:
 - acts_as_multipart_form.gemspec
 - app/controllers/multipart_form/in_progress_forms_controller.rb
 - app/models/multipart_form/in_progress_form.rb
+- app/views/multipart_form/_all_errors.html.erb
 - app/views/multipart_form/_breadcrumb.html.erb
 - app/views/multipart_form/_index_links.html.erb
 - app/views/multipart_form/in_progress_form/index.html.erb
@@ -234,6 +235,7 @@ files:
 - spec/dummy/db/migrate/20110715180834_create_people.rb
 - spec/dummy/db/migrate/20110722130249_create_multipart_form_tables.rb
 - spec/dummy/db/schema.rb
+- spec/dummy/features/all_errors_partial.feature
 - spec/dummy/features/form_breadcrumb.feature
 - spec/dummy/features/form_submission.feature
 - spec/dummy/features/index_links.feature
@@ -275,7 +277,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -4212957645854622535
+      hash: -3656101662010391779
       segments: 
       - 0
       version: "0"