acts_as_lookup 0.0.1 → 0.0.2

data/TODO

@@ -1,5 +1,6 @@
 Things to work on:
 
+
 * find a better workaround for the cached instance problem (see https://rails.lighthouseapp.com/projects/8994/tickets/1339, for example) than explicit requiring of lookup classes (see acts_as_lookup.rb : ActsAsLookupHasLookupClassMethods#has_lookup)
 * for now, it's required to include :id in the values hashes; enhance to allow leaving :id off (by specifying :uniqueness_column) and fetch them from db (option will only be available for :sync_with_db == true)
 * allow gem to be used outside Rails by specifying alternative implementations for db-hitting methods....e.g. add configuration values that specify method names to call to load/write/remove from db. see +acts_as_lookup_fetch_values+ method comment.
@@ -18,6 +19,7 @@ Things to work on:
 ** indexed_columns: which columns can be used in lookup_by_column methods
 *** allows for specifying other values in the model that don't need to be lookupable columns, e.g. if there are columns with non-unique values, foreign keys to other tables etc.
 *** default will be to use all columns specified in the model
+*** probably store the lookup caches in one giant hash, each entry is a hash :column => lookup_hash_for_that_column
 ** uniqueness_column: which column defines uniqueness of a record if :id is not set in model
 *** allows to leave off the id when specifying the rows in model if it doesn't really matter, but still do the inserting/removing of rows automatically
 *** default will be :name (if :name not specified in the data in the model, then if uniqueness_column isn't set, there will be errors)

data/acts_as_lookup.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{acts_as_lookup}
-  s.version = "0.0.1"
+  s.version = "0.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brian Percival"]
-  s.date = %q{2010-04-05}
+  s.date = %q{2010-04-09}
   s.description = %q{Provides an easy means for creating models that act like enumerations or lookup
 tables. You can specify the lookup values in your Rails models and can lazily
 push these to the associated db tables (or not). Also dynamically adds helpful

data/lib/acts_as_lookup.rb

@@ -111,10 +111,10 @@ module ActsAsLookupClassMethods
   # updates the lookup cache hashes from @@acts_as_lookup_values
   #-----------------------------------------------------------------------------
   def acts_as_lookup_refresh_caches
+    # FUTURE: this will get cleaned up, and will dynamically select which
+    #         columns to establish lookup caches for.
     @@acts_as_lookup_values.each do |val|
       @@acts_as_lookup_by_id.reverse_merge! val.id => val
-    end
-    @@acts_as_lookup_values.each do |val|
       @@acts_as_lookup_by_name.reverse_merge! val.name => val
     end
   end
@@ -123,11 +123,28 @@ module ActsAsLookupClassMethods
   # adds a class method to access a particular lookup value via a shortcut
   # method
   #
+  # does the following transformations:
+  #  - converts spaces to underscores
+  #  - downcases entire method name unless the constant is already all caps,
+  #    in which case, leaves method name in all caps
+  #  - checks for name conflicts and raises exception if the shortcut method
+  #    name collides with existing method
+  #
   # FUTURE: will allow for any column to be used here; for now, hardcoded
   #       to lookup by name
   #-----------------------------------------------------------------------------
   def acts_as_lookup_add_shortcut(name)
-    instance_eval "def #{name}; self.lookup_by_name '#{name}'; end"
+
+    method_name = name.gsub(/ /, '_')
+    unless method_name.upcase == method_name
+      method_name.downcase!
+    end
+    if respond_to?(method_name.to_sym)
+      raise "Cannot create method '#{method_name}' to #{self.inspect} " +
+            "as it conflicts with existing method with same name"
+    end
+
+    instance_eval "def #{method_name}; self.lookup_by_name '#{name}'; end"
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: acts_as_lookup
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Brian Percival
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-05 00:00:00 -07:00
+date: 2010-04-09 00:00:00 -07:00
 default_executable: 
 dependencies: []