acts_as_list 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fb937125e21c3674aefbf6cce0dbc334380a975b3c0cbf1e13c79f43a4fecd4
-  data.tar.gz: ead5fb00d9321a35f409e7c005eeebfb66192d7e4952040f4008d557726e38df
+  metadata.gz: dd73c8d74d8ff9e3f912f41181c1c8fe544f8c3a9b9f6f065288207d99b5d116
+  data.tar.gz: bdf48adfe5a2bff8f3b660dfa09fce7217ca62447dc633c89a290568e42707f0
 SHA512:
-  metadata.gz: c8a8c099d4808b9f5c92eefd0a70f3b6f9b7e694b80f68a5b985bab159ec32be9f0256f5d7f9b053891e81d507eae9cb8c0a3fbb56e18646ce2e3202c10c6d68
-  data.tar.gz: 0f4f91c1879293d00012462f37f0cb3e801d88450369d6db52ab7c53a7abab6c4523a1a5b691ad0a9d937bc783fa44008770617c541a22ef35393b69f0afaf3c
+  metadata.gz: 15abab96e0b079ad43a759c8c3eaa221d5c85406780f6255dc49f2f6723222bdad1c3470f79c7fe0c5c9dc53bdd67722b00039bda55e1cb76df20a6051b48fc7
+  data.tar.gz: cdcc37dfb3eaa17ceef2ca2f938e8837b1cfeec5189c815355ae2d385bc70db71c1a3ab139dcc812c1bdece51c2b5d72b702bbadb39596b1a3e09dc5b0fafbc7

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## v1.2.5 - 2025-10-21
+
+- Fix crash when deleting an association with composite primary keys [\#450](https://github.com/brendon/acts_as_list/pull/450) ([smathieu])
+
 ## v1.2.4 - 2024-11-20
 
 ### Added

data/lib/acts_as_list/active_record/acts/scope_method_definer.rb

@@ -21,7 +21,16 @@ module ActiveRecord::Acts::List::ScopeMethodDefiner #:nodoc:
         end
 
         define_method :destroyed_via_scope? do
-          scope == (destroyed_by_association && destroyed_by_association.foreign_key.to_sym)
+          return false unless destroyed_by_association
+
+          foreign_key = destroyed_by_association.foreign_key
+          if foreign_key.is_a?(Array)
+            # Composite foreign key - check if scope is one of the keys
+            foreign_key.map(&:to_sym).include?(scope)
+          else
+            # Single foreign key
+            scope == foreign_key.to_sym
+          end
         end
       elsif scope.is_a?(Array)
         define_method :scope_condition do
@@ -44,7 +53,16 @@ module ActiveRecord::Acts::List::ScopeMethodDefiner #:nodoc:
         end
 
         define_method :destroyed_via_scope? do
-          scope_condition.keys.include? (destroyed_by_association && destroyed_by_association.foreign_key.to_sym)
+          return false unless destroyed_by_association
+
+          foreign_key = destroyed_by_association.foreign_key
+          if foreign_key.is_a?(Array)
+            # Composite foreign key - check if any keys overlap with scope
+            (scope_condition.keys & foreign_key.map(&:to_sym)).any?
+          else
+            # Single foreign key
+            scope_condition.keys.include?(foreign_key.to_sym)
+          end
         end
       else
         define_method :scope_condition do
@@ -68,7 +86,10 @@ module ActiveRecord::Acts::List::ScopeMethodDefiner #:nodoc:
     return name if name.to_s =~ /_id$/
 
     if caller_class.reflections.key?(name.to_s)
-      caller_class.reflections[name.to_s].foreign_key.to_sym
+      foreign_key = caller_class.reflections[name.to_s].foreign_key
+      # Handle composite foreign keys (Arrays) by returning as-is
+      # Single foreign keys should be converted to symbols
+      foreign_key.is_a?(Array) ? foreign_key.map(&:to_sym) : foreign_key.to_sym
     else
       ActiveSupport::Inflector.foreign_key(name).to_sym
     end

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '1.2.4'
+      VERSION = '1.2.5'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Swanand Pagnis
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2025-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -39,90 +39,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
-- !ruby/object:Gem::Dependency
-  name: minitest-hooks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.1.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.1.0
-- !ruby/object:Gem::Dependency
-  name: timecop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.8
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.8
-- !ruby/object:Gem::Dependency
-  name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.6
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.6
-- !ruby/object:Gem::Dependency
-  name: pg
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.5
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.5
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.7.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.7.2
 description: This "acts_as" extension provides the capabilities for sorting and reordering
   a number of objects in a list. The class that has this specified needs to have a
   "position" column defined as an integer on the mapped database table.
@@ -176,7 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: A gem adding sorting, reordering capabilities to an active_record model,