acts_as_list 1.2.1 → 1.2.3

data/test/shared_list_sub.rb

@@ -1,188 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module ListSub
-    def setup
-      (1..4).each do |i|
-        node = ((i % 2 == 1) ? ListMixinSub1 : ListMixinSub2).new parent_id: 5000
-        node.pos = i
-        node.save!
-      end
-    end
-
-    def test_reordering
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_lower
-      assert_equal [1, 3, 2, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_higher
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 1).first.move_to_bottom
-      assert_equal [2, 3, 4, 1], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 1).first.move_to_top
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_to_bottom
-      assert_equal [1, 3, 4, 2], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 4).first.move_to_top
-      assert_equal [4, 1, 3, 2], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-    end
-
-    def test_move_to_bottom_with_next_to_last_item
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-      ListMixin.where(id: 3).first.move_to_bottom
-      assert_equal [1, 2, 4, 3], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-    end
-
-    def test_next_prev
-      assert_equal ListMixin.where(id: 2).first, ListMixin.where(id: 1).first.lower_item
-      assert_nil ListMixin.where(id: 1).first.higher_item
-      assert_equal ListMixin.where(id: 3).first, ListMixin.where(id: 4).first.higher_item
-      assert_nil ListMixin.where(id: 4).first.lower_item
-    end
-
-    def test_next_prev_not_regular_sequence
-      ListMixin.all.each do |item|
-        item.update pos: item.pos * 5
-      end
-
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-      assert_equal [5, 10, 15, 20], ListMixin.where(parent_id: 5000).order('id').map(&:pos)
-
-      ListMixin.where(id: 2).first.move_lower
-      assert_equal [1, 3, 2, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-      assert_equal [5, 15, 10, 20], ListMixin.where(parent_id: 5000).order('id').map(&:pos)
-
-
-      ListMixin.where(id: 2).first.move_higher
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-      assert_equal [5, 10, 15, 20], ListMixin.where(parent_id: 5000).order('id').map(&:pos)
-
-      ListMixin.where(id: 1).first.move_to_bottom
-      assert_equal [2, 3, 4, 1], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 1).first.move_to_top
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_to_bottom
-      assert_equal [1, 3, 4, 2], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 4).first.move_to_top
-      assert_equal [4, 1, 3, 2], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-    end
-
-    def test_next_prev_groups
-      li1 = ListMixin.where(id: 1).first
-      li2 = ListMixin.where(id: 2).first
-      li3 = ListMixin.where(id: 3).first
-      li4 = ListMixin.where(id: 4).first
-      assert_equal [li2, li3, li4], li1.lower_items
-      assert_equal [li4], li3.lower_items
-      assert_equal [li2, li3], li1.lower_items(2)
-      assert_equal [], li4.lower_items
-
-      assert_equal [li2, li1], li3.higher_items
-      assert_equal [li1], li2.higher_items
-      assert_equal [li3, li2], li4.higher_items(2)
-      assert_equal [], li1.higher_items
-    end
-
-    def test_next_prev_groups_with_same_position
-      li1 = ListMixin.where(id: 1).first
-      li2 = ListMixin.where(id: 2).first
-      li3 = ListMixin.where(id: 3).first
-      li4 = ListMixin.where(id: 4).first
-
-      li3.update_column(:pos, 2) # Make the same position as li2
-
-      assert_equal [1, 2, 2, 4], ListMixin.order(:pos).pluck(:pos)
-
-      assert_equal [li3, li4], li2.lower_items
-      assert_equal [li2, li4], li3.lower_items
-
-      assert_equal [li3, li1], li2.higher_items
-      assert_equal [li2, li1], li3.higher_items
-    end
-
-    def test_injection
-      item = ListMixin.new("parent_id"=>1)
-      assert_equal({ parent_id: 1 }, item.scope_condition)
-      assert_equal "pos", item.position_column
-    end
-
-    def test_insert_at
-      new = ListMixin.create("parent_id" => 20)
-      assert_equal 1, new.pos
-
-      new = ListMixinSub1.create("parent_id" => 20)
-      assert_equal 2, new.pos
-
-      new = ListMixinSub1.create("parent_id" => 20)
-      assert_equal 3, new.pos
-
-      new_noup = ListMixinSub1.acts_as_list_no_update { ListMixinSub1.create("parent_id" => 20) }
-      assert_equal_or_nil $default_position, new_noup.pos
-
-      new4 = ListMixin.create("parent_id" => 20)
-      assert_equal 4, new4.pos
-
-      new4.insert_at(3)
-      assert_equal 3, new4.pos
-
-      new.reload
-      assert_equal 4, new.pos
-
-      new.insert_at(2)
-      assert_equal 2, new.pos
-
-      new4.reload
-      assert_equal 4, new4.pos
-
-      new5 = ListMixinSub1.create("parent_id" => 20)
-      assert_equal 5, new5.pos
-
-      new5.insert_at(1)
-      assert_equal 1, new5.pos
-
-      new4.reload
-      assert_equal 5, new4.pos
-
-      new_noup.reload
-      assert_equal_or_nil $default_position, new_noup.pos
-    end
-
-    def test_delete_middle
-      assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.destroy
-
-      assert_equal [1, 3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      assert_equal 1, ListMixin.where(id: 1).first.pos
-      assert_equal 2, ListMixin.where(id: 3).first.pos
-      assert_equal 3, ListMixin.where(id: 4).first.pos
-
-      ListMixin.where(id: 1).first.destroy
-
-      assert_equal [3, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      assert_equal 1, ListMixin.where(id: 3).first.pos
-      assert_equal 2, ListMixin.where(id: 4).first.pos
-
-      ListMixin.acts_as_list_no_update { ListMixin.where(id: 3).first.destroy }
-
-      assert_equal [4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
-
-      assert_equal 2, ListMixin.where(id: 4).first.pos
-    end
-
-    def test_acts_as_list_class
-      assert_equal TheBaseClass, TheBaseSubclass.new.acts_as_list_class
-      assert_equal TheAbstractSubclass, TheAbstractSubclass.new.acts_as_list_class
-    end
-  end
-end

data/test/shared_no_addition.rb

@@ -1,73 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module NoAddition
-    def setup
-      (1..4).each { |counter| NoAdditionMixin.create! pos: counter, parent_id: 5 }
-    end
-
-    def test_insert
-      new = NoAdditionMixin.create(parent_id: 20)
-      assert_nil new.pos
-      assert !new.in_list?
-
-      new = NoAdditionMixin.create(parent_id: 20)
-      assert_nil new.pos
-    end
-
-    def test_update_does_not_add_to_list
-      new = NoAdditionMixin.create(parent_id: 20)
-      new.update_attribute(:updated_at, Time.now) # force some change
-      new.reload
-
-      assert !new.in_list?
-    end
-
-    def test_update_scope_does_not_add_to_list
-      new = NoAdditionMixin.create
-
-      new.update_attribute(:parent_id, 20)
-      new.reload
-      assert !new.in_list?
-
-      new.update_attribute(:parent_id, 5)
-      new.reload
-      assert !new.in_list?
-    end
-
-    def test_collision_avoidance_with_explicit_position
-      first = NoAdditionMixin.create(parent_id: 20, pos: 1)
-      second = NoAdditionMixin.create(parent_id: 20, pos: 1)
-      third = NoAdditionMixin.create(parent_id: 30, pos: 1)
-
-      first.reload
-      second.reload
-      third.reload
-
-      assert_equal 2, first.pos
-      assert_equal 1, second.pos
-      assert_equal 1, third.pos
-
-      first.update(pos: 1)
-
-      first.reload
-      second.reload
-
-      assert_equal 1, first.pos
-      assert_equal 2, second.pos
-
-      first.update(parent_id: 30)
-
-      first.reload
-      second.reload
-      third.reload
-
-      assert_equal 1, first.pos
-      assert_equal 30, first.parent_id
-      assert_equal 1, second.pos
-      assert_equal 20, second.parent_id
-      assert_equal 2, third.pos
-      assert_equal 30, third.parent_id
-    end
-  end
-end

data/test/shared_quoting.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module Quoting
-
-    def setup
-      3.times { |counter| QuotedList.create! order: counter }
-    end
-
-    def test_create
-      assert_equal QuotedList.in_list.size, 3
-    end
-
-    # This test execute raw queries involving table name
-    def test_moving
-      item = QuotedList.first
-      item.higher_items
-      item.lower_items
-      item.send :bottom_item # Part of private api
-    end
-
-  end
-end

data/test/shared_top_addition.rb

@@ -1,110 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module TopAddition
-    def setup
-      (1..4).each { |counter| TopAdditionMixin.create! pos: counter, parent_id: 5 }
-    end
-
-    def test_setup_state
-      # If we explicitly define a position (as above) then that position is what gets applied
-      assert_equal [1, 2, 3, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-    end
-
-    def test_reordering
-      TopAdditionMixin.where(id: 2).first.move_lower
-      assert_equal [1, 3, 2, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      TopAdditionMixin.where(id: 2).first.move_higher
-      assert_equal [1, 2, 3, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      TopAdditionMixin.where(id: 1).first.move_to_bottom
-      assert_equal [2, 3, 4, 1], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      TopAdditionMixin.where(id: 1).first.move_to_top
-      assert_equal [1, 2, 3, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      TopAdditionMixin.where(id: 2).first.move_to_bottom
-      assert_equal [1, 3, 4, 2], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      TopAdditionMixin.where(id: 4).first.move_to_top
-      assert_equal [4, 1, 3, 2], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-    end
-
-    def test_injection
-      item = TopAdditionMixin.new(parent_id: 1)
-      assert_equal({ parent_id: 1 }, item.scope_condition)
-      assert_equal "pos", item.position_column
-    end
-
-    def test_insert
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-      assert new.first?
-      assert new.last?
-
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-      assert new.first?
-      assert !new.last?
-
-      new = TopAdditionMixin.acts_as_list_no_update { TopAdditionMixin.create(parent_id: 20) }
-      assert_equal_or_nil $default_position, new.pos
-      assert_equal $default_position.is_a?(Integer), new.first?
-      assert !new.last?
-
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-      assert_equal $default_position.nil?, new.first?
-      assert !new.last?
-
-      new = TopAdditionMixin.create(parent_id: 0)
-      assert_equal 1, new.pos
-      assert new.first?
-      assert new.last?
-    end
-
-    def test_insert_at
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-
-      new = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-
-      new = TopAdditionMixin.acts_as_list_no_update { TopAdditionMixin.create(parent_id: 20) }
-      assert_equal_or_nil $default_position, new.pos
-
-      new4 = TopAdditionMixin.create(parent_id: 20)
-      assert_equal 1, new4.pos
-
-      new4.insert_at(3)
-      assert_equal 3, new4.pos
-    end
-
-    def test_supplied_position
-      new = TopAdditionMixin.create(parent_id: 20, pos: 3)
-      assert_equal 3, new.pos
-    end
-
-    def test_delete_middle
-      TopAdditionMixin.where(id: 2).first.destroy
-
-      assert_equal [1, 3, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      assert_equal 1, TopAdditionMixin.where(id: 1).first.pos
-      assert_equal 2, TopAdditionMixin.where(id: 3).first.pos
-      assert_equal 3, TopAdditionMixin.where(id: 4).first.pos
-
-      TopAdditionMixin.acts_as_list_no_update { TopAdditionMixin.where(id: 3).first.destroy }
-
-      assert_equal [1, 4], TopAdditionMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      assert_equal 1, TopAdditionMixin.where(id: 1).first.pos
-      assert_equal 3, TopAdditionMixin.where(id: 4).first.pos
-    end
-
-  end
-end

data/test/shared_zero_based.rb

@@ -1,104 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module ZeroBased
-    def setup
-       (1..4).each { |counter| ZeroBasedMixin.create! pos: counter, parent_id: 5 }
-    end
-
-    def test_insert
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 0, new.pos
-      assert new.first?
-      assert new.last?
-
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-      assert !new.first?
-      assert new.last?
-
-      new = ZeroBasedMixin.acts_as_list_no_update { ZeroBasedMixin.create(parent_id: 20) }
-      assert_equal_or_nil $default_position, new.pos
-      assert !new.first?
-      assert !new.last?
-
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 2, new.pos
-      assert !new.first?
-      assert new.last?
-
-      new = ZeroBasedMixin.create(parent_id: 0)
-      assert_equal 0, new.pos
-      assert new.first?
-      assert new.last?
-
-      new = ZeroBasedMixin.create(parent_id: 1, pos: -500)
-      assert_equal 0, new.pos
-      assert new.first?
-      assert new.last?
-    end
-
-    def test_reordering
-      assert_equal [1, 2, 3, 4], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_lower
-      assert_equal [1, 3, 2, 4], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_higher
-      assert_equal [1, 2, 3, 4], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 1).first.move_to_bottom
-      assert_equal [2, 3, 4, 1], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 1).first.move_to_top
-      assert_equal [1, 2, 3, 4], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 2).first.move_to_bottom
-      assert_equal [1, 3, 4, 2], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-
-      ListMixin.where(id: 4).first.move_to_top
-      assert_equal [4, 1, 3, 2], ZeroBasedMixin.where(parent_id: 5).order('pos').map(&:id)
-    end
-
-    def test_insert_at
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 0, new.pos
-
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 1, new.pos
-
-      new = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 2, new.pos
-
-      new_noup = ZeroBasedMixin.acts_as_list_no_update { ZeroBasedMixin.create(parent_id: 20) }
-      assert_equal_or_nil $default_position, new_noup.pos
-
-      new4 = ZeroBasedMixin.create(parent_id: 20)
-      assert_equal 3, new4.pos
-
-      new4.insert_at(2)
-      assert_equal 2, new4.pos
-
-      new.reload
-      assert_equal 3, new.pos
-
-      new.insert_at(2)
-      assert_equal 2, new.pos
-
-      new4.reload
-      assert_equal 3, new4.pos
-
-      new5 = ListMixin.create(parent_id: 20)
-      assert_equal 4, new5.pos
-
-      new5.insert_at(1)
-      assert_equal 1, new5.pos
-
-      new4.reload
-      assert_equal 4, new4.pos
-
-      new_noup.reload
-      assert_equal_or_nil $default_position, new_noup.pos
-    end
-  end
-end

data/test/support/ci_database.yml

@@ -1,20 +0,0 @@
-sqlite:
-  adapter: sqlite3
-  database: file::memory:?cache=shared
-
-mysql:
-  adapter: mysql2
-  database: runner
-  pool: 5
-  timeout: 5000
-  username: root
-  password: root
-
-postgresql:
-  adapter: postgresql
-  database: runner
-  pool: 5
-  timeout: 5000
-  username: runner
-  password:
-  min_messages: ERROR

data/test/support/database.yml

@@ -1,18 +0,0 @@
-sqlite:
-  adapter: sqlite3
-  database: file::memory:?cache=shared
-
-mysql:
-  adapter: mysql2
-  host: 127.0.0.1
-  username: root
-  password:
-  database: acts_as_list
-
-postgresql:
-  adapter: postgresql
-  host: localhost
-  username: postgres
-  password: postgres
-  database: acts_as_list
-  min_messages: ERROR

data/test/test_default_scope_with_select.rb

@@ -1,33 +0,0 @@
-require 'helper'
-
-class Animal < ActiveRecord::Base
-  acts_as_list
-  default_scope -> { select(:name) }
-end
-
-class DefaultScopeWithSelectTest < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :animals do |t|
-      t.column :position, :integer
-      t.column :name, :string
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    Animal.reset_column_information
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-
-  def test_default_scope_with_select
-    animal1 = Animal.create name: 'Fox'
-    animal2 = Animal.create name: 'Panda'
-    animal3 = Animal.create name: 'Wildebeast'
-    assert_equal 1, animal1.position
-    assert_equal 2, animal2.position
-    assert_equal 3, animal3.position
-  end
-end

data/test/test_joined_list.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-
-class Section < ActiveRecord::Base
-  has_many :items
-  acts_as_list
-
-  scope :visible, -> { where(visible: true) }
-end
-
-class Item < ActiveRecord::Base
-  belongs_to :section
-  acts_as_list scope: :section
-
-  scope :visible, -> { where(visible: true).joins(:section).merge(Section.visible) }
-end
-
-class JoinedTestCase < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :sections do |t|
-      t.column :position, :integer
-      t.column :visible, :boolean, default: true
-    end
-
-    ActiveRecord::Base.connection.create_table :items do |t|
-      t.column :position, :integer
-      t.column :section_id, :integer
-      t.column :visible, :boolean, default: true
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    [Section, Item].each(&:reset_column_information)
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-end
-
-# joining the relation returned by `#higher_items` or `#lower_items` to another table
-# previously could result in ambiguous column names in the query
-class TestHigherLowerItems < JoinedTestCase
-  def test_higher_items
-    section = Section.create
-    item1 = Item.create section: section
-    item2 = Item.create section: section
-    item3 = Item.create section: section
-    assert_equal item3.higher_items.visible, [item2, item1]
-  end
-
-  def test_lower_items
-    section = Section.create
-    item1 = Item.create section: section
-    item2 = Item.create section: section
-    item3 = Item.create section: section
-    assert_equal item1.lower_items.visible, [item2, item3]
-  end
-end