acts_as_list 1.2.1 → 1.2.2

data/test/test_no_update_for_extra_classes.rb

@@ -1,131 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-
-class TodoList < ActiveRecord::Base
-  has_many :todo_items
-  acts_as_list
-end
-
-class TodoItem < ActiveRecord::Base
-  belongs_to :todo_list
-  has_many :todo_item_attachments
-  acts_as_list scope: :todo_list
-end
-
-class TodoItemAttachment < ActiveRecord::Base
-  belongs_to :todo_item
-  acts_as_list scope: :todo_item
-end
-
-class NoUpdateForCollectionClassesTestCase < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :todo_lists do |t|
-      t.column :position, :integer
-    end
-
-    ActiveRecord::Base.connection.create_table :todo_items do |t|
-      t.column :position, :integer
-      t.column :todo_list_id, :integer
-    end
-
-    ActiveRecord::Base.connection.create_table :todo_item_attachments do |t|
-      t.column :position, :integer
-      t.column :todo_item_id, :integer
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    [TodoList, TodoItem, TodoItemAttachment].each(&:reset_column_information)
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-end
-
-class NoUpdateForCollectionClassesTest < NoUpdateForCollectionClassesTestCase
-  def setup
-    super
-    @list_1, @list_2 = (1..2).map { |counter| TodoList.create!(position: counter) }
-
-    @item_1, @item_2 = (1..2).map { |counter| TodoItem.create!(position: counter, todo_list_id: @list_1.id) }
-    @attachment_1, @attachment_2 = (1..2).map { |counter| TodoItemAttachment.create!(position: counter, todo_item_id: @item_1.id) }
-    @attachment_3, @attachment_4 = (1..2).map {|counter| TodoItemAttachment.create!(position: counter, todo_item_id: @item_2.id)}
-  end
-
-  def test_update
-    @item_1.update position: 2
-    assert_equal 2, @item_1.reload.position
-    assert_equal 1, @item_2.reload.position
-  end
-
-  def test_no_update_for_single_class_instances
-    TodoItem.acts_as_list_no_update { @item_1.update position: 2 }
-
-    assert_equal 2, @item_1.reload.position
-    assert_equal 2, @item_2.reload.position
-  end
-
-  def test_no_update_for_different_class_instances
-    TodoItem.acts_as_list_no_update([TodoItemAttachment]) { update_records! }
-
-    assert_equal 2, @item_1.reload.position
-    assert_equal 2, @item_2.reload.position
-
-    assert_equal 2, @attachment_1.reload.position
-    assert_equal 2, @attachment_2.reload.position
-
-    assert_equal 2, @list_1.reload.position
-    assert_equal 1, @list_2.reload.position
-  end
-
-  def test_no_update_for_nested_blocks
-    new_list = @list_1.dup
-    new_list.save!
-
-    TodoItem.acts_as_list_no_update do
-      @list_1.todo_items.reverse.each do |item|
-        new_item = item.dup
-        new_list.todo_items << new_item
-        new_item.save!
-
-        assert_equal new_item.position, item.reload.position
-
-        TodoItemAttachment.acts_as_list_no_update do
-          item.todo_item_attachments.reverse.each do |attach|
-            new_attach = attach.dup
-            new_item.todo_item_attachments << new_attach
-            new_attach.save!
-            assert_equal new_attach.position, attach.reload.position
-          end
-        end
-      end
-    end
-  end
-
-  def test_raising_array_type_error
-    exception = assert_raises ActiveRecord::Acts::List::NoUpdate::ArrayTypeError do
-      TodoList.acts_as_list_no_update(nil)
-    end
-
-    assert_equal("The first argument must be an array", exception.message )
-  end
-
-  def test_non_disparity_classes_error
-    exception = assert_raises ActiveRecord::Acts::List::NoUpdate::DisparityClassesError do
-      TodoList.acts_as_list_no_update([Class])
-    end
-
-    assert_equal("The first argument should contain ActiveRecord or ApplicationRecord classes", exception.message )
-  end
-
-  private
-
-  def update_records!
-    @item_1.update position: 2
-    @attachment_1.update position: 2
-    @list_1.update position: 2
-  end
-end

data/test/test_no_update_for_scope_destruction.rb

@@ -1,69 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-
-class DestructionTodoList < ActiveRecord::Base
-  has_many :destruction_todo_items, dependent: :destroy
-  has_many :destruction_tada_items, dependent: :destroy
-end
-
-class DestructionTodoItem < ActiveRecord::Base
-  belongs_to :destruction_todo_list
-  acts_as_list scope: :destruction_todo_list
-end
-
-class DestructionTadaItem < ActiveRecord::Base
-  belongs_to :destruction_todo_list
-  acts_as_list scope: [:destruction_todo_list_id, :enabled]
-end
-
-class NoUpdateForScopeDestructionTestCase < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :destruction_todo_lists do |t|
-    end
-
-    ActiveRecord::Base.connection.create_table :destruction_todo_items do |t|
-      t.column :position, :integer
-      t.column :destruction_todo_list_id, :integer
-    end
-
-    ActiveRecord::Base.connection.create_table :destruction_tada_items do |t|
-      t.column :position, :integer
-      t.column :destruction_todo_list_id, :integer
-      t.column :enabled, :boolean
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    [DestructionTodoList, DestructionTodoItem, DestructionTadaItem].each(&:reset_column_information)
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-
-  class NoUpdateForScopeDestructionTest < NoUpdateForScopeDestructionTestCase
-    def setup
-      super
-      @list = DestructionTodoList.create!
-
-      @todo_item_1 = DestructionTodoItem.create! position: 1, destruction_todo_list_id: @list.id
-      @tada_item_1 = DestructionTadaItem.create! position: 1, destruction_todo_list_id: @list.id, enabled: true
-    end
-
-    def test_no_update_children_when_parent_destroyed
-      DestructionTodoItem.any_instance.expects(:decrement_positions_on_lower_items).never
-      DestructionTadaItem.any_instance.expects(:decrement_positions_on_lower_items).never
-      assert @list.destroy
-    end
-
-    def test_update_children_when_sibling_destroyed
-      @todo_item_1.expects(:decrement_positions_on_lower_items).once
-      @tada_item_1.expects(:decrement_positions_on_lower_items).once
-      assert @todo_item_1.destroy
-      assert @tada_item_1.destroy
-    end
-
-  end
-end

data/test/test_no_update_for_subclasses.rb

@@ -1,56 +0,0 @@
-# frozen_string_literal: true
-
-require 'helper'
-
-class MasterItem < ActiveRecord::Base
-  acts_as_list
-end
-
-class SlaveItem < MasterItem; end
-
-class NoUpdateForSubclassesTestCase < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :master_items do |t|
-      t.column :position, :integer
-      t.column :type, :string
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    [MasterItem, SlaveItem].each(&:reset_column_information)
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-end
-
-class NoUpdateForSubclassesTest < NoUpdateForSubclassesTestCase
-  def setup
-    super
-    @item_1, @item_2 = (1..2).map do |counter|
-      SlaveItem.create!(position: counter)
-    end
-  end
-
-  def test_update
-    @item_1.update position: 2
-    assert_equal 2, @item_1.reload.position
-    assert_equal 1, @item_2.reload.position
-  end
-
-  def test_no_update_for_subclass_instances_with_no_update_on_superclass
-    MasterItem.acts_as_list_no_update { @item_1.update position: 2 }
-
-    assert_equal 2, @item_1.reload.position
-    assert_equal 2, @item_2.reload.position
-  end
-
-  def test_no_update_for_subclass_instances_with_no_update_on_subclass
-    SlaveItem.acts_as_list_no_update { @item_1.update position: 2 }
-
-    assert_equal 2, @item_1.reload.position
-    assert_equal 2, @item_2.reload.position
-  end
-end

data/test/test_scope_with_user_defined_foreign_key.rb

@@ -1,42 +0,0 @@
-require 'helper'
-
-class Checklist < ActiveRecord::Base
-  has_many :checklist_items, foreign_key: 'list_id', inverse_of: :checklist
-end
-
-class ChecklistItem < ActiveRecord::Base
-  belongs_to :checklist, foreign_key: 'list_id', inverse_of: :checklist_items
-  acts_as_list scope: :checklist
-end
-
-class ScopeWithUserDefinedForeignKeyTest < Minitest::Test
-  def setup
-    ActiveRecord::Base.connection.create_table :checklists do |t|
-    end
-
-    ActiveRecord::Base.connection.create_table :checklist_items do |t|
-      t.column :list_id, :integer
-      t.column :position, :integer
-    end
-
-    ActiveRecord::Base.connection.schema_cache.clear!
-    [Checklist, ChecklistItem].each(&:reset_column_information)
-    super
-  end
-
-  def teardown
-    teardown_db
-    super
-  end
-
-  def test_scope_with_user_defined_foreign_key
-    checklist = Checklist.create
-    checklist_item_1 = checklist.checklist_items.create
-    checklist_item_2 = checklist.checklist_items.create
-    checklist_item_3 = checklist.checklist_items.create
-
-    assert_equal 1, checklist_item_1.position
-    assert_equal 2, checklist_item_2.position
-    assert_equal 3, checklist_item_3.position
-  end
-end