acts_as_list 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 97086f40e0296a92be25b988885cb618bd17323c31639c7b976e20e82005da54
-  data.tar.gz: 225e05bc8973871d0a7955abaf181180ff5b8de3d2b461278eeb260df3a49b2c
+  metadata.gz: bc38c9c0378653bb5f8eb7194bd9cc22d906df7cf2b7a158e9fe763a0d6f5a94
+  data.tar.gz: c67158a399378bab4f1258ba6819f9cb7715eedc0b63e1f995869d0032075b75
 SHA512:
-  metadata.gz: 6d43449915c885f64e477bff8c4a9e0d581e632e4cfab61e0f313fc0b67c4507f6cda9e3aab5afb53357cc44fee664f873e7ca2b93b0f22a22b1e272ed1e39db
-  data.tar.gz: 24dfa6bf08290e1d18331ee5ad7c0eeb03ae1dce2191881503a889058136ccfb8007d0acbee9bc57e5363073740a8efec872225b4978922d0a1f1dcf49c3ca0a
+  metadata.gz: 8b4b29d19abf1dbc2b0c75b4f0a0e4123ec4580084a170af83ca3431ca0bc7d46fa108ba3d6573620585bb00332c0b2b10b68779d2a4fd899fcfc888601e83ab
+  data.tar.gz: 2c999ec1287f4fafacd7406317075c5a0410f84a8c7e0b96ec787fffee0209033ca78aa4947948aee830fe41a6de173ad031fe5895daf33b12679140507aa278

data/CHANGELOG.md

@@ -6,6 +6,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## v1.2.2 - 2024-07-16
+
+### Fixed
+- Updated .gemspec to exclude unnecessary files from the gem package. [\#437](https://github.com/brendon/acts_as_list/pull/437) ([f440])
+
+## v1.2.1 - 2024-06-06
+
+### Fixed
+- We no longer delegate the class `connection` method to the instance. [\#436](https://github.com/brendon/acts_as_list/pull/436) ([davidcelis])
+
 ## v1.2.0 - 2024-06-03
 
 ### Added
@@ -265,7 +275,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 **Closed issues:**
 
 - DEPRECATION WARNING on rails 5.0 as of acts\_as\_list 0.9 [\#251](https://github.com/brendon/acts_as_list/issues/251)
-- highter\_items returns items with the same position value [\#247](https://github.com/brendon/acts_as_list/issues/247)
+- higher\_items returns items with the same position value [\#247](https://github.com/brendon/acts_as_list/issues/247)
 - Broken with unique constraint on position [\#245](https://github.com/brendon/acts_as_list/issues/245)
 
 **Merged pull requests:**
@@ -493,7 +503,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix sanitize\_sql\_hash\_for\_conditions deprecation warning in Rails 4.2 [\#140](https://github.com/brendon/acts_as_list/pull/140) ([eagletmt](https://github.com/eagletmt))
 - Simpler method to find the subclass name [\#139](https://github.com/brendon/acts_as_list/pull/139) ([brendon](https://github.com/brendon))
 - Rails4 enum column support [\#130](https://github.com/brendon/acts_as_list/pull/130) ([arunagw](https://github.com/arunagw))
-- use eval for determing the self.class.name useful when this is used in an abstract class [\#123](https://github.com/brendon/acts_as_list/pull/123) ([flarik](https://github.com/flarik))
+- use eval for determining the self.class.name useful when this is used in an abstract class [\#123](https://github.com/brendon/acts_as_list/pull/123) ([flarik](https://github.com/flarik))
 
 ## [0.5.0](https://github.com/brendon/acts_as_list/tree/0.5.0) (2014-10-31)
 [Full Changelog](https://github.com/brendon/acts_as_list/compare/0.4.0...0.5.0)
@@ -633,7 +643,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - acts\_as\_list :scope =\> "doesnt\_seem\_to\_work" [\#12](https://github.com/brendon/acts_as_list/issues/12)
 - don't work perfectly with default\_scope [\#11](https://github.com/brendon/acts_as_list/issues/11)
 - MySQL: Position column MUST NOT have default [\#10](https://github.com/brendon/acts_as_list/issues/10)
-- insert\_at fails on postgresql w/ non-null constraint on postion\_column  [\#8](https://github.com/brendon/acts_as_list/issues/8)
+- insert\_at fails on postgresql w/ non-null constraint on position\_column  [\#8](https://github.com/brendon/acts_as_list/issues/8)
 
 **Merged pull requests:**
 
@@ -642,7 +652,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Massive test refactorings. [\#24](https://github.com/brendon/acts_as_list/pull/24) ([splattael](https://github.com/splattael))
 - Silent migrations to reduce test noise. [\#22](https://github.com/brendon/acts_as_list/pull/22) ([splattael](https://github.com/splattael))
 - Should decrement lower items after the item has been destroyed to avoid unique key conflicts. [\#18](https://github.com/brendon/acts_as_list/pull/18) ([aepstein](https://github.com/aepstein))
-- Fix spelling and grammer [\#15](https://github.com/brendon/acts_as_list/pull/15) ([tmiller](https://github.com/tmiller))
+- Fix spelling and grammar [\#15](https://github.com/brendon/acts_as_list/pull/15) ([tmiller](https://github.com/tmiller))
 - store\_at\_0 should yank item from the list then decrement items to avoid r [\#14](https://github.com/brendon/acts_as_list/pull/14) ([aepstein](https://github.com/aepstein))
 - Support default\_scope ordering by calling .unscoped [\#13](https://github.com/brendon/acts_as_list/pull/13) ([tanordheim](https://github.com/tanordheim))
 

data/README.md

@@ -1,11 +1,11 @@
 # Acts As List
 
 ## Build Status
-[![Build Status](https://travis-ci.org/brendon/acts_as_list.svg?branch=master)](https://travis-ci.org/brendon/acts_as_list)
+[![Continuous Integration](https://github.com/brendon/acts_as_list/actions/workflows/continuous_integration.yml/badge.svg)](https://github.com/brendon/acts_as_list/actions/workflows/continuous_integration.yml)
 [![Gem Version](https://badge.fury.io/rb/acts_as_list.svg)](https://badge.fury.io/rb/acts_as_list)
 
 ## ANNOUNCING: Positioning, the gem
-As maintainer of both Acts As List and the Ranked Model gems, I've become intimately aquainted with the strengths and weaknesses of each. I ended up writing a small scale Rails Concern for positioning database rows for a recent project and it worked really well so I've decided to release it as a gem: [Positioning](https://github.com/brendon/positioning)
+As maintainer of both Acts As List and the Ranked Model gems, I've become intimately acquainted with the strengths and weaknesses of each. I ended up writing a small scale Rails Concern for positioning database rows for a recent project and it worked really well so I've decided to release it as a gem: [Positioning](https://github.com/brendon/positioning)
 
 Positioning works similarly to Acts As List in that it maintains a sequential list of integer values as positions. It differs in that it encourages a unique constraints on the position column and supports multiple lists per database table. It borrows Ranked Model's concept of relative positioning. I encourage you to check it out and give it a whirl on your project!
 
@@ -290,7 +290,7 @@ All versions `0.1.5` onwards require Rails 3.0.x and higher.
 
 We often hear complaints that `position` values are repeated, incorrect etc. For example, #254. To ensure data integrity, you should rely on your database. There are two things you can do:
 
-1. Use constraints.  If you model `Item` that `belongs_to` an `Order`, and it has a `position` column, then add a unique constraint on `items` with `[:order_id, :position]`.  Think of it as a list invariant. What are the properties of your list that don't change no matter how many items you have in it?  One such propery is that each item has a distinct position. Another _could be_ that position is always greater than 0. It is strongly recommended that you rely on your database to enforce these invariants or constraints. Here are the docs for [PostgreSQL](https://www.postgresql.org/docs/9.5/static/ddl-constraints.html) and [MySQL](https://dev.mysql.com/doc/refman/8.0/en/alter-table.html).
+1. Use constraints.  If you model `Item` that `belongs_to` an `Order`, and it has a `position` column, then add a unique constraint on `items` with `[:order_id, :position]`.  Think of it as a list invariant. What are the properties of your list that don't change no matter how many items you have in it?  One such property is that each item has a distinct position. Another _could be_ that position is always greater than 0. It is strongly recommended that you rely on your database to enforce these invariants or constraints. Here are the docs for [PostgreSQL](https://www.postgresql.org/docs/9.5/static/ddl-constraints.html) and [MySQL](https://dev.mysql.com/doc/refman/8.0/en/alter-table.html).
 2. Use mutexes or row level locks. At its heart the duplicate problem is that of handling concurrency. Adding a contention resolution mechanism like locks will solve it to some extent.  But it is not a solution or replacement for constraints.  Locks are also prone to deadlocks.
 
 As a library, `acts_as_list` may not always have all the context needed to apply these tools. They are much better suited at the application level.

data/lib/acts_as_list/active_record/acts/position_column_method_definer.rb

@@ -72,17 +72,18 @@ module ActiveRecord::Acts::List::PositionColumnMethodDefiner #:nodoc:
         cached_quoted_now = quoted_current_time_from_proper_timezone
 
         timestamp_attributes_for_update_in_model.map do |attr|
-          ", #{connection.quote_column_name(attr)} = #{cached_quoted_now}"
+          ", #{self.class.connection.quote_column_name(attr)} = #{cached_quoted_now}"
         end.join
       end
 
       private
 
-      delegate :connection, to: self
-
       def quoted_current_time_from_proper_timezone
-        connection.quote(connection.quoted_date(
-          current_time_from_proper_timezone))
+        self.class.connection.quote(
+          self.class.connection.quoted_date(
+            current_time_from_proper_timezone
+          )
+        )
       end
     end
   end

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '1.2.0'
+      VERSION = '1.2.2'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Swanand Pagnis
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-02 00:00:00.000000000 Z
+date: 2024-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -134,16 +134,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gemtest"
-- ".github/FUNDING.yml"
-- ".github/dependabot.yml"
-- ".github/workflows/continuous_integration.yml"
-- ".gitignore"
 - CHANGELOG.md
-- Gemfile
 - MIT-LICENSE
 - README.md
 - Rakefile
-- acts_as_list.gemspec
 - init.rb
 - lib/acts_as_list.rb
 - lib/acts_as_list/active_record/acts/active_record.rb
@@ -157,24 +151,6 @@ files:
 - lib/acts_as_list/active_record/acts/sequential_updates_method_definer.rb
 - lib/acts_as_list/active_record/acts/top_of_list_method_definer.rb
 - lib/acts_as_list/version.rb
-- test/helper.rb
-- test/shared.rb
-- test/shared_array_scope_list.rb
-- test/shared_list.rb
-- test/shared_list_sub.rb
-- test/shared_no_addition.rb
-- test/shared_quoting.rb
-- test/shared_top_addition.rb
-- test/shared_zero_based.rb
-- test/support/ci_database.yml
-- test/support/database.yml
-- test/test_default_scope_with_select.rb
-- test/test_joined_list.rb
-- test/test_list.rb
-- test/test_no_update_for_extra_classes.rb
-- test/test_no_update_for_scope_destruction.rb
-- test/test_no_update_for_subclasses.rb
-- test/test_scope_with_user_defined_foreign_key.rb
 homepage: https://github.com/brendon/acts_as_list
 licenses:
 - MIT
@@ -182,6 +158,7 @@ metadata:
   changelog_uri: https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/brendon/acts_as_list
   bug_tracker_uri: https://github.com/brendon/acts_as_list/issues
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -190,7 +167,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.7
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -202,22 +179,4 @@ signing_key:
 specification_version: 4
 summary: A gem adding sorting, reordering capabilities to an active_record model,
   allowing it to act as a list
-test_files:
-- test/helper.rb
-- test/shared.rb
-- test/shared_array_scope_list.rb
-- test/shared_list.rb
-- test/shared_list_sub.rb
-- test/shared_no_addition.rb
-- test/shared_quoting.rb
-- test/shared_top_addition.rb
-- test/shared_zero_based.rb
-- test/support/ci_database.yml
-- test/support/database.yml
-- test/test_default_scope_with_select.rb
-- test/test_joined_list.rb
-- test/test_list.rb
-- test/test_no_update_for_extra_classes.rb
-- test/test_no_update_for_scope_destruction.rb
-- test/test_no_update_for_subclasses.rb
-- test/test_scope_with_user_defined_foreign_key.rb
+test_files: []

data/.github/FUNDING.yml

@@ -1,3 +0,0 @@
-# These are supported funding model platforms
-
-github: [brendon]

data/.github/dependabot.yml

@@ -1,6 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: "github-actions"
-    directory: "/"
-    schedule:
-      interval: "weekly"

data/.github/workflows/continuous_integration.yml

@@ -1,62 +0,0 @@
-name: Continuous Integration
-
-on:
-  push:
-    branches:
-      - master
-  pull_request:
-
-jobs:
-  tests:
-    runs-on: ubuntu-latest
-    name: Ruby ${{ matrix.ruby }}, DB ${{ matrix.db }}, Rails ${{ matrix.rails }}
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby:
-          - '3.0'
-          - '3.1'
-          - '3.2'
-          - '3.3'
-        rails:
-          - '6.1'
-          - '7.0'
-          - '7.1'
-        db:
-          - mysql
-          - postgresql
-          - sqlite
-        exclude:
-          - rails: '7.0'
-            ruby: '3.1'
-          - rails: '7.0'
-            ruby: '3.2'
-          - rails: '7.0'
-            ruby: '3.3'
-    env:
-      DB: ${{ matrix.db }}
-      RAILS_VERSION: ${{ matrix.rails }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler-cache: true
-      - name: Enable MySQL
-        if: ${{ matrix.db == 'mysql' }}
-        run: sudo systemctl start mysql.service
-      - name: Create MySQL Database
-        if: ${{ matrix.db == 'mysql' }}
-        run: mysql -u root -proot -e 'CREATE DATABASE runner;'
-      - name: Enable PostgreSQL
-        if: ${{ matrix.db == 'postgresql' }}
-        run: sudo systemctl start postgresql.service
-      - name: Create PostgreSQL User
-        if: ${{ matrix.db == 'postgresql' }}
-        run: sudo -u postgres -i createuser runner -s
-      - name: Create PostgreSQL Database
-        if: ${{ matrix.db == 'postgresql' }}
-        run: createdb runner
-      - name: Run the default task
-        run: bundle exec rake

data/.gitignore

@@ -1,13 +0,0 @@
-*.gem
-.bundle
-Gemfile.lock
-pkg/*
-.rvmrc
-*.tmproj
-.rbenv-version
-.ruby-gemset
-.ruby-version
-.DS_Store
-/tmp/
-/db/
-file::memory*

data/Gemfile

@@ -1,13 +0,0 @@
-source "http://rubygems.org"
-
-# Specify your gem's dependencies in positioning.gemspec
-gemspec
-
-gem "rake", "~> 13.0"
-
-gem "minitest", "~> 5.0"
-
-if ENV["RAILS_VERSION"]
-  gem "activerecord", ENV["RAILS_VERSION"]
-  gem "activesupport", ENV["RAILS_VERSION"]
-end

data/acts_as_list.gemspec

@@ -1,39 +0,0 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "acts_as_list/version"
-
-Gem::Specification.new do |s|
-  # Description Meta...
-  s.name                  = "acts_as_list"
-  s.version               = ActiveRecord::Acts::List::VERSION
-  s.platform              = Gem::Platform::RUBY
-  s.authors               = ["Swanand Pagnis", "Brendon Muir"]
-  s.email                 = %w(swanand.pagnis@gmail.com brendon@spikeatschool.co.nz)
-  s.homepage              = "https://github.com/brendon/acts_as_list"
-  s.summary               = "A gem adding sorting, reordering capabilities to an active_record model, allowing it to act as a list"
-  s.description           = 'This "acts_as" extension provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a "position" column defined as an integer on the mapped database table.'
-  s.license               = "MIT"
-  s.required_ruby_version = ">= 2.4.7"
-
-  if s.respond_to?(:metadata)
-    s.metadata['changelog_uri']   = 'https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md'
-    s.metadata['source_code_uri'] = 'https://github.com/brendon/acts_as_list'
-    s.metadata['bug_tracker_uri'] = 'https://github.com/brendon/acts_as_list/issues'
-  end
-
-  # Load Paths...
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map {|f| File.basename(f)}
-  s.require_paths = ["lib"]
-
-  # Dependencies (installed via "bundle install")
-  s.add_dependency "activerecord", ">= 6.1"
-  s.add_dependency "activesupport", ">= 6.1"
-  s.add_development_dependency "minitest-hooks", "~> 1.5.1"
-  s.add_development_dependency "mocha", "~> 2.1.0"
-  s.add_development_dependency "timecop", "~> 0.9.8"
-  s.add_development_dependency "mysql2", "~> 0.5.6"
-  s.add_development_dependency "pg", "~> 1.5.5"
-  s.add_development_dependency "sqlite3", "~> 1.7.2"
-end

data/test/helper.rb

@@ -1,81 +0,0 @@
-# frozen_string_literal: true
-
-# $DEBUG = true
-
-require "rubygems"
-require "bundler/setup"
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require "active_record"
-require "minitest/autorun"
-require "mocha/minitest"
-require "#{File.dirname(__FILE__)}/../init"
-
-ENV["DB"] = "mysql" unless ENV["DB"]
-
-if defined?(ActiveRecord::VERSION) &&
-  ActiveRecord::VERSION::MAJOR == 4 && ActiveRecord::VERSION::MINOR >= 2
-
-  # Was removed in Rails 5 and is effectively true.
-  ActiveRecord::Base.raise_in_transactional_callbacks = true
-end
-
-database_configuration = ENV["CI"] ? "test/support/ci_database.yml" : "test/support/database.yml"
-
-ActiveRecord::Base.configurations = YAML.safe_load(IO.read(database_configuration))
-ActiveRecord::Base.establish_connection(ENV["DB"].to_sym)
-ActiveRecord::Schema.verbose = false
-
-def teardown_db
-  if ActiveRecord::VERSION::MAJOR >= 5
-    tables = ActiveRecord::Base.connection.data_sources
-  else
-    tables = ActiveRecord::Base.connection.tables
-  end
-
-  tables.each do |table|
-    ActiveRecord::Base.connection.drop_table(table)
-  end
-end
-
-require "shared"
-
-# require 'logger'
-# ActiveRecord::Base.logger = Logger.new(STDOUT)
-
-def assert_equal_or_nil(a, b)
-  if a.nil?
-    assert_nil b
-  else
-    assert_equal a, b
-  end
-end
-
-def assert_no_deprecation_warning_raised_by(failure_message = 'ActiveRecord deprecation warning raised when we didn\'t expect it', pass_message = 'No ActiveRecord deprecation raised')
-  original_behavior = active_record_deprecator.behavior
-  active_record_deprecator.behavior = :raise
-  begin
-    yield
-  rescue ActiveSupport::DeprecationException => e
-    flunk "#{failure_message}: #{e}"
-  rescue
-    raise
-  else
-    pass pass_message
-  end
-ensure
-  active_record_deprecator.behavior = original_behavior
-end
-
-def active_record_deprecator
-  if ActiveRecord::VERSION::MAJOR == 7 && ActiveRecord::VERSION::MINOR >= 1 || ActiveRecord::VERSION::MAJOR > 7
-    ActiveRecord.deprecator
-  else
-    ActiveSupport::Deprecation
-  end
-end

data/test/shared.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-# Common shared behaviour.
-module Shared
-  autoload :List,           'shared_list'
-  autoload :ListSub,        'shared_list_sub'
-  autoload :ZeroBased,      'shared_zero_based'
-  autoload :ArrayScopeList, 'shared_array_scope_list'
-  autoload :TopAddition,    'shared_top_addition'
-  autoload :NoAddition,     'shared_no_addition'
-  autoload :Quoting,        'shared_quoting'
-end

data/test/shared_array_scope_list.rb

@@ -1,177 +0,0 @@
-# frozen_string_literal: true
-
-module Shared
-  module ArrayScopeList
-    def setup
-      (1..4).each { |counter| ArrayScopeListMixin.create! pos: counter, parent_id: 5, parent_type: 'ParentClass' }
-      (1..4).each { |counter| ArrayScopeListMixin.create! pos: counter, parent_id: 6, parent_type: 'ParentClass' }
-    end
-
-    def test_reordering
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.move_lower
-      assert_equal [1, 3, 2, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.move_higher
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 1).first.move_to_bottom
-      assert_equal [2, 3, 4, 1], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 1).first.move_to_top
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.move_to_bottom
-      assert_equal [1, 3, 4, 2], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 4).first.move_to_top
-      assert_equal [4, 1, 3, 2], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 4).first.insert_at(4)
-      assert_equal [1, 3, 2, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:pos)
-    end
-
-    def test_move_to_bottom_with_next_to_last_item
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-      ArrayScopeListMixin.where(id: 3).first.move_to_bottom
-      assert_equal [1, 2, 4, 3], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-    end
-
-    def test_next_prev
-      assert_equal ArrayScopeListMixin.where(id: 2).first, ArrayScopeListMixin.where(id: 1).first.lower_item
-      assert_nil ArrayScopeListMixin.where(id: 1).first.higher_item
-      assert_equal ArrayScopeListMixin.where(id: 3).first, ArrayScopeListMixin.where(id: 4).first.higher_item
-      assert_nil ArrayScopeListMixin.where(id: 4).first.lower_item
-    end
-
-    def test_injection
-      item = ArrayScopeListMixin.new(parent_id: 1, parent_type: 'ParentClass')
-      assert_equal "pos", item.position_column
-    end
-
-    def test_insert
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 1, new.pos
-      assert new.first?
-      assert new.last?
-
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 2, new.pos
-      assert !new.first?
-      assert new.last?
-
-      new = ArrayScopeListMixin.acts_as_list_no_update { ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass') }
-      assert_equal_or_nil $default_position,new.pos
-      assert_equal $default_position.is_a?(Integer), new.first?
-      assert !new.last?
-
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 3, new.pos
-      assert !new.first?
-      assert new.last?
-
-      new = ArrayScopeListMixin.create(parent_id: 0, parent_type: 'ParentClass')
-      assert_equal 1, new.pos
-      assert new.first?
-      assert new.last?
-    end
-
-    def test_insert_at
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 1, new.pos
-
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 2, new.pos
-
-      new = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 3, new.pos
-
-      new_noup = ArrayScopeListMixin.acts_as_list_no_update { ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass') }
-      assert_equal_or_nil $default_position,new_noup.pos
-
-      new4 = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 4, new4.pos
-
-      new4.insert_at(3)
-      assert_equal 3, new4.pos
-
-      new.reload
-      assert_equal 4, new.pos
-
-      new.insert_at(2)
-      assert_equal 2, new.pos
-
-      new4.reload
-      assert_equal 4, new4.pos
-
-      new5 = ArrayScopeListMixin.create(parent_id: 20, parent_type: 'ParentClass')
-      assert_equal 5, new5.pos
-
-      new5.insert_at(1)
-      assert_equal 1, new5.pos
-
-      new4.reload
-      assert_equal 5, new4.pos
-
-      new_noup.reload
-      assert_equal_or_nil $default_position, new_noup.pos
-    end
-
-    def test_delete_middle
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.destroy
-
-      assert_equal [1, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      assert_equal 1, ArrayScopeListMixin.where(id: 1).first.pos
-      assert_equal 2, ArrayScopeListMixin.where(id: 3).first.pos
-      assert_equal 3, ArrayScopeListMixin.where(id: 4).first.pos
-
-      ArrayScopeListMixin.where(id: 1).first.destroy
-
-      assert_equal [3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      assert_equal 1, ArrayScopeListMixin.where(id: 3).first.pos
-      assert_equal 2, ArrayScopeListMixin.where(id: 4).first.pos
-
-      ArrayScopeListMixin.acts_as_list_no_update { ArrayScopeListMixin.where(id: 3).first.destroy }
-
-      assert_equal [4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      assert_equal 2, ArrayScopeListMixin.where(id: 4).first.pos
-    end
-
-    def test_remove_from_list_should_then_fail_in_list?
-      assert_equal true, ArrayScopeListMixin.where(id: 1).first.in_list?
-      ArrayScopeListMixin.where(id: 1).first.remove_from_list
-      assert_equal false, ArrayScopeListMixin.where(id: 1).first.in_list?
-    end
-
-    def test_remove_from_list_should_set_position_to_nil
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.remove_from_list
-
-      assert_equal 1,   ArrayScopeListMixin.where(id: 1).first.pos
-      assert_nil        ArrayScopeListMixin.where(id: 2).first.pos
-      assert_equal 2,   ArrayScopeListMixin.where(id: 3).first.pos
-      assert_equal 3,   ArrayScopeListMixin.where(id: 4).first.pos
-    end
-
-    def test_remove_before_destroy_does_not_shift_lower_items_twice
-      assert_equal [1, 2, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      ArrayScopeListMixin.where(id: 2).first.remove_from_list
-      ArrayScopeListMixin.where(id: 2).first.destroy
-
-      assert_equal [1, 3, 4], ArrayScopeListMixin.where(parent_id: 5, parent_type: 'ParentClass').order('pos').map(&:id)
-
-      assert_equal 1, ArrayScopeListMixin.where(id: 1).first.pos
-      assert_equal 2, ArrayScopeListMixin.where(id: 3).first.pos
-      assert_equal 3, ArrayScopeListMixin.where(id: 4).first.pos
-    end
-  end
-end