acts_as_list 1.1.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ece77b4a7a9c6c50d1d7a188c91c6dedd4c1dba4c8ece714c2922b339c3b5490
-  data.tar.gz: e7d925c76332e504d6a3db3706c4362b962d5bef2f9c882023bef99a0763e2d1
+  metadata.gz: f9d85921cd5b149fa3581d5868734c62fb42e449e4058db26cffb0e62a146b9c
+  data.tar.gz: 94b6b6a6599ec0fa381f737bd5b2132258b7620905016bb467e1663f9552021a
 SHA512:
-  metadata.gz: 8ca617673d046ef18baab0a51d4e481ac10e7b044c569a9efb201c894be702aec66eb72cbc5364bb85b6374c144990fcc3c367b01cc62e0f431d87b6e41e0f4f
-  data.tar.gz: c1ce411f1aa503b28a837b714db52a4bcb42ae78542183f6641aa0d0f483c9c98b3521a4557554e9de539b12effeee6f901632636d61408e423c55d67287f47b
+  metadata.gz: f991880d1399bdbe56e4ef2511368115fc382dfebe2549188e0b8123f5cd8a93b33f067a602aadd8dbfa70893662b6fe5072d9deea7aba26d8827b83b9e1ac41
+  data.tar.gz: df1570e602643b91b602ed3044c9fbe8457ce95e42cf8fdca5858d8bd1460f4105f8839bf87c5338cb0fb4cbac11c46b15c6206dc039cc39cc3c1b561129fcee

data/.github/workflows/continuous_integration.yml

@@ -0,0 +1,62 @@
+name: Continuous Integration
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    name: Ruby ${{ matrix.ruby }}, DB ${{ matrix.db }}, Rails ${{ matrix.rails }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.0'
+          - '3.1'
+          - '3.2'
+          - '3.3'
+        rails:
+          - '6.1'
+          - '7.0'
+          - '7.1'
+        db:
+          - mysql
+          - postgresql
+          - sqlite
+        exclude:
+          - rails: '7.0'
+            ruby: '3.1'
+          - rails: '7.0'
+            ruby: '3.2'
+          - rails: '7.0'
+            ruby: '3.3'
+    env:
+      DB: ${{ matrix.db }}
+      RAILS_VERSION: ${{ matrix.rails }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Enable MySQL
+        if: ${{ matrix.db == 'mysql' }}
+        run: sudo systemctl start mysql.service
+      - name: Create MySQL Database
+        if: ${{ matrix.db == 'mysql' }}
+        run: mysql -u root -proot -e 'CREATE DATABASE runner;'
+      - name: Enable PostgreSQL
+        if: ${{ matrix.db == 'postgresql' }}
+        run: sudo systemctl start postgresql.service
+      - name: Create PostgreSQL User
+        if: ${{ matrix.db == 'postgresql' }}
+        run: sudo -u postgres -i createuser runner -s
+      - name: Create PostgreSQL Database
+        if: ${{ matrix.db == 'postgresql' }}
+        run: createdb runner
+      - name: Run the default task
+        run: bundle exec rake

data/.gitignore

@@ -7,6 +7,7 @@ pkg/*
 .rbenv-version
 .ruby-gemset
 .ruby-version
-# Appraisal generated lockfiles
-*.gemfile.lock
 .DS_Store
+/tmp/
+/db/
+file::memory*

data/CHANGELOG.md

@@ -6,6 +6,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## v1.2.1 - 2024-06-06
+
+### Fixed
+- We no longer delegate the class `connection` method to the instance. [\#436](https://github.com/brendon/acts_as_list/pull/436) ([davidcelis])
+
+## v1.2.0 - 2024-06-03
+
+### Added
+- Add support for composite primary keys. [\#430](https://github.com/brendon/acts_as_list/pull/430) ([divagueame])
+
+### Changed
+- Refactored CI testing framework and removed the Appraisals gem. Use RAILS_VERSION to switch the Rails version you are currently running the tests against.
+- We now only explicitly test against Rails 6.1+ and Ruby 3.0+.
+
 ## v1.1.0 - 2023-02-01
 
 ### Fixed (Possibly Breaking)
@@ -256,7 +270,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 **Closed issues:**
 
 - DEPRECATION WARNING on rails 5.0 as of acts\_as\_list 0.9 [\#251](https://github.com/brendon/acts_as_list/issues/251)
-- highter\_items returns items with the same position value [\#247](https://github.com/brendon/acts_as_list/issues/247)
+- higher\_items returns items with the same position value [\#247](https://github.com/brendon/acts_as_list/issues/247)
 - Broken with unique constraint on position [\#245](https://github.com/brendon/acts_as_list/issues/245)
 
 **Merged pull requests:**
@@ -484,7 +498,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix sanitize\_sql\_hash\_for\_conditions deprecation warning in Rails 4.2 [\#140](https://github.com/brendon/acts_as_list/pull/140) ([eagletmt](https://github.com/eagletmt))
 - Simpler method to find the subclass name [\#139](https://github.com/brendon/acts_as_list/pull/139) ([brendon](https://github.com/brendon))
 - Rails4 enum column support [\#130](https://github.com/brendon/acts_as_list/pull/130) ([arunagw](https://github.com/arunagw))
-- use eval for determing the self.class.name useful when this is used in an abstract class [\#123](https://github.com/brendon/acts_as_list/pull/123) ([flarik](https://github.com/flarik))
+- use eval for determining the self.class.name useful when this is used in an abstract class [\#123](https://github.com/brendon/acts_as_list/pull/123) ([flarik](https://github.com/flarik))
 
 ## [0.5.0](https://github.com/brendon/acts_as_list/tree/0.5.0) (2014-10-31)
 [Full Changelog](https://github.com/brendon/acts_as_list/compare/0.4.0...0.5.0)
@@ -624,7 +638,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - acts\_as\_list :scope =\> "doesnt\_seem\_to\_work" [\#12](https://github.com/brendon/acts_as_list/issues/12)
 - don't work perfectly with default\_scope [\#11](https://github.com/brendon/acts_as_list/issues/11)
 - MySQL: Position column MUST NOT have default [\#10](https://github.com/brendon/acts_as_list/issues/10)
-- insert\_at fails on postgresql w/ non-null constraint on postion\_column  [\#8](https://github.com/brendon/acts_as_list/issues/8)
+- insert\_at fails on postgresql w/ non-null constraint on position\_column  [\#8](https://github.com/brendon/acts_as_list/issues/8)
 
 **Merged pull requests:**
 
@@ -633,7 +647,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Massive test refactorings. [\#24](https://github.com/brendon/acts_as_list/pull/24) ([splattael](https://github.com/splattael))
 - Silent migrations to reduce test noise. [\#22](https://github.com/brendon/acts_as_list/pull/22) ([splattael](https://github.com/splattael))
 - Should decrement lower items after the item has been destroyed to avoid unique key conflicts. [\#18](https://github.com/brendon/acts_as_list/pull/18) ([aepstein](https://github.com/aepstein))
-- Fix spelling and grammer [\#15](https://github.com/brendon/acts_as_list/pull/15) ([tmiller](https://github.com/tmiller))
+- Fix spelling and grammar [\#15](https://github.com/brendon/acts_as_list/pull/15) ([tmiller](https://github.com/tmiller))
 - store\_at\_0 should yank item from the list then decrement items to avoid r [\#14](https://github.com/brendon/acts_as_list/pull/14) ([aepstein](https://github.com/aepstein))
 - Support default\_scope ordering by calling .unscoped [\#13](https://github.com/brendon/acts_as_list/pull/13) ([tanordheim](https://github.com/tanordheim))
 

data/Gemfile

@@ -1,28 +1,13 @@
 source "http://rubygems.org"
 
+# Specify your gem's dependencies in positioning.gemspec
 gemspec
 
-gem "rake"
-gem "appraisal"
+gem "rake", "~> 13.0"
 
-group :development do
-  gem "github_changelog_generator", "1.9.0"
-end
-
-group :test do
-  gem "minitest", "~> 5.0"
-  gem "timecop"
-  gem "mocha"
-end
-
-group :sqlite do
-  gem "sqlite3", "~> 1.4"
-end
-
-group :postgresql do
-  gem "pg", "~> 1.2.0"
-end
+gem "minitest", "~> 5.0"
 
-group :mysql do
-  gem "mysql2", "~> 0.5.0"
+if ENV["RAILS_VERSION"]
+  gem "activerecord", ENV["RAILS_VERSION"]
+  gem "activesupport", ENV["RAILS_VERSION"]
 end

data/README.md

@@ -1,9 +1,14 @@
 # Acts As List
 
 ## Build Status
-[![Build Status](https://travis-ci.org/brendon/acts_as_list.svg?branch=master)](https://travis-ci.org/brendon/acts_as_list)
+[![Continuous Integration](https://github.com/brendon/acts_as_list/actions/workflows/continuous_integration.yml/badge.svg)](https://github.com/brendon/acts_as_list/actions/workflows/continuous_integration.yml)
 [![Gem Version](https://badge.fury.io/rb/acts_as_list.svg)](https://badge.fury.io/rb/acts_as_list)
 
+## ANNOUNCING: Positioning, the gem
+As maintainer of both Acts As List and the Ranked Model gems, I've become intimately acquainted with the strengths and weaknesses of each. I ended up writing a small scale Rails Concern for positioning database rows for a recent project and it worked really well so I've decided to release it as a gem: [Positioning](https://github.com/brendon/positioning)
+
+Positioning works similarly to Acts As List in that it maintains a sequential list of integer values as positions. It differs in that it encourages a unique constraints on the position column and supports multiple lists per database table. It borrows Ranked Model's concept of relative positioning. I encourage you to check it out and give it a whirl on your project!
+
 ## Description
 
 This `acts_as` extension provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a `position` column defined as an integer on the mapped database table.
@@ -117,7 +122,7 @@ When using PostgreSQL, it is also possible to leave this migration up to the dat
        ROW_NUMBER() OVER (
          PARTITION BY todo_list_id
          ORDER BY updated_at
-       ) as new_position
+       ) AS new_position
      FROM todo_items
    ) AS mapping
    WHERE todo_items.id = mapping.id;
@@ -195,7 +200,7 @@ class TodoItem < ActiveRecord::Base
 end
 
 class TodoAttachment < ActiveRecord::Base
-  belongs_to :todo_list
+  belongs_to :todo_item
   acts_as_list scope: :todo_item
 end
 
@@ -285,7 +290,7 @@ All versions `0.1.5` onwards require Rails 3.0.x and higher.
 
 We often hear complaints that `position` values are repeated, incorrect etc. For example, #254. To ensure data integrity, you should rely on your database. There are two things you can do:
 
-1. Use constraints.  If you model `Item` that `belongs_to` an `Order`, and it has a `position` column, then add a unique constraint on `items` with `[:order_id, :position]`.  Think of it as a list invariant. What are the properties of your list that don't change no matter how many items you have in it?  One such propery is that each item has a distinct position. Another _could be_ that position is always greater than 0. It is strongly recommended that you rely on your database to enforce these invariants or constraints. Here are the docs for [PostgreSQL](https://www.postgresql.org/docs/9.5/static/ddl-constraints.html) and [MySQL](https://dev.mysql.com/doc/refman/8.0/en/alter-table.html).
+1. Use constraints.  If you model `Item` that `belongs_to` an `Order`, and it has a `position` column, then add a unique constraint on `items` with `[:order_id, :position]`.  Think of it as a list invariant. What are the properties of your list that don't change no matter how many items you have in it?  One such property is that each item has a distinct position. Another _could be_ that position is always greater than 0. It is strongly recommended that you rely on your database to enforce these invariants or constraints. Here are the docs for [PostgreSQL](https://www.postgresql.org/docs/9.5/static/ddl-constraints.html) and [MySQL](https://dev.mysql.com/doc/refman/8.0/en/alter-table.html).
 2. Use mutexes or row level locks. At its heart the duplicate problem is that of handling concurrency. Adding a contention resolution mechanism like locks will solve it to some extent.  But it is not a solution or replacement for constraints.  Locks are also prone to deadlocks.
 
 As a library, `acts_as_list` may not always have all the context needed to apply these tools. They are much better suited at the application level.

data/Rakefile

@@ -32,11 +32,3 @@ rescue LoadError
 rescue StandardError
   puts "RDocTask is not supported on this platform."
 end
-
-# See https://github.com/skywinder/github-changelog-generator#rake-task for details
-# and github_changelog_generator --help for available options
-require 'github_changelog_generator/task'
-GitHubChangelogGenerator::RakeTask.new :changelog do |config|
-  config.project = 'acts_as_list'
-  config.user = 'brendon'
-end

data/acts_as_list.gemspec

@@ -9,16 +9,17 @@ Gem::Specification.new do |s|
   s.platform              = Gem::Platform::RUBY
   s.authors               = ["Swanand Pagnis", "Brendon Muir"]
   s.email                 = %w(swanand.pagnis@gmail.com brendon@spikeatschool.co.nz)
-  s.homepage              = "http://github.com/brendon/acts_as_list"
+  s.homepage              = "https://github.com/brendon/acts_as_list"
   s.summary               = "A gem adding sorting, reordering capabilities to an active_record model, allowing it to act as a list"
   s.description           = 'This "acts_as" extension provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a "position" column defined as an integer on the mapped database table.'
   s.license               = "MIT"
-  s.required_ruby_version = ">= 2.4.7"
+  s.required_ruby_version = ">= 2.5"
 
   if s.respond_to?(:metadata)
     s.metadata['changelog_uri']   = 'https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md'
     s.metadata['source_code_uri'] = 'https://github.com/brendon/acts_as_list'
     s.metadata['bug_tracker_uri'] = 'https://github.com/brendon/acts_as_list/issues'
+    s.metadata['rubygems_mfa_required'] = 'true'
   end
 
   # Load Paths...
@@ -27,8 +28,13 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map {|f| File.basename(f)}
   s.require_paths = ["lib"]
 
-
   # Dependencies (installed via "bundle install")
-  s.add_dependency "activerecord", ">= 4.2"
-  s.add_development_dependency "bundler", ">= 1.0.0"
+  s.add_dependency "activerecord", ">= 6.1"
+  s.add_dependency "activesupport", ">= 6.1"
+  s.add_development_dependency "minitest-hooks", "~> 1.5.1"
+  s.add_development_dependency "mocha", "~> 2.1.0"
+  s.add_development_dependency "timecop", "~> 0.9.8"
+  s.add_development_dependency "mysql2", "~> 0.5.6"
+  s.add_development_dependency "pg", "~> 1.5.5"
+  s.add_development_dependency "sqlite3", "~> 1.7.2"
 end

data/lib/acts_as_list/active_record/acts/list.rb

@@ -171,7 +171,7 @@ module ActiveRecord
           limit ||= acts_as_list_list.count
           acts_as_list_list.
             where("#{quoted_position_column_with_table_name} <= ?", current_position).
-            where("#{quoted_table_name}.#{self.class.primary_key} != ?", self.send(self.class.primary_key)).
+            where.not(primary_key_condition).
             reorder(acts_as_list_order_argument(:desc)).
             limit(limit)
         end
@@ -188,7 +188,7 @@ module ActiveRecord
           limit ||= acts_as_list_list.count
           acts_as_list_list.
             where("#{quoted_position_column_with_table_name} >= ?", current_position).
-            where("#{quoted_table_name}.#{self.class.primary_key} != ?", self.send(self.class.primary_key)).
+            where.not(primary_key_condition).
             reorder(acts_as_list_order_argument(:asc)).
             limit(limit)
         end
@@ -273,7 +273,7 @@ module ActiveRecord
           scope = acts_as_list_list
 
           if except
-            scope = scope.where("#{quoted_table_name}.#{self.class.primary_key} != ?", except.id)
+            scope = scope.where.not(primary_key_condition(except.id))
           end
 
           scope.in_list.reorder(acts_as_list_order_argument(:desc)).first
@@ -300,7 +300,7 @@ module ActiveRecord
           scope = acts_as_list_list
 
           if avoid_id
-            scope = scope.where("#{quoted_table_name}.#{self.class.primary_key} != ?", avoid_id)
+            scope = scope.where.not(primary_key_condition(avoid_id))
           end
 
           if sequential_updates?
@@ -341,7 +341,7 @@ module ActiveRecord
           scope = acts_as_list_list
 
           if avoid_id
-            scope = scope.where("#{quoted_table_name}.#{self.class.primary_key} != ?", avoid_id)
+            scope = scope.where.not(primary_key_condition(avoid_id))
           end
 
           if old_position < new_position
@@ -480,6 +480,11 @@ module ActiveRecord
           version = Gem.loaded_specs['activerecord'].version
           requirement.satisfied_by?(version)
         end
+
+        def primary_key_condition(id = nil)
+          primary_keys = Array.wrap(self.class.primary_key)
+          id ? primary_keys.zip(Array.wrap(id)).to_h : slice(*primary_keys)
+        end
       end
 
     end

data/lib/acts_as_list/active_record/acts/position_column_method_definer.rb

@@ -72,17 +72,18 @@ module ActiveRecord::Acts::List::PositionColumnMethodDefiner #:nodoc:
         cached_quoted_now = quoted_current_time_from_proper_timezone
 
         timestamp_attributes_for_update_in_model.map do |attr|
-          ", #{connection.quote_column_name(attr)} = #{cached_quoted_now}"
+          ", #{self.class.connection.quote_column_name(attr)} = #{cached_quoted_now}"
         end.join
       end
 
       private
 
-      delegate :connection, to: self
-
       def quoted_current_time_from_proper_timezone
-        connection.quote(connection.quoted_date(
-          current_time_from_proper_timezone))
+        self.class.connection.quote(
+          self.class.connection.quoted_date(
+            current_time_from_proper_timezone
+          )
+        )
       end
     end
   end

data/lib/acts_as_list/active_record/acts/scope_method_definer.rb

@@ -2,7 +2,6 @@
 require "active_support/inflector"
 
 module ActiveRecord::Acts::List::ScopeMethodDefiner #:nodoc:
-  extend ActiveSupport::Inflector
 
   def self.call(caller_class, scope)
     scope = idify(caller_class, scope) if scope.is_a?(Symbol)
@@ -71,7 +70,7 @@ module ActiveRecord::Acts::List::ScopeMethodDefiner #:nodoc:
     if caller_class.reflections.key?(name.to_s)
       caller_class.reflections[name.to_s].foreign_key.to_sym
     else
-      foreign_key(name).to_sym
+      ActiveSupport::Inflector.foreign_key(name).to_sym
     end
   end
 end

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '1.1.0'
+      VERSION = '1.2.1'
     end
   end
 end

data/test/helper.rb

@@ -16,6 +16,8 @@ require "minitest/autorun"
 require "mocha/minitest"
 require "#{File.dirname(__FILE__)}/../init"
 
+ENV["DB"] = "mysql" unless ENV["DB"]
+
 if defined?(ActiveRecord::VERSION) &&
   ActiveRecord::VERSION::MAJOR == 4 && ActiveRecord::VERSION::MINOR >= 2
 
@@ -23,8 +25,10 @@ if defined?(ActiveRecord::VERSION) &&
   ActiveRecord::Base.raise_in_transactional_callbacks = true
 end
 
-db_config = YAML.load_file(File.expand_path("../database.yml", __FILE__)).fetch(ENV["DB"] || "sqlite")
-ActiveRecord::Base.establish_connection(db_config)
+database_configuration = ENV["CI"] ? "test/support/ci_database.yml" : "test/support/database.yml"
+
+ActiveRecord::Base.configurations = YAML.safe_load(IO.read(database_configuration))
+ActiveRecord::Base.establish_connection(ENV["DB"].to_sym)
 ActiveRecord::Schema.verbose = false
 
 def teardown_db
@@ -53,8 +57,8 @@ def assert_equal_or_nil(a, b)
 end
 
 def assert_no_deprecation_warning_raised_by(failure_message = 'ActiveRecord deprecation warning raised when we didn\'t expect it', pass_message = 'No ActiveRecord deprecation raised')
-  original_behavior = ActiveSupport::Deprecation.behavior
-  ActiveSupport::Deprecation.behavior = :raise
+  original_behavior = active_record_deprecator.behavior
+  active_record_deprecator.behavior = :raise
   begin
     yield
   rescue ActiveSupport::DeprecationException => e
@@ -65,5 +69,13 @@ def assert_no_deprecation_warning_raised_by(failure_message = 'ActiveRecord depr
     pass pass_message
   end
 ensure
-  ActiveSupport::Deprecation.behavior = original_behavior
+  active_record_deprecator.behavior = original_behavior
+end
+
+def active_record_deprecator
+  if ActiveRecord::VERSION::MAJOR == 7 && ActiveRecord::VERSION::MINOR >= 1 || ActiveRecord::VERSION::MAJOR > 7
+    ActiveRecord.deprecator
+  else
+    ActiveSupport::Deprecation
+  end
 end