acts_as_list 1.0.0 → 1.0.1

data/README.md

@@ -12,8 +12,8 @@ This `acts_as` extension provides the capabilities for sorting and reordering a
 
 There are a couple of changes of behaviour from `0.8.0` onwards:
 
-- If you specify `add_new_at: :top`, new items will be added to the top of the list like always. But now, if you specify a position at insert time: `.create(position: 3)`, the position will be respected. In this example, the item will end up at position `3` and will move other items further down the list. Before `0.8.0` the position would be ignored and the item would still be added to the top of the list. [#220](https://github.com/swanandp/acts_as_list/pull/220)
-- `acts_as_list` now copes with disparate position integers (i.e. gaps between the numbers). There has been a change in behaviour for the `higher_items` method. It now returns items with the first item in the collection being the closest item to the reference item, and the last item in the collection being the furthest from the reference item (a.k.a. the first item in the list). [#223](https://github.com/swanandp/acts_as_list/pull/223)
+- If you specify `add_new_at: :top`, new items will be added to the top of the list like always. But now, if you specify a position at insert time: `.create(position: 3)`, the position will be respected. In this example, the item will end up at position `3` and will move other items further down the list. Before `0.8.0` the position would be ignored and the item would still be added to the top of the list. [#220](https://github.com/brendon/acts_as_list/pull/220)
+- `acts_as_list` now copes with disparate position integers (i.e. gaps between the numbers). There has been a change in behaviour for the `higher_items` method. It now returns items with the first item in the collection being the closest item to the reference item, and the last item in the collection being the furthest from the reference item (a.k.a. the first item in the list). [#223](https://github.com/brendon/acts_as_list/pull/223)
 
 ## Installation
 
@@ -105,6 +105,25 @@ TodoList.all.each do |todo_list|
 end
 ```
 
+When using PostgreSQL, it is also possible to leave this migration up to the database layer. Inside of the `change` block you could write:
+
+```ruby
+ execute <<~SQL.squeeze
+   UPDATE todo_items
+   SET position = mapping.new_position
+   FROM (
+     SELECT
+       id,
+       ROW_NUMBER() OVER (
+         PARTITION BY todo_list_id
+         ORDER BY updated_at
+       ) as new_position
+     FROM todo_items
+   ) AS mapping
+   WHERE todo_items.id = mapping.id;
+ SQL
+```
+
 ## Notes
 All `position` queries (select, update, etc.) inside gem methods are executed without the default scope (i.e. `Model.unscoped`), this will prevent nasty issues when the default scope is different from `acts_as_list` scope.
 
@@ -144,6 +163,8 @@ default: `1`. Use this option to define the top of the list. Use 0 to make the c
 default: `:bottom`. Use this option to specify whether objects get added to the `:top` or `:bottom` of the list. `nil` will result in new items not being added to the list on create, i.e, position will be kept nil after create.
 - `touch_on_update`
 default: `true`. Use `touch_on_update: false` if you don't want to update the timestamps of the associated records.
+- `sequential_updates`
+Specifies whether insert_at should update objects positions during shuffling one by one to respect position column unique not null constraint. Defaults to true if position column has unique index, otherwise false. If constraint is `deferrable initially deferred` (PostgreSQL), overriding it with false will speed up insert_at.
 
 ## Disabling temporarily
 
@@ -251,7 +272,7 @@ end
 ```
 
 ## Versions
-Version `0.9.0` adds `acts_as_list_no_update` (https://github.com/swanandp/acts_as_list/pull/244) and compatibility with not-null and uniqueness constraints on the database (https://github.com/swanandp/acts_as_list/pull/246). These additions shouldn't break compatibility with existing implementations.
+Version `0.9.0` adds `acts_as_list_no_update` (https://github.com/brendon/acts_as_list/pull/244) and compatibility with not-null and uniqueness constraints on the database (https://github.com/brendon/acts_as_list/pull/246). These additions shouldn't break compatibility with existing implementations.
 
 As of version `0.7.5` Rails 5 is supported.
 

data/Rakefile

@@ -38,5 +38,5 @@ end
 require 'github_changelog_generator/task'
 GitHubChangelogGenerator::RakeTask.new :changelog do |config|
   config.project = 'acts_as_list'
-  config.user = 'swanandp'
+  config.user = 'brendon'
 end

data/acts_as_list.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.platform              = Gem::Platform::RUBY
   s.authors               = ["Swanand Pagnis", "Brendon Muir"]
   s.email                 = %w(swanand.pagnis@gmail.com brendon@spikeatschool.co.nz)
-  s.homepage              = "http://github.com/swanandp/acts_as_list"
+  s.homepage              = "http://github.com/brendon/acts_as_list"
   s.summary               = "A gem adding sorting, reordering capabilities to an active_record model, allowing it to act as a list"
   s.description           = 'This "acts_as" extension provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a "position" column defined as an integer on the mapped database table.'
   s.license               = "MIT"
@@ -17,9 +17,9 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 2.4.7"
 
   if s.respond_to?(:metadata)
-    s.metadata['changelog_uri']   = 'https://github.com/swanandp/acts_as_list/blob/master/CHANGELOG.md'
-    s.metadata['source_code_uri'] = 'https://github.com/swanandp/acts_as_list'
-    s.metadata['bug_tracker_uri'] = 'https://github.com/swanandp/acts_as_list/issues'
+    s.metadata['changelog_uri']   = 'https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md'
+    s.metadata['source_code_uri'] = 'https://github.com/brendon/acts_as_list'
+    s.metadata['bug_tracker_uri'] = 'https://github.com/brendon/acts_as_list/issues'
   end
 
   # Load Paths...

data/lib/acts_as_list/active_record/acts/list.rb

@@ -312,7 +312,11 @@ module ActiveRecord
             scope = scope.where("#{quoted_table_name}.#{self.class.primary_key} != ?", avoid_id)
           end
 
-          scope.where("#{quoted_position_column_with_table_name} >= ?", position).increment_all
+          if sequential_updates?
+            scope.where("#{quoted_position_column_with_table_name} >= ?", position).reorder(acts_as_list_order_argument(:desc)).increment_sequentially
+          else
+            scope.where("#{quoted_position_column_with_table_name} >= ?", position).increment_all
+          end
         end
 
         # This has the effect of moving all the higher items up one.

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '1.0.0'
+      VERSION = '1.0.1'
     end
   end
 end

data/test/test_list.rb

@@ -995,6 +995,11 @@ class SequentialUpdatesMixinNotNullUniquePositiveConstraintsTest < ActsAsListTes
       assert_equal 3, new.pos
     end
 
+    def test_create_at_top
+      new = SequentialUpdatesAltId.create!(pos: 1)
+      assert_equal 1, new.pos
+    end
+
     def test_move_to_bottom
       item = SequentialUpdatesAltId.order(:pos).first
       item.move_to_bottom

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Swanand Pagnis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-26 00:00:00.000000000 Z
+date: 2020-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -50,6 +50,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gemtest"
+- ".github/FUNDING.yml"
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
@@ -93,13 +94,13 @@ files:
 - test/test_no_update_for_extra_classes.rb
 - test/test_no_update_for_scope_destruction.rb
 - test/test_no_update_for_subclasses.rb
-homepage: http://github.com/swanandp/acts_as_list
+homepage: http://github.com/brendon/acts_as_list
 licenses:
 - MIT
 metadata:
-  changelog_uri: https://github.com/swanandp/acts_as_list/blob/master/CHANGELOG.md
-  source_code_uri: https://github.com/swanandp/acts_as_list
-  bug_tracker_uri: https://github.com/swanandp/acts_as_list/issues
+  changelog_uri: https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/brendon/acts_as_list
+  bug_tracker_uri: https://github.com/brendon/acts_as_list/issues
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -115,8 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: acts_as_list
-rubygems_version: 2.7.6.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A gem adding sorting, reordering capabilities to an active_record model,