acts_as_list 0.9.18 → 1.0.3

data/test/test_no_update_for_scope_destruction.rb

@@ -53,13 +53,8 @@ class NoUpdateForScopeDestructionTestCase < Minitest::Test
     end
 
     def test_no_update_children_when_parent_destroyed
-      if ActiveRecord::VERSION::MAJOR < 4
-        DestructionTodoItem.any_instance.expects(:decrement_positions_on_lower_items).once
-        DestructionTadaItem.any_instance.expects(:decrement_positions_on_lower_items).once
-      else
-        DestructionTodoItem.any_instance.expects(:decrement_positions_on_lower_items).never
-        DestructionTadaItem.any_instance.expects(:decrement_positions_on_lower_items).never
-      end
+      DestructionTodoItem.any_instance.expects(:decrement_positions_on_lower_items).never
+      DestructionTadaItem.any_instance.expects(:decrement_positions_on_lower_items).never
       assert @list.destroy
     end
 

data/test/test_no_update_for_subclasses.rb

@@ -35,20 +35,20 @@ class NoUpdateForSubclassesTest < NoUpdateForSubclassesTestCase
   end
 
   def test_update
-    @item_1.update_attributes(position: 2)
+    @item_1.update position: 2
     assert_equal 2, @item_1.reload.position
     assert_equal 1, @item_2.reload.position
   end
 
   def test_no_update_for_subclass_instances_with_no_update_on_superclass
-    MasterItem.acts_as_list_no_update { @item_1.update_attributes(position: 2) }
+    MasterItem.acts_as_list_no_update { @item_1.update position: 2 }
 
     assert_equal 2, @item_1.reload.position
     assert_equal 2, @item_2.reload.position
   end
 
   def test_no_update_for_subclass_instances_with_no_update_on_subclass
-    SlaveItem.acts_as_list_no_update { @item_1.update_attributes(position: 2) }
+    SlaveItem.acts_as_list_no_update { @item_1.update position: 2 }
 
     assert_equal 2, @item_1.reload.position
     assert_equal 2, @item_2.reload.position

data/test/test_scope_with_user_defined_foreign_key.rb

@@ -0,0 +1,42 @@
+require 'helper'
+
+class Checklist < ActiveRecord::Base
+  has_many :checklist_items, foreign_key: 'list_id', inverse_of: :checklist
+end
+
+class ChecklistItem < ActiveRecord::Base
+  belongs_to :checklist, foreign_key: 'list_id', inverse_of: :checklist_items
+  acts_as_list scope: :checklist
+end
+
+class ScopeWithUserDefinedForeignKeyTest < Minitest::Test
+  def setup
+    ActiveRecord::Base.connection.create_table :checklists do |t|
+    end
+
+    ActiveRecord::Base.connection.create_table :checklist_items do |t|
+      t.column :list_id, :integer
+      t.column :position, :integer
+    end
+
+    ActiveRecord::Base.connection.schema_cache.clear!
+    [Checklist, ChecklistItem].each(&:reset_column_information)
+    super
+  end
+
+  def teardown
+    teardown_db
+    super
+  end
+
+  def test_scope_with_user_defined_foreign_key
+    checklist = Checklist.create
+    checklist_item_1 = checklist.checklist_items.create
+    checklist_item_2 = checklist.checklist_items.create
+    checklist_item_3 = checklist.checklist_items.create
+
+    assert_equal 1, checklist_item_1.position
+    assert_equal 2, checklist_item_2.position
+    assert_equal 3, checklist_item_3.position
+  end
+end

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.9.18
+  version: 1.0.3
 platform: ruby
 authors:
-- David Heinemeier Hansson
 - Swanand Pagnis
-- Quinn Chaffee
+- Brendon Muir
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-07 00:00:00.000000000 Z
+date: 2020-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -45,11 +44,13 @@ description: This "acts_as" extension provides the capabilities for sorting and
   "position" column defined as an integer on the mapped database table.
 email:
 - swanand.pagnis@gmail.com
+- brendon@spikeatschool.co.nz
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gemtest"
+- ".github/FUNDING.yml"
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
@@ -59,12 +60,12 @@ files:
 - README.md
 - Rakefile
 - acts_as_list.gemspec
-- gemfiles/rails_3_2.gemfile
-- gemfiles/rails_4_1.gemfile
 - gemfiles/rails_4_2.gemfile
 - gemfiles/rails_5_0.gemfile
 - gemfiles/rails_5_1.gemfile
 - gemfiles/rails_5_2.gemfile
+- gemfiles/rails_6_0.gemfile
+- gemfiles/rails_6_1.gemfile
 - init.rb
 - lib/acts_as_list.rb
 - lib/acts_as_list/active_record/acts/active_record.rb
@@ -94,13 +95,14 @@ files:
 - test/test_no_update_for_extra_classes.rb
 - test/test_no_update_for_scope_destruction.rb
 - test/test_no_update_for_subclasses.rb
-homepage: http://github.com/swanandp/acts_as_list
+- test/test_scope_with_user_defined_foreign_key.rb
+homepage: http://github.com/brendon/acts_as_list
 licenses:
 - MIT
 metadata:
-  changelog_uri: https://github.com/swanandp/acts_as_list/blob/master/CHANGELOG.md
-  source_code_uri: https://github.com/swanandp/acts_as_list
-  bug_tracker_uri: https://github.com/swanandp/acts_as_list/issues
+  changelog_uri: https://github.com/brendon/acts_as_list/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/brendon/acts_as_list
+  bug_tracker_uri: https://github.com/brendon/acts_as_list/issues
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -109,15 +111,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 2.4.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: acts_as_list
-rubygems_version: 2.5.2.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A gem adding sorting, reordering capabilities to an active_record model,
@@ -139,3 +140,4 @@ test_files:
 - test/test_no_update_for_extra_classes.rb
 - test/test_no_update_for_scope_destruction.rb
 - test/test_no_update_for_subclasses.rb
+- test/test_scope_with_user_defined_foreign_key.rb

data/gemfiles/rails_3_2.gemfile

@@ -1,34 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rack", "~> 1", platforms: [:ruby_19, :ruby_20, :ruby_21]
-gem "rake", "~> 12.2.0", platforms: [:ruby_19]
-gem "appraisal"
-gem "activerecord", "~> 3.2.22.2"
-
-group :development do
-  gem "github_changelog_generator", "1.9.0"
-end
-
-group :test do
-  gem "minitest", "~> 5.0"
-  gem "test_after_commit", "~> 0.4.2"
-  gem "timecop"
-  gem "mocha"
-  gem "after_commit_exception_notification"
-end
-
-group :sqlite do
-  gem "sqlite3", "~> 1.3.13", platforms: [:ruby]
-end
-
-group :postgresql do
-  gem "pg", "~> 0.18.0", platforms: [:ruby]
-end
-
-group :mysql do
-  gem "mysql2", "~> 0.3.21", platforms: [:ruby]
-end
-
-gemspec path: "../"

data/gemfiles/rails_4_1.gemfile

@@ -1,34 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rack", "~> 1", platforms: [:ruby_19, :ruby_20, :ruby_21]
-gem "rake", "~> 12.2.0", platforms: [:ruby_19]
-gem "appraisal"
-gem "activerecord", "~> 4.1.16"
-
-group :development do
-  gem "github_changelog_generator", "1.9.0"
-end
-
-group :test do
-  gem "minitest", "~> 5.0"
-  gem "test_after_commit", "~> 0.4.2"
-  gem "timecop"
-  gem "mocha"
-  gem "after_commit_exception_notification"
-end
-
-group :sqlite do
-  gem "sqlite3", "~> 1.3.13", platforms: [:ruby]
-end
-
-group :postgresql do
-  gem "pg", "~> 0.18.0", platforms: [:ruby]
-end
-
-group :mysql do
-  gem "mysql2", "~> 0.3.21", platforms: [:ruby]
-end
-
-gemspec path: "../"