acts_as_list 0.9.16 → 0.9.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 370205f3c55e44c0633e2aabc665fa4489bf4e4c
-  data.tar.gz: 2ce434302042df344231d3b8cb4fc053ba2c39af
+  metadata.gz: fab8be3ea9754103e60311aaa592f0ab4b7c84e3
+  data.tar.gz: 166a2aff0b3f6cbb6cfc67709de71fda2f4b3960
 SHA512:
-  metadata.gz: 4bc4009e669c92bc3822baa35d9560c54d66cd32ef950fad5f2c0f1ff1f6f04cc5d3f747265fc1a7462bf0118ba917aff33256dde5037cfa2398dbe34f6e140b
-  data.tar.gz: 6ee14901baf239084f2c31fa89e63d50b92e6de9113f91cecb3db18f0dae751cbfd50eb5578bd6d4960c6427dc5cfef0f6ab73e167b1d45e1dbe6f4286c0a806
+  metadata.gz: 5afeff2ad86a92fb1261062596b2646508dee23473242686bf20ccf809623834705e467c3ad701963eba9a46c839f29fc2f3aba4adbce62dbe49d91e810f628d
+  data.tar.gz: 037aa8e4d42c306040f7e2da8c9f9615e1c1a1c123df08edb7d1cb511fadb63a388f65567a45e20ea58a3444905f024f38da10fa54b0e55cdd3c610587539af4

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Change Log
 
+## [v0.9.16](https://github.com/swanandp/acts_as_list/tree/v0.9.16) (2018-08-30)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.15...v0.9.16)
+
+**Closed issues:**
+
+- Re-ordering at specific position [\#318](https://github.com/swanandp/acts_as_list/issues/318)
+- `no\_update` is not applied to subclasses [\#314](https://github.com/swanandp/acts_as_list/issues/314)
+- NoMethodError: undefined method `acts\_as\_list' [\#303](https://github.com/swanandp/acts_as_list/issues/303)
+- Cannot create item at position 0 [\#297](https://github.com/swanandp/acts_as_list/issues/297)
+
+**Merged pull requests:**
+
+- Unscope `select` to avoid PG::UndefinedFunction [\#283](https://github.com/swanandp/acts_as_list/pull/283) ([donv](https://github.com/donv))
+
 ## [v0.9.15](https://github.com/swanandp/acts_as_list/tree/v0.9.15) (2018-06-11)
 [Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.14...v0.9.15)
 

data/lib/acts_as_list/active_record/acts/list.rb

@@ -105,20 +105,14 @@ module ActiveRecord
         # position adjusted accordingly.
         def move_to_bottom
           return unless in_list?
-          acts_as_list_class.transaction do
-            decrement_positions_on_lower_items
-            assume_bottom_position
-          end
+          insert_at_position bottom_position_in_list.to_i
         end
 
         # Move to the top of the list. If the item is already in the list, the items above it have their
         # position adjusted accordingly.
         def move_to_top
           return unless in_list?
-          acts_as_list_class.transaction do
-            increment_positions_on_higher_items
-            assume_top_position
-          end
+          insert_at_position acts_as_list_top
         end
 
         # Removes the item from the list.
@@ -399,6 +393,7 @@ module ActiveRecord
         end
 
         def insert_at_position(position, raise_exception_if_save_fails=false)
+          raise ArgumentError.new("position cannot be lower than top") if position < acts_as_list_top
           return set_list_position(position, raise_exception_if_save_fails) if new_record?
           with_lock do
             if in_list?

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '0.9.16'
+      VERSION = '0.9.17'
     end
   end
 end

data/test/test_list.rb

@@ -897,6 +897,20 @@ class SequentialUpdatesMixinNotNullUniquePositiveConstraintsTest < ActsAsListTes
     assert_equal 3, new.pos
   end
 
+  def test_move_to_bottom
+    item = SequentialUpdatesDefault.order(:pos).first
+    item.move_to_bottom
+    assert_equal 4, item.pos
+  end
+
+  def test_move_to_top
+    new_item = SequentialUpdatesDefault.create!
+    assert_equal 5, new_item.pos
+
+    new_item.move_to_top
+    assert_equal 1, new_item.pos
+  end
+
   def test_destroy
     new_item = SequentialUpdatesDefault.create
     assert_equal 5, new_item.pos
@@ -908,4 +922,12 @@ class SequentialUpdatesMixinNotNullUniquePositiveConstraintsTest < ActsAsListTes
     assert_equal [1,2,3,4], SequentialUpdatesDefault.all.map(&:pos).sort
 
   end
+
+  def test_exception_on_wrong_position
+    new_item = SequentialUpdatesDefault.create
+
+    assert_raises ArgumentError do
+      new_item.insert_at(0)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.9.16
+  version: 0.9.17
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-30 00:00:00.000000000 Z
+date: 2018-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord