acts_as_list 0.7.5 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c73ad553a7510872487e1d9bf560277e02ba3159
-  data.tar.gz: cc8e55f14d3c25aa21b1e2c239077e48a789c338
+  metadata.gz: ac758ea2c45c36f2da4a70277a4e359e32cbebec
+  data.tar.gz: 44cb219c5932187141cb11cb774e2165b9be86f0
 SHA512:
-  metadata.gz: 4ff90570f627ca4911a842a95e06c0570db69ed3ea2d908eaef1339dea143dbafb17e70d53009dddcb3fcf1ab2a12afe2fe5ceea0c71cd62ca3b1b337b18f947
-  data.tar.gz: e2c8a70ecaaea9b85437feb857a82cb5073eace0a50474fc914461bd19fd7113f27c866591dc291cbabf17342d2c2a98c75d8fd4eaf3d247a98c8eb6a19db968
+  metadata.gz: 32474515db63aa64fea168c43654ebc2d86e24ad5bba2e1e793b0a484ff6d0e40d880c62d559fdf5d830b4213f9ca4a56f5ab776e102daf28e86a1ee1e772dbb
+  data.tar.gz: ab9e2ae5dbe3313a1b69f8cb82019494a10bce07c0343acc88062cd8475774dc2202fa8104cbb156797aae53b87631cabe8766cdf0f627eac7296934ae5dd50b

data/CHANGELOG.md

@@ -1,12 +1,53 @@
 # Change Log
 
-## [Unreleased](https://github.com/swanandp/acts_as_list/tree/HEAD)
+## [v0.7.5](https://github.com/swanandp/acts_as_list/tree/v0.7.5) (2016-06-30)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.4...v0.7.5)
 
-[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.4...HEAD)
+**Implemented enhancements:**
+
+- Touch when reordering [\#173](https://github.com/swanandp/acts_as_list/pull/173) ([botandrose](https://github.com/botandrose))
 
 **Closed issues:**
 
+- Exception raised when calling destroy "NameError - instance variable @scope\_changed not defined:" [\#206](https://github.com/swanandp/acts_as_list/issues/206)
 - Undefined instance variable @scope\_changed since 0.7.3 [\#199](https://github.com/swanandp/acts_as_list/issues/199)
+- Reordering large lists is slow [\#198](https://github.com/swanandp/acts_as_list/issues/198)
+- Reparenting child leaves gap in source list in rails 5 [\#194](https://github.com/swanandp/acts_as_list/issues/194)
+- Support rails 5 ? [\#186](https://github.com/swanandp/acts_as_list/issues/186)
+- I get a NoMethodError: undefined method `acts\_as\_list' when trying to include acts\_as\_list [\#176](https://github.com/swanandp/acts_as_list/issues/176)
+- Phenomenon of mysterious value of the position is skipped by one [\#166](https://github.com/swanandp/acts_as_list/issues/166)
+- Model.find being called twice with acts\_as\_list on destroy [\#161](https://github.com/swanandp/acts_as_list/issues/161)
+- `scope\_changed?` problem with acts\_as\_paranoid [\#158](https://github.com/swanandp/acts_as_list/issues/158)
+- Inconsistent behaviour between Symbol and Array scopes [\#155](https://github.com/swanandp/acts_as_list/issues/155)
+- insert\_at doesn't seem to be working in ActiveRecord callback \(Rails 4.2\) [\#150](https://github.com/swanandp/acts_as_list/issues/150)
+- Project Documentation link redirects to expired domain [\#149](https://github.com/swanandp/acts_as_list/issues/149)
+- Problem when updating an position of array of AR objects. [\#137](https://github.com/swanandp/acts_as_list/issues/137)
+- Unexpected behaviour when inserting consecutive items with default positions [\#124](https://github.com/swanandp/acts_as_list/issues/124)
+- self.reload prone to error [\#122](https://github.com/swanandp/acts_as_list/issues/122)
+- Rails 3.0.x in\_list causes the return of default\_scope [\#120](https://github.com/swanandp/acts_as_list/issues/120)
+- Relationships with dependency:destroy cause ActiveRecord::RecordNotFound [\#118](https://github.com/swanandp/acts_as_list/issues/118)
+- Using insert\_at with values with type String [\#117](https://github.com/swanandp/acts_as_list/issues/117)
+- Batch setting of position [\#112](https://github.com/swanandp/acts_as_list/issues/112)
+- position: 0 now makes model pushed to top? [\#110](https://github.com/swanandp/acts_as_list/issues/110)
+- Create element in default position [\#103](https://github.com/swanandp/acts_as_list/issues/103)
+- Enhancement: Expose scope object [\#97](https://github.com/swanandp/acts_as_list/issues/97)
+- Shuffle list [\#96](https://github.com/swanandp/acts_as_list/issues/96)
+- Creating an item with a nil scope should not add it to the list [\#92](https://github.com/swanandp/acts_as_list/issues/92)
+- Performance Improvements  [\#88](https://github.com/swanandp/acts_as_list/issues/88)
+- has\_many :through or has\_many\_and\_belongs\_to\_many support [\#86](https://github.com/swanandp/acts_as_list/issues/86)
+- ActiveRecord dependency causes rake assets:compile to fail without access to a database [\#84](https://github.com/swanandp/acts_as_list/issues/84)
+- move\_higher/move\_lower vs move\_to\_top/move\_to\_bottom act differently when item is already at top or bottom [\#77](https://github.com/swanandp/acts_as_list/issues/77)
+- Limiting the list size [\#61](https://github.com/swanandp/acts_as_list/issues/61)
+- Adding multiple creates strange ordering [\#55](https://github.com/swanandp/acts_as_list/issues/55)
+- Feature: sort [\#26](https://github.com/swanandp/acts_as_list/issues/26)
+
+**Merged pull requests:**
+
+- Removed duplicated assignment [\#207](https://github.com/swanandp/acts_as_list/pull/207) ([shunwen](https://github.com/shunwen))
+- Quote all identifiers [\#205](https://github.com/swanandp/acts_as_list/pull/205) ([fabn](https://github.com/fabn))
+- Start testing Rails 5 [\#203](https://github.com/swanandp/acts_as_list/pull/203) ([brendon](https://github.com/brendon))
+- Lock! the record before destroying [\#201](https://github.com/swanandp/acts_as_list/pull/201) ([brendon](https://github.com/brendon))
+- Fix ambiguous column error when joining some relations [\#180](https://github.com/swanandp/acts_as_list/pull/180) ([natw](https://github.com/natw))
 
 ## [v0.7.4](https://github.com/swanandp/acts_as_list/tree/v0.7.4) (2016-04-15)
 [Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.3...v0.7.4)

data/README.md

@@ -95,6 +95,8 @@ default: '1'. Use this option to define the top of the list. Use 0 to make the c
 default: ':bottom'. Use this option to specify whether objects get added to the :top or :bottom of the list. `nil` will result in new items not being added to the list on create, i.e, position will be kept nil after create.
 
 ## Versions
+As of version `0.7.5` Rails 5 is supported.
+
 All versions `0.1.5` onwards require Rails 3.0.x and higher.
 
 ## Build Status
@@ -106,7 +108,6 @@ All versions `0.1.5` onwards require Rails 3.0.x and higher.
 ## Roadmap
 
 1. Sort based feature
-2. Rails 4 compatibility and bye bye Rails 2! Older versions would of course continue to work with Rails 2, but there won't be any support on those.
 
 ## Contributing to `acts_as_list`
  

data/lib/acts_as_list/active_record/acts/list.rb

@@ -77,6 +77,10 @@ module ActiveRecord
           quoted_position_column = connection.quote_column_name(configuration[:column])
 
           class_eval <<-EOV, __FILE__, __LINE__ + 1
+            def self.acts_as_list_top
+              #{configuration[:top_of_list]}.to_i
+            end
+
             def acts_as_list_top
               #{configuration[:top_of_list]}.to_i
             end
@@ -471,7 +475,7 @@ module ActiveRecord
               send('decrement_positions_on_lower_items') if lower_item
               cached_changes.each { |attribute, values| self[attribute] = values[1] }
 
-              send("add_to_list_#{add_new_at}")
+              send("add_to_list_#{add_new_at}") if add_new_at.present?
             end
           end
 

data/lib/acts_as_list/version.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '0.7.5'
+      VERSION = '0.7.6'
     end
   end
 end

data/test/shared_no_addition.rb

@@ -21,5 +21,16 @@ module Shared
       assert !new.in_list?
     end
 
+    def test_update_scope_does_not_add_to_list
+      new = NoAdditionMixin.create
+
+      new.update_attribute(:parent_id, 20)
+      new.reload
+      assert !new.in_list?
+
+      new.update_attribute(:parent_id, 5)
+      new.reload
+      assert !new.in_list?
+    end
   end
 end

data/test/test_list.rb

@@ -691,3 +691,19 @@ class TouchTest < ActsAsListTestCase
     end
   end
 end
+
+class ActsAsListTopTest < ActsAsListTestCase
+  def setup
+    setup_db
+  end
+
+  def test_acts_as_list_top
+    assert_equal 1, TheBaseSubclass.new.acts_as_list_top
+    assert_equal 0, ZeroBasedMixin.new.acts_as_list_top
+  end
+
+  def test_class_acts_as_list_top
+    assert_equal 1, TheBaseSubclass.acts_as_list_top
+    assert_equal 0, ZeroBasedMixin.acts_as_list_top
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.6
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-30 00:00:00.000000000 Z
+date: 2016-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord