acts_as_list 0.7.4 → 0.8.2

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ODI0OTU2NzgzMmY0MmI3YjMyMDk2ZDg5YWJjNjkxZDE4ZjViODliYQ==
-  data.tar.gz: !binary |-
-    OThlMWNiYjU3MGRmMGQzNjA5NzQ1MDk1MzdiYTg1MGFjODJlNDJmYQ==
+SHA1:
+  metadata.gz: 5b311fb3c5f9b0839f22ff361020142db9c63045
+  data.tar.gz: 7600388596e829712e8936f9a31b70008ee7d18b
 SHA512:
-  metadata.gz: !binary |-
-    ZDMzOWRkNzQ2ZjNmZGRlM2QxYzJkN2VjYzM2MGY1Yzk4MjE1MmZiOWQyZjY1
-    NmY4Y2FjY2U4YjczNjliZjFmYzYwYmMzYTNlNTA2MjU4NmVlODFmMzg1NGY0
-    OWNkN2Y4MGU2ZTM4YjM2YjY0MTZkNjcwMjk0NmQ1YzBkMmNjYjE=
-  data.tar.gz: !binary |-
-    Mzg4NGQwNmY2NjdjN2MxZWIzYWE4MWNiOTlkMTc5NGM5NTRiMzRmY2MwNDVh
-    ODI2YTVhZmUwMzE1OTAwNzA1OWZjMjc3ZGNhZmI1Y2ZmNmU4NmYzNGQ3ZTc1
-    OGUyZDE0NjZkZTVjNmQxZTJhOWUyNjdhOWIwMjJiMTg2YzA2NWI=
+  metadata.gz: dc169373691b7a79c44393a368f4f589b04462c341f8f423f7eeedf846f29346dd3c6821f618287244a24ceafe04ebe416b4c6b6704f0be8470e69a1cd098a76
+  data.tar.gz: 748929065353ef8d675953d0469a4bd26ec8aee6921edfe6710b97186b25f75abc4a57bd648a2b076923cf5283e6dafb225ba0e6596efd21b23734897adc2f66

data/.gitignore

@@ -9,3 +9,4 @@ pkg/*
 .ruby-version
 # Appraisal generated lockfiles
 *.gemfile.lock
+.DS_Store

data/.travis.yml

@@ -9,9 +9,24 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.2.2
   - jruby-19mode
   - rbx-2
 gemfile:
   - gemfiles/rails_3_2.gemfile
   - gemfiles/rails_4_1.gemfile
   - gemfiles/rails_4_2.gemfile
+  - gemfiles/rails_5_0.gemfile
+matrix:
+  exclude:
+    - rvm: 1.9.3
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: 2.0.0
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: 2.1.0
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: jruby-19mode
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: rbx-2
+      gemfile: gemfiles/rails_5_0.gemfile
+

data/Appraisals

@@ -1,11 +1,21 @@
 appraise "rails-3-2" do
-  gem "activerecord", "~> 3.2.21"
+  gem "activerecord", "~> 3.2.22.2"
+  group :test do
+    gem "after_commit_exception_notification"
+  end
 end
 
 appraise "rails-4-1" do
-  gem "activerecord", "~> 4.1.10"
+  gem "activerecord", "~> 4.1.16"
+  group :test do
+    gem "after_commit_exception_notification"
+  end
 end
 
 appraise "rails-4-2" do
-  gem "activerecord", "~> 4.2.1"
+  gem "activerecord", "~> 4.2.7"
+end
+
+appraise "rails-5-0" do
+  gem "activerecord", "~> 5.0.0"
 end

data/CHANGELOG.md

@@ -1,7 +1,122 @@
 # Change Log
 
+## [v0.8.1](https://github.com/swanandp/acts_as_list/tree/v0.8.1) (2016-09-06)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.8.0...v0.8.1)
+
+**Closed issues:**
+
+- Rubinius Intermittent testing error [\#218](https://github.com/swanandp/acts_as_list/issues/218)
+- ActiveRecord dependency causes rake assets:compile to fail without access to a database [\#84](https://github.com/swanandp/acts_as_list/issues/84)
+
+**Merged pull requests:**
+
+- Refactor class\_eval with string into class\_eval with block [\#215](https://github.com/swanandp/acts_as_list/pull/215) ([rdvdijk](https://github.com/rdvdijk))
+
+## [v0.8.0](https://github.com/swanandp/acts_as_list/tree/v0.8.0) (2016-08-23)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.7...v0.8.0)
+
+**Closed issues:**
+
+- Behavior with DB default seems unclear [\#219](https://github.com/swanandp/acts_as_list/issues/219)
+
+**Merged pull requests:**
+
+- No longer a need specify additional rbx gems [\#225](https://github.com/swanandp/acts_as_list/pull/225) ([brendon](https://github.com/brendon))
+- Fix position when no serial positions [\#223](https://github.com/swanandp/acts_as_list/pull/223) ([jpalumickas](https://github.com/jpalumickas))
+- Bug: Specifying a position with add\_new\_at: :top fails to insert at that position [\#220](https://github.com/swanandp/acts_as_list/pull/220) ([brendon](https://github.com/brendon))
+
+## [v0.7.7](https://github.com/swanandp/acts_as_list/tree/v0.7.7) (2016-08-18)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.6...v0.7.7)
+
+**Closed issues:**
+
+- Issue after upgrading to 0.7.5: No connection pool with id primary found. [\#214](https://github.com/swanandp/acts_as_list/issues/214)
+- Changing scope is inconsistent based on add\_new\_at [\#138](https://github.com/swanandp/acts_as_list/issues/138)
+- Duplicate positions and lost items [\#76](https://github.com/swanandp/acts_as_list/issues/76)
+
+**Merged pull requests:**
+
+- Add quoted table names to some columns [\#221](https://github.com/swanandp/acts_as_list/pull/221) ([jpalumickas](https://github.com/jpalumickas))
+- Appraisals cleanup [\#217](https://github.com/swanandp/acts_as_list/pull/217) ([brendon](https://github.com/brendon))
+- Fix insert\_at\_position in race condition [\#195](https://github.com/swanandp/acts_as_list/pull/195) ([danielross](https://github.com/danielross))
+
+## [v0.7.6](https://github.com/swanandp/acts_as_list/tree/v0.7.6) (2016-07-15)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.5...v0.7.6)
+
+**Closed issues:**
+
+- add\_new\_at nil with scope causes NoMethodError [\#211](https://github.com/swanandp/acts_as_list/issues/211)
+
+**Merged pull requests:**
+
+- Add class method acts\_as\_list\_top as reader for configured top\_of\_list [\#213](https://github.com/swanandp/acts_as_list/pull/213) ([krzysiek1507](https://github.com/krzysiek1507))
+- Bugfix/add new at nil on scope change [\#212](https://github.com/swanandp/acts_as_list/pull/212) ([greatghoul](https://github.com/greatghoul))
+
+## [v0.7.5](https://github.com/swanandp/acts_as_list/tree/v0.7.5) (2016-06-30)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.4...v0.7.5)
+
+**Implemented enhancements:**
+
+- Touch when reordering [\#173](https://github.com/swanandp/acts_as_list/pull/173) ([botandrose](https://github.com/botandrose))
+
+**Closed issues:**
+
+- Exception raised when calling destroy "NameError - instance variable @scope\_changed not defined:" [\#206](https://github.com/swanandp/acts_as_list/issues/206)
+- Undefined instance variable @scope\_changed since 0.7.3 [\#199](https://github.com/swanandp/acts_as_list/issues/199)
+- Reordering large lists is slow [\#198](https://github.com/swanandp/acts_as_list/issues/198)
+- Reparenting child leaves gap in source list in rails 5 [\#194](https://github.com/swanandp/acts_as_list/issues/194)
+- Support rails 5 ? [\#186](https://github.com/swanandp/acts_as_list/issues/186)
+- I get a NoMethodError: undefined method `acts\_as\_list' when trying to include acts\_as\_list [\#176](https://github.com/swanandp/acts_as_list/issues/176)
+- Phenomenon of mysterious value of the position is skipped by one [\#166](https://github.com/swanandp/acts_as_list/issues/166)
+- Model.find being called twice with acts\_as\_list on destroy [\#161](https://github.com/swanandp/acts_as_list/issues/161)
+- `scope\_changed?` problem with acts\_as\_paranoid [\#158](https://github.com/swanandp/acts_as_list/issues/158)
+- Inconsistent behaviour between Symbol and Array scopes [\#155](https://github.com/swanandp/acts_as_list/issues/155)
+- insert\_at doesn't seem to be working in ActiveRecord callback \(Rails 4.2\) [\#150](https://github.com/swanandp/acts_as_list/issues/150)
+- Project Documentation link redirects to expired domain [\#149](https://github.com/swanandp/acts_as_list/issues/149)
+- Problem when updating an position of array of AR objects. [\#137](https://github.com/swanandp/acts_as_list/issues/137)
+- Unexpected behaviour when inserting consecutive items with default positions [\#124](https://github.com/swanandp/acts_as_list/issues/124)
+- self.reload prone to error [\#122](https://github.com/swanandp/acts_as_list/issues/122)
+- Rails 3.0.x in\_list causes the return of default\_scope [\#120](https://github.com/swanandp/acts_as_list/issues/120)
+- Relationships with dependency:destroy cause ActiveRecord::RecordNotFound [\#118](https://github.com/swanandp/acts_as_list/issues/118)
+- Using insert\_at with values with type String [\#117](https://github.com/swanandp/acts_as_list/issues/117)
+- Batch setting of position [\#112](https://github.com/swanandp/acts_as_list/issues/112)
+- position: 0 now makes model pushed to top? [\#110](https://github.com/swanandp/acts_as_list/issues/110)
+- Create element in default position [\#103](https://github.com/swanandp/acts_as_list/issues/103)
+- Enhancement: Expose scope object [\#97](https://github.com/swanandp/acts_as_list/issues/97)
+- Shuffle list [\#96](https://github.com/swanandp/acts_as_list/issues/96)
+- Creating an item with a nil scope should not add it to the list [\#92](https://github.com/swanandp/acts_as_list/issues/92)
+- Performance Improvements  [\#88](https://github.com/swanandp/acts_as_list/issues/88)
+- has\_many :through or has\_many\_and\_belongs\_to\_many support [\#86](https://github.com/swanandp/acts_as_list/issues/86)
+- move\_higher/move\_lower vs move\_to\_top/move\_to\_bottom act differently when item is already at top or bottom [\#77](https://github.com/swanandp/acts_as_list/issues/77)
+- Limiting the list size [\#61](https://github.com/swanandp/acts_as_list/issues/61)
+- Adding multiple creates strange ordering [\#55](https://github.com/swanandp/acts_as_list/issues/55)
+- Feature: sort [\#26](https://github.com/swanandp/acts_as_list/issues/26)
+
+**Merged pull requests:**
+
+- Fix position when no serial positions [\#208](https://github.com/swanandp/acts_as_list/pull/208) ([PoslinskiNet](https://github.com/PoslinskiNet))
+- Removed duplicated assignment [\#207](https://github.com/swanandp/acts_as_list/pull/207) ([shunwen](https://github.com/shunwen))
+- Quote all identifiers [\#205](https://github.com/swanandp/acts_as_list/pull/205) ([fabn](https://github.com/fabn))
+- Start testing Rails 5 [\#203](https://github.com/swanandp/acts_as_list/pull/203) ([brendon](https://github.com/brendon))
+- Lock! the record before destroying [\#201](https://github.com/swanandp/acts_as_list/pull/201) ([brendon](https://github.com/brendon))
+- Fix ambiguous column error when joining some relations [\#180](https://github.com/swanandp/acts_as_list/pull/180) ([natw](https://github.com/natw))
+
+## [v0.7.4](https://github.com/swanandp/acts_as_list/tree/v0.7.4) (2016-04-15)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.3...v0.7.4)
+
+**Closed issues:**
+
+- Releasing a new gem version [\#196](https://github.com/swanandp/acts_as_list/issues/196)
+
+**Merged pull requests:**
+
+- Fix scope changed [\#200](https://github.com/swanandp/acts_as_list/pull/200) ([brendon](https://github.com/brendon))
+
 ## [v0.7.3](https://github.com/swanandp/acts_as_list/tree/v0.7.3) (2016-04-14)
-[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.7.1...v0.7.3)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.2...v0.7.3)
+
+## [v0.7.2](https://github.com/swanandp/acts_as_list/tree/v0.7.2) (2016-04-01)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.7.2...v0.7.2)
 
 **Closed issues:**
 
@@ -238,4 +353,4 @@
 
 
 
-\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

data/Gemfile

@@ -3,21 +3,15 @@ source "http://rubygems.org"
 gem "sqlite3", platforms: [:ruby]
 gem "activerecord-jdbcsqlite3-adapter", platforms: [:jruby]
 
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "rubinius-developer_tools"
-  gem "rubysl-test-unit"
-end
+gem "rack", "~> 1", platforms: [:ruby_19, :ruby_20, :ruby_21, :jruby]
 
-# Specify your gem"s dependencies in acts_as_list-rails3.gemspec
 gemspec
 
 gem "rake"
 gem "appraisal"
-# Used to automatically generate changelog file
 gem "github_changelog_generator", "1.9.0"
 
 group :test do
-	gem "minitest", "~> 5.0"
+  gem "minitest", "~> 5.0"
   gem "test_after_commit", "~> 0.4.2"
 end

data/README.md

@@ -4,6 +4,13 @@
 
 This `acts_as` extension provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a `position` column defined as an integer on the mapped database table.
 
+## 0.8.0 Upgrade Notes
+
+There are a couple of changes of behaviour from `0.8.0` onwards:
+
+- If you specify `add_new_at: :top`, new items will be added to the top of the list like always. But now, if you specify a position at insert time: `.create(position: 3)`, the position will be respected. In this example, the item will end up at position `3` and will move other items further down the list. Before `0.8.0` the position would be ignored and the item would still be added to the top of the list. [#220](https://github.com/swanandp/acts_as_list/pull/220)
+- `acts_as_list` now copes with disparate position integers (i.e. gaps between the numbers). There has been a change in behaviour for the `higher_items` method. It now returns items with the first item in the collection being the closest item to the reference item, and the last item in the collection being the furthest from the reference item (a.k.a. the first item in the list). [#223](https://github.com/swanandp/acts_as_list/pull/223)
+
 ## Installation
 
 In your Gemfile:
@@ -71,8 +78,6 @@ In `acts_as_list`, "higher" means further up the list (a lower `position`), and
 - `list_item.lower_items` will return all the items below `list_item` in the list (ordered by the position, ascending)
 
 ## Notes
-If the `position` column has a default value, then there is a slight change in behavior, i.e if you have 4 items in the list, and you insert 1, with a default position 0, it would be pushed to the bottom of the list. Please look at the tests for this and some recent pull requests for discussions related to this.
-
 All `position` queries (select, update, etc.) inside gem methods are executed without the default scope (i.e. `Model.unscoped`), this will prevent nasty issues when the default scope is different from `acts_as_list` scope.
 
 The `position` column is set after validations are called, so you should not put a `presence` validation on the `position` column.
@@ -88,13 +93,15 @@ end
 
 ## More Options
 - `column`
-default: 'position'. Use this option if the column name in your database is different from position.
+default: `position`. Use this option if the column name in your database is different from position.
 - `top_of_list`
-default: '1'. Use this option to define the top of the list. Use 0 to make the collection act more like an array in its indexing.
+default: `1`. Use this option to define the top of the list. Use 0 to make the collection act more like an array in its indexing.
 - `add_new_at`
-default: ':bottom'. Use this option to specify whether objects get added to the :top or :bottom of the list. `nil` will result in new items not being added to the list on create, i.e, position will be kept nil after create.
+default: `:bottom`. Use this option to specify whether objects get added to the `:top` or `:bottom` of the list. `nil` will result in new items not being added to the list on create, i.e, position will be kept nil after create.
 
 ## Versions
+As of version `0.7.5` Rails 5 is supported.
+
 All versions `0.1.5` onwards require Rails 3.0.x and higher.
 
 ## Build Status
@@ -106,7 +113,6 @@ All versions `0.1.5` onwards require Rails 3.0.x and higher.
 ## Roadmap
 
 1. Sort based feature
-2. Rails 4 compatibility and bye bye Rails 2! Older versions would of course continue to work with Rails 2, but there won't be any support on those.
 
 ## Contributing to `acts_as_list`
  

data/gemfiles/rails_3_2.gemfile

@@ -4,10 +4,11 @@ source "http://rubygems.org"
 
 gem "sqlite3", :platforms => [:ruby]
 gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
+gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
 gem "rake"
 gem "appraisal"
 gem "github_changelog_generator", "1.9.0"
-gem "activerecord", "~> 3.2.21"
+gem "activerecord", "~> 3.2.22.2"
 
 group :test do
   gem "minitest", "~> 5.0"
@@ -15,10 +16,4 @@ group :test do
   gem "after_commit_exception_notification"
 end
 
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "rubinius-developer_tools"
-  gem "rubysl-test-unit"
-end
-
 gemspec :path => "../"

data/gemfiles/rails_4_1.gemfile

@@ -4,10 +4,11 @@ source "http://rubygems.org"
 
 gem "sqlite3", :platforms => [:ruby]
 gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
+gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
 gem "rake"
 gem "appraisal"
 gem "github_changelog_generator", "1.9.0"
-gem "activerecord", "~> 4.1.10"
+gem "activerecord", "~> 4.1.16"
 
 group :test do
   gem "minitest", "~> 5.0"
@@ -15,10 +16,4 @@ group :test do
   gem "after_commit_exception_notification"
 end
 
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "rubinius-developer_tools"
-  gem "rubysl-test-unit"
-end
-
 gemspec :path => "../"

data/gemfiles/rails_4_2.gemfile

@@ -4,20 +4,15 @@ source "http://rubygems.org"
 
 gem "sqlite3", :platforms => [:ruby]
 gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
+gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
 gem "rake"
 gem "appraisal"
 gem "github_changelog_generator", "1.9.0"
-gem "activerecord", "~> 4.2.1"
+gem "activerecord", "~> 4.2.7"
 
 group :test do
   gem "minitest", "~> 5.0"
   gem "test_after_commit", "~> 0.4.2"
 end
 
-platforms :rbx do
-  gem "rubysl", "~> 2.0"
-  gem "rubinius-developer_tools"
-  gem "rubysl-test-unit"
-end
-
 gemspec :path => "../"

data/gemfiles/rails_5_0.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "sqlite3", :platforms => [:ruby]
+gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
+gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
+gem "rake"
+gem "appraisal"
+gem "github_changelog_generator", "1.9.0"
+gem "activerecord", "~> 5.0.0"
+
+group :test do
+  gem "minitest", "~> 5.0"
+  gem "test_after_commit", "~> 0.4.2"
+end
+
+gemspec :path => "../"