acts_as_list 0.7.2 → 0.7.7
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +5 -13
- data/.gitignore +2 -0
- data/.travis.yml +21 -0
- data/Appraisals +13 -3
- data/CHANGELOG.md +316 -0
- data/Gemfile +5 -2
- data/README.md +14 -4
- data/Rakefile +8 -0
- data/gemfiles/rails_3_2.gemfile +6 -2
- data/gemfiles/rails_4_1.gemfile +6 -2
- data/gemfiles/rails_4_2.gemfile +5 -2
- data/gemfiles/rails_5_0.gemfile +24 -0
- data/lib/acts_as_list/active_record/acts/list.rb +135 -117
- data/lib/acts_as_list/version.rb +1 -1
- data/test/helper.rb +7 -0
- data/test/shared.rb +1 -0
- data/test/shared_list.rb +13 -1
- data/test/shared_no_addition.rb +11 -0
- data/test/shared_quoting.rb +21 -0
- data/test/test_joined_list.rb +64 -0
- data/test/test_list.rb +183 -3
- metadata +17 -14
- data/gemfiles/rails_3_2.gemfile.lock +0 -258
- data/gemfiles/rails_4_1.gemfile.lock +0 -262
- data/gemfiles/rails_4_2.gemfile.lock +0 -53
checksums.yaml
CHANGED
|
@@ -1,15 +1,7 @@
|
|
|
1
1
|
---
|
|
2
|
-
|
|
3
|
-
metadata.gz:
|
|
4
|
-
|
|
5
|
-
data.tar.gz: !binary |-
|
|
6
|
-
ZTkxMmRiOWFhNmFjNDJmNWYxMDAyNGYyNzVmNmNmNGQwN2Y5ZTkxMw==
|
|
2
|
+
SHA1:
|
|
3
|
+
metadata.gz: d62dacdeb7972152a2ee04cee3cccb8ef26898d7
|
|
4
|
+
data.tar.gz: fe6b02bfa1c5ed33407d1852c7b988a1848c7cd4
|
|
7
5
|
SHA512:
|
|
8
|
-
metadata.gz:
|
|
9
|
-
|
|
10
|
-
ODc0YjM5NGIyZGU2YWI2ZjQzNGUzNTY2YmJiODY0ZDM5NDYwNWVmNTM5YzQy
|
|
11
|
-
YzUyYWQxNWUwYWIwMTYwYWJiZjc0OWJkNzYxZWI4YTM0NTEzNTY=
|
|
12
|
-
data.tar.gz: !binary |-
|
|
13
|
-
MzYyMjUyMjdlOGI5OTI5MDYwN2UyZDFjZGY2NzdlYjQyNDA3NzkzNjNiNDE2
|
|
14
|
-
ODk1MmJlZTM1Yzk5MmE3MzYzZDY2YjE3MjJlMDFmZTY1M2RkMGVmYmQxZWNh
|
|
15
|
-
Yzk2Y2UzOTI5MGQ5YjIzNDZjYzRkMWJlNGRiOTFlYjZhZDU4MDM=
|
|
6
|
+
metadata.gz: 6b376b14646463802f4aee7080663eefdb3d7b1a43088df7126f57c84ecfb0a8730470efe4b57758f2b2079d6bd52b19f2a80293b211095318425d5892194897
|
|
7
|
+
data.tar.gz: fa104b99749d08767074e96f5fea1e97590ee841673660c39d03bb3d2cd50a3d2db2de4d1d195d5503d1bfadec7cbe84e046714f0ab98d0d509bc4c4797949e2
|
data/.gitignore
CHANGED
data/.travis.yml
CHANGED
|
@@ -1,11 +1,32 @@
|
|
|
1
1
|
language: ruby
|
|
2
|
+
# Explicit usage of containerized builds, should provide faster feedback
|
|
3
|
+
# see https://docs.travis-ci.com/user/workers/container-based-infrastructure/
|
|
4
|
+
# and https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments
|
|
5
|
+
sudo: false
|
|
6
|
+
before_install:
|
|
7
|
+
- gem update bundler
|
|
2
8
|
rvm:
|
|
3
9
|
- 1.9.3
|
|
4
10
|
- 2.0.0
|
|
5
11
|
- 2.1.0
|
|
12
|
+
- 2.2.2
|
|
6
13
|
- jruby-19mode
|
|
7
14
|
- rbx-2
|
|
8
15
|
gemfile:
|
|
9
16
|
- gemfiles/rails_3_2.gemfile
|
|
10
17
|
- gemfiles/rails_4_1.gemfile
|
|
11
18
|
- gemfiles/rails_4_2.gemfile
|
|
19
|
+
- gemfiles/rails_5_0.gemfile
|
|
20
|
+
matrix:
|
|
21
|
+
exclude:
|
|
22
|
+
- rvm: 1.9.3
|
|
23
|
+
gemfile: gemfiles/rails_5_0.gemfile
|
|
24
|
+
- rvm: 2.0.0
|
|
25
|
+
gemfile: gemfiles/rails_5_0.gemfile
|
|
26
|
+
- rvm: 2.1.0
|
|
27
|
+
gemfile: gemfiles/rails_5_0.gemfile
|
|
28
|
+
- rvm: jruby-19mode
|
|
29
|
+
gemfile: gemfiles/rails_5_0.gemfile
|
|
30
|
+
- rvm: rbx-2
|
|
31
|
+
gemfile: gemfiles/rails_5_0.gemfile
|
|
32
|
+
|
data/Appraisals
CHANGED
|
@@ -1,11 +1,21 @@
|
|
|
1
1
|
appraise "rails-3-2" do
|
|
2
|
-
gem "activerecord", "3.2.
|
|
2
|
+
gem "activerecord", "~> 3.2.22.2"
|
|
3
|
+
group :test do
|
|
4
|
+
gem "after_commit_exception_notification"
|
|
5
|
+
end
|
|
3
6
|
end
|
|
4
7
|
|
|
5
8
|
appraise "rails-4-1" do
|
|
6
|
-
gem "activerecord", "4.1.
|
|
9
|
+
gem "activerecord", "~> 4.1.16"
|
|
10
|
+
group :test do
|
|
11
|
+
gem "after_commit_exception_notification"
|
|
12
|
+
end
|
|
7
13
|
end
|
|
8
14
|
|
|
9
15
|
appraise "rails-4-2" do
|
|
10
|
-
gem "activerecord", "4.2.
|
|
16
|
+
gem "activerecord", "~> 4.2.7"
|
|
17
|
+
end
|
|
18
|
+
|
|
19
|
+
appraise "rails-5-0" do
|
|
20
|
+
gem "activerecord", "~> 5.0.0"
|
|
11
21
|
end
|
data/CHANGELOG.md
ADDED
|
@@ -0,0 +1,316 @@
|
|
|
1
|
+
# Change Log
|
|
2
|
+
|
|
3
|
+
## [v0.7.6](https://github.com/swanandp/acts_as_list/tree/v0.7.6) (2016-07-15)
|
|
4
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.5...v0.7.6)
|
|
5
|
+
|
|
6
|
+
**Closed issues:**
|
|
7
|
+
|
|
8
|
+
- add\_new\_at nil with scope causes NoMethodError [\#211](https://github.com/swanandp/acts_as_list/issues/211)
|
|
9
|
+
|
|
10
|
+
**Merged pull requests:**
|
|
11
|
+
|
|
12
|
+
- Add class method acts\_as\_list\_top as reader for configured top\_of\_list [\#213](https://github.com/swanandp/acts_as_list/pull/213) ([krzysiek1507](https://github.com/krzysiek1507))
|
|
13
|
+
- Bugfix/add new at nil on scope change [\#212](https://github.com/swanandp/acts_as_list/pull/212) ([greatghoul](https://github.com/greatghoul))
|
|
14
|
+
|
|
15
|
+
## [v0.7.5](https://github.com/swanandp/acts_as_list/tree/v0.7.5) (2016-06-30)
|
|
16
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.4...v0.7.5)
|
|
17
|
+
|
|
18
|
+
**Implemented enhancements:**
|
|
19
|
+
|
|
20
|
+
- Touch when reordering [\#173](https://github.com/swanandp/acts_as_list/pull/173) ([botandrose](https://github.com/botandrose))
|
|
21
|
+
|
|
22
|
+
**Closed issues:**
|
|
23
|
+
|
|
24
|
+
- Exception raised when calling destroy "NameError - instance variable @scope\_changed not defined:" [\#206](https://github.com/swanandp/acts_as_list/issues/206)
|
|
25
|
+
- Undefined instance variable @scope\_changed since 0.7.3 [\#199](https://github.com/swanandp/acts_as_list/issues/199)
|
|
26
|
+
- Reordering large lists is slow [\#198](https://github.com/swanandp/acts_as_list/issues/198)
|
|
27
|
+
- Reparenting child leaves gap in source list in rails 5 [\#194](https://github.com/swanandp/acts_as_list/issues/194)
|
|
28
|
+
- Support rails 5 ? [\#186](https://github.com/swanandp/acts_as_list/issues/186)
|
|
29
|
+
- I get a NoMethodError: undefined method `acts\_as\_list' when trying to include acts\_as\_list [\#176](https://github.com/swanandp/acts_as_list/issues/176)
|
|
30
|
+
- Phenomenon of mysterious value of the position is skipped by one [\#166](https://github.com/swanandp/acts_as_list/issues/166)
|
|
31
|
+
- Model.find being called twice with acts\_as\_list on destroy [\#161](https://github.com/swanandp/acts_as_list/issues/161)
|
|
32
|
+
- `scope\_changed?` problem with acts\_as\_paranoid [\#158](https://github.com/swanandp/acts_as_list/issues/158)
|
|
33
|
+
- Inconsistent behaviour between Symbol and Array scopes [\#155](https://github.com/swanandp/acts_as_list/issues/155)
|
|
34
|
+
- insert\_at doesn't seem to be working in ActiveRecord callback \(Rails 4.2\) [\#150](https://github.com/swanandp/acts_as_list/issues/150)
|
|
35
|
+
- Project Documentation link redirects to expired domain [\#149](https://github.com/swanandp/acts_as_list/issues/149)
|
|
36
|
+
- Problem when updating an position of array of AR objects. [\#137](https://github.com/swanandp/acts_as_list/issues/137)
|
|
37
|
+
- Unexpected behaviour when inserting consecutive items with default positions [\#124](https://github.com/swanandp/acts_as_list/issues/124)
|
|
38
|
+
- self.reload prone to error [\#122](https://github.com/swanandp/acts_as_list/issues/122)
|
|
39
|
+
- Rails 3.0.x in\_list causes the return of default\_scope [\#120](https://github.com/swanandp/acts_as_list/issues/120)
|
|
40
|
+
- Relationships with dependency:destroy cause ActiveRecord::RecordNotFound [\#118](https://github.com/swanandp/acts_as_list/issues/118)
|
|
41
|
+
- Using insert\_at with values with type String [\#117](https://github.com/swanandp/acts_as_list/issues/117)
|
|
42
|
+
- Batch setting of position [\#112](https://github.com/swanandp/acts_as_list/issues/112)
|
|
43
|
+
- position: 0 now makes model pushed to top? [\#110](https://github.com/swanandp/acts_as_list/issues/110)
|
|
44
|
+
- Create element in default position [\#103](https://github.com/swanandp/acts_as_list/issues/103)
|
|
45
|
+
- Enhancement: Expose scope object [\#97](https://github.com/swanandp/acts_as_list/issues/97)
|
|
46
|
+
- Shuffle list [\#96](https://github.com/swanandp/acts_as_list/issues/96)
|
|
47
|
+
- Creating an item with a nil scope should not add it to the list [\#92](https://github.com/swanandp/acts_as_list/issues/92)
|
|
48
|
+
- Performance Improvements [\#88](https://github.com/swanandp/acts_as_list/issues/88)
|
|
49
|
+
- has\_many :through or has\_many\_and\_belongs\_to\_many support [\#86](https://github.com/swanandp/acts_as_list/issues/86)
|
|
50
|
+
- ActiveRecord dependency causes rake assets:compile to fail without access to a database [\#84](https://github.com/swanandp/acts_as_list/issues/84)
|
|
51
|
+
- move\_higher/move\_lower vs move\_to\_top/move\_to\_bottom act differently when item is already at top or bottom [\#77](https://github.com/swanandp/acts_as_list/issues/77)
|
|
52
|
+
- Limiting the list size [\#61](https://github.com/swanandp/acts_as_list/issues/61)
|
|
53
|
+
- Adding multiple creates strange ordering [\#55](https://github.com/swanandp/acts_as_list/issues/55)
|
|
54
|
+
- Feature: sort [\#26](https://github.com/swanandp/acts_as_list/issues/26)
|
|
55
|
+
|
|
56
|
+
**Merged pull requests:**
|
|
57
|
+
|
|
58
|
+
- Removed duplicated assignment [\#207](https://github.com/swanandp/acts_as_list/pull/207) ([shunwen](https://github.com/shunwen))
|
|
59
|
+
- Quote all identifiers [\#205](https://github.com/swanandp/acts_as_list/pull/205) ([fabn](https://github.com/fabn))
|
|
60
|
+
- Start testing Rails 5 [\#203](https://github.com/swanandp/acts_as_list/pull/203) ([brendon](https://github.com/brendon))
|
|
61
|
+
- Lock! the record before destroying [\#201](https://github.com/swanandp/acts_as_list/pull/201) ([brendon](https://github.com/brendon))
|
|
62
|
+
- Fix ambiguous column error when joining some relations [\#180](https://github.com/swanandp/acts_as_list/pull/180) ([natw](https://github.com/natw))
|
|
63
|
+
|
|
64
|
+
## [v0.7.4](https://github.com/swanandp/acts_as_list/tree/v0.7.4) (2016-04-15)
|
|
65
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.3...v0.7.4)
|
|
66
|
+
|
|
67
|
+
**Closed issues:**
|
|
68
|
+
|
|
69
|
+
- Releasing a new gem version [\#196](https://github.com/swanandp/acts_as_list/issues/196)
|
|
70
|
+
|
|
71
|
+
**Merged pull requests:**
|
|
72
|
+
|
|
73
|
+
- Fix scope changed [\#200](https://github.com/swanandp/acts_as_list/pull/200) ([brendon](https://github.com/brendon))
|
|
74
|
+
|
|
75
|
+
## [v0.7.3](https://github.com/swanandp/acts_as_list/tree/v0.7.3) (2016-04-14)
|
|
76
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.7.2...v0.7.3)
|
|
77
|
+
|
|
78
|
+
## [v0.7.2](https://github.com/swanandp/acts_as_list/tree/v0.7.2) (2016-04-01)
|
|
79
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.7.2...v0.7.2)
|
|
80
|
+
|
|
81
|
+
**Closed issues:**
|
|
82
|
+
|
|
83
|
+
- DEPRECATION WARNING: Passing string to define callback on Rails 5 beta 3 [\#191](https://github.com/swanandp/acts_as_list/issues/191)
|
|
84
|
+
- Why is `add\_to\_list\_bottom` private? [\#187](https://github.com/swanandp/acts_as_list/issues/187)
|
|
85
|
+
- Ordering of children when there are two possible parent models. [\#172](https://github.com/swanandp/acts_as_list/issues/172)
|
|
86
|
+
- Fix the jruby and rbx builds [\#169](https://github.com/swanandp/acts_as_list/issues/169)
|
|
87
|
+
- Unable to run tests [\#162](https://github.com/swanandp/acts_as_list/issues/162)
|
|
88
|
+
- shuffle\_positions\_on\_intermediate\_items is creating problems [\#134](https://github.com/swanandp/acts_as_list/issues/134)
|
|
89
|
+
- introduce Changelog file to quickly track changes [\#68](https://github.com/swanandp/acts_as_list/issues/68)
|
|
90
|
+
- Mongoid support? [\#52](https://github.com/swanandp/acts_as_list/issues/52)
|
|
91
|
+
|
|
92
|
+
**Merged pull requests:**
|
|
93
|
+
|
|
94
|
+
- Add filename/line number to class\_eval call [\#193](https://github.com/swanandp/acts_as_list/pull/193) ([hfwang](https://github.com/hfwang))
|
|
95
|
+
- Use a symbol as a string to define callback [\#192](https://github.com/swanandp/acts_as_list/pull/192) ([brendon](https://github.com/brendon))
|
|
96
|
+
- Pin changelog generator to a working version [\#190](https://github.com/swanandp/acts_as_list/pull/190) ([fabn](https://github.com/fabn))
|
|
97
|
+
- Fix bug, position is recomputed when object saved [\#188](https://github.com/swanandp/acts_as_list/pull/188) ([chrisortman](https://github.com/chrisortman))
|
|
98
|
+
- Update bundler before running tests, fixes test run on travis [\#179](https://github.com/swanandp/acts_as_list/pull/179) ([fabn](https://github.com/fabn))
|
|
99
|
+
- Changelog generator, closes \#68 [\#177](https://github.com/swanandp/acts_as_list/pull/177) ([fabn](https://github.com/fabn))
|
|
100
|
+
- Updating README example [\#175](https://github.com/swanandp/acts_as_list/pull/175) ([ryanbillings](https://github.com/ryanbillings))
|
|
101
|
+
- Adds description about various options available with the acts\_as\_list method [\#168](https://github.com/swanandp/acts_as_list/pull/168) ([udit7590](https://github.com/udit7590))
|
|
102
|
+
- Small changes to DRY up list.rb [\#163](https://github.com/swanandp/acts_as_list/pull/163) ([Albin-Willman](https://github.com/Albin-Willman))
|
|
103
|
+
- Only swap changed attributes which are persistable, i.e. are DB columns. [\#152](https://github.com/swanandp/acts_as_list/pull/152) ([ludwigschubert](https://github.com/ludwigschubert))
|
|
104
|
+
|
|
105
|
+
## [0.7.2](https://github.com/swanandp/acts_as_list/tree/0.7.2) (2015-05-06)
|
|
106
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.7.1...0.7.2)
|
|
107
|
+
|
|
108
|
+
## [0.7.1](https://github.com/swanandp/acts_as_list/tree/0.7.1) (2015-05-06)
|
|
109
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.7.0...0.7.1)
|
|
110
|
+
|
|
111
|
+
**Merged pull requests:**
|
|
112
|
+
|
|
113
|
+
- Update README.md [\#159](https://github.com/swanandp/acts_as_list/pull/159) ([tibastral](https://github.com/tibastral))
|
|
114
|
+
|
|
115
|
+
## [0.7.0](https://github.com/swanandp/acts_as_list/tree/0.7.0) (2015-05-01)
|
|
116
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.6.0...0.7.0)
|
|
117
|
+
|
|
118
|
+
**Closed issues:**
|
|
119
|
+
|
|
120
|
+
- Problem with reordering scoped list items [\#154](https://github.com/swanandp/acts_as_list/issues/154)
|
|
121
|
+
- Can no longer load acts\_as\_list in isolation if Rails is installed [\#145](https://github.com/swanandp/acts_as_list/issues/145)
|
|
122
|
+
|
|
123
|
+
**Merged pull requests:**
|
|
124
|
+
|
|
125
|
+
- Fix regression with using acts\_as\_list on base classes [\#147](https://github.com/swanandp/acts_as_list/pull/147) ([botandrose](https://github.com/botandrose))
|
|
126
|
+
- Don't require rails when loading [\#146](https://github.com/swanandp/acts_as_list/pull/146) ([botandrose](https://github.com/botandrose))
|
|
127
|
+
|
|
128
|
+
## [0.6.0](https://github.com/swanandp/acts_as_list/tree/0.6.0) (2014-12-24)
|
|
129
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.5.0...0.6.0)
|
|
130
|
+
|
|
131
|
+
**Closed issues:**
|
|
132
|
+
|
|
133
|
+
- Deprecation Warning: sanitize\_sql\_hash\_for\_conditions is deprecated and will be removed in Rails 5.0 [\#143](https://github.com/swanandp/acts_as_list/issues/143)
|
|
134
|
+
- Release a new gem version [\#136](https://github.com/swanandp/acts_as_list/issues/136)
|
|
135
|
+
|
|
136
|
+
**Merged pull requests:**
|
|
137
|
+
|
|
138
|
+
- Fix sanitize\_sql\_hash\_for\_conditions deprecation warning in Rails 4.2 [\#140](https://github.com/swanandp/acts_as_list/pull/140) ([eagletmt](https://github.com/eagletmt))
|
|
139
|
+
- Simpler method to find the subclass name [\#139](https://github.com/swanandp/acts_as_list/pull/139) ([brendon](https://github.com/brendon))
|
|
140
|
+
- Rails4 enum column support [\#130](https://github.com/swanandp/acts_as_list/pull/130) ([arunagw](https://github.com/arunagw))
|
|
141
|
+
- use eval for determing the self.class.name useful when this is used in an abstract class [\#123](https://github.com/swanandp/acts_as_list/pull/123) ([flarik](https://github.com/flarik))
|
|
142
|
+
|
|
143
|
+
## [0.5.0](https://github.com/swanandp/acts_as_list/tree/0.5.0) (2014-10-31)
|
|
144
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.4.0...0.5.0)
|
|
145
|
+
|
|
146
|
+
**Closed issues:**
|
|
147
|
+
|
|
148
|
+
- I want to have my existing records works like list [\#133](https://github.com/swanandp/acts_as_list/issues/133)
|
|
149
|
+
- Add Support For Multiple Indexes [\#127](https://github.com/swanandp/acts_as_list/issues/127)
|
|
150
|
+
- changing parent\_id does not update item positions [\#126](https://github.com/swanandp/acts_as_list/issues/126)
|
|
151
|
+
- How to exclude objects to be positioned? [\#125](https://github.com/swanandp/acts_as_list/issues/125)
|
|
152
|
+
- Scope for Polymorphic association + ManyToMany [\#106](https://github.com/swanandp/acts_as_list/issues/106)
|
|
153
|
+
- Bug when use \#insert\_at on an invalid ActiveRecord object [\#99](https://github.com/swanandp/acts_as_list/issues/99)
|
|
154
|
+
- has\_many :through with acts as list [\#95](https://github.com/swanandp/acts_as_list/issues/95)
|
|
155
|
+
- Update position when scope changes [\#19](https://github.com/swanandp/acts_as_list/issues/19)
|
|
156
|
+
|
|
157
|
+
**Merged pull requests:**
|
|
158
|
+
|
|
159
|
+
- Cast column default value to int before comparing with position column [\#129](https://github.com/swanandp/acts_as_list/pull/129) ([wioux](https://github.com/wioux))
|
|
160
|
+
- Fix travis builds for rbx [\#128](https://github.com/swanandp/acts_as_list/pull/128) ([meineerde](https://github.com/meineerde))
|
|
161
|
+
- Use unscoped blocks instead of chaining [\#121](https://github.com/swanandp/acts_as_list/pull/121) ([brendon](https://github.com/brendon))
|
|
162
|
+
- Make acts\_as\_list more compatible with BINARY column [\#116](https://github.com/swanandp/acts_as_list/pull/116) ([sikachu](https://github.com/sikachu))
|
|
163
|
+
- Added help notes on non-association scopes [\#115](https://github.com/swanandp/acts_as_list/pull/115) ([VorontsovIE](https://github.com/VorontsovIE))
|
|
164
|
+
- Let AR::Base properly lazy-loaded if Railtie is available [\#114](https://github.com/swanandp/acts_as_list/pull/114) ([amatsuda](https://github.com/amatsuda))
|
|
165
|
+
|
|
166
|
+
## [0.4.0](https://github.com/swanandp/acts_as_list/tree/0.4.0) (2014-02-22)
|
|
167
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.3.0...0.4.0)
|
|
168
|
+
|
|
169
|
+
**Closed issues:**
|
|
170
|
+
|
|
171
|
+
- insert\_at creates gaps [\#108](https://github.com/swanandp/acts_as_list/issues/108)
|
|
172
|
+
- move\_lower and move\_higher not working returning nil [\#57](https://github.com/swanandp/acts_as_list/issues/57)
|
|
173
|
+
- Mass-assignment issue with 0.1.8 [\#50](https://github.com/swanandp/acts_as_list/issues/50)
|
|
174
|
+
- validates error [\#49](https://github.com/swanandp/acts_as_list/issues/49)
|
|
175
|
+
- Ability to move multiple at once [\#40](https://github.com/swanandp/acts_as_list/issues/40)
|
|
176
|
+
- Duplicates created when using accepts\_nested\_attributes\_for [\#29](https://github.com/swanandp/acts_as_list/issues/29)
|
|
177
|
+
|
|
178
|
+
**Merged pull requests:**
|
|
179
|
+
|
|
180
|
+
- Update README [\#107](https://github.com/swanandp/acts_as_list/pull/107) ([Senjai](https://github.com/Senjai))
|
|
181
|
+
- Add license info: license file and gemspec [\#105](https://github.com/swanandp/acts_as_list/pull/105) ([chulkilee](https://github.com/chulkilee))
|
|
182
|
+
- Fix top position when position is lower than top position [\#104](https://github.com/swanandp/acts_as_list/pull/104) ([csaura](https://github.com/csaura))
|
|
183
|
+
- Get specs running under Rails 4.1.0.beta1 [\#101](https://github.com/swanandp/acts_as_list/pull/101) ([petergoldstein](https://github.com/petergoldstein))
|
|
184
|
+
- Add support for JRuby and Rubinius specs [\#100](https://github.com/swanandp/acts_as_list/pull/100) ([petergoldstein](https://github.com/petergoldstein))
|
|
185
|
+
- Use the correct syntax for conditions in Rails 4 on the readme. [\#94](https://github.com/swanandp/acts_as_list/pull/94) ([gotjosh](https://github.com/gotjosh))
|
|
186
|
+
- Adds `required\_ruby\_version` to gemspec [\#90](https://github.com/swanandp/acts_as_list/pull/90) ([tvdeyen](https://github.com/tvdeyen))
|
|
187
|
+
|
|
188
|
+
## [0.3.0](https://github.com/swanandp/acts_as_list/tree/0.3.0) (2013-08-02)
|
|
189
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.2.0...0.3.0)
|
|
190
|
+
|
|
191
|
+
**Closed issues:**
|
|
192
|
+
|
|
193
|
+
- act\_as\_list didn't install with bundle install [\#83](https://github.com/swanandp/acts_as_list/issues/83)
|
|
194
|
+
- Cannot update to version 0.1.7 [\#48](https://github.com/swanandp/acts_as_list/issues/48)
|
|
195
|
+
- when position is null all new items get inserted in position 1 [\#41](https://github.com/swanandp/acts_as_list/issues/41)
|
|
196
|
+
|
|
197
|
+
**Merged pull requests:**
|
|
198
|
+
|
|
199
|
+
- Test against activerecord v3 and v4 [\#82](https://github.com/swanandp/acts_as_list/pull/82) ([sanemat](https://github.com/sanemat))
|
|
200
|
+
- Fix check\_scope to work on lists with array scopes [\#81](https://github.com/swanandp/acts_as_list/pull/81) ([conzett](https://github.com/conzett))
|
|
201
|
+
- Rails4 compatibility [\#80](https://github.com/swanandp/acts_as_list/pull/80) ([philippfranke](https://github.com/philippfranke))
|
|
202
|
+
- Add tests for moving within scope and add method: move\_within\_scope [\#79](https://github.com/swanandp/acts_as_list/pull/79) ([philippfranke](https://github.com/philippfranke))
|
|
203
|
+
- Option to not automatically add items to the list [\#72](https://github.com/swanandp/acts_as_list/pull/72) ([forrest](https://github.com/forrest))
|
|
204
|
+
|
|
205
|
+
## [0.2.0](https://github.com/swanandp/acts_as_list/tree/0.2.0) (2013-02-28)
|
|
206
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.9...0.2.0)
|
|
207
|
+
|
|
208
|
+
**Merged pull requests:**
|
|
209
|
+
|
|
210
|
+
- Fix update\_all deprecation warnings in Rails 4.0.0.beta1 [\#73](https://github.com/swanandp/acts_as_list/pull/73) ([soffes](https://github.com/soffes))
|
|
211
|
+
- Add quotes to Id in SQL requests [\#69](https://github.com/swanandp/acts_as_list/pull/69) ([noefroidevaux](https://github.com/noefroidevaux))
|
|
212
|
+
- Update position when scope changes [\#67](https://github.com/swanandp/acts_as_list/pull/67) ([philippfranke](https://github.com/philippfranke))
|
|
213
|
+
- add and categorize public instance methods in readme; add misc notes to ... [\#66](https://github.com/swanandp/acts_as_list/pull/66) ([barelyknown](https://github.com/barelyknown))
|
|
214
|
+
- Updates \#bottom\_item .find syntax to \>= Rails 3 compatible syntax. [\#65](https://github.com/swanandp/acts_as_list/pull/65) ([tvdeyen](https://github.com/tvdeyen))
|
|
215
|
+
- add GitHub Flavored Markdown to README [\#63](https://github.com/swanandp/acts_as_list/pull/63) ([phlipper](https://github.com/phlipper))
|
|
216
|
+
|
|
217
|
+
## [0.1.9](https://github.com/swanandp/acts_as_list/tree/0.1.9) (2012-12-04)
|
|
218
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.8...0.1.9)
|
|
219
|
+
|
|
220
|
+
**Closed issues:**
|
|
221
|
+
|
|
222
|
+
- Mysql2 error [\#54](https://github.com/swanandp/acts_as_list/issues/54)
|
|
223
|
+
- Use alternative column name? [\#53](https://github.com/swanandp/acts_as_list/issues/53)
|
|
224
|
+
|
|
225
|
+
**Merged pull requests:**
|
|
226
|
+
|
|
227
|
+
- attr-accessible can be damaging, is not always necessary. [\#60](https://github.com/swanandp/acts_as_list/pull/60) ([graemeworthy](https://github.com/graemeworthy))
|
|
228
|
+
- More reliable lower/higher item detection [\#59](https://github.com/swanandp/acts_as_list/pull/59) ([miks](https://github.com/miks))
|
|
229
|
+
- Instructions for using an array with scope [\#58](https://github.com/swanandp/acts_as_list/pull/58) ([zukowski](https://github.com/zukowski))
|
|
230
|
+
- Attr accessible patch, should solve \#50 [\#51](https://github.com/swanandp/acts_as_list/pull/51) ([fabn](https://github.com/fabn))
|
|
231
|
+
- support accepts\_nested\_attributes\_for multi-destroy [\#46](https://github.com/swanandp/acts_as_list/pull/46) ([saberma](https://github.com/saberma))
|
|
232
|
+
|
|
233
|
+
## [0.1.8](https://github.com/swanandp/acts_as_list/tree/0.1.8) (2012-08-09)
|
|
234
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.7...0.1.8)
|
|
235
|
+
|
|
236
|
+
## [0.1.7](https://github.com/swanandp/acts_as_list/tree/0.1.7) (2012-08-09)
|
|
237
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.6...0.1.7)
|
|
238
|
+
|
|
239
|
+
**Closed issues:**
|
|
240
|
+
|
|
241
|
+
- Remove use of update\_attribute [\#44](https://github.com/swanandp/acts_as_list/issues/44)
|
|
242
|
+
- Order is reversed when adding multiple rows at once [\#34](https://github.com/swanandp/acts_as_list/issues/34)
|
|
243
|
+
|
|
244
|
+
**Merged pull requests:**
|
|
245
|
+
|
|
246
|
+
- Fixed issue with update\_positions that wasn't taking 'scope\_condition' into account [\#47](https://github.com/swanandp/acts_as_list/pull/47) ([bastien](https://github.com/bastien))
|
|
247
|
+
- Replaced usage of update\_attribute with update\_attribute! [\#45](https://github.com/swanandp/acts_as_list/pull/45) ([kevmoo](https://github.com/kevmoo))
|
|
248
|
+
- use self.class.primary\_key instead of id in shuffle\_positions\_on\_intermediate\_items [\#42](https://github.com/swanandp/acts_as_list/pull/42) ([servercrunch](https://github.com/servercrunch))
|
|
249
|
+
- initialize gem [\#39](https://github.com/swanandp/acts_as_list/pull/39) ([megatux](https://github.com/megatux))
|
|
250
|
+
- Added ability to set item positions directly \(e.g. In a form\) [\#38](https://github.com/swanandp/acts_as_list/pull/38) ([dubroe](https://github.com/dubroe))
|
|
251
|
+
- Prevent SQL error when position\_column is not unique [\#37](https://github.com/swanandp/acts_as_list/pull/37) ([hinrik](https://github.com/hinrik))
|
|
252
|
+
- Add installation instructions to README.md [\#35](https://github.com/swanandp/acts_as_list/pull/35) ([mark-rushakoff](https://github.com/mark-rushakoff))
|
|
253
|
+
|
|
254
|
+
## [0.1.6](https://github.com/swanandp/acts_as_list/tree/0.1.6) (2012-04-19)
|
|
255
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.5...0.1.6)
|
|
256
|
+
|
|
257
|
+
**Closed issues:**
|
|
258
|
+
|
|
259
|
+
- eval mistakenly resolved the module path [\#32](https://github.com/swanandp/acts_as_list/issues/32)
|
|
260
|
+
- Duplicated positions when creating parent and children from scratch in 0.1.5 [\#31](https://github.com/swanandp/acts_as_list/issues/31)
|
|
261
|
+
- add info about v0.1.5 require Rails 3 [\#28](https://github.com/swanandp/acts_as_list/issues/28)
|
|
262
|
+
- position not updated with move\_higher or move\_lover [\#23](https://github.com/swanandp/acts_as_list/issues/23)
|
|
263
|
+
|
|
264
|
+
**Merged pull requests:**
|
|
265
|
+
|
|
266
|
+
- update ActiveRecord class eval to support ActiveSupport on\_load [\#33](https://github.com/swanandp/acts_as_list/pull/33) ([mergulhao](https://github.com/mergulhao))
|
|
267
|
+
- Add :add\_new\_at option [\#30](https://github.com/swanandp/acts_as_list/pull/30) ([mjbellantoni](https://github.com/mjbellantoni))
|
|
268
|
+
|
|
269
|
+
## [0.1.5](https://github.com/swanandp/acts_as_list/tree/0.1.5) (2012-02-24)
|
|
270
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.4...0.1.5)
|
|
271
|
+
|
|
272
|
+
**Closed issues:**
|
|
273
|
+
|
|
274
|
+
- increment\_positions\_on\_lower\_items called twice on insert\_at with new item [\#21](https://github.com/swanandp/acts_as_list/issues/21)
|
|
275
|
+
- Change bundler dependency from ~\>1.0.0 to ~\>1.0 [\#20](https://github.com/swanandp/acts_as_list/issues/20)
|
|
276
|
+
- decrement\_positions\_on\_lower\_items method [\#17](https://github.com/swanandp/acts_as_list/issues/17)
|
|
277
|
+
- New gem release [\#16](https://github.com/swanandp/acts_as_list/issues/16)
|
|
278
|
+
- acts\_as\_list :scope =\> "doesnt\_seem\_to\_work" [\#12](https://github.com/swanandp/acts_as_list/issues/12)
|
|
279
|
+
- don't work perfectly with default\_scope [\#11](https://github.com/swanandp/acts_as_list/issues/11)
|
|
280
|
+
- MySQL: Position column MUST NOT have default [\#10](https://github.com/swanandp/acts_as_list/issues/10)
|
|
281
|
+
- insert\_at fails on postgresql w/ non-null constraint on postion\_column [\#8](https://github.com/swanandp/acts_as_list/issues/8)
|
|
282
|
+
|
|
283
|
+
**Merged pull requests:**
|
|
284
|
+
|
|
285
|
+
- Efficiency improvement for insert\_at when repositioning an existing item [\#27](https://github.com/swanandp/acts_as_list/pull/27) ([bradediger](https://github.com/bradediger))
|
|
286
|
+
- Use before validate instead of before create [\#25](https://github.com/swanandp/acts_as_list/pull/25) ([webervin](https://github.com/webervin))
|
|
287
|
+
- Massive test refactorings. [\#24](https://github.com/swanandp/acts_as_list/pull/24) ([splattael](https://github.com/splattael))
|
|
288
|
+
- Silent migrations to reduce test noise. [\#22](https://github.com/swanandp/acts_as_list/pull/22) ([splattael](https://github.com/splattael))
|
|
289
|
+
- Should decrement lower items after the item has been destroyed to avoid unique key conflicts. [\#18](https://github.com/swanandp/acts_as_list/pull/18) ([aepstein](https://github.com/aepstein))
|
|
290
|
+
- Fix spelling and grammer [\#15](https://github.com/swanandp/acts_as_list/pull/15) ([tmiller](https://github.com/tmiller))
|
|
291
|
+
- store\_at\_0 should yank item from the list then decrement items to avoid r [\#14](https://github.com/swanandp/acts_as_list/pull/14) ([aepstein](https://github.com/aepstein))
|
|
292
|
+
- Support default\_scope ordering by calling .unscoped [\#13](https://github.com/swanandp/acts_as_list/pull/13) ([tanordheim](https://github.com/tanordheim))
|
|
293
|
+
|
|
294
|
+
## [0.1.4](https://github.com/swanandp/acts_as_list/tree/0.1.4) (2011-07-27)
|
|
295
|
+
[Full Changelog](https://github.com/swanandp/acts_as_list/compare/0.1.3...0.1.4)
|
|
296
|
+
|
|
297
|
+
**Merged pull requests:**
|
|
298
|
+
|
|
299
|
+
- Fix sqlite3 dependency [\#7](https://github.com/swanandp/acts_as_list/pull/7) ([joneslee85](https://github.com/joneslee85))
|
|
300
|
+
|
|
301
|
+
## [0.1.3](https://github.com/swanandp/acts_as_list/tree/0.1.3) (2011-06-10)
|
|
302
|
+
**Closed issues:**
|
|
303
|
+
|
|
304
|
+
- Graph like behaviour [\#5](https://github.com/swanandp/acts_as_list/issues/5)
|
|
305
|
+
- Updated Gem? [\#4](https://github.com/swanandp/acts_as_list/issues/4)
|
|
306
|
+
|
|
307
|
+
**Merged pull requests:**
|
|
308
|
+
|
|
309
|
+
- Converted into a gem... plus some slight refactors [\#6](https://github.com/swanandp/acts_as_list/pull/6) ([chaffeqa](https://github.com/chaffeqa))
|
|
310
|
+
- Fixed test issue for test\_injection: expected SQL was reversed. [\#3](https://github.com/swanandp/acts_as_list/pull/3) ([afriqs](https://github.com/afriqs))
|
|
311
|
+
- Added an option to set the top of the position [\#2](https://github.com/swanandp/acts_as_list/pull/2) ([danielcooper](https://github.com/danielcooper))
|
|
312
|
+
- minor change to acts\_as\_list's callbacks [\#1](https://github.com/swanandp/acts_as_list/pull/1) ([tiegz](https://github.com/tiegz))
|
|
313
|
+
|
|
314
|
+
|
|
315
|
+
|
|
316
|
+
\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
|
data/Gemfile
CHANGED
|
@@ -9,12 +9,15 @@ platforms :rbx do
|
|
|
9
9
|
gem "rubysl-test-unit"
|
|
10
10
|
end
|
|
11
11
|
|
|
12
|
-
|
|
12
|
+
gem "rack", "~> 1", platforms: [:ruby_19, :ruby_20, :ruby_21, :jruby]
|
|
13
|
+
|
|
13
14
|
gemspec
|
|
14
15
|
|
|
15
16
|
gem "rake"
|
|
16
17
|
gem "appraisal"
|
|
18
|
+
gem "github_changelog_generator", "1.9.0"
|
|
17
19
|
|
|
18
20
|
group :test do
|
|
19
|
-
gem "minitest"
|
|
21
|
+
gem "minitest", "~> 5.0"
|
|
22
|
+
gem "test_after_commit", "~> 0.4.2"
|
|
20
23
|
end
|
data/README.md
CHANGED
|
@@ -32,9 +32,10 @@ class TodoItem < ActiveRecord::Base
|
|
|
32
32
|
belongs_to :todo_list
|
|
33
33
|
acts_as_list scope: :todo_list
|
|
34
34
|
end
|
|
35
|
-
|
|
36
|
-
todo_list.
|
|
37
|
-
todo_list.
|
|
35
|
+
|
|
36
|
+
todo_list = TodoList.find(...)
|
|
37
|
+
todo_list.todo_items.first.move_to_bottom
|
|
38
|
+
todo_list.todo_items.last.move_higher
|
|
38
39
|
```
|
|
39
40
|
|
|
40
41
|
## Instance Methods Added To ActiveRecord Models
|
|
@@ -85,7 +86,17 @@ class TodoItem < ActiveRecord::Base
|
|
|
85
86
|
end
|
|
86
87
|
```
|
|
87
88
|
|
|
89
|
+
## More Options
|
|
90
|
+
- `column`
|
|
91
|
+
default: 'position'. Use this option if the column name in your database is different from position.
|
|
92
|
+
- `top_of_list`
|
|
93
|
+
default: '1'. Use this option to define the top of the list. Use 0 to make the collection act more like an array in its indexing.
|
|
94
|
+
- `add_new_at`
|
|
95
|
+
default: ':bottom'. Use this option to specify whether objects get added to the :top or :bottom of the list. `nil` will result in new items not being added to the list on create, i.e, position will be kept nil after create.
|
|
96
|
+
|
|
88
97
|
## Versions
|
|
98
|
+
As of version `0.7.5` Rails 5 is supported.
|
|
99
|
+
|
|
89
100
|
All versions `0.1.5` onwards require Rails 3.0.x and higher.
|
|
90
101
|
|
|
91
102
|
## Build Status
|
|
@@ -97,7 +108,6 @@ All versions `0.1.5` onwards require Rails 3.0.x and higher.
|
|
|
97
108
|
## Roadmap
|
|
98
109
|
|
|
99
110
|
1. Sort based feature
|
|
100
|
-
2. Rails 4 compatibility and bye bye Rails 2! Older versions would of course continue to work with Rails 2, but there won't be any support on those.
|
|
101
111
|
|
|
102
112
|
## Contributing to `acts_as_list`
|
|
103
113
|
|
data/Rakefile
CHANGED
|
@@ -32,3 +32,11 @@ rescue LoadError
|
|
|
32
32
|
rescue StandardError
|
|
33
33
|
puts "RDocTask is not supported on this platform."
|
|
34
34
|
end
|
|
35
|
+
|
|
36
|
+
# See https://github.com/skywinder/github-changelog-generator#rake-task for details
|
|
37
|
+
# and github_changelog_generator --help for available options
|
|
38
|
+
require 'github_changelog_generator/task'
|
|
39
|
+
GitHubChangelogGenerator::RakeTask.new :changelog do |config|
|
|
40
|
+
config.project = 'acts_as_list'
|
|
41
|
+
config.user = 'swanandp'
|
|
42
|
+
end
|
data/gemfiles/rails_3_2.gemfile
CHANGED
|
@@ -4,12 +4,16 @@ source "http://rubygems.org"
|
|
|
4
4
|
|
|
5
5
|
gem "sqlite3", :platforms => [:ruby]
|
|
6
6
|
gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
|
|
7
|
+
gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
|
|
7
8
|
gem "rake"
|
|
8
9
|
gem "appraisal"
|
|
9
|
-
gem "
|
|
10
|
+
gem "github_changelog_generator", "1.9.0"
|
|
11
|
+
gem "activerecord", "~> 3.2.22.2"
|
|
10
12
|
|
|
11
13
|
group :test do
|
|
12
|
-
gem "minitest"
|
|
14
|
+
gem "minitest", "~> 5.0"
|
|
15
|
+
gem "test_after_commit", "~> 0.4.2"
|
|
16
|
+
gem "after_commit_exception_notification"
|
|
13
17
|
end
|
|
14
18
|
|
|
15
19
|
platforms :rbx do
|
data/gemfiles/rails_4_1.gemfile
CHANGED
|
@@ -4,12 +4,16 @@ source "http://rubygems.org"
|
|
|
4
4
|
|
|
5
5
|
gem "sqlite3", :platforms => [:ruby]
|
|
6
6
|
gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
|
|
7
|
+
gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
|
|
7
8
|
gem "rake"
|
|
8
9
|
gem "appraisal"
|
|
9
|
-
gem "
|
|
10
|
+
gem "github_changelog_generator", "1.9.0"
|
|
11
|
+
gem "activerecord", "~> 4.1.16"
|
|
10
12
|
|
|
11
13
|
group :test do
|
|
12
|
-
gem "minitest"
|
|
14
|
+
gem "minitest", "~> 5.0"
|
|
15
|
+
gem "test_after_commit", "~> 0.4.2"
|
|
16
|
+
gem "after_commit_exception_notification"
|
|
13
17
|
end
|
|
14
18
|
|
|
15
19
|
platforms :rbx do
|
data/gemfiles/rails_4_2.gemfile
CHANGED
|
@@ -4,12 +4,15 @@ source "http://rubygems.org"
|
|
|
4
4
|
|
|
5
5
|
gem "sqlite3", :platforms => [:ruby]
|
|
6
6
|
gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
|
|
7
|
+
gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
|
|
7
8
|
gem "rake"
|
|
8
9
|
gem "appraisal"
|
|
9
|
-
gem "
|
|
10
|
+
gem "github_changelog_generator", "1.9.0"
|
|
11
|
+
gem "activerecord", "~> 4.2.7"
|
|
10
12
|
|
|
11
13
|
group :test do
|
|
12
|
-
gem "minitest"
|
|
14
|
+
gem "minitest", "~> 5.0"
|
|
15
|
+
gem "test_after_commit", "~> 0.4.2"
|
|
13
16
|
end
|
|
14
17
|
|
|
15
18
|
platforms :rbx do
|
|
@@ -0,0 +1,24 @@
|
|
|
1
|
+
# This file was generated by Appraisal
|
|
2
|
+
|
|
3
|
+
source "http://rubygems.org"
|
|
4
|
+
|
|
5
|
+
gem "sqlite3", :platforms => [:ruby]
|
|
6
|
+
gem "activerecord-jdbcsqlite3-adapter", :platforms => [:jruby]
|
|
7
|
+
gem "rack", "~> 1", :platforms => [:ruby_19, :ruby_20, :ruby_21, :jruby]
|
|
8
|
+
gem "rake"
|
|
9
|
+
gem "appraisal"
|
|
10
|
+
gem "github_changelog_generator", "1.9.0"
|
|
11
|
+
gem "activerecord", "~> 5.0.0"
|
|
12
|
+
|
|
13
|
+
group :test do
|
|
14
|
+
gem "minitest", "~> 5.0"
|
|
15
|
+
gem "test_after_commit", "~> 0.4.2"
|
|
16
|
+
end
|
|
17
|
+
|
|
18
|
+
platforms :rbx do
|
|
19
|
+
gem "rubysl", "~> 2.0"
|
|
20
|
+
gem "rubinius-developer_tools"
|
|
21
|
+
gem "rubysl-test-unit"
|
|
22
|
+
end
|
|
23
|
+
|
|
24
|
+
gemspec :path => "../"
|