acts_as_inheritable 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2b1041cc8ec082ae65cf0b6c89252e2298bd24bd
-  data.tar.gz: 77d74d6cdcba7e5f40239ae9e361536d18778feb
+  metadata.gz: 391d2159779c617d4641194c7a9e49585763661f
+  data.tar.gz: 96ff7393944b993f84b0976e31e88b38669fcc62
 SHA512:
-  metadata.gz: 3a2fe15e1ce0aefb9a44bf9528de5055caa03dc4112a103cadcaabaebf12e69518c3ba484c1c5db9191d5b431c4b898a26c579c8cc4cff248a9e6eb401ce0ed4
-  data.tar.gz: db0ae6bfb76bd7fcf4c0f3308b77dc0ae80798ff1ed22af9f888dd61f0b5b7c3f104def94d576a72b9b756d50a71c8f85511181afa1b1e16d0027a8623439d4f
+  metadata.gz: e3bfcbbc59f32c2205ffa8debfa389d5ef5301b2fc641ad8ba38fe9b0cbf356b0d6727039451b3ca545f02c07b28063bd81d9cebfac4f23fc5cbea9ed433851a
+  data.tar.gz: 6d4c676e640ac8f32c8b8ce100446a38cef44702a5c5e8196c0150ca7ad2d6ec372e9030430ccd8e3c40d46880d030335956f819036765c3bd582d894b659b5a

data/.codeclimate.yml

@@ -17,6 +17,9 @@ engines:
 # to turn off an engine, set enabled to `false` or remove it
   rubocop:
     enabled: true
+    checks:
+      Rubocop/Style/Documentation:
+        enabled: false
 
 # Engines can analyze files and report issues on them, but you can separately
 # decide which files will receive ratings based on those issues. This is

data/README.md

@@ -101,6 +101,19 @@ son.pet.inspect # => #<Pet id: 2, person_id: 2, name: "Mango", breed: "Golden Re
 
 ````
 
+### Handling your own `dup`
+
+By default new relations are _duplicated_ using [dup](http://ruby-doc.org/core-2.2.3/Object.html#method-i-dup), which produces a shallow copy of the object. But you can also handle this as you want by defining a `duplicate!` method.
+
+
+## Testing
+
+All tests follow the RSpec format and are located in the spec directory. They can be run with:
+
+````bash
+$ rspec
+````
+
 ## Contributing
 
 1. Fork it ( https://github.com/esbanarango/acts_as_inheritable/fork )
@@ -109,6 +122,14 @@ son.pet.inspect # => #<Pet id: 2, person_id: 2, name: "Mango", breed: "Golden Re
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
 
+## Donating
+Support this project and [others by esbanarango][gratipay-esbanarango] via [gratipay][gratipay-esbanarango].
+
+[![Support via Gratipay][gratipay]][gratipay-esbanarango]
+
+[gratipay]: https://cdn.rawgit.com/gratipay/gratipay-badge/2.3.0/dist/gratipay.png
+[gratipay-esbanarango]: https://gratipay.com/esbanarango/
+
 ## Author
 
 This was written by [Esteban Arango Medina](http://esbanarango.com) while working at [Blue Sky Cards](https://www.blueskycards.com/).

data/lib/acts_as_inheritable.rb

@@ -1,10 +1,10 @@
 require 'active_record'
-require "acts_as_inheritable/version"
+require 'acts_as_inheritable/version'
 
 module ActsAsInheritable
   def acts_as_inheritable(options)
-    raise ArgumentError, "Hash expected, got #{options.class.name}" if !options.is_a?(Hash)
-    raise ArgumentError, "Empty options" if options[:attributes].blank? && options[:associations].blank?
+    fail ArgumentError, "Hash expected, got #{options.class.name}" unless options.is_a?(Hash)
+    fail ArgumentError, 'Empty options' if options[:attributes].blank? && options[:associations].blank?
 
     class_attribute :inheritable_configuration
 
@@ -20,8 +20,8 @@ module ActsAsInheritable
       # relations defined on `INHERITABLE_ASSOCIATIONS`. For each instance on
       # each relation it re-creates it.
       def inherit_relations(model_parent = send(:parent), current = self)
-        if model_parent && model_parent.class.method_defined?(:inheritable_configuration) && model_parent.class::inheritable_configuration[:associations]
-          model_parent.class::inheritable_configuration[:associations].each do |relation|
+        if model_parent && current.class.method_defined?(:inheritable_configuration) && current.class.inheritable_configuration[:associations]
+          current.class.inheritable_configuration[:associations].each do |relation|
             parent_relation = model_parent.send(relation)
             relation_instances = parent_relation.respond_to?(:each) ? parent_relation : [parent_relation].compact
             relation_instances.each do |relation_instance|
@@ -55,22 +55,25 @@ module ActsAsInheritable
         return parent_name if new_relation.respond_to?(parent_name)
         many_and_one_associations = model_parent.class.reflect_on_all_associations.select { |a| a.macro != :belongs_to }
         many_and_one_associations.each do |association|
-          if association.klass.to_s.downcase == new_relation.class.to_s.downcase && association.options.has_key?(:as)
-            as = association.options[:as].to_s
-            parent_name = as if new_relation.respond_to?(as) && !new_relation.respond_to?(parent_name)
+          next unless association.klass.to_s.downcase == new_relation.class.to_s.downcase && association.options.key?(:as)
+          as = association.options[:as].to_s
+          if new_relation.respond_to?(as) && !new_relation.respond_to?(parent_name)
+            parent_name = as
             break
           end
         end
         # Relations has a diffeent name
         unless new_relation.respond_to?(parent_name)
-          new_relation.class.reflections.each_key  do |reflection|
-            parent_name = reflection if new_relation.class.reflections[reflection].class_name == model_parent.class.name
+          new_relation.class.reflections.each_key do |reflection|
+            next unless new_relation.class.reflections[reflection].class_name == model_parent.class.name
+            parent_name = reflection
+            break
           end
         end
         parent_name
       end
 
-      def inherit_attributes(force = false, not_force_for=[])
+      def inherit_attributes(force = false, not_force_for = [])
         if has_parent? && self.class.inheritable_configuration[:attributes]
           # Attributes
           self.class.inheritable_configuration[:attributes].each do |attribute|
@@ -83,6 +86,7 @@ module ActsAsInheritable
       end
     end
   end
+
   if defined?(ActiveRecord)
     # Extend ActiveRecord's functionality
     ActiveRecord::Base.send :extend, ActsAsInheritable

data/lib/acts_as_inheritable/version.rb

@@ -1,3 +1,3 @@
 module ActsAsInheritable
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_inheritable
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Esteban Arango Medina
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-27 00:00:00.000000000 Z
+date: 2015-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler