acts_as_inheritable 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db1788d731e0bcdd74204824b7218dfe127d3fed
-  data.tar.gz: 8766188de301ee46e0b142b089a67b6addd1b8e8
+  metadata.gz: 61f0d977c0caf99cd17883ba4e0f0e1a945be197
+  data.tar.gz: 28d9e8a7c3bb486dcfba2970eedbb25d4d4ec22e
 SHA512:
-  metadata.gz: a772d675fa5aa5c279cb05b218c92c136fbeac132bc25b455e5473cc46f7506eeb858d9d1086749717a8ad8a938a5e5abd582fc401dcbd5b5c6787419bf2b93a
-  data.tar.gz: 331e075044f1f3028bb67a892bb6f7ccb8f9c51bb87dc04994ba4a90e03986d6713a8b10816fb69595867485c11a53086378f2effbfacc29a996c82595f1b628
+  metadata.gz: 72b8c954ef211b5f35164393614ab2c062d418df267bfb5a5eeb771d5f4550e1d03f00898ddaacce18e1039fa04ce95e9902200faf3c39b7338f8bfae44b4773
+  data.tar.gz: e62c7d4bf845b2b476120537a674b6b05c9a8fa179f1d6de929a1c20beaaf082b812d18f6280cb53777b9d5a818a39fa8a5af0149fd886cda674b00505930f24

data/.gitignore

@@ -1,3 +1,4 @@
+*.gem
 /.bundle/
 /.yardoc
 /Gemfile.lock

data/README.md

@@ -1,8 +1,8 @@
 # ActsAsInheritable
 
-[![Build Status](https://travis-ci.org/esbanarango/acts_as_inheritable.svg)](https://travis-ci.org/esbanarango/acts_as_inheritable) [![Test Coverage](https://codeclimate.com/github/esbanarango/acts_as_inheritable/badges/coverage.svg)](https://codeclimate.com/github/esbanarango/acts_as_inheritable/coverage) [![Code Climate](https://codeclimate.com/github/esbanarango/acts_as_inheritable/badges/gpa.svg)](https://codeclimate.com/github/esbanarango/acts_as_inheritable)
+[![Gem Version](https://badge.fury.io/rb/acts_as_inheritable.svg)](https://badge.fury.io/rb/acts_as_inheritable) [![Build Status](https://travis-ci.org/esbanarango/acts_as_inheritable.svg)](https://travis-ci.org/esbanarango/acts_as_inheritable) [![Test Coverage](https://codeclimate.com/github/esbanarango/acts_as_inheritable/badges/coverage.svg)](https://codeclimate.com/github/esbanarango/acts_as_inheritable/coverage) [![Code Climate](https://codeclimate.com/github/esbanarango/acts_as_inheritable/badges/gpa.svg)](https://codeclimate.com/github/esbanarango/acts_as_inheritable)
 
-This is gem mean to be used with the [_Self-Referential Association_](#self-referential-association), or with a model having a `parent` that share the inheritable attributes. This will let you inherit any __attribute__ or __relation__ from the _parent_ model.
+_Acts As Inheritable_ is a Ruby Gem specifically written for Rails/ActiveRecord models. It is mean to be used with the [_Self-Referential Association_](#self-referential-association), or with a model having a `parent` that share the inheritable attributes. This will let you inherit any __attribute__ or __relation__ from the _parent_ model.
 
 ### Self-Referential Association
 
@@ -49,6 +49,7 @@ class Person < ActiveRecord::Base
   has_many    :children, class_name: 'Person', foreign_key: :parent_id
   has_many    :toys
   has_many    :shoes
+  has_one     :pet
   has_many    :pictures, as: :imageable
 
   # Callbacks
@@ -56,15 +57,49 @@ class Person < ActiveRecord::Base
   before_validation :inherit_relations, on: :create
 end
 
+parent = Person.create(last_name: 'Arango', soccer_team: 'Verdolaga', favorite_color:'Green')
+
+son = Person.create(parent: parent)
+son.last_name # => Arango
+son.soccer_team # => Verdolaga
+son.favorite_color # => Green
+
 ````
+### Available methods
+By adding `acts_as_inheritable` to your models you will have access to these methods:
 
 #### inherit_attributes
+By default this method  will only set values that are [blank?](http://api.rubyonrails.org/classes/Object.html#method-i-blank-3F).
+
 ##### params
-  - `force` | default to true. Set the attribute even if it's _present_.
-  - `not_force_for` | array of attributes. When setting `force` to _true_, you can also specify the attributes you don't want to overwrite.
+  - `force`: Default to true. Set the attribute even if it's _present_.
+  - `not_force_for`: Default to empty array. When setting `force` to _true_, you can also specify the attributes you don't want to overwrite.
+
+#### inherit_relations
+
+```ruby
 
-__inherit_attributes__ method by default will only set values that are [blank?](http://api.rubyonrails.org/classes/Object.html#method-i-blank-3F).
+class Person < ActiveRecord::Base
+  acts_as_inheritable
+
+  # Constants
+  INHERITABLE_ASSOCIATIONS = %w(pet)
 
+  # Associations
+  has_one     :pet
+
+  # Callbacks
+  before_validation :inherit_relations, on: :create
+end
+
+parent = Person.create(last_name: 'Arango')
+parent_pet = Pet.create(person: parent, name: 'Mango', breed:'Golden Retriver')
+parent_pet.inspect #=> #<Pet id: 1, person_id: 1, name: "Mango", breed: "Golden Retriver">
+
+son = Person.create(parent: parent)
+son.pet.inspect # => #<Pet id: 2, person_id: 2, name: "Mango", breed: "Golden Retriver">
+
+````
 
 ## Contributing
 

data/acts_as_inheritable.gemspec

@@ -23,10 +23,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "factory_girl", "~> 4.5", ">= 4.5.0"
   spec.add_development_dependency "faker", "~> 1.5", ">= 1.5.0"
   spec.add_development_dependency "rspec", "~> 3.3", ">= 3.3.0"
-  spec.add_development_dependency "rspec-nc", "~> 0.2.0"
+  spec.add_development_dependency "rspec-nc", "~> 0.2", ">= 0.2.0"
   spec.add_development_dependency "sqlite3", "~> 1.3"
   spec.add_development_dependency "nyan-cat-formatter", "~> 0.11"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 0.4.3"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 0.4", ">= 0.4.3"
 
   spec.add_dependency "activesupport", "~> 4"
   spec.add_dependency "activerecord", "~> 4", ">= 4.1.2"

data/lib/acts_as_inheritable/version.rb

@@ -1,3 +1,3 @@
 module ActsAsInheritable
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/acts_as_inheritable.rb

@@ -43,6 +43,7 @@ module ActsAsInheritable
 
       def verify_parent_name(new_relation, model_parent)
         parent_name = model_parent.class.to_s.downcase
+        return parent_name if new_relation.respond_to?(parent_name)
         many_and_one_associations = model_parent.class.reflect_on_all_associations.select { |a| a.macro != :belongs_to }
         many_and_one_associations.each do |association|
           if association.klass.to_s.downcase == new_relation.class.to_s.downcase && association.options.has_key?(:as)
@@ -51,6 +52,12 @@ module ActsAsInheritable
             break
           end
         end
+        # Relations has a diffeent name
+        unless new_relation.respond_to?(parent_name)
+          new_relation.class.reflections.keys.each do |reflection|
+            parent_name = reflection if new_relation.class.reflections[reflection].class_name == model_parent.class.name
+          end
+        end
         parent_name
       end
 

data/spec/acts_as_inheritable_spec.rb

@@ -9,13 +9,43 @@ RSpec.describe "ActiveRecord::Base model with #acts_as_inheritable" do
     let(:person){ create(:person, :with_parent, favorite_color: nil, last_name: nil, soccer_team: nil) }
     let!(:person_parent) { person.parent }
     it 'inherits values from his parent' do
+      person.inherit_attributes
       expect(person.favorite_color).to eq person_parent.favorite_color
       expect(person.last_name).to eq person_parent.last_name
       expect(person.soccer_team).to eq person_parent.soccer_team
     end
+    context 'when `force` is set to true' do
+      let(:person){ create(:person, :with_parent, favorite_color: nil, last_name: 'r3d3 restrepo', soccer_team: 'verdolaga') }
+      let!(:person_parent) { person.parent }
+      it 'inherits values from his parent even if those attributes have a value' do
+        person.inherit_attributes true
+        expect(person.favorite_color).to eq person_parent.favorite_color
+        expect(person.last_name).to eq person_parent.last_name
+        expect(person.soccer_team).to eq person_parent.soccer_team
+      end
+      context 'and `not_force_for` has attributes' do
+        it 'inherits values from his parent even if those attributes have a value but exclude then ones on `not_force_for`' do
+          person.inherit_attributes true, ['soccer_team']
+          expect(person.favorite_color).to eq person_parent.favorite_color
+          expect(person.last_name).to eq person_parent.last_name
+          expect(person.soccer_team).to eq 'verdolaga'
+        end
+      end
+    end
   end
 
   describe '#inherit_relations' do
+    describe '`has_one` associations' do
+      let(:person_parent) { create(:person, :with_pet) }
+      let!(:person){ create(:person, parent: person_parent) }
+
+      it 're-creates the pet from the parent' do
+        expect {
+          person.inherit_relations
+        }.to change(Pet, :count).by(1)
+        expect(person.pet.id).to_not eq person_parent.pet.id
+      end
+    end
   	describe '`belongs_to` associations' do
 	    let(:person_parent) { create(:person, :with_clan) }
 	    let!(:person){ create(:person, parent: person_parent) }
@@ -49,14 +79,14 @@ RSpec.describe "ActiveRecord::Base model with #acts_as_inheritable" do
 		    end
   		end
 
-			context 'when association is polymorphic' do
-		    let(:person_parent) { create(:person, :with_pictures, number_of_pictures: 2) }
+			context 'when association uses a different name' do
+		    let(:person_parent) { create(:person, :with_toys, number_of_toys: 2) }
 		    let!(:person){ create(:person, parent: person_parent) }
 
-		    it 're-creates all the pictures from the parent' do
+		    it 're-creates all the toys from the parent' do
 		      expect {
 		        person.inherit_relations
-		      }.to change(Picture, :count).by(person_parent.pictures.count)
+		      }.to change(Toy, :count).by(person_parent.toys.count)
 		    end
   		end
   	end

data/spec/support/factories.rb

@@ -15,6 +15,10 @@ FactoryGirl.define do
       clan { create(:clan) }
     end
 
+    trait :with_pet do
+      pet { create(:pet) }
+    end
+
     trait :with_toys do
       transient do
         number_of_toys 4
@@ -47,6 +51,11 @@ FactoryGirl.define do
     name     { Faker::Lorem.word }
   end
 
+  factory :pet do
+    name     { Faker::Lorem.word }
+    breed     { Faker::Lorem.word }
+  end
+
   factory :picture do
     url      { Faker::Internet.url }
     place    { Faker::Address.city }

data/spec/support/migrations.rb

@@ -40,4 +40,11 @@ initialize_database do
   add_reference :people, :clan, index: true
   add_foreign_key :people, :clans
 
+  create_table :pets do |t|
+    t.belongs_to :person, index: true
+    t.string :name
+    t.string :breed
+    t.timestamps null: false
+  end
+
 end

data/spec/support/models.rb

@@ -5,7 +5,7 @@ class Person < ActiveRecord::Base
 
   # Constants
   INHERITABLE_ATTRIBUTES = %w(favorite_color last_name soccer_team)
-  INHERITABLE_ASSOCIATIONS = %w(shoes pictures clan)
+  INHERITABLE_ASSOCIATIONS = %w(shoes pictures clan toys pet)
 
   # Associations
   belongs_to  :parent, class_name: 'Person'
@@ -13,10 +13,9 @@ class Person < ActiveRecord::Base
   has_many    :children, class_name: 'Person', foreign_key: :parent_id
   has_many    :toys
   has_many    :shoes
+  has_one     :pet
   has_many 		:pictures, as: :imageable
 
-  # Callbacks
-  before_validation :inherit_attributes, on: :create
 end
 
 class Clan < ActiveRecord::Base
@@ -34,8 +33,12 @@ class Shoe < ActiveRecord::Base
   belongs_to  :person
 end
 
-class Picture < ActiveRecord::Base
+class Pet < ActiveRecord::Base
   # Associations
-  belongs_to :imageable, polymorphic: true
+  belongs_to  :person
 end
 
+class Picture < ActiveRecord::Base
+  # Associations
+  belongs_to :imageable, polymorphic: true
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_inheritable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Esteban Arango Medina
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-21 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -103,6 +103,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
   type: :development
@@ -110,6 +113,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
@@ -145,6 +151,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.3
   type: :development
@@ -152,6 +161,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.3
 - !ruby/object:Gem::Dependency
@@ -234,7 +246,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Inheritable behavior for models with parent.
@@ -245,4 +257,3 @@ test_files:
 - spec/support/factories.rb
 - spec/support/migrations.rb
 - spec/support/models.rb
-has_rdoc: