acts_as_hashids 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8382391d902cd40f0456018a39049f170e031698
-  data.tar.gz: 76c9d57e2098e71319e53f9207f739d971cbe57c
+  metadata.gz: 7e73bc8dc01050b7cd4e73c8f66d41f9490505dc
+  data.tar.gz: e45de056b6215bfcf51ff03872a15468430f08da
 SHA512:
-  metadata.gz: b81058339a4bdf54f29f0a8985e4f725837bb85eb991e4d7c13ce40e69bffdd607070b4a730a21947cb84c9e8e9ea1fc0148907ec540a193ef5c11457db2975c
-  data.tar.gz: fa7d5efc9250e544d89d09ced677b62adefd05e2e472d19194e724aede5b13d3323e59d818261ed9687b02136dde0baa3bc5da6130bcd023e3fd3ee9c48e9f23
+  metadata.gz: 418e43334a2518847872d4cfa12ddae479d26d6a604edf65ea4b042bdde73150dd732d17fd5112b8d1b3657870f66c7364157c48566113e09dc42d674d5c800f
+  data.tar.gz: 2304ac53bd1c53ce1f00f8eb2fb16d5f172dd64e7f4cceaf73974af0057312b836499089aca832f2ff5824210062c076ceb0d820bba1e150c7f56c4cbf728ee8

data/.travis.yml

@@ -1,21 +1,28 @@
 language: ruby
-sudo: required
+sudo: false
 rvm:
-  - 2.2
-  - 2.3.0
+  - 2.2.6
+  - 2.3.3
+  - 2.4.0
 env:
   -
-  - ACTIVE_RECORD_VERSION=4.0
-  - ACTIVE_RECORD_VERSION=4.1
-  - ACTIVE_RECORD_VERSION=4.2
-  - ACTIVE_RECORD_VERSION=5.0.0.beta4
+  - ACTIVE_RECORD_VERSION=4.0.0
+  - ACTIVE_RECORD_VERSION=4.1.0
+  - ACTIVE_RECORD_VERSION=4.2.0
+  - ACTIVE_RECORD_VERSION=5.0.0
+matrix:
+  allow_failures:
+    - rvm: 2.4.0
+      env: ACTIVE_RECORD_VERSION=4.0.0
+    - rvm: 2.4.0
+      env: ACTIVE_RECORD_VERSION=4.1.0
 cache: bundler
-install:
-  - 'gem install bundler'
-  - 'bundle install --jobs=3 --retry=3'
+before_install:
+  - gem update --system
+  - gem --version
+  - gem update bundler
+  - bundler --version
 script:
   - 'bundle exec rake'
-services:
-  - docker
 notifications:
   email: false

data/Gemfile

@@ -1,6 +1,8 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', "~> #{ENV['ACTIVE_RECORD_VERSION']}" if ENV['ACTIVE_RECORD_VERSION'].to_s != ''
-
-# Specify your gem's dependencies in acts_as_hashids.gemspec
 gemspec
+
+gem 'gem-release'
+gem 'pry'
+
+gem 'activerecord', "~> #{ENV['ACTIVE_RECORD_VERSION']}" if ENV['ACTIVE_RECORD_VERSION'].to_s != ''

data/README.md

@@ -5,7 +5,7 @@
 [![Coverage Status][cov-image]][cov-link]
 [![Code Climate][gpa-image]][gpa-link]
 
-Use [Hashids](https://github.com/peterhellberg/hashids.rb) in ActiveRecord effectively.
+Use [Hashids](https://github.com/peterhellberg/hashids.rb) (a.k.a. Youtube-Like ID) in ActiveRecord effectively.
 
 ## Installation
 

data/acts_as_hashids.gemspec

@@ -6,6 +6,7 @@ require 'acts_as_hashids/version'
 Gem::Specification.new do |spec|
   spec.name          = 'acts_as_hashids'
   spec.version       = ActsAsHashids::VERSION
+  spec.platform      = Gem::Platform::RUBY
   spec.authors       = ['dtaniwaki']
   spec.email         = ['daisuketaniwaki@gmail.com']
 
@@ -15,14 +16,15 @@ Gem::Specification.new do |spec|
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  spec.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'hashids', '~> 1.0'
-  spec.add_dependency 'activerecord', '>= 4.0'
+  spec.required_ruby_version = ['>= 2.2.2', '< 2.5']
+
+  spec.add_runtime_dependency 'hashids', '~> 1.0'
+  spec.add_runtime_dependency 'activerecord', '>= 4.0', '< 6.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'sqlite3', '~> 1.3'

data/lib/acts_as_hashids/version.rb

@@ -1,3 +1,3 @@
 module ActsAsHashids
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/spec/acts_as_hashids/core_spec.rb

@@ -0,0 +1,109 @@
+require 'spec_helper'
+
+RSpec.describe ActsAsHashids::Core do
+  around :context do |block|
+    m = ActiveRecord::Migration.new
+    m.verbose = false
+    m.create_table :core_foos, force: true do |t|
+    end
+    m.create_table :core_bars, force: true do |t|
+      t.integer :core_foo_id, index: true
+    end
+    begin
+      block.call
+    ensure
+      m.drop_table :core_foos
+      m.drop_table :core_bars
+    end
+  end
+
+  class Base < ActiveRecord::Base
+    self.abstract_class = true
+    acts_as_hashids
+  end
+
+  class CoreFoo < Base
+    has_many :core_bars
+  end
+
+  class CoreBar < Base
+    belongs_to :core_foo
+  end
+
+  describe '.find' do
+    subject { CoreFoo }
+    let!(:foo1) { CoreFoo.create }
+    let!(:foo2) { CoreFoo.create }
+    context 'for single argument' do
+      it 'decodes hash id and returns the record' do
+        expect(subject.find(foo1.to_param)).to eq foo1
+      end
+      context 'with unexisting hash id' do
+        it 'raises an exception' do
+          expect { subject.find('GXbMabNA') }.to raise_error(
+            ActiveRecord::RecordNotFound, "Couldn't find CoreFoo with 'id'=\"GXbMabNA\""
+          )
+        end
+      end
+    end
+    context 'for multiple arguments' do
+      it 'decodes hash id and returns the record' do
+        expect(subject.find([foo1.to_param, foo2.to_param])).to eq [foo1, foo2]
+      end
+      context 'with unexisting hash id' do
+        it 'raises an exception' do
+          expect { subject.find(%w(GXbMabNA ePQgabdg)) }.to raise_error(
+            ActiveRecord::RecordNotFound,
+            "Couldn't find all CoreFoos with 'id': (\"GXbMabNA\", \"ePQgabdg\") (found 1 results, but was looking for 2)"
+          )
+        end
+      end
+    end
+    context 'as ActiveRecord_Relation' do
+      it 'decodes hash id and returns the record' do
+        expect(subject.where(nil).find(foo1.to_param)).to eq foo1
+      end
+    end
+    context 'as ActiveRecord_Associations_CollectionProxy' do
+      let!(:bar3) { CoreBar.create core_foo: foo1 }
+      let!(:bar4) { CoreBar.create core_foo: foo1 }
+      it 'decodes hash id and returns the record' do
+        expect(foo1.core_bars.find(bar3.to_param)).to eq bar3
+      end
+      context 'without arguments' do
+        it 'delegates to detect method' do
+          expect(foo1.core_bars).to receive(:detect).once.and_call_original
+          expect(foo1.core_bars.find { |bar| bar == bar3 }).to eq bar3
+        end
+      end
+    end
+    context 'reloaded' do
+      subject { CoreFoo.create }
+      it 'decodes hash id and returns the record' do
+        expect do
+          subject.reload
+        end.not_to raise_error
+      end
+    end
+  end
+  describe '.with_hashids' do
+    subject { CoreFoo }
+    let!(:foo1) { CoreFoo.create }
+    let!(:foo2) { CoreFoo.create }
+    it 'decodes hash id and returns the record' do
+      expect(subject.with_hashids([foo1.to_param, foo2.to_param]).all).to eq [foo1, foo2]
+    end
+    context 'with invalid hash id' do
+      it 'raises an exception' do
+        expect { subject.with_hashids('@').all }.to raise_error(ActsAsHashids::Exception, 'Decode error: ["@"]')
+      end
+    end
+  end
+  describe '#to_param' do
+    subject { CoreFoo.create }
+    it 'returns hash id' do
+      allow(subject).to receive(:id).and_return 5
+      expect(subject.to_param).to eq 'GXbMabNA'
+    end
+  end
+end

data/spec/acts_as_hashids/methods_spec.rb

@@ -0,0 +1,74 @@
+require 'spec_helper'
+
+RSpec.describe ActsAsHashids::Methods do
+  around :context do |block|
+    m = ActiveRecord::Migration.new
+    m.verbose = false
+    m.create_table :methods_foos, force: true do |t|
+    end
+    m.create_table :methods_bars, force: true do |t|
+      t.string :type
+    end
+    begin
+      block.call
+    ensure
+      m.drop_table :methods_foos
+      m.drop_table :methods_bars
+    end
+  end
+
+  def create_model(name, options = {})
+    base = options[:base] || ActiveRecord::Base
+    Object.send :remove_const, name if Object.const_defined?(name)
+    klass = Class.new(base) do
+      acts_as_hashids options
+    end
+    Object.const_set name, klass
+    Object.const_get name
+  end
+
+  describe '.hashids_secret' do
+    subject { create_model 'MethodsFoo' }
+    it 'returns the class name' do
+      expect(subject.hashids_secret).to eq 'MethodsFoo'
+    end
+    context 'for STI' do
+      let!(:bar) { create_model 'MethodsBar' }
+      subject { create_model 'MethodsFoo', base: MethodsBar }
+      it 'returns the base class name' do
+        expect(subject.hashids_secret).to eq 'MethodsBar'
+      end
+    end
+    context 'with custom secret' do
+      subject { create_model 'MethodsFoo', secret: '^_^' }
+      it 'returns the custom secret' do
+        expect(subject.hashids_secret).to eq '^_^'
+      end
+      context 'with executable secret' do
+        subject { create_model 'MethodsFoo', secret: -> { "#{self.name} ^_^" } }
+        it 'returns the custom secret' do
+          expect(subject.hashids_secret).to eq 'MethodsFoo ^_^'
+        end
+      end
+    end
+  end
+
+  describe '.hashids' do
+    subject { create_model 'MethodsFoo' }
+    it 'returns the hashids instance' do
+      expect(subject.hashids.encode(1)).to eq Hashids.new('MethodsFoo', 8).encode(1)
+    end
+    context 'with custom length' do
+      subject { create_model 'MethodsFoo', length: 16 }
+      it 'returns the hashids instance' do
+        expect(subject.hashids.encode(1)).to eq Hashids.new('MethodsFoo', 16).encode(1)
+      end
+    end
+    context 'with custom alphabet' do
+      subject { create_model 'MethodsFoo', alphabet: '1234567890abcdef' }
+      it 'returns the hashids instance' do
+        expect(subject.hashids.encode(1)).to eq Hashids.new('MethodsFoo', 8, '1234567890abcdef').encode(1)
+      end
+    end
+  end
+end

data/spec/acts_as_hashids_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe ActsAsHashids do
+  it 'has a version number' do
+    expect(ActsAsHashids::VERSION).not_to be nil
+  end
+  it 'defines acts_as_hashids method in ActiveRecord::Base' do
+    expect(ActiveRecord::Base).to respond_to(:acts_as_hashids)
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,38 @@
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+
+# Test Coverage
+require 'codeclimate-test-reporter'
+require 'coveralls'
+require 'simplecov'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
+  Coveralls::SimpleCov::Formatter,
+  SimpleCov::Formatter::HTMLFormatter,
+  CodeClimate::TestReporter::Formatter
+])
+SimpleCov.minimum_coverage 50
+SimpleCov.start
+
+require 'active_record'
+
+ActiveRecord::Base.establish_connection(
+  adapter: 'sqlite3',
+  host: 'localhost',
+  database: 'test.db'
+)
+
+require 'acts_as_hashids'
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.default_formatter = 'doc' if config.files_to_run.one?
+  config.profile_examples = 10
+  config.order = :random
+  Kernel.srand config.seed
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_hashids
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - dtaniwaki
 autorequire: 
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2016-05-12 00:00:00.000000000 Z
+date: 2017-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashids
@@ -31,6 +31,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,20 +41,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.11'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -167,7 +159,9 @@ dependencies:
 description: Use Hashids in ActiveRecord effectively.
 email:
 - daisuketaniwaki@gmail.com
-executables: []
+executables:
+- console
+- setup
 extensions: []
 extra_rdoc_files: []
 files:
@@ -187,6 +181,10 @@ files:
 - lib/acts_as_hashids/methods.rb
 - lib/acts_as_hashids/railtie.rb
 - lib/acts_as_hashids/version.rb
+- spec/acts_as_hashids/core_spec.rb
+- spec/acts_as_hashids/methods_spec.rb
+- spec/acts_as_hashids_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/dtaniwaki/acts_as_hashids
 licenses:
 - MIT
@@ -199,7 +197,10 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.2
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -207,9 +208,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Hashids in ActiveRecord effectively.
-test_files: []
-has_rdoc: 
+test_files:
+- spec/acts_as_hashids/core_spec.rb
+- spec/acts_as_hashids/methods_spec.rb
+- spec/acts_as_hashids_spec.rb
+- spec/spec_helper.rb