acts_as_geocodable 2.0.3 → 2.1.0

data/spec/geocode_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+
+describe Geocode do
+  describe "distance_to" do
+    before do
+      @washington_dc = FactoryGirl.create(:white_house_geocode)
+      @chicago = FactoryGirl.create(:chicago_geocode)
+    end
+
+    it "should properly calculate distance in default units" do
+      expect(@washington_dc.distance_to(@chicago)).to be_within(1.0).of(594.820)
+    end
+
+    it "should properly calculate distance in default miles" do
+      expect(@washington_dc.distance_to(@chicago, :miles)).to be_within(1.0).of(594.820)
+    end
+
+    it "should properly calculate distance in default kilometers" do
+      expect(@washington_dc.distance_to(@chicago, :kilometers)).to be_within(1.0).of(957.275)
+    end
+
+    it "should return nil with invalid geocode" do
+      expect(@chicago.distance_to(Geocode.new)).to be_nil
+      expect(@chicago.distance_to(nil)).to be_nil
+    end
+  end
+
+  describe "find_or_create_by_query" do
+    it "should finds existing geocode" do
+      existing = FactoryGirl.create(:holland_geocode)
+      expect(Geocode.find_or_create_by_query("Holland, MI")).to eq(existing)
+    end
+  end
+
+  describe "find_or_create_by_location" do
+    it "should find existing location" do
+      existing = FactoryGirl.create(:white_house_geocode)
+      location = Graticule::Location.new(postal_code: "20502",
+        street: "1600 Pennsylvania Ave NW",
+        locality: "Washington",
+        region: "DC")
+      expect(Geocode.find_or_create_by_location(location)).to eq(existing)
+    end
+
+    it "should return nil when location can't be geocoded" do
+      expect(Geocode.geocoder).to receive(:locate).and_raise(Graticule::Error)
+      expect {
+        expect(Geocode.find_or_create_by_location(Graticule::Location.new(street: "FAIL!"))).to be_nil
+      }.not_to change { Geocode.count }
+    end
+  end
+
+  describe "coordinates" do
+    it "should return longitude and latitude" do
+      geocode = FactoryGirl.create(:saugatuck_geocode)
+      expect(geocode.coordinates).to eq("-86.200722,42.654781")
+    end
+  end
+
+  describe "to_s" do
+    it "should return the coordinates" do
+      geocode = FactoryGirl.create(:saugatuck_geocode)
+      expect(geocode.to_s).to eq(geocode.coordinates)
+    end
+  end
+
+  describe "geocoded?" do
+    it "should be true with both a latitude and a longitude" do
+      expect(Geocode.new(latitude: 1, longitude: 1)).to be_geocoded
+    end
+
+    it "should be false when missing coordinates" do
+      expect(Geocode.new).not_to be_geocoded
+    end
+
+    it "should be false when missing a latitude" do
+      expect(Geocode.new(latitude: 1)).not_to be_geocoded
+    end
+
+    it "should be false when missing a longitude" do
+      expect(Geocode.new(latitude: 1)).not_to be_geocoded
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,31 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
+require "acts_as_geocodable"
+
+require "bundler"
+Bundler.require(:test)
+
+plugin_test_dir = File.dirname(__FILE__)
+ActiveRecord::Base.logger = Logger.new(plugin_test_dir + "/debug.log")
+ActiveRecord::Base.configurations = YAML::load(IO.read(plugin_test_dir + "/db/database.yml"))
+ActiveRecord::Base.establish_connection((ENV["DB"] || "mysql").to_sym)
+ActiveRecord::Migration.verbose = false
+load(File.join(plugin_test_dir, "db", "schema.rb"))
+
+require "support/geocoder"
+require "support/models"
+require "support/factories"
+
+RSpec.configure do |config|
+  # Use database cleaner to remove factories
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :truncation
+  end
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/factories.rb

@@ -0,0 +1,110 @@
+FactoryGirl.define do
+  factory :chicago, class: City do
+    zip ""
+    name "Chicago"
+  end
+
+  factory :holland, class: City do
+    zip 49423
+    name "Holland"
+  end
+
+  factory :nowhere, class: City do
+    zip ""
+    name "Nowhere"
+  end
+
+  factory :chicago_geocode, class: Geocode do
+    query "Chicago, IL"
+    longitude(-87.65)
+    locality "Chicago"
+    postal_code ""
+    latitude 41.85
+    region "IL"
+  end
+
+  factory :white_house_geocode, class: Geocode do
+    query "1600 Pennsylvania Ave NW\nWashington, DC 20502"
+    longitude(-77.037684)
+    locality "Washington"
+    street "1600 Pennsylvania Ave NW"
+    postal_code 20502
+    latitude 38.898748
+    region "DC"
+  end
+
+  factory :saugatuck_geocode, class: Geocode do
+    query "Saugatuck, MI"
+    longitude(-86.200722)
+    locality "Saugatuck"
+    latitude 42.654781
+    region "MI"
+  end
+
+  factory :douglas_geocode, class: Geocode do
+    query 49406
+    longitude(-86.2005)
+    locality "Douglas"
+    postal_code 49406
+    country "US"
+    latitude 42.6433
+    region "MI"
+  end
+
+  factory :beverly_hills, class: Geocode do
+    query "Beverly Hills, 90210"
+    longitude(-118.4098)
+    locality "Beverly Hills"
+    postal_code 90210
+    country "US"
+    latitude 34.0924
+    region "CA"
+  end
+
+  factory :holland_geocode, class: Geocode do
+    query "Holland, MI"
+    longitude(-86.109039)
+    locality "Holland"
+    postal_code ""
+    country "US"
+    latitude 42.787567
+    region "MI"
+  end
+
+  factory :chicago_geocoding, class: Geocoding do
+    geocode_id 3
+    geocodable_id 1
+    geocodable_type "City"
+  end
+
+  factory :white_house_geocoding, class: Geocoding do
+    geocode_id 2
+    geocodable_id 2
+    geocodable_type "Vacation"
+  end
+
+  factory :saugatuck_geocoding, class: Geocoding do
+    geocode
+    geocodable
+  end
+
+  factory :saugatuck, class: Vacation do
+    name "Saugatuck, Michigan"
+    locality "Saugatuck"
+    region "MI"
+  end
+
+  factory :whitehouse, class: Vacation do
+    locality "Washington"
+    street "1600 Pennsylvania Ave NW"
+    postal_code 20502
+    name "The White House"
+    region "DC"
+  end
+
+  factory :mystery_spot, class: Vacation do
+    street "150 Martin Lake Rd."
+    postal_code 49781
+    name "The Mystery Spot"
+  end
+end

data/spec/support/geocoder.rb

@@ -0,0 +1,52 @@
+class Graticule::Geocoder::Canned
+  class_attribute :responses
+  self.responses = {}
+  class_attribute :default
+
+  def locate(query)
+    location = responses[query.to_s.strip]
+    raise %Q{No Location for query: "#{query.to_s.inspect}" Add it to spec/support/geocoder.rb} unless location
+    location
+  end
+end
+
+Geocode.geocoder = Graticule::Geocoder::Canned.new
+
+saugatuck = Graticule::Location.new(
+  locality: "Saugatuck",
+  region: "MI",
+  country: "USA",
+  precision: :street,
+  latitude: 42.654781,
+  longitude: -86.200722,
+  postal_code: 49406
+)
+
+sf = Graticule::Location.new(
+  locality: "San Francisco",
+  region: "CA",
+  country: "USA",
+  precision: :street,
+  latitude: 37.775206,
+  longitude: -122.419209,
+  postal_code: 94110
+)
+
+Geocode.geocoder.responses = {
+  "San Francisco" => sf,
+  "San Francisco, CA" => sf,
+
+  "49406" => saugatuck,
+  "Saugatuck, MI" => saugatuck,
+  "Saugatuck, MI 49406" => saugatuck,
+
+  "1600 Pennsylvania Ave NW\nWashington, DC 20502" => Graticule::Location.new(
+    locality: "Washington",
+    region: "DC",
+    country: "USA",
+    precision: :street,
+    latitude: 38.898748,
+    longitude: -77.037684,
+    postal_code: "20502"
+  )
+}

data/spec/support/models.rb

@@ -0,0 +1,35 @@
+class Vacation < ActiveRecord::Base
+  acts_as_geocodable normalize_address: true
+  belongs_to :nearest_city, class_name: "City", foreign_key: "city_id"
+end
+
+class Staycation < ActiveRecord::Base
+  self.table_name = "vacations"
+
+  acts_as_geocodable
+  validates_as_geocodable(allow_nil: false) do |geocode|
+    ["USA", "US"].include?(geocode.country)
+  end
+end
+
+class City < ActiveRecord::Base
+  acts_as_geocodable address: { postal_code: :zip }
+end
+
+class ValidatedVacation < ActiveRecord::Base
+  acts_as_geocodable
+  validates_as_geocodable
+end
+
+class AddressBlobVacation < ActiveRecord::Base
+  acts_as_geocodable address: :address, normalize_address: true
+end
+
+class CallbackLocation < ActiveRecord::Base
+  acts_as_geocodable address: :address
+  set_callback :geocoding, :after, :done_geocoding
+
+  def done_geocoding
+    true
+  end
+end

metadata

@@ -1,92 +1,147 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: acts_as_geocodable
-version: !ruby/object:Gem::Version 
-  hash: 9
-  prerelease: 
-  segments: 
-  - 2
-  - 0
-  - 3
-  version: 2.0.3
+version: !ruby/object:Gem::Version
+  version: 2.1.0
 platform: ruby
-authors: 
+authors:
 - Daniel Morrison
 - Brandon Keepers
 - Brian Ryckbost
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-11-15 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 0
-        - 0
-        version: 2.0.0
-  requirement: *id001
+date: 2014-06-10 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: graticule
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
-  name: graticule
-description: Simple geocoding for Rails ActiveRecord models. See the README for more details.
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '10.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '10.3'
+description: Simple geocoding for Active Record models. See the README for more details.
 email: info@collectiveidea.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
+- .gitignore
+- .rspec
+- .travis.yml
+- CHANGELOG.md
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- acts_as_geocodable.gemspec
+- gemfiles/rails30.gemfile
+- gemfiles/rails31.gemfile
+- gemfiles/rails32.gemfile
+- gemfiles/rails40.gemfile
+- gemfiles/rails41.gemfile
+- lib/acts_as_geocodable.rb
 - lib/acts_as_geocodable/geocode.rb
 - lib/acts_as_geocodable/geocoding.rb
 - lib/acts_as_geocodable/remote_location.rb
 - lib/acts_as_geocodable/version.rb
-- lib/acts_as_geocodable.rb
+- lib/generators/acts_as_geocodable/USAGE
 - lib/generators/acts_as_geocodable/acts_as_geocodable_generator.rb
 - lib/generators/acts_as_geocodable/templates/migration.rb
-- lib/generators/acts_as_geocodable/USAGE
-- CHANGELOG
-- MIT-LICENSE
-- README.textile
-homepage: http://github.com/collectiveidea/acts_as_geocodable
-licenses: []
-
+- spec/acts_as_geocodable_generator_spec.rb
+- spec/acts_as_geocodable_spec.rb
+- spec/db/database.yml.example
+- spec/db/schema.rb
+- spec/geocode_spec.rb
+- spec/spec_helper.rb
+- spec/support/factories.rb
+- spec/support/geocoder.rb
+- spec/support/models.rb
+homepage: https://github.com/collectiveidea/acts_as_geocodable
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
-require_paths: 
+rdoc_options: []
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
-summary: Simple geocoding for Rails ActiveRecord models
-test_files: []
-
+specification_version: 4
+summary: Simple geocoding for Active Record models
+test_files:
+- spec/acts_as_geocodable_generator_spec.rb
+- spec/acts_as_geocodable_spec.rb
+- spec/db/database.yml.example
+- spec/db/schema.rb
+- spec/geocode_spec.rb
+- spec/spec_helper.rb
+- spec/support/factories.rb
+- spec/support/geocoder.rb
+- spec/support/models.rb