acts_as_filterable 0.2.0 → 0.3.0

data/test/acts_as_filterable_integration_test.rb

@@ -1,106 +1,80 @@
 require "test_helper"
 
-class ActsAsFilterableIntegrationTest < Test::Unit::TestCase
-  
-  context "An ActiveRecord model using acts_as_filterable" do
-    setup do
-      @model = ContactDetail.new do |cd|
-        cd.name = "joe smith"
-        cd.phone_number = "2223334444"
-        cd.discount = 0.25
-      end
-    end
-   
-    should "add an #apply_filters instance method" do
-      @model.send(:apply_filters).nil?.should_not be(true)
+describe ActsAsFilterable::ActiveRecordExt::Base do
+  before do
+    @model = ContactDetail.new do |cd|
+      cd.name = "joe smith"
+      cd.phone_number = "2223334444"
+      cd.discount = 0.25
     end
+  end
 
-    should "know about the types of filters that will be applied to the attributes" do
-      ContactDetail.respond_to?(:filtered_attributes).should be(true)
-    end
-    
-    should "add a macro to filter non-numeric values from string fields" do
-      ContactDetail.respond_to?(:filter_for_digits).should be(true)
-    end
-  
-    should "add a macro to filter values to lowercase from string fields" do
-      ContactDetail.respond_to?(:filter_for_lowercase).should be(true)
-    end
-    
-    should "be savable with valid data" do
-      @model.save.should be(true)
-    end
-    
-    context "with formatted phone number data" do
-      setup do
-        @model.phone_number = "(222) 333-4444"
-        @model.valid?
-      end
-    
-      should "strip all formatting" do
-        @model.phone_number.should be("2223334444")
-      end
-      
-      should "return a coercable numeric value" do
-        @model.phone_number.to_f.should be(2223334444)
-      end
-    
-    end
-    
-    context "with a nil attribute value" do
-      setup do
-        @model.phone_number = nil
-      end
-      
-      should "not raise any errors due to a nil attribute value" do
-        lambda { @model.valid? }.should_not raise_error
-      end
-      
-      should "not attempt to change the attribute value" do
-        @model.valid?
-        @model.phone_number.nil?.should be(true)
-      end
-    end
-    
-    context "with non-string attributes" do
-      setup do
-        ContactDetail.filter_for_digits :discount
-      end
-      
-      should "not raise any errors due to a non-string attribute value" do
-        lambda { @model.valid? }.should_not raise_error
-      end
-      
-      should "not attempt to change the attribute value" do
-        @model.valid?
-        @model.discount.should be(0.25)
-      end
-      
-    end
-    
-    context "with an attribute value that contains no values to be stripped" do
-      setup do 
-        @model.phone_number = "2223334444"
-        @model.valid?
-      end
-      
-      should "not change the attribute value" do
-        @model.phone_number.should be("2223334444")
-      end
-    end
-    
-    context "that has filtered attribute names that are identical to another filtered model" do
-      
-      should "hold seperate collections of filtered_attributes" do
-        User.filtered_attributes.should_not === ContactDetail.filtered_attributes
-      end
-   
-      should "not add attributes to other models errantly" do
-        ContactDetail.filtered_attributes[:digits].should_not include(:handle)
-      end
+  it "should add an #apply_filters instance method" do
+    @model.send(:apply_filters).wont_equal(nil)
+  end
 
-    end
-    
+  it "should know about the types of filters that will be applied to the attributes" do
+    ContactDetail.must_respond_to(:filtered_attributes)
+  end
+
+  it "should add a macro to filter non-numeric values from string fields" do
+    ContactDetail.must_respond_to(:filter_for_digits)
+  end
+
+  it "should add a macro to filter values to lowercase from string fields" do
+    ContactDetail.must_respond_to(:filter_for_lowercase)
+  end
+
+  it "should be savable with valid data" do
+    @model.save.must_equal(true)
+  end
+
+  it "should strip all formatting" do
+    @model.phone_number = "(222) 333-4444"
+    @model.valid?
+    @model.phone_number.must_equal("2223334444")
+  end
+
+  it "should return a coercable numeric value" do
+    @model.phone_number = "(222) 333-4444"
+    @model.valid?
+    @model.phone_number.to_i.must_equal(2223334444)
+  end
+
+  it "should not raise any errors due to a nil attribute value" do
+    @model.phone_number = nil
+    @model.valid?.must_equal(true)
+  end
+
+  it "should not attempt to change the attribute value" do
+    @model.phone_number = nil
+    @model.valid?
+    @model.phone_number.must_equal(nil)
+  end
+
+  it "should not raise formatting errors" do
+    ContactDetail.filter_for_digits :discount
+    @model.valid?.must_equal(true)
+  end
+
+  it "should not attempt to change the attribute value" do
+    ContactDetail.filter_for_digits :discount
+    @model.valid?
+    @model.discount.must_equal(0.25)
+  end
+
+  it "should not change the attribute value" do
+    @model.phone_number = "2223334444"
+    @model.valid?
+    @model.phone_number.must_equal("2223334444")
+  end
+
+  it "should hold seperate collections of filtered_attributes" do
+    User.filtered_attributes.wont_be_same_as ContactDetail.filtered_attributes
+  end
+
+  it "should not add attributes to other models errantly" do
+    ContactDetail.filtered_attributes[:digits].flatten.wont_include([:handle].flatten)
   end
 
 end

data/test/filter_test.rb

@@ -1,129 +1,101 @@
 require "test_helper"
 
-class FilterTest < Test::Unit::TestCase
-
-  def assert_identity_after_filter(filter, value)
-    identity = value.object_id
-    filter.call(value)
-    identity.should == value.object_id
-  end
-
-  context "Filters" do
-    should "default filters that don't exist to an empty array" do
-      ActsAsFilterable::Filters[:test].empty?.should be(true)
-    end
-  
-    should "contain some filters initially" do
-      ActsAsFilterable::Filters[:numeric].nil?.should_not be(true)
-      ActsAsFilterable::Filters[:lowercase].nil?.should_not be(true)
-    end
-  
-    should "freeze the macro collection so it cannot be mutated" do
-      lambda { ActsAsFilterable::Filters.store(:test, /./) }.should raise_error
-    end
-  end
-
-  context "When applying the" do
-    
-    context "digit filter, it" do
-      setup do
-        @filter = ActsAsFilterable::Filters[:digits]
-      end
-      
-      should "strip any non-digit values from the string" do
-        value = "45tr.,2"
-        @filter.call(value)
-        value.should be("452")
-      end
-      
-      should "not lose digit values" do
-        value = "432099132"
-        @filter.call(value)
-        value.should be("432099132")
-      end
-      
-      should "return a coercable numerica value" do
-        value = "4"
-        @filter.call(value)
-        value.to_i.should be(4)
-      end
-      
-      should "not create extra string objects when replacing values" do
-        assert_identity_after_filter @filter, "54tr"
-      end
-    
-      should "not create extra string objects when no values are to be replaced" do
-        assert_identity_after_filter @filter, "54"
-      end
-    
-    end
-    
-    context "lowercase filter, it" do
-      setup do
-        @filter = ActsAsFilterable::Filters[:lowercase]
-      end
-
-      should "lowercase all alpha values" do
-        value = "FAIl STRING"
-        @filter.call(value)
-        value.should be("fail string")
-      end
-      
-      should "not create extra string objects when replacing values" do
-        assert_identity_after_filter @filter, "TRANSLATE"
-      end
-    
-      should "not create extra string objects when no values are to be replaced" do
-        assert_identity_after_filter @filter, "43"
-      end
-    end
-
-    context "uppercase filter, it" do
-      setup do
-        @filter = ActsAsFilterable::Filters[:uppercase]
-      end
-
-      should "uppercase all alpha values" do
-        value = "lowercase string"
-        @filter.call(value)
-        value.should be("LOWERCASE STRING")
-      end
-      
-      should "not create extra string objects when replacing values" do
-        assert_identity_after_filter @filter, "translate"
-      end
-    
-      should "not create extra string objects when no values are to be replaced" do
-        assert_identity_after_filter @filter, "43"
-      end
-    end
-
-    context "whitesapce filter, it" do
-      setup do
-        @filter = ActsAsFilterable::Filters[:whitespace]
-      end
-
-      should "replace all un-neccessary whitespace" do
-        value = "\t hai!    this is neat\n\nok?  \t"
-        @filter.call(value)
-        value.should be("hai! this is neat ok?")
-      end
-      
-      should "trim the ends of the string" do
-        value = " this "
-        @filter.call(value)
-        value.should be("this")
-      end
-      
-      should "not create extra string objects when replacing values" do
-        assert_identity_after_filter @filter, "TRANSLATE"
-      end
-    
-      should "not create extra string objects when no values are to be replaced" do
-        assert_identity_after_filter @filter, "43"
-      end
-    end
+def assert_identity_after_filter(filter, value)
+  identity = value.object_id
+  filter.call(value)
+  identity.must_equal value.object_id
+end
+
+describe ActsAsFilterable::Filters do
+  before do
+    @filter = ActsAsFilterable::Filters[:digits]
+  end
+
+  it "should default filters that don't exist to an empty array" do
+    ActsAsFilterable::Filters[:test].empty?.must_equal(true)
+  end
+
+  it "should contain some filters initially" do
+    ActsAsFilterable::Filters[:numeric].nil?.wont_equal(true)
+    ActsAsFilterable::Filters[:lowercase].nil?.wont_equal(true)
+  end
+
+  it "should freeze the macro collection so it cannot be mutated" do
+    proc { ActsAsFilterable::Filters.store(:test, /./) }.must_raise TypeError, RuntimeError
+  end
+
+  it "should strip any non-digit values from the string" do
+    value = "45tr.,2"
+    ActsAsFilterable::Filters[:digits].call(value)
+    value.must_equal("452")
+  end
+
+  it "should not lose digit values" do
+    value = "432099132"
+    ActsAsFilterable::Filters[:digits].call(value)
+    value.must_equal("432099132")
+  end
+
+  it "should return a coercable numerica value" do
+    value = "4"
+    ActsAsFilterable::Filters[:digits].call(value)
+    value.to_i.must_equal(4)
+  end
+
+  it "should not create extra string objects when replacing values" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:digits], "54tr"
+  end
+
+  it "should not create extra string objects when no values are to be replaced" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:digits], "54"
+  end
+
+  it "should lowercase all alpha values" do
+    value = "FAIl STRING"
+    ActsAsFilterable::Filters[:lowercase].call(value)
+    value.must_equal("fail string")
+  end
+
+  it "should not create extra string objects when replacing values" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:lowercase], "TRANSLATE"
+  end
+
+  it "should not create extra string objects when no values are to be replaced" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:lowercase], "43"
+  end
+
+  it "should uppercase all alpha values" do
+    value = "lowercase string"
+    ActsAsFilterable::Filters[:uppercase].call(value)
+    value.must_equal("LOWERCASE STRING")
+  end
+
+  it "should not create extra string objects when replacing values" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:uppercase], "translate"
+  end
+
+  it "should not create extra string objects when no values are to be replaced" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:uppercase], "43"
+  end
+
+  it "should replace all un-neccessary whitespace" do
+    value = "\t hai!    this is neat\n\nok?  \t"
+    ActsAsFilterable::Filters[:whitespace].call(value)
+    value.must_equal("hai! this is neat ok?")
+  end
+
+  it "should trim the ends of the string" do
+    value = " this "
+    ActsAsFilterable::Filters[:whitespace].call(value)
+    value.must_equal("this")
+  end
+
+  it "should not create extra string objects when replacing values" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:whitespace], "TRANSLATE"
+  end
 
+  it "should not create extra string objects when no values are to be replaced" do
+    assert_identity_after_filter ActsAsFilterable::Filters[:whitespace], "43"
   end
 
 end

data/test/test_helper.rb

@@ -1,7 +1,5 @@
-require "test/unit"
-require "activerecord"
-require "shoulda"
-require "matchy"
+require "minitest/spec"
+require "active_record"
 
 require "acts_as_filterable"
 
@@ -15,7 +13,7 @@ ActiveRecord::Schema.define do
     t.string :fax_number
     t.float :discount
   end
-  
+
   create_table :users, :force => true do |t|
     t.string :handle
     t.string :phone_number
@@ -31,5 +29,4 @@ class User < ActiveRecord::Base
   filter_for_lowercase :handle
 end
 
-class Test::Unit::TestCase
-end
+MiniTest::Unit.autorun

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: acts_as_filterable
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  prerelease: false
+  segments: 
+  - 0
+  - 3
+  - 0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Rob Ares
@@ -9,49 +14,51 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-29 00:00:00 -04:00
+date: 2010-03-07 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 15
+        - 0
         version: 1.15.0
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: activesupport
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 4
+        - 4
         version: 1.4.4
-    version: 
+  type: :runtime
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: Shoulda
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  name: minitest
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
-- !ruby/object:Gem::Dependency 
-  name: matchy
+        segments: 
+        - 1
+        - 5
+        - 0
+        version: 1.5.0
   type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
+  version_requirements: *id003
 description: 
 email: rob.ares@gmail.com
 executables: []
@@ -73,6 +80,7 @@ files:
 - lib/acts_as_filterable.rb
 - lib/acts_as_filterable/base.rb
 - rails/init.rb
+- setup.rb
 - test/acts_as_filterable_integration_test.rb
 - test/filter_test.rb
 - test/test_helper.rb
@@ -89,18 +97,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Filter attributes and stuff.